All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] gitlab-ci: use the Docker image from gitlab registry
@ 2021-10-20 20:38 Romain Naour
  2021-10-24 14:13 ` Thomas Petazzoni
  2021-12-11 22:59 ` Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Romain Naour @ 2021-10-20 20:38 UTC (permalink / raw)
  To: buildroot; +Cc: Romain Naour

From [1]:
"In November 2020, Docker introduced rate limits on pull requests from
Docker Hub [2]. If your GitLab CI/CD configuration uses an image from
Docker Hub, each time a job runs, it may count as a pull request."

Since then, some jobs in our gitlab-ci fail when this rate limits is
reached [3].

To avoid this rate limit, move our Docker image from dockerhub to the
registry provided by gitlab. Keeping the image from dockerhub would be
possible by using dependency proxy [4] but the gitlab registry is good
enough.

Tested on gitlab:
https://gitlab.com/kubu93/buildroot/-/jobs/1694863584

[1] https://docs.gitlab.com/ee/user/packages/container_registry/index.html
[2] https://docs.docker.com/docker-hub/download-rate-limit/
[3] https://gitlab.com/buildroot.org/buildroot/-/jobs/1687590417
[4] https://docs.gitlab.com/ee/user/packages/dependency_proxy

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 150b8eac1a..dc45744a81 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,7 +1,7 @@
 # Configuration for Gitlab-CI.
 # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines
 
-image: buildroot/base:20210922.2200
+image: $CI_REGISTRY/buildroot.org/buildroot/base:20210922.2200
 
 stages:
   - generate-gitlab-ci
-- 
2.31.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] gitlab-ci: use the Docker image from gitlab registry
  2021-10-20 20:38 [Buildroot] [PATCH] gitlab-ci: use the Docker image from gitlab registry Romain Naour
@ 2021-10-24 14:13 ` Thomas Petazzoni
  2021-11-13 11:15   ` Romain Naour
  2021-12-11 22:59 ` Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2021-10-24 14:13 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

On Wed, 20 Oct 2021 22:38:16 +0200
Romain Naour <romain.naour@gmail.com> wrote:

> From [1]:
> "In November 2020, Docker introduced rate limits on pull requests from
> Docker Hub [2]. If your GitLab CI/CD configuration uses an image from
> Docker Hub, each time a job runs, it may count as a pull request."
> 
> Since then, some jobs in our gitlab-ci fail when this rate limits is
> reached [3].
> 
> To avoid this rate limit, move our Docker image from dockerhub to the
> registry provided by gitlab. Keeping the image from dockerhub would be
> possible by using dependency proxy [4] but the gitlab registry is good
> enough.
> 
> Tested on gitlab:
> https://gitlab.com/kubu93/buildroot/-/jobs/1694863584
> 
> [1] https://docs.gitlab.com/ee/user/packages/container_registry/index.html
> [2] https://docs.docker.com/docker-hub/download-rate-limit/
> [3] https://gitlab.com/buildroot.org/buildroot/-/jobs/1687590417
> [4] https://docs.gitlab.com/ee/user/packages/dependency_proxy
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  .gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] gitlab-ci: use the Docker image from gitlab registry
  2021-10-24 14:13 ` Thomas Petazzoni
@ 2021-11-13 11:15   ` Romain Naour
  0 siblings, 0 replies; 4+ messages in thread
From: Romain Naour @ 2021-11-13 11:15 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: Thomas Petazzoni, buildroot

Hello Peter,

Le 24/10/2021 à 16:13, Thomas Petazzoni a écrit :
> On Wed, 20 Oct 2021 22:38:16 +0200
> Romain Naour <romain.naour@gmail.com> wrote:
> 
>> From [1]:
>> "In November 2020, Docker introduced rate limits on pull requests from
>> Docker Hub [2]. If your GitLab CI/CD configuration uses an image from
>> Docker Hub, each time a job runs, it may count as a pull request."
>>
>> Since then, some jobs in our gitlab-ci fail when this rate limits is
>> reached [3].
>>
>> To avoid this rate limit, move our Docker image from dockerhub to the
>> registry provided by gitlab. Keeping the image from dockerhub would be
>> possible by using dependency proxy [4] but the gitlab registry is good
>> enough.
>>
>> Tested on gitlab:
>> https://gitlab.com/kubu93/buildroot/-/jobs/1694863584
>>
>> [1] https://docs.gitlab.com/ee/user/packages/container_registry/index.html
>> [2] https://docs.docker.com/docker-hub/download-rate-limit/
>> [3] https://gitlab.com/buildroot.org/buildroot/-/jobs/1687590417
>> [4] https://docs.gitlab.com/ee/user/packages/dependency_proxy
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>> ---
>>  .gitlab-ci.yml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied to master, thanks.

If you want to backport this patch, I already pushed the docker image
(20200814.2228) used by the Buildroot stable version to the gitlab registry:

https://gitlab.com/buildroot.org/buildroot/container_registry/2395076

Best regards,
Romain


> 
> Thomas
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] gitlab-ci: use the Docker image from gitlab registry
  2021-10-20 20:38 [Buildroot] [PATCH] gitlab-ci: use the Docker image from gitlab registry Romain Naour
  2021-10-24 14:13 ` Thomas Petazzoni
@ 2021-12-11 22:59 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2021-12-11 22:59 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > From [1]:
 > "In November 2020, Docker introduced rate limits on pull requests from
 > Docker Hub [2]. If your GitLab CI/CD configuration uses an image from
 > Docker Hub, each time a job runs, it may count as a pull request."

 > Since then, some jobs in our gitlab-ci fail when this rate limits is
 > reached [3].

 > To avoid this rate limit, move our Docker image from dockerhub to the
 > registry provided by gitlab. Keeping the image from dockerhub would be
 > possible by using dependency proxy [4] but the gitlab registry is good
 > enough.

 > Tested on gitlab:
 > https://gitlab.com/kubu93/buildroot/-/jobs/1694863584

 > [1] https://docs.gitlab.com/ee/user/packages/container_registry/index.html
 > [2] https://docs.docker.com/docker-hub/download-rate-limit/
 > [3] https://gitlab.com/buildroot.org/buildroot/-/jobs/1687590417
 > [4] https://docs.gitlab.com/ee/user/packages/dependency_proxy

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed to 2021.02.x and 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-11 22:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20 20:38 [Buildroot] [PATCH] gitlab-ci: use the Docker image from gitlab registry Romain Naour
2021-10-24 14:13 ` Thomas Petazzoni
2021-11-13 11:15   ` Romain Naour
2021-12-11 22:59 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.