All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mux: fix kernel doc prototype
@ 2021-10-19  6:45 Vincent Whitchurch
  2021-10-19  7:17 ` Peter Rosin
  0 siblings, 1 reply; 4+ messages in thread
From: Vincent Whitchurch @ 2021-10-19  6:45 UTC (permalink / raw)
  To: jic23, Peter Rosin
  Cc: kernel, linux-iio, Vincent Whitchurch, kernel test robot, linux-kernel

Fix this warning from scripts/kernel-doc:

 drivers/mux/core.c:391: warning: expecting prototype for
 mux_control_try_select(). Prototype was for
 mux_control_try_select_delay() instead

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
---
 drivers/mux/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mux/core.c b/drivers/mux/core.c
index dee6945e92f7..22f4709768d1 100644
--- a/drivers/mux/core.c
+++ b/drivers/mux/core.c
@@ -371,7 +371,7 @@ int mux_control_select_delay(struct mux_control *mux, unsigned int state,
 EXPORT_SYMBOL_GPL(mux_control_select_delay);
 
 /**
- * mux_control_try_select() - Try to select the given multiplexer state.
+ * mux_control_try_select_delay() - Try to select the given multiplexer state.
  * @mux: The mux-control to request a change of state from.
  * @state: The new requested state.
  * @delay_us: The time to delay (in microseconds) if the mux state is changed.
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mux: fix kernel doc prototype
  2021-10-19  6:45 [PATCH] mux: fix kernel doc prototype Vincent Whitchurch
@ 2021-10-19  7:17 ` Peter Rosin
  2021-10-20 20:27   ` Jonathan Cameron
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Rosin @ 2021-10-19  7:17 UTC (permalink / raw)
  To: Vincent Whitchurch, jic23
  Cc: kernel, linux-iio, kernel test robot, linux-kernel

On 2021-10-19 08:45, Vincent Whitchurch wrote:
> Fix this warning from scripts/kernel-doc:
> 
>  drivers/mux/core.c:391: warning: expecting prototype for
>  mux_control_try_select(). Prototype was for
>  mux_control_try_select_delay() instead
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>

Obviously. Or, just squash it if that's still an option?

In case it's easier to just pile it on top:

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mux: fix kernel doc prototype
  2021-10-19  7:17 ` Peter Rosin
@ 2021-10-20 20:27   ` Jonathan Cameron
  2021-10-20 20:49     ` Peter Rosin
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2021-10-20 20:27 UTC (permalink / raw)
  To: Peter Rosin
  Cc: Vincent Whitchurch, kernel, linux-iio, kernel test robot, linux-kernel

On Tue, 19 Oct 2021 09:17:07 +0200
Peter Rosin <peda@axentia.se> wrote:

> On 2021-10-19 08:45, Vincent Whitchurch wrote:
> > Fix this warning from scripts/kernel-doc:
> > 
> >  drivers/mux/core.c:391: warning: expecting prototype for
> >  mux_control_try_select(). Prototype was for
> >  mux_control_try_select_delay() instead
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>  
> 
> Obviously. Or, just squash it if that's still an option?
Folded into original commit.

Thanks,

Jonathan

> 
> In case it's easier to just pile it on top:
> 
> Acked-by: Peter Rosin <peda@axentia.se>
> 
> Cheers,
> Peter


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mux: fix kernel doc prototype
  2021-10-20 20:27   ` Jonathan Cameron
@ 2021-10-20 20:49     ` Peter Rosin
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Rosin @ 2021-10-20 20:49 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Vincent Whitchurch, kernel, linux-iio, kernel test robot, linux-kernel

On 2021-10-20 22:27, Jonathan Cameron wrote:
> On Tue, 19 Oct 2021 09:17:07 +0200
> Peter Rosin <peda@axentia.se> wrote:
> 
>> On 2021-10-19 08:45, Vincent Whitchurch wrote:
>>> Fix this warning from scripts/kernel-doc:
>>>
>>>  drivers/mux/core.c:391: warning: expecting prototype for
>>>  mux_control_try_select(). Prototype was for
>>>  mux_control_try_select_delay() instead
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>  
>>
>> Obviously. Or, just squash it if that's still an option?
> Folded into original commit.
> 
> Thanks,
> 
> Jonathan

And I would like to say thanks for a nice series from Vincent and
to you Jonathan for taking care of the mechanics. Much appreciated!

Cheers,
Peter

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-20 20:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19  6:45 [PATCH] mux: fix kernel doc prototype Vincent Whitchurch
2021-10-19  7:17 ` Peter Rosin
2021-10-20 20:27   ` Jonathan Cameron
2021-10-20 20:49     ` Peter Rosin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.