All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nghia Le" <nghialm78@gmail.com>
To: lukas.bulwahn@gmail.com, linux-safety@lists.elisa.tech
Cc: Nghia Le <nghialm78@gmail.com>
Subject: [linux-safety] [PATCH v2] ext4: remove useless resetting io_end_size in mpage_process_page()
Date: Fri, 22 Oct 2021 00:42:42 +0700	[thread overview]
Message-ID: <20211021174242.20627-1-nghialm78@gmail.com> (raw)

The command "make clang-analyzer" detects dead stores.

Do not reset io_end_size to 0 in the current paths, as the function
exists on those paths wihout further using io_end_sized.

Signed-off-by: Nghia Le <nghialm78@gmail.com>
---
 fs/ext4/inode.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 0f06305167d5..03efed2ed1ea 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2260,7 +2260,6 @@ static int mpage_process_page(struct mpage_da_data *mpd, struct page *page,
 			mpd->map.m_len = 0;
 			mpd->map.m_flags = 0;
 			io_end_vec->size += io_end_size;
-			io_end_size = 0;
 
 			err = mpage_process_page_bufs(mpd, head, bh, lblk);
 			if (err > 0)
@@ -2285,7 +2284,6 @@ static int mpage_process_page(struct mpage_da_data *mpd, struct page *page,
 	} while (lblk++, (bh = bh->b_this_page) != head);
 
 	io_end_vec->size += io_end_size;
-	io_end_size = 0;
 	*map_bh = false;
 out:
 	*m_lblk = lblk;
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#254): https://lists.elisa.tech/g/linux-safety/message/254
Mute This Topic: https://lists.elisa.tech/mt/86495840/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-



WARNING: multiple messages have this Message-ID (diff)
From: Nghia Le <nghialm78@gmail.com>
To: lukas.bulwahn@gmail.com, linux-safety@lists.elisa.tech
Cc: Nghia Le <nghialm78@gmail.com>
Subject: [PATCH v2] ext4: remove useless resetting io_end_size in mpage_process_page()
Date: Fri, 22 Oct 2021 00:42:42 +0700	[thread overview]
Message-ID: <20211021174242.20627-1-nghialm78@gmail.com> (raw)
Message-ID: <20211021174242.CR6NSOJ5I0XXzepaVnr4z0i0QZX0zOsU6zD8vEj-A2o@z> (raw)

The command "make clang-analyzer" detects dead stores.

Do not reset io_end_size to 0 in the current paths, as the function
exists on those paths wihout further using io_end_sized.

Signed-off-by: Nghia Le <nghialm78@gmail.com>
---
 fs/ext4/inode.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 0f06305167d5..03efed2ed1ea 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2260,7 +2260,6 @@ static int mpage_process_page(struct mpage_da_data *mpd, struct page *page,
 			mpd->map.m_len = 0;
 			mpd->map.m_flags = 0;
 			io_end_vec->size += io_end_size;
-			io_end_size = 0;
 
 			err = mpage_process_page_bufs(mpd, head, bh, lblk);
 			if (err > 0)
@@ -2285,7 +2284,6 @@ static int mpage_process_page(struct mpage_da_data *mpd, struct page *page,
 	} while (lblk++, (bh = bh->b_this_page) != head);
 
 	io_end_vec->size += io_end_size;
-	io_end_size = 0;
 	*map_bh = false;
 out:
 	*m_lblk = lblk;
-- 
2.25.1



             reply	other threads:[~2021-10-21 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 17:42 Nghia Le [this message]
2021-10-21 17:42 ` [PATCH v2] ext4: remove useless resetting io_end_size in mpage_process_page() Nghia Le
2021-10-25 15:49 ` Lukas Bulwahn
2021-10-25 15:49   ` [linux-safety] " Lukas Bulwahn
2021-10-25 22:25   ` Nghia Le
2021-10-25 22:25     ` [linux-safety] " Nghia Le

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211021174242.20627-1-nghialm78@gmail.com \
    --to=nghialm78@gmail.com \
    --cc=linux-safety@lists.elisa.tech \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.