All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: <linux-usb@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@kernel.org>
Cc: Daniel Mack <daniel@zonque.org>, <linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 03/10] usb: gadget: udc: pxa25x: fix deferred probing
Date: Thu, 21 Oct 2021 22:14:30 +0300	[thread overview]
Message-ID: <20211021191437.8737-4-s.shtylyov@omp.ru> (raw)
In-Reply-To: <20211021191437.8737-1-s.shtylyov@omp.ru>

The driver overrides the error codes returned by platform_get_irq() to
-ENODEV for some strange reason, so if it returns -EPROBE_DEFER, the driver
will fail the probe permanently instead of the deferred probing. Switch to
propagating the error codes upstream.

Fixes: 34ebcd28235d ("pxa2xx_udc: cleanups, use platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
 drivers/usb/gadget/udc/pxa25x_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c
index 52cdfd8212d6..b38747fd3bb0 100644
--- a/drivers/usb/gadget/udc/pxa25x_udc.c
+++ b/drivers/usb/gadget/udc/pxa25x_udc.c
@@ -2364,7 +2364,7 @@ static int pxa25x_udc_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0)
-		return -ENODEV;
+		return irq;
 
 	dev->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(dev->regs))
-- 
2.26.3


WARNING: multiple messages have this Message-ID (diff)
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: <linux-usb@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@kernel.org>
Cc: Daniel Mack <daniel@zonque.org>, <linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 03/10] usb: gadget: udc: pxa25x: fix deferred probing
Date: Thu, 21 Oct 2021 22:14:30 +0300	[thread overview]
Message-ID: <20211021191437.8737-4-s.shtylyov@omp.ru> (raw)
In-Reply-To: <20211021191437.8737-1-s.shtylyov@omp.ru>

The driver overrides the error codes returned by platform_get_irq() to
-ENODEV for some strange reason, so if it returns -EPROBE_DEFER, the driver
will fail the probe permanently instead of the deferred probing. Switch to
propagating the error codes upstream.

Fixes: 34ebcd28235d ("pxa2xx_udc: cleanups, use platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
 drivers/usb/gadget/udc/pxa25x_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c
index 52cdfd8212d6..b38747fd3bb0 100644
--- a/drivers/usb/gadget/udc/pxa25x_udc.c
+++ b/drivers/usb/gadget/udc/pxa25x_udc.c
@@ -2364,7 +2364,7 @@ static int pxa25x_udc_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0)
-		return -ENODEV;
+		return irq;
 
 	dev->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(dev->regs))
-- 
2.26.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-10-21 19:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 19:14 [PATCH 00/10] Fix deferred probing in the USB host/gadget drivers Sergey Shtylyov
2021-10-21 19:14 ` [PATCH 01/10] usb: gadget: udc: bcm63xx: fix deferred probing Sergey Shtylyov
2021-10-21 19:14   ` Sergey Shtylyov
2021-10-26 21:33   ` Florian Fainelli
2021-10-26 21:33     ` Florian Fainelli
2021-12-10 19:53     ` Sergey Shtylyov
2021-12-10 19:53       ` Sergey Shtylyov
2021-10-21 19:14 ` [PATCH 02/10] usb: gadget: udc: gr: " Sergey Shtylyov
2021-10-21 19:14 ` Sergey Shtylyov [this message]
2021-10-21 19:14   ` [PATCH 03/10] usb: gadget: udc: pxa25x: " Sergey Shtylyov
2021-10-21 19:14 ` [PATCH 04/10] usb: host: ehci-atmel: " Sergey Shtylyov
2021-10-21 19:14   ` Sergey Shtylyov
2021-10-21 19:21   ` Alan Stern
2021-10-21 19:21     ` Alan Stern
2021-10-21 19:14 ` [PATCH 05/10] usb: host: ehci-orion: " Sergey Shtylyov
2021-10-21 19:14 ` [PATCH 06/10] usb: host: ehci-sh: " Sergey Shtylyov
2021-10-21 19:14 ` [PATCH 07/10] usb: host: ohci-da8xx: " Sergey Shtylyov
2021-10-21 19:17   ` Sergey Shtylyov
2021-10-22  9:08     ` Greg Kroah-Hartman
2021-10-21 19:14 ` [PATCH 08/10] usb: host: ohci-nxp: " Sergey Shtylyov
2021-10-21 19:14   ` Sergey Shtylyov
2021-10-23 18:48   ` Vladimir Zapolskiy
2021-10-23 18:48     ` Vladimir Zapolskiy
2021-10-21 19:14 ` [PATCH 09/10] usb: host: ohci-omap: " Sergey Shtylyov
2021-10-21 19:14 ` [PATCH 10/10] usb: musb: core: " Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211021191437.8737-4-s.shtylyov@omp.ru \
    --to=s.shtylyov@omp.ru \
    --cc=balbi@kernel.org \
    --cc=daniel@zonque.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.