From: Jan Kara <jack@suse.cz> To: Christoph Hellwig <hch@lst.de> Cc: Andrew Morton <akpm@linux-foundation.org>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Jan Kara <jack@suse.cz>, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] mm: don't automatically unregister bdis Date: Fri, 22 Oct 2021 10:51:07 +0200 [thread overview] Message-ID: <20211022085107.GE1026@quack2.suse.cz> (raw) In-Reply-To: <20211021124441.668816-5-hch@lst.de> On Thu 21-10-21 14:44:40, Christoph Hellwig wrote: > All BDI users now unregister explicitly. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > mm/backing-dev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/backing-dev.c b/mm/backing-dev.c > index 8a46a0a4b72fa..768e9ae489f66 100644 > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -965,8 +965,7 @@ static void release_bdi(struct kref *ref) > struct backing_dev_info *bdi = > container_of(ref, struct backing_dev_info, refcnt); > > - if (test_bit(WB_registered, &bdi->wb.state)) > - bdi_unregister(bdi); > + WARN_ON_ONCE(test_bit(WB_registered, &bdi->wb.state)); > WARN_ON_ONCE(bdi->dev); > wb_exit(&bdi->wb); > kfree(bdi); > -- > 2.30.2 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz> To: Christoph Hellwig <hch@lst.de> Cc: Andrew Morton <akpm@linux-foundation.org>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Jan Kara <jack@suse.cz>, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] mm: don't automatically unregister bdis Date: Fri, 22 Oct 2021 10:51:07 +0200 [thread overview] Message-ID: <20211022085107.GE1026@quack2.suse.cz> (raw) In-Reply-To: <20211021124441.668816-5-hch@lst.de> On Thu 21-10-21 14:44:40, Christoph Hellwig wrote: > All BDI users now unregister explicitly. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > mm/backing-dev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/backing-dev.c b/mm/backing-dev.c > index 8a46a0a4b72fa..768e9ae489f66 100644 > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -965,8 +965,7 @@ static void release_bdi(struct kref *ref) > struct backing_dev_info *bdi = > container_of(ref, struct backing_dev_info, refcnt); > > - if (test_bit(WB_registered, &bdi->wb.state)) > - bdi_unregister(bdi); > + WARN_ON_ONCE(test_bit(WB_registered, &bdi->wb.state)); > WARN_ON_ONCE(bdi->dev); > wb_exit(&bdi->wb); > kfree(bdi); > -- > 2.30.2 > -- Jan Kara <jack@suse.com> SUSE Labs, CR ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-10-22 8:51 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-21 12:44 simplify bdi unregistation Christoph Hellwig 2021-10-21 12:44 ` Christoph Hellwig 2021-10-21 12:44 ` [PATCH 1/5] mm: export bdi_unregister Christoph Hellwig 2021-10-21 12:44 ` Christoph Hellwig 2021-10-22 8:41 ` Jan Kara 2021-10-22 8:41 ` Jan Kara 2021-10-21 12:44 ` [PATCH 2/5] mtd: call bdi_unregister explicitly Christoph Hellwig 2021-10-21 12:44 ` Christoph Hellwig 2021-10-22 8:43 ` Jan Kara 2021-10-22 8:43 ` Jan Kara 2021-10-21 12:44 ` [PATCH 3/5] fs: explicitly unregister per-superblock BDIs Christoph Hellwig 2021-10-21 12:44 ` Christoph Hellwig 2021-10-22 8:48 ` Jan Kara 2021-10-22 8:48 ` Jan Kara 2021-10-21 12:44 ` [PATCH 4/5] mm: don't automatically unregister bdis Christoph Hellwig 2021-10-21 12:44 ` Christoph Hellwig 2021-10-22 8:51 ` Jan Kara [this message] 2021-10-22 8:51 ` Jan Kara 2021-10-21 12:44 ` [PATCH 5/5] mm: simplify bdi refcounting Christoph Hellwig 2021-10-21 12:44 ` Christoph Hellwig 2021-10-22 9:02 ` Jan Kara 2021-10-22 9:02 ` Jan Kara 2021-10-27 7:42 ` Christoph Hellwig 2021-10-27 7:42 ` Christoph Hellwig 2021-10-27 9:47 ` Jan Kara 2021-10-27 9:47 ` Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211022085107.GE1026@quack2.suse.cz \ --to=jack@suse.cz \ --cc=akpm@linux-foundation.org \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.