* [PATCH] MIPS: Fix build error for brcmstb_gisb
@ 2021-10-22 11:27 Wang Haojun
2021-10-22 15:45 ` Thomas Bogendoerfer
0 siblings, 1 reply; 3+ messages in thread
From: Wang Haojun @ 2021-10-22 11:27 UTC (permalink / raw)
To: Thomas Bogendoerfer, Huacai Chen, Wang Haojun, Li Xuefeng; +Cc: linux-mips
The GISB bus error handler need board_be_handler, but this
code cannot used it when BRCMSTB_GISB_ARB is a module.
ERROR: modpost: "board_be_handler" [drivers/bus/brcmstb_gisb.ko] undefined!
Signed-off-by: Wang Haojun <wanghaojun@loongson.cn>
---
arch/mips/kernel/traps.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 6f07362de5ce..409bcc755b89 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -104,6 +104,7 @@ extern void tlb_do_page_fault_0(void);
void (*board_be_init)(void);
int (*board_be_handler)(struct pt_regs *regs, int is_fixup);
+EXPORT_SYMBOL_GPL(board_be_handler);
void (*board_nmi_handler_setup)(void);
void (*board_ejtag_handler_setup)(void);
void (*board_bind_eic_interrupt)(int irq, int regset);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: Fix build error for brcmstb_gisb
2021-10-22 11:27 [PATCH] MIPS: Fix build error for brcmstb_gisb Wang Haojun
@ 2021-10-22 15:45 ` Thomas Bogendoerfer
2021-10-23 1:46 ` 江流儿
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Bogendoerfer @ 2021-10-22 15:45 UTC (permalink / raw)
To: Wang Haojun; +Cc: Huacai Chen, Wang Haojun, Li Xuefeng, linux-mips
On Fri, Oct 22, 2021 at 07:27:08PM +0800, Wang Haojun wrote:
> The GISB bus error handler need board_be_handler, but this
> code cannot used it when BRCMSTB_GISB_ARB is a module.
>
> ERROR: modpost: "board_be_handler" [drivers/bus/brcmstb_gisb.ko] undefined!
maybe I'm missing a patch but in mips-next tree
config BRCMSTB_GISB_ARB
bool "Broadcom STB GISB bus arbiter"
this can't be a module...
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: Fix build error for brcmstb_gisb
2021-10-22 15:45 ` Thomas Bogendoerfer
@ 2021-10-23 1:46 ` 江流儿
0 siblings, 0 replies; 3+ messages in thread
From: 江流儿 @ 2021-10-23 1:46 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: Huacai Chen, Wang Haojun, Li Xuefeng, linux-mips
This was true before, But after 707a4cdf86e5d ("bus: brcmstb_gisb:
Allow building as module") BRCMSTB_GISB_ARB can be a module in
linux-next.
Thomas Bogendoerfer <tsbogend@alpha.franken.de> 于2021年10月22日周五 下午11:46写道:
>
> On Fri, Oct 22, 2021 at 07:27:08PM +0800, Wang Haojun wrote:
> > The GISB bus error handler need board_be_handler, but this
> > code cannot used it when BRCMSTB_GISB_ARB is a module.
> >
> > ERROR: modpost: "board_be_handler" [drivers/bus/brcmstb_gisb.ko] undefined!
>
> maybe I'm missing a patch but in mips-next tree
>
> config BRCMSTB_GISB_ARB
> bool "Broadcom STB GISB bus arbiter"
>
> this can't be a module...
>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-23 1:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 11:27 [PATCH] MIPS: Fix build error for brcmstb_gisb Wang Haojun
2021-10-22 15:45 ` Thomas Bogendoerfer
2021-10-23 1:46 ` 江流儿
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.