* [PATCH] ARM: stm32: Enable DFU MTD support on DHSOM
@ 2021-10-23 18:32 Marek Vasut
2021-10-25 6:53 ` Patrice CHOTARD
2021-10-25 8:24 ` Patrick DELAUNAY
0 siblings, 2 replies; 5+ messages in thread
From: Marek Vasut @ 2021-10-23 18:32 UTC (permalink / raw)
To: u-boot; +Cc: Marek Vasut, Patrice Chotard, Patrick Delaunay
All the STM32MP1 based DHSOM have SPI NOR from which they boot,
enable DFU_MTD support to make it possible to expose that SPI NOR
via the DFU.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
---
configs/stm32mp15_dhcom_basic_defconfig | 2 ++
configs/stm32mp15_dhcor_basic_defconfig | 2 ++
2 files changed, 4 insertions(+)
diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
index 5b85f6ad03b..083e199e511 100644
--- a/configs/stm32mp15_dhcom_basic_defconfig
+++ b/configs/stm32mp15_dhcom_basic_defconfig
@@ -81,6 +81,7 @@ CONFIG_TFTP_BLOCKSIZE=1536
CONFIG_STM32_ADC=y
CONFIG_SPL_BLOCK_CACHE=y
CONFIG_DFU_MMC=y
+CONFIG_DFU_MTD=y
CONFIG_DFU_RAM=y
CONFIG_DFU_VIRT=y
CONFIG_SET_DFU_ALT_INFO=y
@@ -98,6 +99,7 @@ CONFIG_SYS_I2C_EEPROM_ADDR=0x50
CONFIG_SUPPORT_EMMC_BOOT=y
CONFIG_STM32_SDMMC2=y
CONFIG_MTD=y
+CONFIG_DM_MTD=y
CONFIG_SYS_MTDPARTS_RUNTIME=y
CONFIG_DM_SPI_FLASH=y
CONFIG_SPI_FLASH_MACRONIX=y
diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
index 37dd2754c03..01ac3edb93e 100644
--- a/configs/stm32mp15_dhcor_basic_defconfig
+++ b/configs/stm32mp15_dhcor_basic_defconfig
@@ -79,6 +79,7 @@ CONFIG_STM32_ADC=y
CONFIG_SPL_BLOCK_CACHE=y
CONFIG_DFU_MMC=y
CONFIG_DFU_RAM=y
+CONFIG_DFU_MTD=y
CONFIG_DFU_VIRT=y
CONFIG_GPIO_HOG=y
CONFIG_DM_HWSPINLOCK=y
@@ -94,6 +95,7 @@ CONFIG_SYS_I2C_EEPROM_ADDR=0x53
CONFIG_SUPPORT_EMMC_BOOT=y
CONFIG_STM32_SDMMC2=y
CONFIG_MTD=y
+CONFIG_DM_MTD=y
CONFIG_DM_SPI_FLASH=y
CONFIG_SPI_FLASH_MACRONIX=y
CONFIG_SPI_FLASH_SPANSION=y
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: stm32: Enable DFU MTD support on DHSOM
2021-10-23 18:32 [PATCH] ARM: stm32: Enable DFU MTD support on DHSOM Marek Vasut
@ 2021-10-25 6:53 ` Patrice CHOTARD
2021-10-25 8:24 ` Patrick DELAUNAY
1 sibling, 0 replies; 5+ messages in thread
From: Patrice CHOTARD @ 2021-10-25 6:53 UTC (permalink / raw)
To: Marek Vasut, u-boot; +Cc: Patrick Delaunay
Hi Marek
On 10/23/21 8:32 PM, Marek Vasut wrote:
> All the STM32MP1 based DHSOM have SPI NOR from which they boot,
> enable DFU_MTD support to make it possible to expose that SPI NOR
> via the DFU.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> configs/stm32mp15_dhcom_basic_defconfig | 2 ++
> configs/stm32mp15_dhcor_basic_defconfig | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
> index 5b85f6ad03b..083e199e511 100644
> --- a/configs/stm32mp15_dhcom_basic_defconfig
> +++ b/configs/stm32mp15_dhcom_basic_defconfig
> @@ -81,6 +81,7 @@ CONFIG_TFTP_BLOCKSIZE=1536
> CONFIG_STM32_ADC=y
> CONFIG_SPL_BLOCK_CACHE=y
> CONFIG_DFU_MMC=y
> +CONFIG_DFU_MTD=y
> CONFIG_DFU_RAM=y
> CONFIG_DFU_VIRT=y
> CONFIG_SET_DFU_ALT_INFO=y
> @@ -98,6 +99,7 @@ CONFIG_SYS_I2C_EEPROM_ADDR=0x50
> CONFIG_SUPPORT_EMMC_BOOT=y
> CONFIG_STM32_SDMMC2=y
> CONFIG_MTD=y
> +CONFIG_DM_MTD=y
> CONFIG_SYS_MTDPARTS_RUNTIME=y
> CONFIG_DM_SPI_FLASH=y
> CONFIG_SPI_FLASH_MACRONIX=y
> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
> index 37dd2754c03..01ac3edb93e 100644
> --- a/configs/stm32mp15_dhcor_basic_defconfig
> +++ b/configs/stm32mp15_dhcor_basic_defconfig
> @@ -79,6 +79,7 @@ CONFIG_STM32_ADC=y
> CONFIG_SPL_BLOCK_CACHE=y
> CONFIG_DFU_MMC=y
> CONFIG_DFU_RAM=y
> +CONFIG_DFU_MTD=y
> CONFIG_DFU_VIRT=y
> CONFIG_GPIO_HOG=y
> CONFIG_DM_HWSPINLOCK=y
> @@ -94,6 +95,7 @@ CONFIG_SYS_I2C_EEPROM_ADDR=0x53
> CONFIG_SUPPORT_EMMC_BOOT=y
> CONFIG_STM32_SDMMC2=y
> CONFIG_MTD=y
> +CONFIG_DM_MTD=y
> CONFIG_DM_SPI_FLASH=y
> CONFIG_SPI_FLASH_MACRONIX=y
> CONFIG_SPI_FLASH_SPANSION=y
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: stm32: Enable DFU MTD support on DHSOM
2021-10-23 18:32 [PATCH] ARM: stm32: Enable DFU MTD support on DHSOM Marek Vasut
2021-10-25 6:53 ` Patrice CHOTARD
@ 2021-10-25 8:24 ` Patrick DELAUNAY
2021-10-25 8:48 ` Marek Vasut
1 sibling, 1 reply; 5+ messages in thread
From: Patrick DELAUNAY @ 2021-10-25 8:24 UTC (permalink / raw)
To: Marek Vasut, u-boot; +Cc: Patrice Chotard
Hi Marek,
On 10/23/21 8:32 PM, Marek Vasut wrote:
> All the STM32MP1 based DHSOM have SPI NOR from which they boot,
> enable DFU_MTD support to make it possible to expose that SPI NOR
> via the DFU.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> configs/stm32mp15_dhcom_basic_defconfig | 2 ++
> configs/stm32mp15_dhcor_basic_defconfig | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
> index 5b85f6ad03b..083e199e511 100644
> --- a/configs/stm32mp15_dhcom_basic_defconfig
> +++ b/configs/stm32mp15_dhcom_basic_defconfig
> @@ -81,6 +81,7 @@ CONFIG_TFTP_BLOCKSIZE=1536
> CONFIG_STM32_ADC=y
> CONFIG_SPL_BLOCK_CACHE=y
> CONFIG_DFU_MMC=y
> +CONFIG_DFU_MTD=y
> CONFIG_DFU_RAM=y
> CONFIG_DFU_VIRT=y
> CONFIG_SET_DFU_ALT_INFO=y
> @@ -98,6 +99,7 @@ CONFIG_SYS_I2C_EEPROM_ADDR=0x50
> CONFIG_SUPPORT_EMMC_BOOT=y
> CONFIG_STM32_SDMMC2=y
> CONFIG_MTD=y
> +CONFIG_DM_MTD=y
> CONFIG_SYS_MTDPARTS_RUNTIME=y
> CONFIG_DM_SPI_FLASH=y
> CONFIG_SPI_FLASH_MACRONIX=y
> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
> index 37dd2754c03..01ac3edb93e 100644
> --- a/configs/stm32mp15_dhcor_basic_defconfig
> +++ b/configs/stm32mp15_dhcor_basic_defconfig
> @@ -79,6 +79,7 @@ CONFIG_STM32_ADC=y
> CONFIG_SPL_BLOCK_CACHE=y
> CONFIG_DFU_MMC=y
> CONFIG_DFU_RAM=y
> +CONFIG_DFU_MTD=y
> CONFIG_DFU_VIRT=y
> CONFIG_GPIO_HOG=y
> CONFIG_DM_HWSPINLOCK=y
> @@ -94,6 +95,7 @@ CONFIG_SYS_I2C_EEPROM_ADDR=0x53
> CONFIG_SUPPORT_EMMC_BOOT=y
> CONFIG_STM32_SDMMC2=y
> CONFIG_MTD=y
> +CONFIG_DM_MTD=y
> CONFIG_DM_SPI_FLASH=y
> CONFIG_SPI_FLASH_MACRONIX=y
> CONFIG_SPI_FLASH_SPANSION=y
minor, detected by
grep -l stm32mp15 configs/* | ./tools/moveconfig.py -s -d -
index 083e199e51..9df475d156 100644
@@ -81,8 +81,8 @@ CONFIG_TFTP_BLOCKSIZE=1536
CONFIG_STM32_ADC=y
CONFIG_SPL_BLOCK_CACHE=y
CONFIG_DFU_MMC=y
-CONFIG_DFU_MTD=y
CONFIG_DFU_RAM=y
+CONFIG_DFU_MTD=y
CONFIG_DFU_VIRT=y
CONFIG_SET_DFU_ALT_INFO=y
CONFIG_GPIO_HOG=y
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Thanks
Patrick
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: stm32: Enable DFU MTD support on DHSOM
2021-10-25 8:24 ` Patrick DELAUNAY
@ 2021-10-25 8:48 ` Marek Vasut
2021-11-10 15:59 ` Patrice CHOTARD
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2021-10-25 8:48 UTC (permalink / raw)
To: Patrick DELAUNAY, u-boot; +Cc: Patrice Chotard
On 10/25/21 10:24 AM, Patrick DELAUNAY wrote:
> Hi Marek,
>
> On 10/23/21 8:32 PM, Marek Vasut wrote:
>> All the STM32MP1 based DHSOM have SPI NOR from which they boot,
>> enable DFU_MTD support to make it possible to expose that SPI NOR
>> via the DFU.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> ---
>> configs/stm32mp15_dhcom_basic_defconfig | 2 ++
>> configs/stm32mp15_dhcor_basic_defconfig | 2 ++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/configs/stm32mp15_dhcom_basic_defconfig
>> b/configs/stm32mp15_dhcom_basic_defconfig
>> index 5b85f6ad03b..083e199e511 100644
>> --- a/configs/stm32mp15_dhcom_basic_defconfig
>> +++ b/configs/stm32mp15_dhcom_basic_defconfig
>> @@ -81,6 +81,7 @@ CONFIG_TFTP_BLOCKSIZE=1536
>> CONFIG_STM32_ADC=y
>> CONFIG_SPL_BLOCK_CACHE=y
>> CONFIG_DFU_MMC=y
>> +CONFIG_DFU_MTD=y
>> CONFIG_DFU_RAM=y
>> CONFIG_DFU_VIRT=y
>> CONFIG_SET_DFU_ALT_INFO=y
>> @@ -98,6 +99,7 @@ CONFIG_SYS_I2C_EEPROM_ADDR=0x50
>> CONFIG_SUPPORT_EMMC_BOOT=y
>> CONFIG_STM32_SDMMC2=y
>> CONFIG_MTD=y
>> +CONFIG_DM_MTD=y
>> CONFIG_SYS_MTDPARTS_RUNTIME=y
>> CONFIG_DM_SPI_FLASH=y
>> CONFIG_SPI_FLASH_MACRONIX=y
>> diff --git a/configs/stm32mp15_dhcor_basic_defconfig
>> b/configs/stm32mp15_dhcor_basic_defconfig
>> index 37dd2754c03..01ac3edb93e 100644
>> --- a/configs/stm32mp15_dhcor_basic_defconfig
>> +++ b/configs/stm32mp15_dhcor_basic_defconfig
>> @@ -79,6 +79,7 @@ CONFIG_STM32_ADC=y
>> CONFIG_SPL_BLOCK_CACHE=y
>> CONFIG_DFU_MMC=y
>> CONFIG_DFU_RAM=y
>> +CONFIG_DFU_MTD=y
>> CONFIG_DFU_VIRT=y
>> CONFIG_GPIO_HOG=y
>> CONFIG_DM_HWSPINLOCK=y
>> @@ -94,6 +95,7 @@ CONFIG_SYS_I2C_EEPROM_ADDR=0x53
>> CONFIG_SUPPORT_EMMC_BOOT=y
>> CONFIG_STM32_SDMMC2=y
>> CONFIG_MTD=y
>> +CONFIG_DM_MTD=y
>> CONFIG_DM_SPI_FLASH=y
>> CONFIG_SPI_FLASH_MACRONIX=y
>> CONFIG_SPI_FLASH_SPANSION=y
>
>
> minor, detected by
>
> grep -l stm32mp15 configs/* | ./tools/moveconfig.py -s -d -
I'll rather send Kconfig patch to sort the symbols in
drivers/dfu/Kconfig alphabetically likely today, then this patch would
be fine as-is.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: stm32: Enable DFU MTD support on DHSOM
2021-10-25 8:48 ` Marek Vasut
@ 2021-11-10 15:59 ` Patrice CHOTARD
0 siblings, 0 replies; 5+ messages in thread
From: Patrice CHOTARD @ 2021-11-10 15:59 UTC (permalink / raw)
To: Marek Vasut, Patrick DELAUNAY, u-boot
HI Marek
On 10/25/21 10:48 AM, Marek Vasut wrote:
> On 10/25/21 10:24 AM, Patrick DELAUNAY wrote:
>> Hi Marek,
>>
>> On 10/23/21 8:32 PM, Marek Vasut wrote:
>>> All the STM32MP1 based DHSOM have SPI NOR from which they boot,
>>> enable DFU_MTD support to make it possible to expose that SPI NOR
>>> via the DFU.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>>> ---
>>> configs/stm32mp15_dhcom_basic_defconfig | 2 ++
>>> configs/stm32mp15_dhcor_basic_defconfig | 2 ++
>>> 2 files changed, 4 insertions(+)
>>>
>>> diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
>>> index 5b85f6ad03b..083e199e511 100644
>>> --- a/configs/stm32mp15_dhcom_basic_defconfig
>>> +++ b/configs/stm32mp15_dhcom_basic_defconfig
>>> @@ -81,6 +81,7 @@ CONFIG_TFTP_BLOCKSIZE=1536
>>> CONFIG_STM32_ADC=y
>>> CONFIG_SPL_BLOCK_CACHE=y
>>> CONFIG_DFU_MMC=y
>>> +CONFIG_DFU_MTD=y
>>> CONFIG_DFU_RAM=y
>>> CONFIG_DFU_VIRT=y
>>> CONFIG_SET_DFU_ALT_INFO=y
>>> @@ -98,6 +99,7 @@ CONFIG_SYS_I2C_EEPROM_ADDR=0x50
>>> CONFIG_SUPPORT_EMMC_BOOT=y
>>> CONFIG_STM32_SDMMC2=y
>>> CONFIG_MTD=y
>>> +CONFIG_DM_MTD=y
>>> CONFIG_SYS_MTDPARTS_RUNTIME=y
>>> CONFIG_DM_SPI_FLASH=y
>>> CONFIG_SPI_FLASH_MACRONIX=y
>>> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
>>> index 37dd2754c03..01ac3edb93e 100644
>>> --- a/configs/stm32mp15_dhcor_basic_defconfig
>>> +++ b/configs/stm32mp15_dhcor_basic_defconfig
>>> @@ -79,6 +79,7 @@ CONFIG_STM32_ADC=y
>>> CONFIG_SPL_BLOCK_CACHE=y
>>> CONFIG_DFU_MMC=y
>>> CONFIG_DFU_RAM=y
>>> +CONFIG_DFU_MTD=y
>>> CONFIG_DFU_VIRT=y
>>> CONFIG_GPIO_HOG=y
>>> CONFIG_DM_HWSPINLOCK=y
>>> @@ -94,6 +95,7 @@ CONFIG_SYS_I2C_EEPROM_ADDR=0x53
>>> CONFIG_SUPPORT_EMMC_BOOT=y
>>> CONFIG_STM32_SDMMC2=y
>>> CONFIG_MTD=y
>>> +CONFIG_DM_MTD=y
>>> CONFIG_DM_SPI_FLASH=y
>>> CONFIG_SPI_FLASH_MACRONIX=y
>>> CONFIG_SPI_FLASH_SPANSION=y
>>
>>
>> minor, detected by
>>
>> grep -l stm32mp15 configs/* | ./tools/moveconfig.py -s -d -
>
> I'll rather send Kconfig patch to sort the symbols in drivers/dfu/Kconfig alphabetically likely today, then this patch would be fine as-is.
Applied on u-boot-stm/master
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-10 15:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-23 18:32 [PATCH] ARM: stm32: Enable DFU MTD support on DHSOM Marek Vasut
2021-10-25 6:53 ` Patrice CHOTARD
2021-10-25 8:24 ` Patrick DELAUNAY
2021-10-25 8:48 ` Marek Vasut
2021-11-10 15:59 ` Patrice CHOTARD
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.