* [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1
@ 2021-10-25 22:43 Adrian Perez de Castro
2021-10-25 22:44 ` [Buildroot] [PATCH 1/4] package/libwpe: bump to version 1.12.0 Adrian Perez de Castro
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2021-10-25 22:43 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro
Hi all,
This patch set updates WPE WebKit and its dependencies to the latest releases
of their current stable series. As often happens, I needed to make a patch to
fix the build with multimedia support disabled, and that has been sent to
upstream WebKit as well.
An additional patch to enable the new color management is in the series as
well; but for the moment the support to build with libsoup3 is left out.
I would rather submit that as part of different "add libsoup3 and enable
where supported" patch set some other day ;-)
Cheers,
-Adrian
Adrian Perez de Castro (4):
package/libwpe: bump to version 1.12.0
package/wpebackend-fdo: bump to version 1.12.0
package/wpewebkit: bump to version 2.34.1
package/wpewebkit: use lcms2 for if available
package/libwpe/libwpe.hash | 8 +-
package/libwpe/libwpe.mk | 2 +-
package/wpebackend-fdo/wpebackend-fdo.hash | 8 +-
package/wpebackend-fdo/wpebackend-fdo.mk | 2 +-
...e-build-issues-with-ENABLE_VIDEO-OFF.patch | 78 +++++++++++++++++++
package/wpewebkit/wpewebkit.hash | 8 +-
package/wpewebkit/wpewebkit.mk | 11 ++-
7 files changed, 102 insertions(+), 15 deletions(-)
create mode 100644 package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
--
2.33.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/4] package/libwpe: bump to version 1.12.0
2021-10-25 22:43 [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1 Adrian Perez de Castro
@ 2021-10-25 22:44 ` Adrian Perez de Castro
2021-10-25 22:44 ` [Buildroot] [PATCH 2/4] package/wpebackend-fdo: " Adrian Perez de Castro
` (3 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2021-10-25 22:44 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro
Release notes:
https://wpewebkit.org/release/libwpe-1.12.0.html
Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
package/libwpe/libwpe.hash | 8 ++++----
package/libwpe/libwpe.mk | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/package/libwpe/libwpe.hash b/package/libwpe/libwpe.hash
index 200b6c2798..2ebe4f19bd 100644
--- a/package/libwpe/libwpe.hash
+++ b/package/libwpe/libwpe.hash
@@ -1,7 +1,7 @@
-# From https://wpewebkit.org/releases/libwpe-1.10.1.tar.xz.sums
-md5 f60fc13b519a66d262afb76c77441870 libwpe-1.10.1.tar.xz
-sha1 1a8085b9a172d37e952c07bbb09b1654d4161ab2 libwpe-1.10.1.tar.xz
-sha256 a327b3ffcf2356dbe8148c1db4bbdc5359d7e7163d177f67551a8393b144adf0 libwpe-1.10.1.tar.xz
+# From https://wpewebkit.org/releases/libwpe-1.12.0.tar.xz.sums
+md5 5a3f11789535d826370ba465ea141393 libwpe-1.12.0.tar.xz
+sha1 91aa47a593a5db511d667b3bdbaa76dee4301311 libwpe-1.12.0.tar.xz
+sha256 e8eeca228a6b4c36294cfb63f7d3ba9ada47a430904a5a973b3c99c96a44c18c libwpe-1.12.0.tar.xz
# Hashes for license files:
sha256 35bef295cedbbf179eaee14328002587a0e7dc08ebf3f15ea080a6f2815f0d7b COPYING
diff --git a/package/libwpe/libwpe.mk b/package/libwpe/libwpe.mk
index 6396fe696d..fe3c4b16d7 100644
--- a/package/libwpe/libwpe.mk
+++ b/package/libwpe/libwpe.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LIBWPE_VERSION = 1.10.1
+LIBWPE_VERSION = 1.12.0
LIBWPE_SITE = https://wpewebkit.org/releases
LIBWPE_SOURCE = libwpe-$(LIBWPE_VERSION).tar.xz
LIBWPE_INSTALL_STAGING = YES
--
2.33.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 2/4] package/wpebackend-fdo: bump to version 1.12.0
2021-10-25 22:43 [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1 Adrian Perez de Castro
2021-10-25 22:44 ` [Buildroot] [PATCH 1/4] package/libwpe: bump to version 1.12.0 Adrian Perez de Castro
@ 2021-10-25 22:44 ` Adrian Perez de Castro
2021-10-25 22:44 ` [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1 Adrian Perez de Castro
` (2 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2021-10-25 22:44 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro
Most of the changes from this release were already in 1.10.0, but it
has some Meson build fixes and the new DMA-BUF buffer pool support.
Release notes:
https://wpewebkit.org/release/wpebackend-fdo-1.12.0.html
Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
package/wpebackend-fdo/wpebackend-fdo.hash | 8 ++++----
package/wpebackend-fdo/wpebackend-fdo.mk | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/package/wpebackend-fdo/wpebackend-fdo.hash b/package/wpebackend-fdo/wpebackend-fdo.hash
index f280024b28..06289900b0 100644
--- a/package/wpebackend-fdo/wpebackend-fdo.hash
+++ b/package/wpebackend-fdo/wpebackend-fdo.hash
@@ -1,7 +1,7 @@
-# From https://wpewebkit.org/releases/wpebackend-fdo-1.10.0.tar.xz.sums
-md5 306adbb0c66dc753e1794c83b7a2682b wpebackend-fdo-1.10.0.tar.xz
-sha1 bf71718a213c6511dea278ade5ce90967d181995 wpebackend-fdo-1.10.0.tar.xz
-sha256 b89dfd3500a4dec711132cd7bff72599e67d56a419d000730e14bb99547509cc wpebackend-fdo-1.10.0.tar.xz
+# From https://wpewebkit.org/releases/wpebackend-fdo-1.12.0.tar.xz.sums
+md5 c43b34a4b4933bcd80068ae5776ee346 wpebackend-fdo-1.12.0.tar.xz
+sha1 e2576d564bd6d9a86737a4cd31dd5827ebc00fdf wpebackend-fdo-1.12.0.tar.xz
+sha256 6239c9c15523410798d66315de6b491712ab30009ba180f3e0dd076d9b0074ac wpebackend-fdo-1.12.0.tar.xz
# Hashes for license files:
sha256 c9f6803371047fad3e72200ec6cd226329a5ee08ac61104c8211c2761fb46825 COPYING
diff --git a/package/wpebackend-fdo/wpebackend-fdo.mk b/package/wpebackend-fdo/wpebackend-fdo.mk
index 72f0ad9019..5fe9c5397f 100644
--- a/package/wpebackend-fdo/wpebackend-fdo.mk
+++ b/package/wpebackend-fdo/wpebackend-fdo.mk
@@ -4,7 +4,7 @@
#
################################################################################
-WPEBACKEND_FDO_VERSION = 1.10.0
+WPEBACKEND_FDO_VERSION = 1.12.0
WPEBACKEND_FDO_SITE = https://wpewebkit.org/releases
WPEBACKEND_FDO_SOURCE = wpebackend-fdo-$(WPEBACKEND_FDO_VERSION).tar.xz
WPEBACKEND_FDO_INSTALL_STAGING = YES
--
2.33.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1
2021-10-25 22:43 [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1 Adrian Perez de Castro
2021-10-25 22:44 ` [Buildroot] [PATCH 1/4] package/libwpe: bump to version 1.12.0 Adrian Perez de Castro
2021-10-25 22:44 ` [Buildroot] [PATCH 2/4] package/wpebackend-fdo: " Adrian Perez de Castro
@ 2021-10-25 22:44 ` Adrian Perez de Castro
2021-10-30 18:29 ` James Hilliard
2021-11-17 21:02 ` Arnout Vandecappelle
2021-10-25 22:44 ` [Buildroot] [PATCH 4/4] package/wpewebkit: use lcms2 for if available Adrian Perez de Castro
2021-11-17 21:02 ` [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1 Arnout Vandecappelle
4 siblings, 2 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2021-10-25 22:44 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro
Update to a new major release which brings in improvements and a number
of new features. Release notes:
https://wpewebkit.org/release/wpewebkit-2.34.0.html
https://wpewebkit.org/release/wpewebkit-2.34.1.html
Some of the new features require additional dependencies: HTTP/2
requires libsoup3, which is not yet in packaged in Buildroot, and
disabled at the moment (with -DUSE_SOUP2=ON, to keep using libsoup2);
and the color management support needs LCMS2 (which will be enabled
in a follow-up patch.)
Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
...e-build-issues-with-ENABLE_VIDEO-OFF.patch | 78 +++++++++++++++++++
package/wpewebkit/wpewebkit.hash | 8 +-
package/wpewebkit/wpewebkit.mk | 4 +-
3 files changed, 85 insertions(+), 5 deletions(-)
create mode 100644 package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
diff --git a/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
new file mode 100644
index 0000000000..51212dd82d
--- /dev/null
+++ b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
@@ -0,0 +1,78 @@
+From afc83d41293333f694630451f865a7a257a9b917 Mon Sep 17 00:00:00 2001
+From: Adrian Perez de Castro <aperez@igalia.com>
+Date: Mon, 25 Oct 2021 23:45:15 +0300
+Subject: [PATCH] [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF
+ https://bugs.webkit.org/show_bug.cgi?id=232264
+
+.:
+
+Reviewed by NOBODY (OOPS!).
+
+* Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_SESSION depend on ENABLE_VIDEO.
+
+Source/WebCore:
+
+Reviewed by NOBODY (OOPS!).
+
+No new tests needed.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::isSimpleImage): Guard usage of HTMLMediaElement with ENABLE(VIDEO).
+* page/EventHandler.cpp:
+(WebCore::EventHandler::textRecognitionCandidateElement const): Ditto.
+* platform/graphics/BifurcatedGraphicsContext.cpp: Ditto.
+* platform/graphics/displaylists/DisplayListRecorder.h: Guard usage of MediaPlayer with
+ENABLE(VIDEO).
+* platform/graphics/displaylists/DisplayListRecorderImpl.cpp: Ditto.
+* platform/graphics/displaylists/DisplayListRecorderImpl.h: Ditto.
+
+Source/WebKit:
+
+* WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
+(WebKit::createShareableBitmap): Guard usage of RenderVideo with ENABLE(VIDEO).
+
+Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
+---
+Upstream status: https://bugs.webkit.org/show_bug.cgi?id=232264
+
+ Source/WebCore/accessibility/AXObjectCache.cpp | 2 ++
+ Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp | 2 ++
+ 2 files changed, 4 insertions(+)
+
+diff --git a/Source/WebCore/accessibility/AXObjectCache.cpp b/Source/WebCore/accessibility/AXObjectCache.cpp
+index f2451102040..930b969dcc2 100644
+--- a/Source/WebCore/accessibility/AXObjectCache.cpp
++++ b/Source/WebCore/accessibility/AXObjectCache.cpp
+@@ -528,9 +528,11 @@ static bool isSimpleImage(const RenderObject& renderer)
+ || (is<HTMLImageElement>(node) && downcast<HTMLImageElement>(node)->hasAttributeWithoutSynchronization(usemapAttr)))
+ return false;
+
++#if ENABLE(VIDEO)
+ // Exclude video and audio elements.
+ if (is<HTMLMediaElement>(node))
+ return false;
++#endif // ENABLE(VIDEO)
+
+ return true;
+ }
+diff --git a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
+index c0ce72c5ffc..d7ead303f3c 100644
+--- a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
++++ b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
+@@ -269,11 +269,13 @@ void BifurcatedGraphicsContext::drawPattern(NativeImage& nativeImage, const Floa
+ m_secondaryContext.drawPattern(nativeImage, imageSize, destRect, tileRect, patternTransform, phase, spacing, options);
+ }
+
++#if ENABLE(VIDEO)
+ void BifurcatedGraphicsContext::paintFrameForMedia(MediaPlayer& player, const FloatRect& destination)
+ {
+ m_primaryContext.paintFrameForMedia(player, destination);
+ m_secondaryContext.paintFrameForMedia(player, destination);
+ }
++#endif // ENABLE(VIDEO)
+
+ void BifurcatedGraphicsContext::scale(const FloatSize& scale)
+ {
+--
+2.33.1
+
diff --git a/package/wpewebkit/wpewebkit.hash b/package/wpewebkit/wpewebkit.hash
index ff8bd1f30a..acb3ec4a3e 100644
--- a/package/wpewebkit/wpewebkit.hash
+++ b/package/wpewebkit/wpewebkit.hash
@@ -1,7 +1,7 @@
-# From https://wpewebkit.org/releases/wpewebkit-2.32.4.tar.xz.sums
-md5 94ca1cc3f7b2de8b96c59d6e59cafcd0 wpewebkit-2.32.4.tar.xz
-sha1 19b8ebdbfef193ca50f7625703d871db87624f86 wpewebkit-2.32.4.tar.xz
-sha256 381f1422cbc319db1aa42dda48de39590ed90ac3bec6b81ec83f3f2cae5c3eeb wpewebkit-2.32.4.tar.xz
+# From https://wpewebkit.org/releases/wpewebkit-2.34.1.tar.xz.sums
+md5 915e583b0e7e82efa155cbce917d6319 wpewebkit-2.34.1.tar.xz
+sha1 452081b6df9d079f26d22bd0dca9e90f87943089 wpewebkit-2.34.1.tar.xz
+sha256 cb336986341be9c3a9b1ca2c18de0d29d90ae4e77b9967a6f6879597e7a969f7 wpewebkit-2.34.1.tar.xz
# Hashes for license files:
sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
index 0242f7a288..606a1531c0 100644
--- a/package/wpewebkit/wpewebkit.mk
+++ b/package/wpewebkit/wpewebkit.mk
@@ -4,7 +4,7 @@
#
################################################################################
-WPEWEBKIT_VERSION = 2.32.4
+WPEWEBKIT_VERSION = 2.34.1
WPEWEBKIT_SITE = http://www.wpewebkit.org/releases
WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz
WPEWEBKIT_INSTALL_STAGING = YES
@@ -23,6 +23,8 @@ WPEWEBKIT_CONF_OPTS = \
-DENABLE_ACCESSIBILITY=OFF \
-DENABLE_API_TESTS=OFF \
-DENABLE_MINIBROWSER=OFF \
+ -DUSE_LCMS=OFF \
+ -DUSE_SOUP2=ON \
-DSILENCE_CROSS_COMPILATION_NOTICES=ON
ifeq ($(BR2_PACKAGE_WPEWEBKIT_SANDBOX),y)
--
2.33.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 4/4] package/wpewebkit: use lcms2 for if available
2021-10-25 22:43 [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1 Adrian Perez de Castro
` (2 preceding siblings ...)
2021-10-25 22:44 ` [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1 Adrian Perez de Castro
@ 2021-10-25 22:44 ` Adrian Perez de Castro
2021-11-17 21:03 ` Arnout Vandecappelle
2021-11-17 21:02 ` [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1 Arnout Vandecappelle
4 siblings, 1 reply; 14+ messages in thread
From: Adrian Perez de Castro @ 2021-10-25 22:44 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro
Make wpewebkit support color management if the lcms2 package
has been selected.
Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
package/wpewebkit/wpewebkit.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
index 606a1531c0..ab45d4a67c 100644
--- a/package/wpewebkit/wpewebkit.mk
+++ b/package/wpewebkit/wpewebkit.mk
@@ -67,6 +67,13 @@ else
WPEWEBKIT_CONF_OPTS += -DENABLE_WEBDRIVER=OFF
endif
+ifeq ($(BR2_PACKAGE_LCMS2),y)
+WPEWEBKIT_CONF_OPTS += -DUSE_LCMS=ON
+WPEWEBKIT_DEPENDENCIES += lcms2
+else
+WPEWEBKIT_CONF_OPTS += -DUSE_LCMS=OFF
+endif
+
ifeq ($(BR2_PACKAGE_WOFF2),y)
WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=ON
WPEWEBKIT_DEPENDENCIES += woff2
--
2.33.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1
2021-10-25 22:44 ` [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1 Adrian Perez de Castro
@ 2021-10-30 18:29 ` James Hilliard
2021-12-07 14:07 ` James Hilliard
2021-11-17 21:02 ` Arnout Vandecappelle
1 sibling, 1 reply; 14+ messages in thread
From: James Hilliard @ 2021-10-30 18:29 UTC (permalink / raw)
To: Adrian Perez de Castro; +Cc: buildroot
Looks like there's a crash when loading gstreamer mediastream devices
or something:
#0 __pthread_kill_internal (signo=6, threadid=<optimized out>) at
pthread_kill.c:45
#1 __GI___pthread_kill (threadid=<optimized out>,
signo=signo@entry=6) at pthread_kill.c:62
#2 0x00007f266d284382 in __GI_raise (sig=sig@entry=6) at
../sysdeps/posix/raise.c:26
#3 0x00007f266d26f43f in __GI_abort () at abort.c:79
#4 0x00007f266e5679e0 in CRASH_WITH_INFO(...) () at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Assertions.h:750
#5 WebCore::makeGStreamerBin (description=<optimized out>,
ghostUnlinkedPads=<optimized out>)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:516
#6 0x00007f266f662f35 in WebCore::GStreamerCapturer::setupPipeline
(this=0x7f25e3ea75b0)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:151
#7 0x00007f266f66386a in
WebCore::GStreamerVideoCaptureSource::startProducingData
(this=0x7f2605217a00)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:183
#8 0x00007f266f13de98 in WebCore::RealtimeMediaSource::start
(this=0x7f2605217a00) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:231
#9 WebCore::RealtimeMediaSource::start (this=0x7f2605217a00) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:223
#10 0x00007f266f13df9c in WebCore::RealtimeMediaSource::setMuted
(this=0x7f2605217a00, muted=<optimized out>)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:117
#11 0x00007f266e9e761e in WebCore::MediaStreamTrackPrivate::setMuted
(muted=<optimized out>, this=<optimized out>)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h:87
#12 0x00007f266e9eb04d in WebCore::MediaStreamTrack::create
(context=..., privateTrack=...) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:76
#13 0x00007f266e9ebb13 in WebCore::MediaStream::MediaStream
(this=0x7f260571c8b0, document=..., streamPrivate=...) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/RefCounted.h:49
#14 0x00007f266e9ebbd7 in WebCore::MediaStream::create (document=...,
streamPrivate=...) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/MediaStream.cpp:63
#15 0x00007f266e9f7971 in
operator()<std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate>,
WTF::String> > (privateStreamOrError=..., __closure=0x7f25e84815d8)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:260
#16 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&,
WebCore::CaptureDevice&&, WTF::String&&,
WTF::CompletionHandler<void()>&&)::<lambda()>
mutable::<lambda(auto:44)>, void,
std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >,
WTF::String>&&>::call(std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >, WTF::String> &&)
(this=0x7f25e84815d0, in#0=...) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
#17 0x00007f266f13fde1 in operator()<WTF::String> (errorMessage=...,
this=0x7f25e3ed3968) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:112
#18 WTF::Detail::CallableWrapper<WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<const
WTF::Logger, WTF::RawPtrTraits<const WTF::Logger> >&&,
WebCore::RealtimeMediaSourceCenter::NewMediaStreamHandler&&,
WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
const WebCore::MediaStreamRequest&)::<lambda(auto:26&&)> mutable [with
auto:26 = WTF::String]::<lambda(auto:27&&)>, void,
WTF::String&&>::call(WTF::String &&) (
this=0x7f25e3ed3960, in#0=...) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
#19 0x00007f266e1ed059 in WTF::Function<void
(WTF::String&&)>::operator()(WTF::String&&) const (in#0=...,
this=<optimized out>) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
#20 WTF::CompletionHandler<void
(WTF::String&&)>::operator()(WTF::String&&) (this=<optimized out>,
in#0=...) at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
#21 0x00007f266e19b436 in WTF::Function<void
(WTF::String)>::operator()(WTF::String) const (in#0=...,
this=<optimized out>) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
#22 WTF::CompletionHandler<void
(WTF::String)>::operator()(WTF::String)
(this=this@entry=0x7ffd53b9eff8, in#0=...) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
#23 0x00007f266e19b49b in
WebCore::RealtimeMediaSource::whenReady(WTF::CompletionHandler<void
(WTF::String)>&&) (this=this@entry=0x7f2605217a00, callback=...)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WebCore/PrivateHeaders/WebCore/RealtimeMediaSource.h:322
#24 0x00007f266f13fca1 in operator()<WTF::String> (errorMessage=...,
__closure=<optimized out>)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:114
#25 WTF::Detail::CallableWrapper<WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<const
WTF::Logger, WTF::RawPtrTraits<const WTF::Logger> >&&,
WebCore::RealtimeMediaSourceCenter::NewMediaStreamHandler&&,
WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
const WebCore::MediaStreamRequest&)::<lambda(auto:26&&)>, void,
WTF::String&&>::call(WTF::String &&) (this=<optimized out>, in#0=...)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
#26 0x00007f266e1ed059 in WTF::Function<void
(WTF::String&&)>::operator()(WTF::String&&) const (in#0=...,
this=<optimized out>) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
#27 WTF::CompletionHandler<void
(WTF::String&&)>::operator()(WTF::String&&) (this=<optimized out>,
in#0=...) at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
#28 0x00007f266f13f9e6 in
WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<WTF::Logger
const, WTF::RawPtrTraits<WTF::Logger const> >&&, WTF::Function<void
(std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >, WTF::String>&&)>&&,
WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
WebCore::MediaStreamRequest const&) (
this=this@entry=0x7f2670feae20
<WebCore::RealtimeMediaSourceCenter::singleton()::center>, logger=...,
completionHandler=..., hashSalt=..., audioDevice=..., videoDevice=...,
request=...)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:117
#29 0x00007f266e9f6dba in operator() (__closure=<optimized out>) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:274
#30 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&,
WebCore::CaptureDevice&&, WTF::String&&,
WTF::CompletionHandler<void()>&&)::<lambda()>, void>::call(void)
(this=0x7f25e3e3d958)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
#31 0x00007f266ec7c7f1 in WebCore::EventLoop::run
(this=0x7f26698bf9c0) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/dom/EventLoop.cpp:123
#32 0x00007f266ecd12e2 in WebCore::WindowEventLoop::didReachTimeToRun
(this=<optimized out>) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/dom/WindowEventLoop.cpp:120
#33 0x00007f266f07cf0e in
WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x7f26698969d8)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/ThreadTimers.cpp:127
#34 WebCore::ThreadTimers::sharedTimerFiredInternal
(this=0x7f26698969d8) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/ThreadTimers.cpp:99
#35 0x00007f2670114548 in operator() (__closure=0x0,
userData=<optimized out>, userData@entry=0x7f2670fea290
<WebCore::MainThreadSharedTimer::singleton()::instance+16>)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:177
#36 _FUN () at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:181
#37 0x00007f2670114daf in operator() (__closure=0x0,
userData=0x7f2670fea290
<WebCore::MainThreadSharedTimer::singleton()::instance+16>,
callback=0x7f2670114523 <_FUN(gpointer)>, source=0x55934de74760)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:53
#38 _FUN () at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:56
#39 0x00007f266d87b5eb in g_main_dispatch (context=0x55934dd1fc10) at
../glib/gmain.c:3337
#40 g_main_context_dispatch (context=0x55934dd1fc10) at ../glib/gmain.c:4055
#41 0x00007f266d87b852 in g_main_context_iterate
(context=0x55934dd1fc10, block=block@entry=1,
dispatch=dispatch@entry=1, self=<optimized out>) at
../glib/gmain.c:4131
#42 0x00007f266d87bb92 in g_main_loop_run
(loop=loop@entry=0x55934dd20dc0) at ../glib/gmain.c:4329
#43 0x00007f2670114916 in WTF::RunLoop::run () at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:108
#44 0x00007f266e565d25 in
WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run
(argc=3, argv=0x7ffd53b9f618, this=0x7ffd53b9f468)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:70
#45 WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run
(argv=0x7ffd53b9f618, argc=3, this=0x7ffd53b9f468)
at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:57
#46 WebKit::AuxiliaryProcessMain<WebKit::WebProcessMainWPE> (argc=3,
argv=0x7ffd53b9f618) at
/home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:96
#47 0x00007f266d2701d7 in __libc_start_call_main
(main=main@entry=0x55934d51d060 <main(int, char**)>,
argc=argc@entry=3, argv=argv@entry=0x7ffd53b9f618) at
../sysdeps/nptl/libc_start_call_main.h:58
#48 0x00007f266d270288 in __libc_start_main_impl (main=0x55934d51d060
<main(int, char**)>, argc=3, argv=0x7ffd53b9f618, init=<optimized
out>, fini=<optimized out>, rtld_fini=<optimized out>,
stack_end=0x7ffd53b9f608)
at ../csu/libc-start.c:409
#49 0x000055934d51d091 in _start () at ../sysdeps/x86_64/start.S:116
On Mon, Oct 25, 2021 at 4:45 PM Adrian Perez de Castro
<aperez@igalia.com> wrote:
>
> Update to a new major release which brings in improvements and a number
> of new features. Release notes:
>
> https://wpewebkit.org/release/wpewebkit-2.34.0.html
> https://wpewebkit.org/release/wpewebkit-2.34.1.html
>
> Some of the new features require additional dependencies: HTTP/2
> requires libsoup3, which is not yet in packaged in Buildroot, and
> disabled at the moment (with -DUSE_SOUP2=ON, to keep using libsoup2);
> and the color management support needs LCMS2 (which will be enabled
> in a follow-up patch.)
>
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> ...e-build-issues-with-ENABLE_VIDEO-OFF.patch | 78 +++++++++++++++++++
> package/wpewebkit/wpewebkit.hash | 8 +-
> package/wpewebkit/wpewebkit.mk | 4 +-
> 3 files changed, 85 insertions(+), 5 deletions(-)
> create mode 100644 package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
>
> diff --git a/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> new file mode 100644
> index 0000000000..51212dd82d
> --- /dev/null
> +++ b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> @@ -0,0 +1,78 @@
> +From afc83d41293333f694630451f865a7a257a9b917 Mon Sep 17 00:00:00 2001
> +From: Adrian Perez de Castro <aperez@igalia.com>
> +Date: Mon, 25 Oct 2021 23:45:15 +0300
> +Subject: [PATCH] [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF
> + https://bugs.webkit.org/show_bug.cgi?id=232264
> +
> +.:
> +
> +Reviewed by NOBODY (OOPS!).
> +
> +* Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_SESSION depend on ENABLE_VIDEO.
> +
> +Source/WebCore:
> +
> +Reviewed by NOBODY (OOPS!).
> +
> +No new tests needed.
> +
> +* accessibility/AXObjectCache.cpp:
> +(WebCore::isSimpleImage): Guard usage of HTMLMediaElement with ENABLE(VIDEO).
> +* page/EventHandler.cpp:
> +(WebCore::EventHandler::textRecognitionCandidateElement const): Ditto.
> +* platform/graphics/BifurcatedGraphicsContext.cpp: Ditto.
> +* platform/graphics/displaylists/DisplayListRecorder.h: Guard usage of MediaPlayer with
> +ENABLE(VIDEO).
> +* platform/graphics/displaylists/DisplayListRecorderImpl.cpp: Ditto.
> +* platform/graphics/displaylists/DisplayListRecorderImpl.h: Ditto.
> +
> +Source/WebKit:
> +
> +* WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
> +(WebKit::createShareableBitmap): Guard usage of RenderVideo with ENABLE(VIDEO).
> +
> +Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> +---
> +Upstream status: https://bugs.webkit.org/show_bug.cgi?id=232264
> +
> + Source/WebCore/accessibility/AXObjectCache.cpp | 2 ++
> + Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp | 2 ++
> + 2 files changed, 4 insertions(+)
> +
> +diff --git a/Source/WebCore/accessibility/AXObjectCache.cpp b/Source/WebCore/accessibility/AXObjectCache.cpp
> +index f2451102040..930b969dcc2 100644
> +--- a/Source/WebCore/accessibility/AXObjectCache.cpp
> ++++ b/Source/WebCore/accessibility/AXObjectCache.cpp
> +@@ -528,9 +528,11 @@ static bool isSimpleImage(const RenderObject& renderer)
> + || (is<HTMLImageElement>(node) && downcast<HTMLImageElement>(node)->hasAttributeWithoutSynchronization(usemapAttr)))
> + return false;
> +
> ++#if ENABLE(VIDEO)
> + // Exclude video and audio elements.
> + if (is<HTMLMediaElement>(node))
> + return false;
> ++#endif // ENABLE(VIDEO)
> +
> + return true;
> + }
> +diff --git a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> +index c0ce72c5ffc..d7ead303f3c 100644
> +--- a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> ++++ b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> +@@ -269,11 +269,13 @@ void BifurcatedGraphicsContext::drawPattern(NativeImage& nativeImage, const Floa
> + m_secondaryContext.drawPattern(nativeImage, imageSize, destRect, tileRect, patternTransform, phase, spacing, options);
> + }
> +
> ++#if ENABLE(VIDEO)
> + void BifurcatedGraphicsContext::paintFrameForMedia(MediaPlayer& player, const FloatRect& destination)
> + {
> + m_primaryContext.paintFrameForMedia(player, destination);
> + m_secondaryContext.paintFrameForMedia(player, destination);
> + }
> ++#endif // ENABLE(VIDEO)
> +
> + void BifurcatedGraphicsContext::scale(const FloatSize& scale)
> + {
> +--
> +2.33.1
> +
> diff --git a/package/wpewebkit/wpewebkit.hash b/package/wpewebkit/wpewebkit.hash
> index ff8bd1f30a..acb3ec4a3e 100644
> --- a/package/wpewebkit/wpewebkit.hash
> +++ b/package/wpewebkit/wpewebkit.hash
> @@ -1,7 +1,7 @@
> -# From https://wpewebkit.org/releases/wpewebkit-2.32.4.tar.xz.sums
> -md5 94ca1cc3f7b2de8b96c59d6e59cafcd0 wpewebkit-2.32.4.tar.xz
> -sha1 19b8ebdbfef193ca50f7625703d871db87624f86 wpewebkit-2.32.4.tar.xz
> -sha256 381f1422cbc319db1aa42dda48de39590ed90ac3bec6b81ec83f3f2cae5c3eeb wpewebkit-2.32.4.tar.xz
> +# From https://wpewebkit.org/releases/wpewebkit-2.34.1.tar.xz.sums
> +md5 915e583b0e7e82efa155cbce917d6319 wpewebkit-2.34.1.tar.xz
> +sha1 452081b6df9d079f26d22bd0dca9e90f87943089 wpewebkit-2.34.1.tar.xz
> +sha256 cb336986341be9c3a9b1ca2c18de0d29d90ae4e77b9967a6f6879597e7a969f7 wpewebkit-2.34.1.tar.xz
>
> # Hashes for license files:
> sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> index 0242f7a288..606a1531c0 100644
> --- a/package/wpewebkit/wpewebkit.mk
> +++ b/package/wpewebkit/wpewebkit.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -WPEWEBKIT_VERSION = 2.32.4
> +WPEWEBKIT_VERSION = 2.34.1
> WPEWEBKIT_SITE = http://www.wpewebkit.org/releases
> WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz
> WPEWEBKIT_INSTALL_STAGING = YES
> @@ -23,6 +23,8 @@ WPEWEBKIT_CONF_OPTS = \
> -DENABLE_ACCESSIBILITY=OFF \
> -DENABLE_API_TESTS=OFF \
> -DENABLE_MINIBROWSER=OFF \
> + -DUSE_LCMS=OFF \
> + -DUSE_SOUP2=ON \
> -DSILENCE_CROSS_COMPILATION_NOTICES=ON
>
> ifeq ($(BR2_PACKAGE_WPEWEBKIT_SANDBOX),y)
> --
> 2.33.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1
2021-10-25 22:43 [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1 Adrian Perez de Castro
` (3 preceding siblings ...)
2021-10-25 22:44 ` [Buildroot] [PATCH 4/4] package/wpewebkit: use lcms2 for if available Adrian Perez de Castro
@ 2021-11-17 21:02 ` Arnout Vandecappelle
2021-11-24 20:51 ` Adrian Perez de Castro
4 siblings, 1 reply; 14+ messages in thread
From: Arnout Vandecappelle @ 2021-11-17 21:02 UTC (permalink / raw)
To: Adrian Perez de Castro, buildroot; +Cc: James Hilliard
On 26/10/2021 00:43, Adrian Perez de Castro wrote:
> Hi all,
>
> This patch set updates WPE WebKit and its dependencies to the latest releases
> of their current stable series. As often happens, I needed to make a patch to
> fix the build with multimedia support disabled, and that has been sent to
> upstream WebKit as well.
>
> An additional patch to enable the new color management is in the series as
> well; but for the moment the support to build with libsoup3 is left out.
> I would rather submit that as part of different "add libsoup3 and enable
> where supported" patch set some other day ;-)
>
> Cheers,
> -Adrian
Series applied to next, thanks. Hopefully this motivates someone to fix the
crash reported by James :-)
Two small comments on two of the patches, which I'll make in-line.
Regards,
Arnout
>
>
> Adrian Perez de Castro (4):
> package/libwpe: bump to version 1.12.0
> package/wpebackend-fdo: bump to version 1.12.0
> package/wpewebkit: bump to version 2.34.1
> package/wpewebkit: use lcms2 for if available
>
> package/libwpe/libwpe.hash | 8 +-
> package/libwpe/libwpe.mk | 2 +-
> package/wpebackend-fdo/wpebackend-fdo.hash | 8 +-
> package/wpebackend-fdo/wpebackend-fdo.mk | 2 +-
> ...e-build-issues-with-ENABLE_VIDEO-OFF.patch | 78 +++++++++++++++++++
> package/wpewebkit/wpewebkit.hash | 8 +-
> package/wpewebkit/wpewebkit.mk | 11 ++-
> 7 files changed, 102 insertions(+), 15 deletions(-)
> create mode 100644 package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1
2021-10-25 22:44 ` [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1 Adrian Perez de Castro
2021-10-30 18:29 ` James Hilliard
@ 2021-11-17 21:02 ` Arnout Vandecappelle
1 sibling, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2021-11-17 21:02 UTC (permalink / raw)
To: Adrian Perez de Castro, buildroot
On 26/10/2021 00:44, Adrian Perez de Castro wrote:
> Update to a new major release which brings in improvements and a number
> of new features. Release notes:
>
> https://wpewebkit.org/release/wpewebkit-2.34.0.html
> https://wpewebkit.org/release/wpewebkit-2.34.1.html
>
> Some of the new features require additional dependencies: HTTP/2
> requires libsoup3, which is not yet in packaged in Buildroot, and
> disabled at the moment (with -DUSE_SOUP2=ON, to keep using libsoup2);
> and the color management support needs LCMS2 (which will be enabled
> in a follow-up patch.)
>
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> ...e-build-issues-with-ENABLE_VIDEO-OFF.patch | 78 +++++++++++++++++++
> package/wpewebkit/wpewebkit.hash | 8 +-
> package/wpewebkit/wpewebkit.mk | 4 +-
> 3 files changed, 85 insertions(+), 5 deletions(-)
> create mode 100644 package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
>
> diff --git a/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> new file mode 100644
> index 0000000000..51212dd82d
> --- /dev/null
> +++ b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> @@ -0,0 +1,78 @@
> +From afc83d41293333f694630451f865a7a257a9b917 Mon Sep 17 00:00:00 2001
> +From: Adrian Perez de Castro <aperez@igalia.com>
> +Date: Mon, 25 Oct 2021 23:45:15 +0300
> +Subject: [PATCH] [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF
> + https://bugs.webkit.org/show_bug.cgi?id=232264
> +
> +.:
> +
> +Reviewed by NOBODY (OOPS!).
> +
> +* Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_SESSION depend on ENABLE_VIDEO.
> +
> +Source/WebCore:
> +
> +Reviewed by NOBODY (OOPS!).
> +
> +No new tests needed.
> +
> +* accessibility/AXObjectCache.cpp:
> +(WebCore::isSimpleImage): Guard usage of HTMLMediaElement with ENABLE(VIDEO).
> +* page/EventHandler.cpp:
> +(WebCore::EventHandler::textRecognitionCandidateElement const): Ditto.
> +* platform/graphics/BifurcatedGraphicsContext.cpp: Ditto.
> +* platform/graphics/displaylists/DisplayListRecorder.h: Guard usage of MediaPlayer with
> +ENABLE(VIDEO).
> +* platform/graphics/displaylists/DisplayListRecorderImpl.cpp: Ditto.
> +* platform/graphics/displaylists/DisplayListRecorderImpl.h: Ditto.
> +
> +Source/WebKit:
> +
> +* WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
> +(WebKit::createShareableBitmap): Guard usage of RenderVideo with ENABLE(VIDEO).
> +
> +Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> +---
> +Upstream status: https://bugs.webkit.org/show_bug.cgi?id=232264
Since this has landed now, I've changed it into the trac link.
Regards,
Arnout
> +
> + Source/WebCore/accessibility/AXObjectCache.cpp | 2 ++
> + Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp | 2 ++
> + 2 files changed, 4 insertions(+)
> +
> +diff --git a/Source/WebCore/accessibility/AXObjectCache.cpp b/Source/WebCore/accessibility/AXObjectCache.cpp
> +index f2451102040..930b969dcc2 100644
> +--- a/Source/WebCore/accessibility/AXObjectCache.cpp
> ++++ b/Source/WebCore/accessibility/AXObjectCache.cpp
> +@@ -528,9 +528,11 @@ static bool isSimpleImage(const RenderObject& renderer)
> + || (is<HTMLImageElement>(node) && downcast<HTMLImageElement>(node)->hasAttributeWithoutSynchronization(usemapAttr)))
> + return false;
> +
> ++#if ENABLE(VIDEO)
> + // Exclude video and audio elements.
> + if (is<HTMLMediaElement>(node))
> + return false;
> ++#endif // ENABLE(VIDEO)
> +
> + return true;
> + }
> +diff --git a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> +index c0ce72c5ffc..d7ead303f3c 100644
> +--- a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> ++++ b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> +@@ -269,11 +269,13 @@ void BifurcatedGraphicsContext::drawPattern(NativeImage& nativeImage, const Floa
> + m_secondaryContext.drawPattern(nativeImage, imageSize, destRect, tileRect, patternTransform, phase, spacing, options);
> + }
> +
> ++#if ENABLE(VIDEO)
> + void BifurcatedGraphicsContext::paintFrameForMedia(MediaPlayer& player, const FloatRect& destination)
> + {
> + m_primaryContext.paintFrameForMedia(player, destination);
> + m_secondaryContext.paintFrameForMedia(player, destination);
> + }
> ++#endif // ENABLE(VIDEO)
> +
> + void BifurcatedGraphicsContext::scale(const FloatSize& scale)
> + {
> +--
> +2.33.1
> +
> diff --git a/package/wpewebkit/wpewebkit.hash b/package/wpewebkit/wpewebkit.hash
> index ff8bd1f30a..acb3ec4a3e 100644
> --- a/package/wpewebkit/wpewebkit.hash
> +++ b/package/wpewebkit/wpewebkit.hash
> @@ -1,7 +1,7 @@
> -# From https://wpewebkit.org/releases/wpewebkit-2.32.4.tar.xz.sums
> -md5 94ca1cc3f7b2de8b96c59d6e59cafcd0 wpewebkit-2.32.4.tar.xz
> -sha1 19b8ebdbfef193ca50f7625703d871db87624f86 wpewebkit-2.32.4.tar.xz
> -sha256 381f1422cbc319db1aa42dda48de39590ed90ac3bec6b81ec83f3f2cae5c3eeb wpewebkit-2.32.4.tar.xz
> +# From https://wpewebkit.org/releases/wpewebkit-2.34.1.tar.xz.sums
> +md5 915e583b0e7e82efa155cbce917d6319 wpewebkit-2.34.1.tar.xz
> +sha1 452081b6df9d079f26d22bd0dca9e90f87943089 wpewebkit-2.34.1.tar.xz
> +sha256 cb336986341be9c3a9b1ca2c18de0d29d90ae4e77b9967a6f6879597e7a969f7 wpewebkit-2.34.1.tar.xz
>
> # Hashes for license files:
> sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> index 0242f7a288..606a1531c0 100644
> --- a/package/wpewebkit/wpewebkit.mk
> +++ b/package/wpewebkit/wpewebkit.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -WPEWEBKIT_VERSION = 2.32.4
> +WPEWEBKIT_VERSION = 2.34.1
> WPEWEBKIT_SITE = http://www.wpewebkit.org/releases
> WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz
> WPEWEBKIT_INSTALL_STAGING = YES
> @@ -23,6 +23,8 @@ WPEWEBKIT_CONF_OPTS = \
> -DENABLE_ACCESSIBILITY=OFF \
> -DENABLE_API_TESTS=OFF \
> -DENABLE_MINIBROWSER=OFF \
> + -DUSE_LCMS=OFF \
> + -DUSE_SOUP2=ON \
> -DSILENCE_CROSS_COMPILATION_NOTICES=ON
>
> ifeq ($(BR2_PACKAGE_WPEWEBKIT_SANDBOX),y)
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 4/4] package/wpewebkit: use lcms2 for if available
2021-10-25 22:44 ` [Buildroot] [PATCH 4/4] package/wpewebkit: use lcms2 for if available Adrian Perez de Castro
@ 2021-11-17 21:03 ` Arnout Vandecappelle
0 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2021-11-17 21:03 UTC (permalink / raw)
To: Adrian Perez de Castro, buildroot
On 26/10/2021 00:44, Adrian Perez de Castro wrote:
> Make wpewebkit support color management if the lcms2 package
> has been selected.
>
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/wpewebkit/wpewebkit.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> index 606a1531c0..ab45d4a67c 100644
> --- a/package/wpewebkit/wpewebkit.mk
> +++ b/package/wpewebkit/wpewebkit.mk
> @@ -67,6 +67,13 @@ else
> WPEWEBKIT_CONF_OPTS += -DENABLE_WEBDRIVER=OFF
> endif
>
> +ifeq ($(BR2_PACKAGE_LCMS2),y)
> +WPEWEBKIT_CONF_OPTS += -DUSE_LCMS=ON
> +WPEWEBKIT_DEPENDENCIES += lcms2
> +else
> +WPEWEBKIT_CONF_OPTS += -DUSE_LCMS=OFF
There was already a -DUSE_LCMS=OFF in the unconditional optoins, so I've
removed that one.
Regards,
Arnout
> +endif
> +
> ifeq ($(BR2_PACKAGE_WOFF2),y)
> WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=ON
> WPEWEBKIT_DEPENDENCIES += woff2
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1
2021-11-17 21:02 ` [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1 Arnout Vandecappelle
@ 2021-11-24 20:51 ` Adrian Perez de Castro
0 siblings, 0 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2021-11-24 20:51 UTC (permalink / raw)
To: Arnout Vandecappelle; +Cc: James Hilliard, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 1136 bytes --]
Hi,
On Wed, 17 Nov 2021 22:02:30 +0100 Arnout Vandecappelle <arnout@mind.be> wrote:
> On 26/10/2021 00:43, Adrian Perez de Castro wrote:
>
> > This patch set updates WPE WebKit and its dependencies to the latest releases
> > of their current stable series. As often happens, I needed to make a patch to
> > fix the build with multimedia support disabled, and that has been sent to
> > upstream WebKit as well.
> >
> > An additional patch to enable the new color management is in the series as
> > well; but for the moment the support to build with libsoup3 is left out.
> > I would rather submit that as part of different "add libsoup3 and enable
> > where supported" patch set some other day ;-)
> >
> > Cheers,
> > -Adrian
>
> Series applied to next, thanks. Hopefully this motivates someone to fix the
> crash reported by James :-)
>
> Two small comments on two of the patches, which I'll make in-line.
\o/
Thanks Arnout! I will be submitting the update to 2.34.2 momentarily, which
removes the need for the patch we have in the repo; and also an update to
Cog 0.12.0, which has just been released.
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1
2021-10-30 18:29 ` James Hilliard
@ 2021-12-07 14:07 ` James Hilliard
2021-12-07 20:59 ` Adrian Perez de Castro
0 siblings, 1 reply; 14+ messages in thread
From: James Hilliard @ 2021-12-07 14:07 UTC (permalink / raw)
To: Adrian Perez de Castro; +Cc: buildroot
Selecting BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEORATE appears to
fix this crash.
On Sat, Oct 30, 2021 at 12:29 PM James Hilliard
<james.hilliard1@gmail.com> wrote:
>
> Looks like there's a crash when loading gstreamer mediastream devices
> or something:
> #0 __pthread_kill_internal (signo=6, threadid=<optimized out>) at
> pthread_kill.c:45
> #1 __GI___pthread_kill (threadid=<optimized out>,
> signo=signo@entry=6) at pthread_kill.c:62
> #2 0x00007f266d284382 in __GI_raise (sig=sig@entry=6) at
> ../sysdeps/posix/raise.c:26
> #3 0x00007f266d26f43f in __GI_abort () at abort.c:79
> #4 0x00007f266e5679e0 in CRASH_WITH_INFO(...) () at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Assertions.h:750
> #5 WebCore::makeGStreamerBin (description=<optimized out>,
> ghostUnlinkedPads=<optimized out>)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:516
> #6 0x00007f266f662f35 in WebCore::GStreamerCapturer::setupPipeline
> (this=0x7f25e3ea75b0)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:151
> #7 0x00007f266f66386a in
> WebCore::GStreamerVideoCaptureSource::startProducingData
> (this=0x7f2605217a00)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:183
> #8 0x00007f266f13de98 in WebCore::RealtimeMediaSource::start
> (this=0x7f2605217a00) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:231
> #9 WebCore::RealtimeMediaSource::start (this=0x7f2605217a00) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:223
> #10 0x00007f266f13df9c in WebCore::RealtimeMediaSource::setMuted
> (this=0x7f2605217a00, muted=<optimized out>)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:117
> #11 0x00007f266e9e761e in WebCore::MediaStreamTrackPrivate::setMuted
> (muted=<optimized out>, this=<optimized out>)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h:87
> #12 0x00007f266e9eb04d in WebCore::MediaStreamTrack::create
> (context=..., privateTrack=...) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:76
> #13 0x00007f266e9ebb13 in WebCore::MediaStream::MediaStream
> (this=0x7f260571c8b0, document=..., streamPrivate=...) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/RefCounted.h:49
> #14 0x00007f266e9ebbd7 in WebCore::MediaStream::create (document=...,
> streamPrivate=...) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/MediaStream.cpp:63
> #15 0x00007f266e9f7971 in
> operator()<std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate>,
> WTF::String> > (privateStreamOrError=..., __closure=0x7f25e84815d8)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:260
> #16 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&,
> WebCore::CaptureDevice&&, WTF::String&&,
> WTF::CompletionHandler<void()>&&)::<lambda()>
> mutable::<lambda(auto:44)>, void,
> std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >,
> WTF::String>&&>::call(std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >, WTF::String> &&)
> (this=0x7f25e84815d0, in#0=...) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> #17 0x00007f266f13fde1 in operator()<WTF::String> (errorMessage=...,
> this=0x7f25e3ed3968) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:112
> #18 WTF::Detail::CallableWrapper<WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<const
> WTF::Logger, WTF::RawPtrTraits<const WTF::Logger> >&&,
> WebCore::RealtimeMediaSourceCenter::NewMediaStreamHandler&&,
> WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> const WebCore::MediaStreamRequest&)::<lambda(auto:26&&)> mutable [with
> auto:26 = WTF::String]::<lambda(auto:27&&)>, void,
> WTF::String&&>::call(WTF::String &&) (
> this=0x7f25e3ed3960, in#0=...) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> #19 0x00007f266e1ed059 in WTF::Function<void
> (WTF::String&&)>::operator()(WTF::String&&) const (in#0=...,
> this=<optimized out>) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> #20 WTF::CompletionHandler<void
> (WTF::String&&)>::operator()(WTF::String&&) (this=<optimized out>,
> in#0=...) at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> #21 0x00007f266e19b436 in WTF::Function<void
> (WTF::String)>::operator()(WTF::String) const (in#0=...,
> this=<optimized out>) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> #22 WTF::CompletionHandler<void
> (WTF::String)>::operator()(WTF::String)
> (this=this@entry=0x7ffd53b9eff8, in#0=...) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> #23 0x00007f266e19b49b in
> WebCore::RealtimeMediaSource::whenReady(WTF::CompletionHandler<void
> (WTF::String)>&&) (this=this@entry=0x7f2605217a00, callback=...)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WebCore/PrivateHeaders/WebCore/RealtimeMediaSource.h:322
> #24 0x00007f266f13fca1 in operator()<WTF::String> (errorMessage=...,
> __closure=<optimized out>)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:114
> #25 WTF::Detail::CallableWrapper<WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<const
> WTF::Logger, WTF::RawPtrTraits<const WTF::Logger> >&&,
> WebCore::RealtimeMediaSourceCenter::NewMediaStreamHandler&&,
> WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> const WebCore::MediaStreamRequest&)::<lambda(auto:26&&)>, void,
> WTF::String&&>::call(WTF::String &&) (this=<optimized out>, in#0=...)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> #26 0x00007f266e1ed059 in WTF::Function<void
> (WTF::String&&)>::operator()(WTF::String&&) const (in#0=...,
> this=<optimized out>) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> #27 WTF::CompletionHandler<void
> (WTF::String&&)>::operator()(WTF::String&&) (this=<optimized out>,
> in#0=...) at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> #28 0x00007f266f13f9e6 in
> WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<WTF::Logger
> const, WTF::RawPtrTraits<WTF::Logger const> >&&, WTF::Function<void
> (std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >, WTF::String>&&)>&&,
> WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> WebCore::MediaStreamRequest const&) (
> this=this@entry=0x7f2670feae20
> <WebCore::RealtimeMediaSourceCenter::singleton()::center>, logger=...,
> completionHandler=..., hashSalt=..., audioDevice=..., videoDevice=...,
> request=...)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:117
> #29 0x00007f266e9f6dba in operator() (__closure=<optimized out>) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:274
> #30 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&,
> WebCore::CaptureDevice&&, WTF::String&&,
> WTF::CompletionHandler<void()>&&)::<lambda()>, void>::call(void)
> (this=0x7f25e3e3d958)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> #31 0x00007f266ec7c7f1 in WebCore::EventLoop::run
> (this=0x7f26698bf9c0) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/dom/EventLoop.cpp:123
> #32 0x00007f266ecd12e2 in WebCore::WindowEventLoop::didReachTimeToRun
> (this=<optimized out>) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/dom/WindowEventLoop.cpp:120
> #33 0x00007f266f07cf0e in
> WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x7f26698969d8)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/ThreadTimers.cpp:127
> #34 WebCore::ThreadTimers::sharedTimerFiredInternal
> (this=0x7f26698969d8) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/ThreadTimers.cpp:99
> #35 0x00007f2670114548 in operator() (__closure=0x0,
> userData=<optimized out>, userData@entry=0x7f2670fea290
> <WebCore::MainThreadSharedTimer::singleton()::instance+16>)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:177
> #36 _FUN () at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:181
> #37 0x00007f2670114daf in operator() (__closure=0x0,
> userData=0x7f2670fea290
> <WebCore::MainThreadSharedTimer::singleton()::instance+16>,
> callback=0x7f2670114523 <_FUN(gpointer)>, source=0x55934de74760)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:53
> #38 _FUN () at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:56
> #39 0x00007f266d87b5eb in g_main_dispatch (context=0x55934dd1fc10) at
> ../glib/gmain.c:3337
> #40 g_main_context_dispatch (context=0x55934dd1fc10) at ../glib/gmain.c:4055
> #41 0x00007f266d87b852 in g_main_context_iterate
> (context=0x55934dd1fc10, block=block@entry=1,
> dispatch=dispatch@entry=1, self=<optimized out>) at
> ../glib/gmain.c:4131
> #42 0x00007f266d87bb92 in g_main_loop_run
> (loop=loop@entry=0x55934dd20dc0) at ../glib/gmain.c:4329
> #43 0x00007f2670114916 in WTF::RunLoop::run () at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:108
> #44 0x00007f266e565d25 in
> WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run
> (argc=3, argv=0x7ffd53b9f618, this=0x7ffd53b9f468)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:70
> #45 WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run
> (argv=0x7ffd53b9f618, argc=3, this=0x7ffd53b9f468)
> at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:57
> #46 WebKit::AuxiliaryProcessMain<WebKit::WebProcessMainWPE> (argc=3,
> argv=0x7ffd53b9f618) at
> /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:96
> #47 0x00007f266d2701d7 in __libc_start_call_main
> (main=main@entry=0x55934d51d060 <main(int, char**)>,
> argc=argc@entry=3, argv=argv@entry=0x7ffd53b9f618) at
> ../sysdeps/nptl/libc_start_call_main.h:58
> #48 0x00007f266d270288 in __libc_start_main_impl (main=0x55934d51d060
> <main(int, char**)>, argc=3, argv=0x7ffd53b9f618, init=<optimized
> out>, fini=<optimized out>, rtld_fini=<optimized out>,
> stack_end=0x7ffd53b9f608)
> at ../csu/libc-start.c:409
> #49 0x000055934d51d091 in _start () at ../sysdeps/x86_64/start.S:116
>
> On Mon, Oct 25, 2021 at 4:45 PM Adrian Perez de Castro
> <aperez@igalia.com> wrote:
> >
> > Update to a new major release which brings in improvements and a number
> > of new features. Release notes:
> >
> > https://wpewebkit.org/release/wpewebkit-2.34.0.html
> > https://wpewebkit.org/release/wpewebkit-2.34.1.html
> >
> > Some of the new features require additional dependencies: HTTP/2
> > requires libsoup3, which is not yet in packaged in Buildroot, and
> > disabled at the moment (with -DUSE_SOUP2=ON, to keep using libsoup2);
> > and the color management support needs LCMS2 (which will be enabled
> > in a follow-up patch.)
> >
> > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> > ---
> > ...e-build-issues-with-ENABLE_VIDEO-OFF.patch | 78 +++++++++++++++++++
> > package/wpewebkit/wpewebkit.hash | 8 +-
> > package/wpewebkit/wpewebkit.mk | 4 +-
> > 3 files changed, 85 insertions(+), 5 deletions(-)
> > create mode 100644 package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> >
> > diff --git a/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > new file mode 100644
> > index 0000000000..51212dd82d
> > --- /dev/null
> > +++ b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > @@ -0,0 +1,78 @@
> > +From afc83d41293333f694630451f865a7a257a9b917 Mon Sep 17 00:00:00 2001
> > +From: Adrian Perez de Castro <aperez@igalia.com>
> > +Date: Mon, 25 Oct 2021 23:45:15 +0300
> > +Subject: [PATCH] [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF
> > + https://bugs.webkit.org/show_bug.cgi?id=232264
> > +
> > +.:
> > +
> > +Reviewed by NOBODY (OOPS!).
> > +
> > +* Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_SESSION depend on ENABLE_VIDEO.
> > +
> > +Source/WebCore:
> > +
> > +Reviewed by NOBODY (OOPS!).
> > +
> > +No new tests needed.
> > +
> > +* accessibility/AXObjectCache.cpp:
> > +(WebCore::isSimpleImage): Guard usage of HTMLMediaElement with ENABLE(VIDEO).
> > +* page/EventHandler.cpp:
> > +(WebCore::EventHandler::textRecognitionCandidateElement const): Ditto.
> > +* platform/graphics/BifurcatedGraphicsContext.cpp: Ditto.
> > +* platform/graphics/displaylists/DisplayListRecorder.h: Guard usage of MediaPlayer with
> > +ENABLE(VIDEO).
> > +* platform/graphics/displaylists/DisplayListRecorderImpl.cpp: Ditto.
> > +* platform/graphics/displaylists/DisplayListRecorderImpl.h: Ditto.
> > +
> > +Source/WebKit:
> > +
> > +* WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
> > +(WebKit::createShareableBitmap): Guard usage of RenderVideo with ENABLE(VIDEO).
> > +
> > +Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> > +---
> > +Upstream status: https://bugs.webkit.org/show_bug.cgi?id=232264
> > +
> > + Source/WebCore/accessibility/AXObjectCache.cpp | 2 ++
> > + Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp | 2 ++
> > + 2 files changed, 4 insertions(+)
> > +
> > +diff --git a/Source/WebCore/accessibility/AXObjectCache.cpp b/Source/WebCore/accessibility/AXObjectCache.cpp
> > +index f2451102040..930b969dcc2 100644
> > +--- a/Source/WebCore/accessibility/AXObjectCache.cpp
> > ++++ b/Source/WebCore/accessibility/AXObjectCache.cpp
> > +@@ -528,9 +528,11 @@ static bool isSimpleImage(const RenderObject& renderer)
> > + || (is<HTMLImageElement>(node) && downcast<HTMLImageElement>(node)->hasAttributeWithoutSynchronization(usemapAttr)))
> > + return false;
> > +
> > ++#if ENABLE(VIDEO)
> > + // Exclude video and audio elements.
> > + if (is<HTMLMediaElement>(node))
> > + return false;
> > ++#endif // ENABLE(VIDEO)
> > +
> > + return true;
> > + }
> > +diff --git a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > +index c0ce72c5ffc..d7ead303f3c 100644
> > +--- a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > ++++ b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > +@@ -269,11 +269,13 @@ void BifurcatedGraphicsContext::drawPattern(NativeImage& nativeImage, const Floa
> > + m_secondaryContext.drawPattern(nativeImage, imageSize, destRect, tileRect, patternTransform, phase, spacing, options);
> > + }
> > +
> > ++#if ENABLE(VIDEO)
> > + void BifurcatedGraphicsContext::paintFrameForMedia(MediaPlayer& player, const FloatRect& destination)
> > + {
> > + m_primaryContext.paintFrameForMedia(player, destination);
> > + m_secondaryContext.paintFrameForMedia(player, destination);
> > + }
> > ++#endif // ENABLE(VIDEO)
> > +
> > + void BifurcatedGraphicsContext::scale(const FloatSize& scale)
> > + {
> > +--
> > +2.33.1
> > +
> > diff --git a/package/wpewebkit/wpewebkit.hash b/package/wpewebkit/wpewebkit.hash
> > index ff8bd1f30a..acb3ec4a3e 100644
> > --- a/package/wpewebkit/wpewebkit.hash
> > +++ b/package/wpewebkit/wpewebkit.hash
> > @@ -1,7 +1,7 @@
> > -# From https://wpewebkit.org/releases/wpewebkit-2.32.4.tar.xz.sums
> > -md5 94ca1cc3f7b2de8b96c59d6e59cafcd0 wpewebkit-2.32.4.tar.xz
> > -sha1 19b8ebdbfef193ca50f7625703d871db87624f86 wpewebkit-2.32.4.tar.xz
> > -sha256 381f1422cbc319db1aa42dda48de39590ed90ac3bec6b81ec83f3f2cae5c3eeb wpewebkit-2.32.4.tar.xz
> > +# From https://wpewebkit.org/releases/wpewebkit-2.34.1.tar.xz.sums
> > +md5 915e583b0e7e82efa155cbce917d6319 wpewebkit-2.34.1.tar.xz
> > +sha1 452081b6df9d079f26d22bd0dca9e90f87943089 wpewebkit-2.34.1.tar.xz
> > +sha256 cb336986341be9c3a9b1ca2c18de0d29d90ae4e77b9967a6f6879597e7a969f7 wpewebkit-2.34.1.tar.xz
> >
> > # Hashes for license files:
> > sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
> > diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> > index 0242f7a288..606a1531c0 100644
> > --- a/package/wpewebkit/wpewebkit.mk
> > +++ b/package/wpewebkit/wpewebkit.mk
> > @@ -4,7 +4,7 @@
> > #
> > ################################################################################
> >
> > -WPEWEBKIT_VERSION = 2.32.4
> > +WPEWEBKIT_VERSION = 2.34.1
> > WPEWEBKIT_SITE = http://www.wpewebkit.org/releases
> > WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz
> > WPEWEBKIT_INSTALL_STAGING = YES
> > @@ -23,6 +23,8 @@ WPEWEBKIT_CONF_OPTS = \
> > -DENABLE_ACCESSIBILITY=OFF \
> > -DENABLE_API_TESTS=OFF \
> > -DENABLE_MINIBROWSER=OFF \
> > + -DUSE_LCMS=OFF \
> > + -DUSE_SOUP2=ON \
> > -DSILENCE_CROSS_COMPILATION_NOTICES=ON
> >
> > ifeq ($(BR2_PACKAGE_WPEWEBKIT_SANDBOX),y)
> > --
> > 2.33.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1
2021-12-07 14:07 ` James Hilliard
@ 2021-12-07 20:59 ` Adrian Perez de Castro
2021-12-07 21:07 ` James Hilliard
2021-12-07 21:15 ` Adrian Perez de Castro
0 siblings, 2 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2021-12-07 20:59 UTC (permalink / raw)
To: James Hilliard; +Cc: buildroot
[-- Attachment #1.1: Type: text/plain, Size: 19824 bytes --]
On Tue, 07 Dec 2021 07:07:17 -0700 James Hilliard <james.hilliard1@gmail.com> wrote:
> Selecting BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEORATE appears to
> fix this crash.
Good find! Amusingly we have nowadays support in WebKit to report a
meaningful message when a required GStreamer element is missing (using
the RELEASE_ASSERT_WITH_MESSAGE macro) but sadly at the moment those only
go to journald and for catching this kind of issues we really would want
those to *also* go to stderr.
> On Sat, Oct 30, 2021 at 12:29 PM James Hilliard
> <james.hilliard1@gmail.com> wrote:
> >
> > Looks like there's a crash when loading gstreamer mediastream devices
> > or something:
> > #0 __pthread_kill_internal (signo=6, threadid=<optimized out>) at
> > pthread_kill.c:45
> > #1 __GI___pthread_kill (threadid=<optimized out>,
> > signo=signo@entry=6) at pthread_kill.c:62
> > #2 0x00007f266d284382 in __GI_raise (sig=sig@entry=6) at
> > ../sysdeps/posix/raise.c:26
> > #3 0x00007f266d26f43f in __GI_abort () at abort.c:79
> > #4 0x00007f266e5679e0 in CRASH_WITH_INFO(...) () at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Assertions.h:750
> > #5 WebCore::makeGStreamerBin (description=<optimized out>,
> > ghostUnlinkedPads=<optimized out>)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:516
> > #6 0x00007f266f662f35 in WebCore::GStreamerCapturer::setupPipeline
> > (this=0x7f25e3ea75b0)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:151
> > #7 0x00007f266f66386a in
> > WebCore::GStreamerVideoCaptureSource::startProducingData
> > (this=0x7f2605217a00)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:183
> > #8 0x00007f266f13de98 in WebCore::RealtimeMediaSource::start
> > (this=0x7f2605217a00) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:231
> > #9 WebCore::RealtimeMediaSource::start (this=0x7f2605217a00) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:223
> > #10 0x00007f266f13df9c in WebCore::RealtimeMediaSource::setMuted
> > (this=0x7f2605217a00, muted=<optimized out>)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:117
> > #11 0x00007f266e9e761e in WebCore::MediaStreamTrackPrivate::setMuted
> > (muted=<optimized out>, this=<optimized out>)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h:87
> > #12 0x00007f266e9eb04d in WebCore::MediaStreamTrack::create
> > (context=..., privateTrack=...) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:76
> > #13 0x00007f266e9ebb13 in WebCore::MediaStream::MediaStream
> > (this=0x7f260571c8b0, document=..., streamPrivate=...) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/RefCounted.h:49
> > #14 0x00007f266e9ebbd7 in WebCore::MediaStream::create (document=...,
> > streamPrivate=...) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/MediaStream.cpp:63
> > #15 0x00007f266e9f7971 in
> > operator()<std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate>,
> > WTF::String> > (privateStreamOrError=..., __closure=0x7f25e84815d8)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:260
> > #16 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&,
> > WebCore::CaptureDevice&&, WTF::String&&,
> > WTF::CompletionHandler<void()>&&)::<lambda()>
> > mutable::<lambda(auto:44)>, void,
> > std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> > WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >,
> > WTF::String>&&>::call(std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> > WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >, WTF::String> &&)
> > (this=0x7f25e84815d0, in#0=...) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > #17 0x00007f266f13fde1 in operator()<WTF::String> (errorMessage=...,
> > this=0x7f25e3ed3968) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:112
> > #18 WTF::Detail::CallableWrapper<WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<const
> > WTF::Logger, WTF::RawPtrTraits<const WTF::Logger> >&&,
> > WebCore::RealtimeMediaSourceCenter::NewMediaStreamHandler&&,
> > WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> > const WebCore::MediaStreamRequest&)::<lambda(auto:26&&)> mutable [with
> > auto:26 = WTF::String]::<lambda(auto:27&&)>, void,
> > WTF::String&&>::call(WTF::String &&) (
> > this=0x7f25e3ed3960, in#0=...) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > #19 0x00007f266e1ed059 in WTF::Function<void
> > (WTF::String&&)>::operator()(WTF::String&&) const (in#0=...,
> > this=<optimized out>) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> > #20 WTF::CompletionHandler<void
> > (WTF::String&&)>::operator()(WTF::String&&) (this=<optimized out>,
> > in#0=...) at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> > #21 0x00007f266e19b436 in WTF::Function<void
> > (WTF::String)>::operator()(WTF::String) const (in#0=...,
> > this=<optimized out>) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> > #22 WTF::CompletionHandler<void
> > (WTF::String)>::operator()(WTF::String)
> > (this=this@entry=0x7ffd53b9eff8, in#0=...) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> > #23 0x00007f266e19b49b in
> > WebCore::RealtimeMediaSource::whenReady(WTF::CompletionHandler<void
> > (WTF::String)>&&) (this=this@entry=0x7f2605217a00, callback=...)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WebCore/PrivateHeaders/WebCore/RealtimeMediaSource.h:322
> > #24 0x00007f266f13fca1 in operator()<WTF::String> (errorMessage=...,
> > __closure=<optimized out>)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:114
> > #25 WTF::Detail::CallableWrapper<WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<const
> > WTF::Logger, WTF::RawPtrTraits<const WTF::Logger> >&&,
> > WebCore::RealtimeMediaSourceCenter::NewMediaStreamHandler&&,
> > WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> > const WebCore::MediaStreamRequest&)::<lambda(auto:26&&)>, void,
> > WTF::String&&>::call(WTF::String &&) (this=<optimized out>, in#0=...)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > #26 0x00007f266e1ed059 in WTF::Function<void
> > (WTF::String&&)>::operator()(WTF::String&&) const (in#0=...,
> > this=<optimized out>) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> > #27 WTF::CompletionHandler<void
> > (WTF::String&&)>::operator()(WTF::String&&) (this=<optimized out>,
> > in#0=...) at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> > #28 0x00007f266f13f9e6 in
> > WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<WTF::Logger
> > const, WTF::RawPtrTraits<WTF::Logger const> >&&, WTF::Function<void
> > (std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> > WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >, WTF::String>&&)>&&,
> > WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> > WebCore::MediaStreamRequest const&) (
> > this=this@entry=0x7f2670feae20
> > <WebCore::RealtimeMediaSourceCenter::singleton()::center>, logger=...,
> > completionHandler=..., hashSalt=..., audioDevice=..., videoDevice=...,
> > request=...)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:117
> > #29 0x00007f266e9f6dba in operator() (__closure=<optimized out>) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:274
> > #30 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&,
> > WebCore::CaptureDevice&&, WTF::String&&,
> > WTF::CompletionHandler<void()>&&)::<lambda()>, void>::call(void)
> > (this=0x7f25e3e3d958)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > #31 0x00007f266ec7c7f1 in WebCore::EventLoop::run
> > (this=0x7f26698bf9c0) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/dom/EventLoop.cpp:123
> > #32 0x00007f266ecd12e2 in WebCore::WindowEventLoop::didReachTimeToRun
> > (this=<optimized out>) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/dom/WindowEventLoop.cpp:120
> > #33 0x00007f266f07cf0e in
> > WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x7f26698969d8)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/ThreadTimers.cpp:127
> > #34 WebCore::ThreadTimers::sharedTimerFiredInternal
> > (this=0x7f26698969d8) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/ThreadTimers.cpp:99
> > #35 0x00007f2670114548 in operator() (__closure=0x0,
> > userData=<optimized out>, userData@entry=0x7f2670fea290
> > <WebCore::MainThreadSharedTimer::singleton()::instance+16>)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:177
> > #36 _FUN () at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:181
> > #37 0x00007f2670114daf in operator() (__closure=0x0,
> > userData=0x7f2670fea290
> > <WebCore::MainThreadSharedTimer::singleton()::instance+16>,
> > callback=0x7f2670114523 <_FUN(gpointer)>, source=0x55934de74760)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:53
> > #38 _FUN () at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:56
> > #39 0x00007f266d87b5eb in g_main_dispatch (context=0x55934dd1fc10) at
> > ../glib/gmain.c:3337
> > #40 g_main_context_dispatch (context=0x55934dd1fc10) at ../glib/gmain.c:4055
> > #41 0x00007f266d87b852 in g_main_context_iterate
> > (context=0x55934dd1fc10, block=block@entry=1,
> > dispatch=dispatch@entry=1, self=<optimized out>) at
> > ../glib/gmain.c:4131
> > #42 0x00007f266d87bb92 in g_main_loop_run
> > (loop=loop@entry=0x55934dd20dc0) at ../glib/gmain.c:4329
> > #43 0x00007f2670114916 in WTF::RunLoop::run () at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:108
> > #44 0x00007f266e565d25 in
> > WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run
> > (argc=3, argv=0x7ffd53b9f618, this=0x7ffd53b9f468)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:70
> > #45 WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run
> > (argv=0x7ffd53b9f618, argc=3, this=0x7ffd53b9f468)
> > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:57
> > #46 WebKit::AuxiliaryProcessMain<WebKit::WebProcessMainWPE> (argc=3,
> > argv=0x7ffd53b9f618) at
> > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:96
> > #47 0x00007f266d2701d7 in __libc_start_call_main
> > (main=main@entry=0x55934d51d060 <main(int, char**)>,
> > argc=argc@entry=3, argv=argv@entry=0x7ffd53b9f618) at
> > ../sysdeps/nptl/libc_start_call_main.h:58
> > #48 0x00007f266d270288 in __libc_start_main_impl (main=0x55934d51d060
> > <main(int, char**)>, argc=3, argv=0x7ffd53b9f618, init=<optimized
> > out>, fini=<optimized out>, rtld_fini=<optimized out>,
> > stack_end=0x7ffd53b9f608)
> > at ../csu/libc-start.c:409
> > #49 0x000055934d51d091 in _start () at ../sysdeps/x86_64/start.S:116
> >
> > On Mon, Oct 25, 2021 at 4:45 PM Adrian Perez de Castro
> > <aperez@igalia.com> wrote:
> > >
> > > Update to a new major release which brings in improvements and a number
> > > of new features. Release notes:
> > >
> > > https://wpewebkit.org/release/wpewebkit-2.34.0.html
> > > https://wpewebkit.org/release/wpewebkit-2.34.1.html
> > >
> > > Some of the new features require additional dependencies: HTTP/2
> > > requires libsoup3, which is not yet in packaged in Buildroot, and
> > > disabled at the moment (with -DUSE_SOUP2=ON, to keep using libsoup2);
> > > and the color management support needs LCMS2 (which will be enabled
> > > in a follow-up patch.)
> > >
> > > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> > > ---
> > > ...e-build-issues-with-ENABLE_VIDEO-OFF.patch | 78 +++++++++++++++++++
> > > package/wpewebkit/wpewebkit.hash | 8 +-
> > > package/wpewebkit/wpewebkit.mk | 4 +-
> > > 3 files changed, 85 insertions(+), 5 deletions(-)
> > > create mode 100644 package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > >
> > > diff --git a/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > > new file mode 100644
> > > index 0000000000..51212dd82d
> > > --- /dev/null
> > > +++ b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > > @@ -0,0 +1,78 @@
> > > +From afc83d41293333f694630451f865a7a257a9b917 Mon Sep 17 00:00:00 2001
> > > +From: Adrian Perez de Castro <aperez@igalia.com>
> > > +Date: Mon, 25 Oct 2021 23:45:15 +0300
> > > +Subject: [PATCH] [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF
> > > + https://bugs.webkit.org/show_bug.cgi?id=232264
> > > +
> > > +.:
> > > +
> > > +Reviewed by NOBODY (OOPS!).
> > > +
> > > +* Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_SESSION depend on ENABLE_VIDEO.
> > > +
> > > +Source/WebCore:
> > > +
> > > +Reviewed by NOBODY (OOPS!).
> > > +
> > > +No new tests needed.
> > > +
> > > +* accessibility/AXObjectCache.cpp:
> > > +(WebCore::isSimpleImage): Guard usage of HTMLMediaElement with ENABLE(VIDEO).
> > > +* page/EventHandler.cpp:
> > > +(WebCore::EventHandler::textRecognitionCandidateElement const): Ditto.
> > > +* platform/graphics/BifurcatedGraphicsContext.cpp: Ditto.
> > > +* platform/graphics/displaylists/DisplayListRecorder.h: Guard usage of MediaPlayer with
> > > +ENABLE(VIDEO).
> > > +* platform/graphics/displaylists/DisplayListRecorderImpl.cpp: Ditto.
> > > +* platform/graphics/displaylists/DisplayListRecorderImpl.h: Ditto.
> > > +
> > > +Source/WebKit:
> > > +
> > > +* WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
> > > +(WebKit::createShareableBitmap): Guard usage of RenderVideo with ENABLE(VIDEO).
> > > +
> > > +Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> > > +---
> > > +Upstream status: https://bugs.webkit.org/show_bug.cgi?id=232264
> > > +
> > > + Source/WebCore/accessibility/AXObjectCache.cpp | 2 ++
> > > + Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp | 2 ++
> > > + 2 files changed, 4 insertions(+)
> > > +
> > > +diff --git a/Source/WebCore/accessibility/AXObjectCache.cpp b/Source/WebCore/accessibility/AXObjectCache.cpp
> > > +index f2451102040..930b969dcc2 100644
> > > +--- a/Source/WebCore/accessibility/AXObjectCache.cpp
> > > ++++ b/Source/WebCore/accessibility/AXObjectCache.cpp
> > > +@@ -528,9 +528,11 @@ static bool isSimpleImage(const RenderObject& renderer)
> > > + || (is<HTMLImageElement>(node) && downcast<HTMLImageElement>(node)->hasAttributeWithoutSynchronization(usemapAttr)))
> > > + return false;
> > > +
> > > ++#if ENABLE(VIDEO)
> > > + // Exclude video and audio elements.
> > > + if (is<HTMLMediaElement>(node))
> > > + return false;
> > > ++#endif // ENABLE(VIDEO)
> > > +
> > > + return true;
> > > + }
> > > +diff --git a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > > +index c0ce72c5ffc..d7ead303f3c 100644
> > > +--- a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > > ++++ b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > > +@@ -269,11 +269,13 @@ void BifurcatedGraphicsContext::drawPattern(NativeImage& nativeImage, const Floa
> > > + m_secondaryContext.drawPattern(nativeImage, imageSize, destRect, tileRect, patternTransform, phase, spacing, options);
> > > + }
> > > +
> > > ++#if ENABLE(VIDEO)
> > > + void BifurcatedGraphicsContext::paintFrameForMedia(MediaPlayer& player, const FloatRect& destination)
> > > + {
> > > + m_primaryContext.paintFrameForMedia(player, destination);
> > > + m_secondaryContext.paintFrameForMedia(player, destination);
> > > + }
> > > ++#endif // ENABLE(VIDEO)
> > > +
> > > + void BifurcatedGraphicsContext::scale(const FloatSize& scale)
> > > + {
> > > +--
> > > +2.33.1
> > > +
> > > diff --git a/package/wpewebkit/wpewebkit.hash b/package/wpewebkit/wpewebkit.hash
> > > index ff8bd1f30a..acb3ec4a3e 100644
> > > --- a/package/wpewebkit/wpewebkit.hash
> > > +++ b/package/wpewebkit/wpewebkit.hash
> > > @@ -1,7 +1,7 @@
> > > -# From https://wpewebkit.org/releases/wpewebkit-2.32.4.tar.xz.sums
> > > -md5 94ca1cc3f7b2de8b96c59d6e59cafcd0 wpewebkit-2.32.4.tar.xz
> > > -sha1 19b8ebdbfef193ca50f7625703d871db87624f86 wpewebkit-2.32.4.tar.xz
> > > -sha256 381f1422cbc319db1aa42dda48de39590ed90ac3bec6b81ec83f3f2cae5c3eeb wpewebkit-2.32.4.tar.xz
> > > +# From https://wpewebkit.org/releases/wpewebkit-2.34.1.tar.xz.sums
> > > +md5 915e583b0e7e82efa155cbce917d6319 wpewebkit-2.34.1.tar.xz
> > > +sha1 452081b6df9d079f26d22bd0dca9e90f87943089 wpewebkit-2.34.1.tar.xz
> > > +sha256 cb336986341be9c3a9b1ca2c18de0d29d90ae4e77b9967a6f6879597e7a969f7 wpewebkit-2.34.1.tar.xz
> > >
> > > # Hashes for license files:
> > > sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
> > > diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> > > index 0242f7a288..606a1531c0 100644
> > > --- a/package/wpewebkit/wpewebkit.mk
> > > +++ b/package/wpewebkit/wpewebkit.mk
> > > @@ -4,7 +4,7 @@
> > > #
> > > ################################################################################
> > >
> > > -WPEWEBKIT_VERSION = 2.32.4
> > > +WPEWEBKIT_VERSION = 2.34.1
> > > WPEWEBKIT_SITE = http://www.wpewebkit.org/releases
> > > WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz
> > > WPEWEBKIT_INSTALL_STAGING = YES
> > > @@ -23,6 +23,8 @@ WPEWEBKIT_CONF_OPTS = \
> > > -DENABLE_ACCESSIBILITY=OFF \
> > > -DENABLE_API_TESTS=OFF \
> > > -DENABLE_MINIBROWSER=OFF \
> > > + -DUSE_LCMS=OFF \
> > > + -DUSE_SOUP2=ON \
> > > -DSILENCE_CROSS_COMPILATION_NOTICES=ON
> > >
> > > ifeq ($(BR2_PACKAGE_WPEWEBKIT_SANDBOX),y)
> > > --
> > > 2.33.1
> > >
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot@buildroot.org
> > > https://lists.buildroot.org/mailman/listinfo/buildroot
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1
2021-12-07 20:59 ` Adrian Perez de Castro
@ 2021-12-07 21:07 ` James Hilliard
2021-12-07 21:15 ` Adrian Perez de Castro
1 sibling, 0 replies; 14+ messages in thread
From: James Hilliard @ 2021-12-07 21:07 UTC (permalink / raw)
To: Adrian Perez de Castro; +Cc: buildroot
On Tue, Dec 7, 2021 at 1:59 PM Adrian Perez de Castro <aperez@igalia.com> wrote:
>
> On Tue, 07 Dec 2021 07:07:17 -0700 James Hilliard <james.hilliard1@gmail.com> wrote:
> > Selecting BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEORATE appears to
> > fix this crash.
>
> Good find! Amusingly we have nowadays support in WebKit to report a
> meaningful message when a required GStreamer element is missing (using
> the RELEASE_ASSERT_WITH_MESSAGE macro) but sadly at the moment those only
> go to journald and for catching this kind of issues we really would want
> those to *also* go to stderr.
Strange, I was running cog inside a systemd service with journald
logging and never saw
it throw a meaningful error message there. Is it considered a bug that
the webprocess crashes
if a gstreamer element is missing rather than just disabling
media-stream support?
>
> > On Sat, Oct 30, 2021 at 12:29 PM James Hilliard
> > <james.hilliard1@gmail.com> wrote:
> > >
> > > Looks like there's a crash when loading gstreamer mediastream devices
> > > or something:
> > > #0 __pthread_kill_internal (signo=6, threadid=<optimized out>) at
> > > pthread_kill.c:45
> > > #1 __GI___pthread_kill (threadid=<optimized out>,
> > > signo=signo@entry=6) at pthread_kill.c:62
> > > #2 0x00007f266d284382 in __GI_raise (sig=sig@entry=6) at
> > > ../sysdeps/posix/raise.c:26
> > > #3 0x00007f266d26f43f in __GI_abort () at abort.c:79
> > > #4 0x00007f266e5679e0 in CRASH_WITH_INFO(...) () at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Assertions.h:750
> > > #5 WebCore::makeGStreamerBin (description=<optimized out>,
> > > ghostUnlinkedPads=<optimized out>)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:516
> > > #6 0x00007f266f662f35 in WebCore::GStreamerCapturer::setupPipeline
> > > (this=0x7f25e3ea75b0)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:151
> > > #7 0x00007f266f66386a in
> > > WebCore::GStreamerVideoCaptureSource::startProducingData
> > > (this=0x7f2605217a00)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:183
> > > #8 0x00007f266f13de98 in WebCore::RealtimeMediaSource::start
> > > (this=0x7f2605217a00) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:231
> > > #9 WebCore::RealtimeMediaSource::start (this=0x7f2605217a00) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:223
> > > #10 0x00007f266f13df9c in WebCore::RealtimeMediaSource::setMuted
> > > (this=0x7f2605217a00, muted=<optimized out>)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:117
> > > #11 0x00007f266e9e761e in WebCore::MediaStreamTrackPrivate::setMuted
> > > (muted=<optimized out>, this=<optimized out>)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h:87
> > > #12 0x00007f266e9eb04d in WebCore::MediaStreamTrack::create
> > > (context=..., privateTrack=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:76
> > > #13 0x00007f266e9ebb13 in WebCore::MediaStream::MediaStream
> > > (this=0x7f260571c8b0, document=..., streamPrivate=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/RefCounted.h:49
> > > #14 0x00007f266e9ebbd7 in WebCore::MediaStream::create (document=...,
> > > streamPrivate=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/MediaStream.cpp:63
> > > #15 0x00007f266e9f7971 in
> > > operator()<std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate>,
> > > WTF::String> > (privateStreamOrError=..., __closure=0x7f25e84815d8)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:260
> > > #16 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&,
> > > WebCore::CaptureDevice&&, WTF::String&&,
> > > WTF::CompletionHandler<void()>&&)::<lambda()>
> > > mutable::<lambda(auto:44)>, void,
> > > std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> > > WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >,
> > > WTF::String>&&>::call(std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> > > WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >, WTF::String> &&)
> > > (this=0x7f25e84815d0, in#0=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > > #17 0x00007f266f13fde1 in operator()<WTF::String> (errorMessage=...,
> > > this=0x7f25e3ed3968) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:112
> > > #18 WTF::Detail::CallableWrapper<WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<const
> > > WTF::Logger, WTF::RawPtrTraits<const WTF::Logger> >&&,
> > > WebCore::RealtimeMediaSourceCenter::NewMediaStreamHandler&&,
> > > WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> > > const WebCore::MediaStreamRequest&)::<lambda(auto:26&&)> mutable [with
> > > auto:26 = WTF::String]::<lambda(auto:27&&)>, void,
> > > WTF::String&&>::call(WTF::String &&) (
> > > this=0x7f25e3ed3960, in#0=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > > #19 0x00007f266e1ed059 in WTF::Function<void
> > > (WTF::String&&)>::operator()(WTF::String&&) const (in#0=...,
> > > this=<optimized out>) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> > > #20 WTF::CompletionHandler<void
> > > (WTF::String&&)>::operator()(WTF::String&&) (this=<optimized out>,
> > > in#0=...) at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> > > #21 0x00007f266e19b436 in WTF::Function<void
> > > (WTF::String)>::operator()(WTF::String) const (in#0=...,
> > > this=<optimized out>) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> > > #22 WTF::CompletionHandler<void
> > > (WTF::String)>::operator()(WTF::String)
> > > (this=this@entry=0x7ffd53b9eff8, in#0=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> > > #23 0x00007f266e19b49b in
> > > WebCore::RealtimeMediaSource::whenReady(WTF::CompletionHandler<void
> > > (WTF::String)>&&) (this=this@entry=0x7f2605217a00, callback=...)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WebCore/PrivateHeaders/WebCore/RealtimeMediaSource.h:322
> > > #24 0x00007f266f13fca1 in operator()<WTF::String> (errorMessage=...,
> > > __closure=<optimized out>)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:114
> > > #25 WTF::Detail::CallableWrapper<WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<const
> > > WTF::Logger, WTF::RawPtrTraits<const WTF::Logger> >&&,
> > > WebCore::RealtimeMediaSourceCenter::NewMediaStreamHandler&&,
> > > WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> > > const WebCore::MediaStreamRequest&)::<lambda(auto:26&&)>, void,
> > > WTF::String&&>::call(WTF::String &&) (this=<optimized out>, in#0=...)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > > #26 0x00007f266e1ed059 in WTF::Function<void
> > > (WTF::String&&)>::operator()(WTF::String&&) const (in#0=...,
> > > this=<optimized out>) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> > > #27 WTF::CompletionHandler<void
> > > (WTF::String&&)>::operator()(WTF::String&&) (this=<optimized out>,
> > > in#0=...) at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> > > #28 0x00007f266f13f9e6 in
> > > WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<WTF::Logger
> > > const, WTF::RawPtrTraits<WTF::Logger const> >&&, WTF::Function<void
> > > (std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> > > WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >, WTF::String>&&)>&&,
> > > WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> > > WebCore::MediaStreamRequest const&) (
> > > this=this@entry=0x7f2670feae20
> > > <WebCore::RealtimeMediaSourceCenter::singleton()::center>, logger=...,
> > > completionHandler=..., hashSalt=..., audioDevice=..., videoDevice=...,
> > > request=...)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:117
> > > #29 0x00007f266e9f6dba in operator() (__closure=<optimized out>) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:274
> > > #30 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&,
> > > WebCore::CaptureDevice&&, WTF::String&&,
> > > WTF::CompletionHandler<void()>&&)::<lambda()>, void>::call(void)
> > > (this=0x7f25e3e3d958)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > > #31 0x00007f266ec7c7f1 in WebCore::EventLoop::run
> > > (this=0x7f26698bf9c0) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/dom/EventLoop.cpp:123
> > > #32 0x00007f266ecd12e2 in WebCore::WindowEventLoop::didReachTimeToRun
> > > (this=<optimized out>) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/dom/WindowEventLoop.cpp:120
> > > #33 0x00007f266f07cf0e in
> > > WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x7f26698969d8)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/ThreadTimers.cpp:127
> > > #34 WebCore::ThreadTimers::sharedTimerFiredInternal
> > > (this=0x7f26698969d8) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/ThreadTimers.cpp:99
> > > #35 0x00007f2670114548 in operator() (__closure=0x0,
> > > userData=<optimized out>, userData@entry=0x7f2670fea290
> > > <WebCore::MainThreadSharedTimer::singleton()::instance+16>)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:177
> > > #36 _FUN () at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:181
> > > #37 0x00007f2670114daf in operator() (__closure=0x0,
> > > userData=0x7f2670fea290
> > > <WebCore::MainThreadSharedTimer::singleton()::instance+16>,
> > > callback=0x7f2670114523 <_FUN(gpointer)>, source=0x55934de74760)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:53
> > > #38 _FUN () at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:56
> > > #39 0x00007f266d87b5eb in g_main_dispatch (context=0x55934dd1fc10) at
> > > ../glib/gmain.c:3337
> > > #40 g_main_context_dispatch (context=0x55934dd1fc10) at ../glib/gmain.c:4055
> > > #41 0x00007f266d87b852 in g_main_context_iterate
> > > (context=0x55934dd1fc10, block=block@entry=1,
> > > dispatch=dispatch@entry=1, self=<optimized out>) at
> > > ../glib/gmain.c:4131
> > > #42 0x00007f266d87bb92 in g_main_loop_run
> > > (loop=loop@entry=0x55934dd20dc0) at ../glib/gmain.c:4329
> > > #43 0x00007f2670114916 in WTF::RunLoop::run () at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:108
> > > #44 0x00007f266e565d25 in
> > > WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run
> > > (argc=3, argv=0x7ffd53b9f618, this=0x7ffd53b9f468)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:70
> > > #45 WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run
> > > (argv=0x7ffd53b9f618, argc=3, this=0x7ffd53b9f468)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:57
> > > #46 WebKit::AuxiliaryProcessMain<WebKit::WebProcessMainWPE> (argc=3,
> > > argv=0x7ffd53b9f618) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:96
> > > #47 0x00007f266d2701d7 in __libc_start_call_main
> > > (main=main@entry=0x55934d51d060 <main(int, char**)>,
> > > argc=argc@entry=3, argv=argv@entry=0x7ffd53b9f618) at
> > > ../sysdeps/nptl/libc_start_call_main.h:58
> > > #48 0x00007f266d270288 in __libc_start_main_impl (main=0x55934d51d060
> > > <main(int, char**)>, argc=3, argv=0x7ffd53b9f618, init=<optimized
> > > out>, fini=<optimized out>, rtld_fini=<optimized out>,
> > > stack_end=0x7ffd53b9f608)
> > > at ../csu/libc-start.c:409
> > > #49 0x000055934d51d091 in _start () at ../sysdeps/x86_64/start.S:116
> > >
> > > On Mon, Oct 25, 2021 at 4:45 PM Adrian Perez de Castro
> > > <aperez@igalia.com> wrote:
> > > >
> > > > Update to a new major release which brings in improvements and a number
> > > > of new features. Release notes:
> > > >
> > > > https://wpewebkit.org/release/wpewebkit-2.34.0.html
> > > > https://wpewebkit.org/release/wpewebkit-2.34.1.html
> > > >
> > > > Some of the new features require additional dependencies: HTTP/2
> > > > requires libsoup3, which is not yet in packaged in Buildroot, and
> > > > disabled at the moment (with -DUSE_SOUP2=ON, to keep using libsoup2);
> > > > and the color management support needs LCMS2 (which will be enabled
> > > > in a follow-up patch.)
> > > >
> > > > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> > > > ---
> > > > ...e-build-issues-with-ENABLE_VIDEO-OFF.patch | 78 +++++++++++++++++++
> > > > package/wpewebkit/wpewebkit.hash | 8 +-
> > > > package/wpewebkit/wpewebkit.mk | 4 +-
> > > > 3 files changed, 85 insertions(+), 5 deletions(-)
> > > > create mode 100644 package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > > >
> > > > diff --git a/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > > > new file mode 100644
> > > > index 0000000000..51212dd82d
> > > > --- /dev/null
> > > > +++ b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > > > @@ -0,0 +1,78 @@
> > > > +From afc83d41293333f694630451f865a7a257a9b917 Mon Sep 17 00:00:00 2001
> > > > +From: Adrian Perez de Castro <aperez@igalia.com>
> > > > +Date: Mon, 25 Oct 2021 23:45:15 +0300
> > > > +Subject: [PATCH] [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF
> > > > + https://bugs.webkit.org/show_bug.cgi?id=232264
> > > > +
> > > > +.:
> > > > +
> > > > +Reviewed by NOBODY (OOPS!).
> > > > +
> > > > +* Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_SESSION depend on ENABLE_VIDEO.
> > > > +
> > > > +Source/WebCore:
> > > > +
> > > > +Reviewed by NOBODY (OOPS!).
> > > > +
> > > > +No new tests needed.
> > > > +
> > > > +* accessibility/AXObjectCache.cpp:
> > > > +(WebCore::isSimpleImage): Guard usage of HTMLMediaElement with ENABLE(VIDEO).
> > > > +* page/EventHandler.cpp:
> > > > +(WebCore::EventHandler::textRecognitionCandidateElement const): Ditto.
> > > > +* platform/graphics/BifurcatedGraphicsContext.cpp: Ditto.
> > > > +* platform/graphics/displaylists/DisplayListRecorder.h: Guard usage of MediaPlayer with
> > > > +ENABLE(VIDEO).
> > > > +* platform/graphics/displaylists/DisplayListRecorderImpl.cpp: Ditto.
> > > > +* platform/graphics/displaylists/DisplayListRecorderImpl.h: Ditto.
> > > > +
> > > > +Source/WebKit:
> > > > +
> > > > +* WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
> > > > +(WebKit::createShareableBitmap): Guard usage of RenderVideo with ENABLE(VIDEO).
> > > > +
> > > > +Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> > > > +---
> > > > +Upstream status: https://bugs.webkit.org/show_bug.cgi?id=232264
> > > > +
> > > > + Source/WebCore/accessibility/AXObjectCache.cpp | 2 ++
> > > > + Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp | 2 ++
> > > > + 2 files changed, 4 insertions(+)
> > > > +
> > > > +diff --git a/Source/WebCore/accessibility/AXObjectCache.cpp b/Source/WebCore/accessibility/AXObjectCache.cpp
> > > > +index f2451102040..930b969dcc2 100644
> > > > +--- a/Source/WebCore/accessibility/AXObjectCache.cpp
> > > > ++++ b/Source/WebCore/accessibility/AXObjectCache.cpp
> > > > +@@ -528,9 +528,11 @@ static bool isSimpleImage(const RenderObject& renderer)
> > > > + || (is<HTMLImageElement>(node) && downcast<HTMLImageElement>(node)->hasAttributeWithoutSynchronization(usemapAttr)))
> > > > + return false;
> > > > +
> > > > ++#if ENABLE(VIDEO)
> > > > + // Exclude video and audio elements.
> > > > + if (is<HTMLMediaElement>(node))
> > > > + return false;
> > > > ++#endif // ENABLE(VIDEO)
> > > > +
> > > > + return true;
> > > > + }
> > > > +diff --git a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > > > +index c0ce72c5ffc..d7ead303f3c 100644
> > > > +--- a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > > > ++++ b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > > > +@@ -269,11 +269,13 @@ void BifurcatedGraphicsContext::drawPattern(NativeImage& nativeImage, const Floa
> > > > + m_secondaryContext.drawPattern(nativeImage, imageSize, destRect, tileRect, patternTransform, phase, spacing, options);
> > > > + }
> > > > +
> > > > ++#if ENABLE(VIDEO)
> > > > + void BifurcatedGraphicsContext::paintFrameForMedia(MediaPlayer& player, const FloatRect& destination)
> > > > + {
> > > > + m_primaryContext.paintFrameForMedia(player, destination);
> > > > + m_secondaryContext.paintFrameForMedia(player, destination);
> > > > + }
> > > > ++#endif // ENABLE(VIDEO)
> > > > +
> > > > + void BifurcatedGraphicsContext::scale(const FloatSize& scale)
> > > > + {
> > > > +--
> > > > +2.33.1
> > > > +
> > > > diff --git a/package/wpewebkit/wpewebkit.hash b/package/wpewebkit/wpewebkit.hash
> > > > index ff8bd1f30a..acb3ec4a3e 100644
> > > > --- a/package/wpewebkit/wpewebkit.hash
> > > > +++ b/package/wpewebkit/wpewebkit.hash
> > > > @@ -1,7 +1,7 @@
> > > > -# From https://wpewebkit.org/releases/wpewebkit-2.32.4.tar.xz.sums
> > > > -md5 94ca1cc3f7b2de8b96c59d6e59cafcd0 wpewebkit-2.32.4.tar.xz
> > > > -sha1 19b8ebdbfef193ca50f7625703d871db87624f86 wpewebkit-2.32.4.tar.xz
> > > > -sha256 381f1422cbc319db1aa42dda48de39590ed90ac3bec6b81ec83f3f2cae5c3eeb wpewebkit-2.32.4.tar.xz
> > > > +# From https://wpewebkit.org/releases/wpewebkit-2.34.1.tar.xz.sums
> > > > +md5 915e583b0e7e82efa155cbce917d6319 wpewebkit-2.34.1.tar.xz
> > > > +sha1 452081b6df9d079f26d22bd0dca9e90f87943089 wpewebkit-2.34.1.tar.xz
> > > > +sha256 cb336986341be9c3a9b1ca2c18de0d29d90ae4e77b9967a6f6879597e7a969f7 wpewebkit-2.34.1.tar.xz
> > > >
> > > > # Hashes for license files:
> > > > sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
> > > > diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> > > > index 0242f7a288..606a1531c0 100644
> > > > --- a/package/wpewebkit/wpewebkit.mk
> > > > +++ b/package/wpewebkit/wpewebkit.mk
> > > > @@ -4,7 +4,7 @@
> > > > #
> > > > ################################################################################
> > > >
> > > > -WPEWEBKIT_VERSION = 2.32.4
> > > > +WPEWEBKIT_VERSION = 2.34.1
> > > > WPEWEBKIT_SITE = http://www.wpewebkit.org/releases
> > > > WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz
> > > > WPEWEBKIT_INSTALL_STAGING = YES
> > > > @@ -23,6 +23,8 @@ WPEWEBKIT_CONF_OPTS = \
> > > > -DENABLE_ACCESSIBILITY=OFF \
> > > > -DENABLE_API_TESTS=OFF \
> > > > -DENABLE_MINIBROWSER=OFF \
> > > > + -DUSE_LCMS=OFF \
> > > > + -DUSE_SOUP2=ON \
> > > > -DSILENCE_CROSS_COMPILATION_NOTICES=ON
> > > >
> > > > ifeq ($(BR2_PACKAGE_WPEWEBKIT_SANDBOX),y)
> > > > --
> > > > 2.33.1
> > > >
> > > > _______________________________________________
> > > > buildroot mailing list
> > > > buildroot@buildroot.org
> > > > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> Cheers,
> —Adrián
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1
2021-12-07 20:59 ` Adrian Perez de Castro
2021-12-07 21:07 ` James Hilliard
@ 2021-12-07 21:15 ` Adrian Perez de Castro
1 sibling, 0 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2021-12-07 21:15 UTC (permalink / raw)
To: James Hilliard; +Cc: buildroot
[-- Attachment #1.1: Type: text/plain, Size: 20816 bytes --]
On Tue, 07 Dec 2021 22:59:23 +0200 Adrian Perez de Castro <aperez@igalia.com> wrote:
> On Tue, 07 Dec 2021 07:07:17 -0700 James Hilliard <james.hilliard1@gmail.com> wrote:
> > Selecting BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEORATE appears to
> > fix this crash.
>
> Good find! Amusingly we have nowadays support in WebKit to report a
> meaningful message when a required GStreamer element is missing (using
> the RELEASE_ASSERT_WITH_MESSAGE macro) but sadly at the moment those only
> go to journald and for catching this kind of issues we really would want
> those to *also* go to stderr.
I posted a patch to make it more obvious when GStreamer elements are missing,
let's see what the multimedia-savvy WebKit reviewers say about it:
https://bugs.webkit.org/show_bug.cgi?id=233949
=)
> > On Sat, Oct 30, 2021 at 12:29 PM James Hilliard
> > <james.hilliard1@gmail.com> wrote:
> > >
> > > Looks like there's a crash when loading gstreamer mediastream devices
> > > or something:
> > > #0 __pthread_kill_internal (signo=6, threadid=<optimized out>) at
> > > pthread_kill.c:45
> > > #1 __GI___pthread_kill (threadid=<optimized out>,
> > > signo=signo@entry=6) at pthread_kill.c:62
> > > #2 0x00007f266d284382 in __GI_raise (sig=sig@entry=6) at
> > > ../sysdeps/posix/raise.c:26
> > > #3 0x00007f266d26f43f in __GI_abort () at abort.c:79
> > > #4 0x00007f266e5679e0 in CRASH_WITH_INFO(...) () at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Assertions.h:750
> > > #5 WebCore::makeGStreamerBin (description=<optimized out>,
> > > ghostUnlinkedPads=<optimized out>)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:516
> > > #6 0x00007f266f662f35 in WebCore::GStreamerCapturer::setupPipeline
> > > (this=0x7f25e3ea75b0)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:151
> > > #7 0x00007f266f66386a in
> > > WebCore::GStreamerVideoCaptureSource::startProducingData
> > > (this=0x7f2605217a00)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:183
> > > #8 0x00007f266f13de98 in WebCore::RealtimeMediaSource::start
> > > (this=0x7f2605217a00) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:231
> > > #9 WebCore::RealtimeMediaSource::start (this=0x7f2605217a00) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:223
> > > #10 0x00007f266f13df9c in WebCore::RealtimeMediaSource::setMuted
> > > (this=0x7f2605217a00, muted=<optimized out>)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:117
> > > #11 0x00007f266e9e761e in WebCore::MediaStreamTrackPrivate::setMuted
> > > (muted=<optimized out>, this=<optimized out>)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h:87
> > > #12 0x00007f266e9eb04d in WebCore::MediaStreamTrack::create
> > > (context=..., privateTrack=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:76
> > > #13 0x00007f266e9ebb13 in WebCore::MediaStream::MediaStream
> > > (this=0x7f260571c8b0, document=..., streamPrivate=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/RefCounted.h:49
> > > #14 0x00007f266e9ebbd7 in WebCore::MediaStream::create (document=...,
> > > streamPrivate=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/MediaStream.cpp:63
> > > #15 0x00007f266e9f7971 in
> > > operator()<std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate>,
> > > WTF::String> > (privateStreamOrError=..., __closure=0x7f25e84815d8)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:260
> > > #16 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&,
> > > WebCore::CaptureDevice&&, WTF::String&&,
> > > WTF::CompletionHandler<void()>&&)::<lambda()>
> > > mutable::<lambda(auto:44)>, void,
> > > std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> > > WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >,
> > > WTF::String>&&>::call(std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> > > WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >, WTF::String> &&)
> > > (this=0x7f25e84815d0, in#0=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > > #17 0x00007f266f13fde1 in operator()<WTF::String> (errorMessage=...,
> > > this=0x7f25e3ed3968) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:112
> > > #18 WTF::Detail::CallableWrapper<WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<const
> > > WTF::Logger, WTF::RawPtrTraits<const WTF::Logger> >&&,
> > > WebCore::RealtimeMediaSourceCenter::NewMediaStreamHandler&&,
> > > WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> > > const WebCore::MediaStreamRequest&)::<lambda(auto:26&&)> mutable [with
> > > auto:26 = WTF::String]::<lambda(auto:27&&)>, void,
> > > WTF::String&&>::call(WTF::String &&) (
> > > this=0x7f25e3ed3960, in#0=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > > #19 0x00007f266e1ed059 in WTF::Function<void
> > > (WTF::String&&)>::operator()(WTF::String&&) const (in#0=...,
> > > this=<optimized out>) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> > > #20 WTF::CompletionHandler<void
> > > (WTF::String&&)>::operator()(WTF::String&&) (this=<optimized out>,
> > > in#0=...) at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> > > #21 0x00007f266e19b436 in WTF::Function<void
> > > (WTF::String)>::operator()(WTF::String) const (in#0=...,
> > > this=<optimized out>) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> > > #22 WTF::CompletionHandler<void
> > > (WTF::String)>::operator()(WTF::String)
> > > (this=this@entry=0x7ffd53b9eff8, in#0=...) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> > > #23 0x00007f266e19b49b in
> > > WebCore::RealtimeMediaSource::whenReady(WTF::CompletionHandler<void
> > > (WTF::String)>&&) (this=this@entry=0x7f2605217a00, callback=...)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WebCore/PrivateHeaders/WebCore/RealtimeMediaSource.h:322
> > > #24 0x00007f266f13fca1 in operator()<WTF::String> (errorMessage=...,
> > > __closure=<optimized out>)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:114
> > > #25 WTF::Detail::CallableWrapper<WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<const
> > > WTF::Logger, WTF::RawPtrTraits<const WTF::Logger> >&&,
> > > WebCore::RealtimeMediaSourceCenter::NewMediaStreamHandler&&,
> > > WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> > > const WebCore::MediaStreamRequest&)::<lambda(auto:26&&)>, void,
> > > WTF::String&&>::call(WTF::String &&) (this=<optimized out>, in#0=...)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > > #26 0x00007f266e1ed059 in WTF::Function<void
> > > (WTF::String&&)>::operator()(WTF::String&&) const (in#0=...,
> > > this=<optimized out>) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:82
> > > #27 WTF::CompletionHandler<void
> > > (WTF::String&&)>::operator()(WTF::String&&) (this=<optimized out>,
> > > in#0=...) at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/CompletionHandler.h:67
> > > #28 0x00007f266f13f9e6 in
> > > WebCore::RealtimeMediaSourceCenter::createMediaStream(WTF::Ref<WTF::Logger
> > > const, WTF::RawPtrTraits<WTF::Logger const> >&&, WTF::Function<void
> > > (std::experimental::fundamentals_v3::expected<WTF::Ref<WebCore::MediaStreamPrivate,
> > > WTF::RawPtrTraits<WebCore::MediaStreamPrivate> >, WTF::String>&&)>&&,
> > > WTF::String&&, WebCore::CaptureDevice&&, WebCore::CaptureDevice&&,
> > > WebCore::MediaStreamRequest const&) (
> > > this=this@entry=0x7f2670feae20
> > > <WebCore::RealtimeMediaSourceCenter::singleton()::center>, logger=...,
> > > completionHandler=..., hashSalt=..., audioDevice=..., videoDevice=...,
> > > request=...)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:117
> > > #29 0x00007f266e9f6dba in operator() (__closure=<optimized out>) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:274
> > > #30 WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&,
> > > WebCore::CaptureDevice&&, WTF::String&&,
> > > WTF::CompletionHandler<void()>&&)::<lambda()>, void>::call(void)
> > > (this=0x7f25e3e3d958)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/WTF/Headers/wtf/Function.h:53
> > > #31 0x00007f266ec7c7f1 in WebCore::EventLoop::run
> > > (this=0x7f26698bf9c0) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/dom/EventLoop.cpp:123
> > > #32 0x00007f266ecd12e2 in WebCore::WindowEventLoop::didReachTimeToRun
> > > (this=<optimized out>) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/dom/WindowEventLoop.cpp:120
> > > #33 0x00007f266f07cf0e in
> > > WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x7f26698969d8)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/ThreadTimers.cpp:127
> > > #34 WebCore::ThreadTimers::sharedTimerFiredInternal
> > > (this=0x7f26698969d8) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebCore/platform/ThreadTimers.cpp:99
> > > #35 0x00007f2670114548 in operator() (__closure=0x0,
> > > userData=<optimized out>, userData@entry=0x7f2670fea290
> > > <WebCore::MainThreadSharedTimer::singleton()::instance+16>)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:177
> > > #36 _FUN () at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:181
> > > #37 0x00007f2670114daf in operator() (__closure=0x0,
> > > userData=0x7f2670fea290
> > > <WebCore::MainThreadSharedTimer::singleton()::instance+16>,
> > > callback=0x7f2670114523 <_FUN(gpointer)>, source=0x55934de74760)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:53
> > > #38 _FUN () at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:56
> > > #39 0x00007f266d87b5eb in g_main_dispatch (context=0x55934dd1fc10) at
> > > ../glib/gmain.c:3337
> > > #40 g_main_context_dispatch (context=0x55934dd1fc10) at ../glib/gmain.c:4055
> > > #41 0x00007f266d87b852 in g_main_context_iterate
> > > (context=0x55934dd1fc10, block=block@entry=1,
> > > dispatch=dispatch@entry=1, self=<optimized out>) at
> > > ../glib/gmain.c:4131
> > > #42 0x00007f266d87bb92 in g_main_loop_run
> > > (loop=loop@entry=0x55934dd20dc0) at ../glib/gmain.c:4329
> > > #43 0x00007f2670114916 in WTF::RunLoop::run () at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WTF/wtf/glib/RunLoopGLib.cpp:108
> > > #44 0x00007f266e565d25 in
> > > WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run
> > > (argc=3, argv=0x7ffd53b9f618, this=0x7ffd53b9f468)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:70
> > > #45 WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run
> > > (argv=0x7ffd53b9f618, argc=3, this=0x7ffd53b9f468)
> > > at /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:57
> > > #46 WebKit::AuxiliaryProcessMain<WebKit::WebProcessMainWPE> (argc=3,
> > > argv=0x7ffd53b9f618) at
> > > /home/buildroot/buildroot/output/build/wpewebkit-2.34.1/Source/WebKit/Shared/AuxiliaryProcessMain.h:96
> > > #47 0x00007f266d2701d7 in __libc_start_call_main
> > > (main=main@entry=0x55934d51d060 <main(int, char**)>,
> > > argc=argc@entry=3, argv=argv@entry=0x7ffd53b9f618) at
> > > ../sysdeps/nptl/libc_start_call_main.h:58
> > > #48 0x00007f266d270288 in __libc_start_main_impl (main=0x55934d51d060
> > > <main(int, char**)>, argc=3, argv=0x7ffd53b9f618, init=<optimized
> > > out>, fini=<optimized out>, rtld_fini=<optimized out>,
> > > stack_end=0x7ffd53b9f608)
> > > at ../csu/libc-start.c:409
> > > #49 0x000055934d51d091 in _start () at ../sysdeps/x86_64/start.S:116
> > >
> > > On Mon, Oct 25, 2021 at 4:45 PM Adrian Perez de Castro
> > > <aperez@igalia.com> wrote:
> > > >
> > > > Update to a new major release which brings in improvements and a number
> > > > of new features. Release notes:
> > > >
> > > > https://wpewebkit.org/release/wpewebkit-2.34.0.html
> > > > https://wpewebkit.org/release/wpewebkit-2.34.1.html
> > > >
> > > > Some of the new features require additional dependencies: HTTP/2
> > > > requires libsoup3, which is not yet in packaged in Buildroot, and
> > > > disabled at the moment (with -DUSE_SOUP2=ON, to keep using libsoup2);
> > > > and the color management support needs LCMS2 (which will be enabled
> > > > in a follow-up patch.)
> > > >
> > > > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> > > > ---
> > > > ...e-build-issues-with-ENABLE_VIDEO-OFF.patch | 78 +++++++++++++++++++
> > > > package/wpewebkit/wpewebkit.hash | 8 +-
> > > > package/wpewebkit/wpewebkit.mk | 4 +-
> > > > 3 files changed, 85 insertions(+), 5 deletions(-)
> > > > create mode 100644 package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > > >
> > > > diff --git a/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > > > new file mode 100644
> > > > index 0000000000..51212dd82d
> > > > --- /dev/null
> > > > +++ b/package/wpewebkit/0001-WPE-GTK-Multiple-build-issues-with-ENABLE_VIDEO-OFF.patch
> > > > @@ -0,0 +1,78 @@
> > > > +From afc83d41293333f694630451f865a7a257a9b917 Mon Sep 17 00:00:00 2001
> > > > +From: Adrian Perez de Castro <aperez@igalia.com>
> > > > +Date: Mon, 25 Oct 2021 23:45:15 +0300
> > > > +Subject: [PATCH] [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF
> > > > + https://bugs.webkit.org/show_bug.cgi?id=232264
> > > > +
> > > > +.:
> > > > +
> > > > +Reviewed by NOBODY (OOPS!).
> > > > +
> > > > +* Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_SESSION depend on ENABLE_VIDEO.
> > > > +
> > > > +Source/WebCore:
> > > > +
> > > > +Reviewed by NOBODY (OOPS!).
> > > > +
> > > > +No new tests needed.
> > > > +
> > > > +* accessibility/AXObjectCache.cpp:
> > > > +(WebCore::isSimpleImage): Guard usage of HTMLMediaElement with ENABLE(VIDEO).
> > > > +* page/EventHandler.cpp:
> > > > +(WebCore::EventHandler::textRecognitionCandidateElement const): Ditto.
> > > > +* platform/graphics/BifurcatedGraphicsContext.cpp: Ditto.
> > > > +* platform/graphics/displaylists/DisplayListRecorder.h: Guard usage of MediaPlayer with
> > > > +ENABLE(VIDEO).
> > > > +* platform/graphics/displaylists/DisplayListRecorderImpl.cpp: Ditto.
> > > > +* platform/graphics/displaylists/DisplayListRecorderImpl.h: Ditto.
> > > > +
> > > > +Source/WebKit:
> > > > +
> > > > +* WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
> > > > +(WebKit::createShareableBitmap): Guard usage of RenderVideo with ENABLE(VIDEO).
> > > > +
> > > > +Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> > > > +---
> > > > +Upstream status: https://bugs.webkit.org/show_bug.cgi?id=232264
> > > > +
> > > > + Source/WebCore/accessibility/AXObjectCache.cpp | 2 ++
> > > > + Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp | 2 ++
> > > > + 2 files changed, 4 insertions(+)
> > > > +
> > > > +diff --git a/Source/WebCore/accessibility/AXObjectCache.cpp b/Source/WebCore/accessibility/AXObjectCache.cpp
> > > > +index f2451102040..930b969dcc2 100644
> > > > +--- a/Source/WebCore/accessibility/AXObjectCache.cpp
> > > > ++++ b/Source/WebCore/accessibility/AXObjectCache.cpp
> > > > +@@ -528,9 +528,11 @@ static bool isSimpleImage(const RenderObject& renderer)
> > > > + || (is<HTMLImageElement>(node) && downcast<HTMLImageElement>(node)->hasAttributeWithoutSynchronization(usemapAttr)))
> > > > + return false;
> > > > +
> > > > ++#if ENABLE(VIDEO)
> > > > + // Exclude video and audio elements.
> > > > + if (is<HTMLMediaElement>(node))
> > > > + return false;
> > > > ++#endif // ENABLE(VIDEO)
> > > > +
> > > > + return true;
> > > > + }
> > > > +diff --git a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > > > +index c0ce72c5ffc..d7ead303f3c 100644
> > > > +--- a/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > > > ++++ b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
> > > > +@@ -269,11 +269,13 @@ void BifurcatedGraphicsContext::drawPattern(NativeImage& nativeImage, const Floa
> > > > + m_secondaryContext.drawPattern(nativeImage, imageSize, destRect, tileRect, patternTransform, phase, spacing, options);
> > > > + }
> > > > +
> > > > ++#if ENABLE(VIDEO)
> > > > + void BifurcatedGraphicsContext::paintFrameForMedia(MediaPlayer& player, const FloatRect& destination)
> > > > + {
> > > > + m_primaryContext.paintFrameForMedia(player, destination);
> > > > + m_secondaryContext.paintFrameForMedia(player, destination);
> > > > + }
> > > > ++#endif // ENABLE(VIDEO)
> > > > +
> > > > + void BifurcatedGraphicsContext::scale(const FloatSize& scale)
> > > > + {
> > > > +--
> > > > +2.33.1
> > > > +
> > > > diff --git a/package/wpewebkit/wpewebkit.hash b/package/wpewebkit/wpewebkit.hash
> > > > index ff8bd1f30a..acb3ec4a3e 100644
> > > > --- a/package/wpewebkit/wpewebkit.hash
> > > > +++ b/package/wpewebkit/wpewebkit.hash
> > > > @@ -1,7 +1,7 @@
> > > > -# From https://wpewebkit.org/releases/wpewebkit-2.32.4.tar.xz.sums
> > > > -md5 94ca1cc3f7b2de8b96c59d6e59cafcd0 wpewebkit-2.32.4.tar.xz
> > > > -sha1 19b8ebdbfef193ca50f7625703d871db87624f86 wpewebkit-2.32.4.tar.xz
> > > > -sha256 381f1422cbc319db1aa42dda48de39590ed90ac3bec6b81ec83f3f2cae5c3eeb wpewebkit-2.32.4.tar.xz
> > > > +# From https://wpewebkit.org/releases/wpewebkit-2.34.1.tar.xz.sums
> > > > +md5 915e583b0e7e82efa155cbce917d6319 wpewebkit-2.34.1.tar.xz
> > > > +sha1 452081b6df9d079f26d22bd0dca9e90f87943089 wpewebkit-2.34.1.tar.xz
> > > > +sha256 cb336986341be9c3a9b1ca2c18de0d29d90ae4e77b9967a6f6879597e7a969f7 wpewebkit-2.34.1.tar.xz
> > > >
> > > > # Hashes for license files:
> > > > sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
> > > > diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> > > > index 0242f7a288..606a1531c0 100644
> > > > --- a/package/wpewebkit/wpewebkit.mk
> > > > +++ b/package/wpewebkit/wpewebkit.mk
> > > > @@ -4,7 +4,7 @@
> > > > #
> > > > ################################################################################
> > > >
> > > > -WPEWEBKIT_VERSION = 2.32.4
> > > > +WPEWEBKIT_VERSION = 2.34.1
> > > > WPEWEBKIT_SITE = http://www.wpewebkit.org/releases
> > > > WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz
> > > > WPEWEBKIT_INSTALL_STAGING = YES
> > > > @@ -23,6 +23,8 @@ WPEWEBKIT_CONF_OPTS = \
> > > > -DENABLE_ACCESSIBILITY=OFF \
> > > > -DENABLE_API_TESTS=OFF \
> > > > -DENABLE_MINIBROWSER=OFF \
> > > > + -DUSE_LCMS=OFF \
> > > > + -DUSE_SOUP2=ON \
> > > > -DSILENCE_CROSS_COMPILATION_NOTICES=ON
> > > >
> > > > ifeq ($(BR2_PACKAGE_WPEWEBKIT_SANDBOX),y)
> > > > --
> > > > 2.33.1
> > > >
> > > > _______________________________________________
> > > > buildroot mailing list
> > > > buildroot@buildroot.org
> > > > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> Cheers,
> —Adrián
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-12-07 21:15 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 22:43 [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1 Adrian Perez de Castro
2021-10-25 22:44 ` [Buildroot] [PATCH 1/4] package/libwpe: bump to version 1.12.0 Adrian Perez de Castro
2021-10-25 22:44 ` [Buildroot] [PATCH 2/4] package/wpebackend-fdo: " Adrian Perez de Castro
2021-10-25 22:44 ` [Buildroot] [PATCH 3/4] package/wpewebkit: bump to version 2.34.1 Adrian Perez de Castro
2021-10-30 18:29 ` James Hilliard
2021-12-07 14:07 ` James Hilliard
2021-12-07 20:59 ` Adrian Perez de Castro
2021-12-07 21:07 ` James Hilliard
2021-12-07 21:15 ` Adrian Perez de Castro
2021-11-17 21:02 ` Arnout Vandecappelle
2021-10-25 22:44 ` [Buildroot] [PATCH 4/4] package/wpewebkit: use lcms2 for if available Adrian Perez de Castro
2021-11-17 21:03 ` Arnout Vandecappelle
2021-11-17 21:02 ` [Buildroot] [PATCH 0/4] Update WPE WebKit (and deps) to 2.34.1 Arnout Vandecappelle
2021-11-24 20:51 ` Adrian Perez de Castro
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.