All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/gpu/drm/i915/display/intel_dp.c:4053:10: warning: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
@ 2021-10-25 23:48 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-10-25 23:48 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 6683 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
CC: Jani Nikula <jani.nikula@intel.com>
CC: Uma Shankar <uma.shankar@intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3906fe9bb7f1a2c8667ae54e967dc8690824f4ea
commit: ced42f2df5fd8621c896faeafe7ecc0ea8b2ea81 drm/i915: Add support for starting FRL training for HDMI2.1 via PCON
date:   10 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 10 months ago
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/gpu/drm/i915/display/intel_dp.c:4053:10: warning: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
    wait_for(is_active = drm_dp_pcon_is_frl_ready(&intel_dp->aux) == true, TIMEOUT_FRL_READY_MS);
            ^
   drivers/gpu/drm/i915/display/intel_dp.c:4072:10: warning: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
    wait_for(is_active = drm_dp_pcon_hdmi_link_active(&intel_dp->aux) == true, TIMEOUT_HDMI_LINK_ACTIVE_MS);
            ^

vim +4053 drivers/gpu/drm/i915/display/intel_dp.c

ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4028  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4029  	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4030  	int max_frl_bw, max_pcon_frl_bw, max_edid_frl_bw, ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4031  	u8 max_frl_bw_mask = 0, frl_trained_mask;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4032  	bool is_active;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4033  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4034  	ret = drm_dp_pcon_reset_frl_config(&intel_dp->aux);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4035  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4036  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4037  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4038  	max_pcon_frl_bw = intel_dp->dfp.pcon_max_frl_bw;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4039  	drm_dbg(&i915->drm, "PCON max rate = %d Gbps\n", max_pcon_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4040  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4041  	max_edid_frl_bw = intel_dp_hdmi_sink_max_frl(intel_dp);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4042  	drm_dbg(&i915->drm, "Sink max rate from EDID = %d Gbps\n", max_edid_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4043  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4044  	max_frl_bw = min(max_edid_frl_bw, max_pcon_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4045  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4046  	if (max_frl_bw <= 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4047  		return -EINVAL;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4048  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4049  	ret = drm_dp_pcon_frl_prepare(&intel_dp->aux, false);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4050  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4051  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4052  	/* Wait for PCON to be FRL Ready */
ced42f2df5fd86 Ankit Nautiyal 2020-12-18 @4053  	wait_for(is_active = drm_dp_pcon_is_frl_ready(&intel_dp->aux) == true, TIMEOUT_FRL_READY_MS);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4054  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4055  	if (!is_active)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4056  		return -ETIMEDOUT;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4057  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4058  	max_frl_bw_mask = intel_dp_pcon_set_frl_mask(max_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4059  	ret = drm_dp_pcon_frl_configure_1(&intel_dp->aux, max_frl_bw, PCON_SEQUENTIAL_MODE);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4060  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4061  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4062  	ret = drm_dp_pcon_frl_configure_2(&intel_dp->aux, max_frl_bw_mask, PCON_NORMAL_TRAIN_MODE);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4063  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4064  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4065  	ret = drm_dp_pcon_frl_enable(&intel_dp->aux);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4066  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4067  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4068  	/*
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4069  	 * Wait for FRL to be completed
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4070  	 * Check if the HDMI Link is up and active.
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4071  	 */
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4072  	wait_for(is_active = drm_dp_pcon_hdmi_link_active(&intel_dp->aux) == true, TIMEOUT_HDMI_LINK_ACTIVE_MS);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4073  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4074  	if (!is_active)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4075  		return -ETIMEDOUT;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4076  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4077  	/* Verify HDMI Link configuration shows FRL Mode */
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4078  	if (drm_dp_pcon_hdmi_link_mode(&intel_dp->aux, &frl_trained_mask) !=
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4079  	    DP_PCON_HDMI_MODE_FRL) {
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4080  		drm_dbg(&i915->drm, "HDMI couldn't be trained in FRL Mode\n");
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4081  		return -EINVAL;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4082  	}
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4083  	drm_dbg(&i915->drm, "MAX_FRL_MASK = %u, FRL_TRAINED_MASK = %u\n", max_frl_bw_mask, frl_trained_mask);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4084  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4085  	intel_dp->frl.trained_rate_gbps = intel_dp_pcon_get_frl_mask(frl_trained_mask);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4086  	intel_dp->frl.is_trained = true;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4087  	drm_dbg(&i915->drm, "FRL trained with : %d Gbps\n", intel_dp->frl.trained_rate_gbps);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4088  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4089  	return 0;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4090  }
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4091  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 3+ messages in thread
* drivers/gpu/drm/i915/display/intel_dp.c:4053:10: warning: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
@ 2021-07-13  0:30 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-07-13  0:30 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 9599 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
CC: Jani Nikula <jani.nikula@intel.com>
CC: Uma Shankar <uma.shankar@intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7fef2edf7cc753b51f7ccc74993971b0a9c81eca
commit: ced42f2df5fd8621c896faeafe7ecc0ea8b2ea81 drm/i915: Add support for starting FRL training for HDMI2.1 via PCON
date:   7 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 7 months ago
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck warnings: (new ones prefixed by >>)
>> drivers/hwmon/adm9240.c:363:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", IN_FROM_REG(data->in[attr->index],
           ^
   drivers/hwmon/adm9240.c:376:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", IN_FROM_REG(data->in_min[attr->index],
           ^
   drivers/hwmon/adm9240.c:389:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", IN_FROM_REG(data->in_max[attr->index],
           ^
   drivers/hwmon/adm9240.c:464:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", FAN_FROM_REG(data->fan[attr->index],
           ^
   drivers/hwmon/adm9240.c:477:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", FAN_FROM_REG(data->fan_min[attr->index],
           ^
   drivers/hwmon/adm9240.c:627:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", AOUT_FROM_REG(data->aout));
           ^
--

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/hwmon/adm9240.c:363:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", IN_FROM_REG(data->in[attr->index],
           ^
   drivers/hwmon/adm9240.c:376:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", IN_FROM_REG(data->in_min[attr->index],
           ^
   drivers/hwmon/adm9240.c:389:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", IN_FROM_REG(data->in_max[attr->index],
           ^
   drivers/hwmon/adm9240.c:464:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", FAN_FROM_REG(data->fan[attr->index],
           ^
   drivers/hwmon/adm9240.c:477:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", FAN_FROM_REG(data->fan_min[attr->index],
           ^
   drivers/hwmon/adm9240.c:627:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
    return sprintf(buf, "%dn", AOUT_FROM_REG(data->aout));
           ^
--
>> drivers/gpu/drm/i915/display/intel_dp.c:4053:10: warning: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
    wait_for(is_active = drm_dp_pcon_is_frl_ready(&intel_dp->aux) == true, TIMEOUT_FRL_READY_MS);
            ^
   drivers/gpu/drm/i915/display/intel_dp.c:4072:10: warning: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
    wait_for(is_active = drm_dp_pcon_hdmi_link_active(&intel_dp->aux) == true, TIMEOUT_HDMI_LINK_ACTIVE_MS);
            ^

vim +4053 drivers/gpu/drm/i915/display/intel_dp.c

ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4028  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4029  	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4030  	int max_frl_bw, max_pcon_frl_bw, max_edid_frl_bw, ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4031  	u8 max_frl_bw_mask = 0, frl_trained_mask;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4032  	bool is_active;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4033  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4034  	ret = drm_dp_pcon_reset_frl_config(&intel_dp->aux);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4035  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4036  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4037  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4038  	max_pcon_frl_bw = intel_dp->dfp.pcon_max_frl_bw;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4039  	drm_dbg(&i915->drm, "PCON max rate = %d Gbps\n", max_pcon_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4040  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4041  	max_edid_frl_bw = intel_dp_hdmi_sink_max_frl(intel_dp);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4042  	drm_dbg(&i915->drm, "Sink max rate from EDID = %d Gbps\n", max_edid_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4043  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4044  	max_frl_bw = min(max_edid_frl_bw, max_pcon_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4045  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4046  	if (max_frl_bw <= 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4047  		return -EINVAL;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4048  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4049  	ret = drm_dp_pcon_frl_prepare(&intel_dp->aux, false);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4050  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4051  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4052  	/* Wait for PCON to be FRL Ready */
ced42f2df5fd86 Ankit Nautiyal 2020-12-18 @4053  	wait_for(is_active = drm_dp_pcon_is_frl_ready(&intel_dp->aux) == true, TIMEOUT_FRL_READY_MS);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4054  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4055  	if (!is_active)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4056  		return -ETIMEDOUT;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4057  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4058  	max_frl_bw_mask = intel_dp_pcon_set_frl_mask(max_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4059  	ret = drm_dp_pcon_frl_configure_1(&intel_dp->aux, max_frl_bw, PCON_SEQUENTIAL_MODE);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4060  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4061  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4062  	ret = drm_dp_pcon_frl_configure_2(&intel_dp->aux, max_frl_bw_mask, PCON_NORMAL_TRAIN_MODE);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4063  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4064  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4065  	ret = drm_dp_pcon_frl_enable(&intel_dp->aux);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4066  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4067  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4068  	/*
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4069  	 * Wait for FRL to be completed
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4070  	 * Check if the HDMI Link is up and active.
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4071  	 */
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4072  	wait_for(is_active = drm_dp_pcon_hdmi_link_active(&intel_dp->aux) == true, TIMEOUT_HDMI_LINK_ACTIVE_MS);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4073  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4074  	if (!is_active)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4075  		return -ETIMEDOUT;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4076  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4077  	/* Verify HDMI Link configuration shows FRL Mode */
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4078  	if (drm_dp_pcon_hdmi_link_mode(&intel_dp->aux, &frl_trained_mask) !=
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4079  	    DP_PCON_HDMI_MODE_FRL) {
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4080  		drm_dbg(&i915->drm, "HDMI couldn't be trained in FRL Mode\n");
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4081  		return -EINVAL;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4082  	}
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4083  	drm_dbg(&i915->drm, "MAX_FRL_MASK = %u, FRL_TRAINED_MASK = %u\n", max_frl_bw_mask, frl_trained_mask);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4084  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4085  	intel_dp->frl.trained_rate_gbps = intel_dp_pcon_get_frl_mask(frl_trained_mask);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4086  	intel_dp->frl.is_trained = true;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4087  	drm_dbg(&i915->drm, "FRL trained with : %d Gbps\n", intel_dp->frl.trained_rate_gbps);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4088  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4089  	return 0;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4090  }
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4091  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 3+ messages in thread
* drivers/gpu/drm/i915/display/intel_dp.c:4053:10: warning: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
@ 2021-04-03  3:35 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-04-03  3:35 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 7025 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
CC: Jani Nikula <jani.nikula@intel.com>
CC: Uma Shankar <uma.shankar@intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d93a0d43e3d0ba9e19387be4dae4a8d5b175a8d7
commit: ced42f2df5fd8621c896faeafe7ecc0ea8b2ea81 drm/i915: Add support for starting FRL training for HDMI2.1 via PCON
date:   3 months ago
:::::: branch date: 4 hours ago
:::::: commit date: 3 months ago
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/net/ethernet/microchip/lan743x_main.c:3021:3: warning: Variable 'mask_index' is modified but its new value is never used. [unreadVariable]
     mask_index++;
     ^
--
>> drivers/gpu/drm/i915/display/intel_psr.c:365:11: warning: Same expression on both sides of '-'. [duplicateExpression]
     [3] = 1 - 1,
             ^
--
>> drivers/gpu/drm/i915/display/intel_dp.c:4053:10: warning: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
    wait_for(is_active = drm_dp_pcon_is_frl_ready(&intel_dp->aux) == true, TIMEOUT_FRL_READY_MS);
            ^
   drivers/gpu/drm/i915/display/intel_dp.c:4072:10: warning: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
    wait_for(is_active = drm_dp_pcon_hdmi_link_active(&intel_dp->aux) == true, TIMEOUT_HDMI_LINK_ACTIVE_MS);
            ^

vim +4053 drivers/gpu/drm/i915/display/intel_dp.c

ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4028  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4029  	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4030  	int max_frl_bw, max_pcon_frl_bw, max_edid_frl_bw, ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4031  	u8 max_frl_bw_mask = 0, frl_trained_mask;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4032  	bool is_active;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4033  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4034  	ret = drm_dp_pcon_reset_frl_config(&intel_dp->aux);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4035  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4036  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4037  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4038  	max_pcon_frl_bw = intel_dp->dfp.pcon_max_frl_bw;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4039  	drm_dbg(&i915->drm, "PCON max rate = %d Gbps\n", max_pcon_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4040  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4041  	max_edid_frl_bw = intel_dp_hdmi_sink_max_frl(intel_dp);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4042  	drm_dbg(&i915->drm, "Sink max rate from EDID = %d Gbps\n", max_edid_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4043  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4044  	max_frl_bw = min(max_edid_frl_bw, max_pcon_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4045  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4046  	if (max_frl_bw <= 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4047  		return -EINVAL;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4048  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4049  	ret = drm_dp_pcon_frl_prepare(&intel_dp->aux, false);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4050  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4051  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4052  	/* Wait for PCON to be FRL Ready */
ced42f2df5fd86 Ankit Nautiyal 2020-12-18 @4053  	wait_for(is_active = drm_dp_pcon_is_frl_ready(&intel_dp->aux) == true, TIMEOUT_FRL_READY_MS);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4054  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4055  	if (!is_active)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4056  		return -ETIMEDOUT;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4057  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4058  	max_frl_bw_mask = intel_dp_pcon_set_frl_mask(max_frl_bw);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4059  	ret = drm_dp_pcon_frl_configure_1(&intel_dp->aux, max_frl_bw, PCON_SEQUENTIAL_MODE);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4060  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4061  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4062  	ret = drm_dp_pcon_frl_configure_2(&intel_dp->aux, max_frl_bw_mask, PCON_NORMAL_TRAIN_MODE);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4063  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4064  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4065  	ret = drm_dp_pcon_frl_enable(&intel_dp->aux);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4066  	if (ret < 0)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4067  		return ret;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4068  	/*
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4069  	 * Wait for FRL to be completed
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4070  	 * Check if the HDMI Link is up and active.
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4071  	 */
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4072  	wait_for(is_active = drm_dp_pcon_hdmi_link_active(&intel_dp->aux) == true, TIMEOUT_HDMI_LINK_ACTIVE_MS);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4073  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4074  	if (!is_active)
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4075  		return -ETIMEDOUT;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4076  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4077  	/* Verify HDMI Link configuration shows FRL Mode */
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4078  	if (drm_dp_pcon_hdmi_link_mode(&intel_dp->aux, &frl_trained_mask) !=
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4079  	    DP_PCON_HDMI_MODE_FRL) {
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4080  		drm_dbg(&i915->drm, "HDMI couldn't be trained in FRL Mode\n");
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4081  		return -EINVAL;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4082  	}
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4083  	drm_dbg(&i915->drm, "MAX_FRL_MASK = %u, FRL_TRAINED_MASK = %u\n", max_frl_bw_mask, frl_trained_mask);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4084  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4085  	intel_dp->frl.trained_rate_gbps = intel_dp_pcon_get_frl_mask(frl_trained_mask);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4086  	intel_dp->frl.is_trained = true;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4087  	drm_dbg(&i915->drm, "FRL trained with : %d Gbps\n", intel_dp->frl.trained_rate_gbps);
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4088  
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4089  	return 0;
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4090  }
ced42f2df5fd86 Ankit Nautiyal 2020-12-18  4091  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-25 23:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 23:48 drivers/gpu/drm/i915/display/intel_dp.c:4053:10: warning: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition] kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-07-13  0:30 kernel test robot
2021-04-03  3:35 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.