From: Mark Rutland <mark.rutland@arm.com> To: linux-kernel@vger.kernel.org Cc: aou@eecs.berkeley.edu, catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, mark.rutland@arm.com, maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com, paul.walmsley@sifive.com, shorne@gmail.com, stefan.kristiansson@saunalahti.fi, tglx@linutronix.de, tsbogend@alpha.franken.de, vgupta@kernel.org, vladimir.murzin@arm.com, will@kernel.org Subject: [PATCH v2 01/17] irq: mips: avoid nested irq_enter() Date: Tue, 26 Oct 2021 10:24:48 +0100 [thread overview] Message-ID: <20211026092504.27071-2-mark.rutland@arm.com> (raw) In-Reply-To: <20211026092504.27071-1-mark.rutland@arm.com> As bcm6345_l1_irq_handle() is a chained irqchip handler, it will be invoked within the context of the root irqchip handler, which must have entered IRQ context already. When bcm6345_l1_irq_handle() calls arch/mips's do_IRQ() , this will nest another call to irq_enter(), and the resulting nested increment to `rcu_data.dynticks_nmi_nesting` will cause rcu_is_cpu_rrupt_from_idle() to fail to identify wakeups from idle, resulting in failure to preempt, and RCU stalls. Chained irqchip handlers must invoke IRQ handlers by way of thee core irqchip code, i.e. generic_handle_irq() or generic_handle_domain_irq() and should not call do_IRQ(), which is intended only for root irqchip handlers. Fix bcm6345_l1_irq_handle() by calling generic_handle_irq() directly. Fixes: c7c42ec2baa1de7a ("irqchips/bmips: Add bcm6345-l1 interrupt controller") Signed-off-by: Mark Rutland <mark.rutland@arm.com> Reviewed-by: Marc Zyngier <maz@kernel.org> Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Thomas Gleixner <tglx@linutronix.de> --- drivers/irqchip/irq-bcm6345-l1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm6345-l1.c b/drivers/irqchip/irq-bcm6345-l1.c index e3483789f4df..1bd0621c4ce2 100644 --- a/drivers/irqchip/irq-bcm6345-l1.c +++ b/drivers/irqchip/irq-bcm6345-l1.c @@ -140,7 +140,7 @@ static void bcm6345_l1_irq_handle(struct irq_desc *desc) for_each_set_bit(hwirq, &pending, IRQS_PER_WORD) { irq = irq_linear_revmap(intc->domain, base + hwirq); if (irq) - do_IRQ(irq); + generic_handle_irq(irq); else spurious_interrupt(); } -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com> To: linux-kernel@vger.kernel.org Cc: aou@eecs.berkeley.edu, catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, mark.rutland@arm.com, maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com, paul.walmsley@sifive.com, shorne@gmail.com, stefan.kristiansson@saunalahti.fi, tglx@linutronix.de, tsbogend@alpha.franken.de, vgupta@kernel.org, vladimir.murzin@arm.com, will@kernel.org Subject: [PATCH v2 01/17] irq: mips: avoid nested irq_enter() Date: Tue, 26 Oct 2021 10:24:48 +0100 [thread overview] Message-ID: <20211026092504.27071-2-mark.rutland@arm.com> (raw) In-Reply-To: <20211026092504.27071-1-mark.rutland@arm.com> As bcm6345_l1_irq_handle() is a chained irqchip handler, it will be invoked within the context of the root irqchip handler, which must have entered IRQ context already. When bcm6345_l1_irq_handle() calls arch/mips's do_IRQ() , this will nest another call to irq_enter(), and the resulting nested increment to `rcu_data.dynticks_nmi_nesting` will cause rcu_is_cpu_rrupt_from_idle() to fail to identify wakeups from idle, resulting in failure to preempt, and RCU stalls. Chained irqchip handlers must invoke IRQ handlers by way of thee core irqchip code, i.e. generic_handle_irq() or generic_handle_domain_irq() and should not call do_IRQ(), which is intended only for root irqchip handlers. Fix bcm6345_l1_irq_handle() by calling generic_handle_irq() directly. Fixes: c7c42ec2baa1de7a ("irqchips/bmips: Add bcm6345-l1 interrupt controller") Signed-off-by: Mark Rutland <mark.rutland@arm.com> Reviewed-by: Marc Zyngier <maz@kernel.org> Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Thomas Gleixner <tglx@linutronix.de> --- drivers/irqchip/irq-bcm6345-l1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm6345-l1.c b/drivers/irqchip/irq-bcm6345-l1.c index e3483789f4df..1bd0621c4ce2 100644 --- a/drivers/irqchip/irq-bcm6345-l1.c +++ b/drivers/irqchip/irq-bcm6345-l1.c @@ -140,7 +140,7 @@ static void bcm6345_l1_irq_handle(struct irq_desc *desc) for_each_set_bit(hwirq, &pending, IRQS_PER_WORD) { irq = irq_linear_revmap(intc->domain, base + hwirq); if (irq) - do_IRQ(irq); + generic_handle_irq(irq); else spurious_interrupt(); } -- 2.11.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-26 9:25 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-26 9:24 [PATCH v2 00/17] irq: remove handle_domain_{irq,nmi}() Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` Mark Rutland [this message] 2021-10-26 9:24 ` [PATCH v2 01/17] irq: mips: avoid nested irq_enter() Mark Rutland 2021-10-26 9:24 ` [PATCH v2 02/17] irq: mips: simplify bcm6345_l1_irq_handle() Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` [PATCH v2 03/17] irq: mips: stop (ab)using handle_domain_irq() Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` [PATCH v2 04/17] irq: mips: simplify do_domain_IRQ() Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` [PATCH v2 05/17] irq: simplify handle_domain_{irq,nmi}() Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` [PATCH v2 06/17] irq: unexport handle_irq_desc() Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` [PATCH v2 07/17] irq: add generic_handle_arch_irq() Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` [PATCH v2 08/17] irq: arc: avoid CONFIG_HANDLE_DOMAIN_IRQ Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` [PATCH v2 09/17] irq: nds32: " Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` [PATCH v2 10/17] irq: add a (temporary) CONFIG_HANDLE_DOMAIN_IRQ_IRQENTRY Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` [PATCH v2 11/17] irq: arm: perform irqentry in entry code Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:24 ` [PATCH v2 12/17] irq: arm64: " Mark Rutland 2021-10-26 9:24 ` Mark Rutland 2021-10-26 9:25 ` [PATCH v2 13/17] irq: csky: " Mark Rutland 2021-10-26 9:25 ` Mark Rutland 2021-10-26 9:25 ` [PATCH v2 14/17] irq: openrisc: " Mark Rutland 2021-10-26 9:25 ` Mark Rutland 2021-10-26 9:25 ` [PATCH v2 15/17] irq: riscv: " Mark Rutland 2021-10-26 9:25 ` Mark Rutland 2021-10-26 9:25 ` [PATCH v2 16/17] irq: remove CONFIG_HANDLE_DOMAIN_IRQ_IRQENTRY Mark Rutland 2021-10-26 9:25 ` Mark Rutland 2021-10-26 9:25 ` [PATCH v2 17/17] irq: remove handle_domain_{irq,nmi}() Mark Rutland 2021-10-26 9:25 ` Mark Rutland 2022-05-06 20:32 ` Lukas Wunner 2022-05-09 8:54 ` Mark Rutland 2022-05-09 8:54 ` Mark Rutland 2022-05-09 9:09 ` Marc Zyngier 2022-05-09 9:09 ` Marc Zyngier 2022-05-09 13:12 ` Thomas Gleixner 2022-05-09 13:12 ` Thomas Gleixner 2022-05-10 23:36 ` Thomas Gleixner 2022-05-10 23:36 ` Thomas Gleixner 2022-05-10 12:13 ` Lukas Wunner 2022-05-10 14:15 ` Mark Rutland 2022-05-10 14:15 ` Mark Rutland 2022-05-10 22:52 ` Thomas Gleixner 2022-05-10 22:52 ` Thomas Gleixner 2022-05-11 8:23 ` Mark Rutland 2022-05-11 8:23 ` Mark Rutland 2022-05-11 8:57 ` Lukas Wunner 2022-05-11 9:27 ` Mark Rutland 2022-05-11 9:27 ` Mark Rutland 2022-05-11 0:11 ` Thomas Gleixner 2022-05-11 0:11 ` Thomas Gleixner 2022-05-11 8:11 ` Mark Rutland 2022-05-11 8:11 ` Mark Rutland 2021-10-26 10:12 ` [PATCH v2 00/17] " Marc Zyngier 2021-10-26 10:12 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211026092504.27071-2-mark.rutland@arm.com \ --to=mark.rutland@arm.com \ --cc=aou@eecs.berkeley.edu \ --cc=catalin.marinas@arm.com \ --cc=deanbo422@gmail.com \ --cc=green.hu@gmail.com \ --cc=guoren@kernel.org \ --cc=jonas@southpole.se \ --cc=kernelfans@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=maz@kernel.org \ --cc=nickhu@andestech.com \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=shorne@gmail.com \ --cc=stefan.kristiansson@saunalahti.fi \ --cc=tglx@linutronix.de \ --cc=tsbogend@alpha.franken.de \ --cc=vgupta@kernel.org \ --cc=vladimir.murzin@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.