From: kernel test robot <lkp@intel.com> To: Davide Caratti <dcaratti@redhat.com>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, Paolo Abeni <pabeni@redhat.com> Cc: kbuild-all@lists.01.org, mptcp@lists.linux.dev, psonparo@redhat.com Subject: Re: [PATCH mptcp-net] mptcp: fix corrupt receiver key in MPC + data + checksum Date: Tue, 26 Oct 2021 12:56:51 +0800 [thread overview] Message-ID: <202110261216.ULu64496-lkp@intel.com> (raw) In-Reply-To: <1207c7d44dd4d1a630afc8b7018cf4185fe4a489.1634827708.git.dcaratti@redhat.com> [-- Attachment #1: Type: text/plain, Size: 2922 bytes --] Hi Davide, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mptcp/export] [also build test WARNING on linus/master v5.15-rc7 next-20211025] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Davide-Caratti/mptcp-fix-corrupt-receiver-key-in-MPC-data-checksum/20211021-225325 base: https://github.com/multipath-tcp/mptcp_net-next.git export config: x86_64-randconfig-s022-20211025 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/2293fadbec3d2e7e3c7f7da01c14f3ffa63c0e17 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Davide-Caratti/mptcp-fix-corrupt-receiver-key-in-MPC-data-checksum/20211021-225325 git checkout 2293fadbec3d2e7e3c7f7da01c14f3ffa63c0e17 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) >> net/mptcp/options.c:1240:14: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __sum16 [usertype] csum @@ got restricted __wsum @@ net/mptcp/options.c:1240:14: sparse: expected restricted __sum16 [usertype] csum net/mptcp/options.c:1240:14: sparse: got restricted __wsum >> net/mptcp/options.c:1241:39: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __wsum [usertype] sum @@ got restricted __sum16 [usertype] csum @@ net/mptcp/options.c:1241:39: sparse: expected restricted __wsum [usertype] sum net/mptcp/options.c:1241:39: sparse: got restricted __sum16 [usertype] csum vim +1240 net/mptcp/options.c 1225 1226 static u16 __mptcp_make_csum(u64 data_seq, u32 subflow_seq, u16 data_len, __sum16 csum) 1227 { 1228 struct csum_pseudo_header header; 1229 1230 /* cfr RFC 8684 3.3.1.: 1231 * the data sequence number used in the pseudo-header is 1232 * always the 64-bit value, irrespective of what length is used in the 1233 * DSS option itself. 1234 */ 1235 header.data_seq = cpu_to_be64(data_seq); 1236 header.subflow_seq = htonl(subflow_seq); 1237 header.data_len = htons(data_len); 1238 header.csum = 0; 1239 > 1240 csum = csum_partial(&header, sizeof(header), ~csum_unfold(csum)); > 1241 return (__force u16)csum_fold(csum); 1242 } 1243 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 40989 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH mptcp-net] mptcp: fix corrupt receiver key in MPC + data + checksum Date: Tue, 26 Oct 2021 12:56:51 +0800 [thread overview] Message-ID: <202110261216.ULu64496-lkp@intel.com> (raw) In-Reply-To: <1207c7d44dd4d1a630afc8b7018cf4185fe4a489.1634827708.git.dcaratti@redhat.com> [-- Attachment #1: Type: text/plain, Size: 2985 bytes --] Hi Davide, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mptcp/export] [also build test WARNING on linus/master v5.15-rc7 next-20211025] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Davide-Caratti/mptcp-fix-corrupt-receiver-key-in-MPC-data-checksum/20211021-225325 base: https://github.com/multipath-tcp/mptcp_net-next.git export config: x86_64-randconfig-s022-20211025 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/2293fadbec3d2e7e3c7f7da01c14f3ffa63c0e17 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Davide-Caratti/mptcp-fix-corrupt-receiver-key-in-MPC-data-checksum/20211021-225325 git checkout 2293fadbec3d2e7e3c7f7da01c14f3ffa63c0e17 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) >> net/mptcp/options.c:1240:14: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __sum16 [usertype] csum @@ got restricted __wsum @@ net/mptcp/options.c:1240:14: sparse: expected restricted __sum16 [usertype] csum net/mptcp/options.c:1240:14: sparse: got restricted __wsum >> net/mptcp/options.c:1241:39: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __wsum [usertype] sum @@ got restricted __sum16 [usertype] csum @@ net/mptcp/options.c:1241:39: sparse: expected restricted __wsum [usertype] sum net/mptcp/options.c:1241:39: sparse: got restricted __sum16 [usertype] csum vim +1240 net/mptcp/options.c 1225 1226 static u16 __mptcp_make_csum(u64 data_seq, u32 subflow_seq, u16 data_len, __sum16 csum) 1227 { 1228 struct csum_pseudo_header header; 1229 1230 /* cfr RFC 8684 3.3.1.: 1231 * the data sequence number used in the pseudo-header is 1232 * always the 64-bit value, irrespective of what length is used in the 1233 * DSS option itself. 1234 */ 1235 header.data_seq = cpu_to_be64(data_seq); 1236 header.subflow_seq = htonl(subflow_seq); 1237 header.data_len = htons(data_len); 1238 header.csum = 0; 1239 > 1240 csum = csum_partial(&header, sizeof(header), ~csum_unfold(csum)); > 1241 return (__force u16)csum_fold(csum); 1242 } 1243 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 40989 bytes --]
next prev parent reply other threads:[~2021-10-26 4:57 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-21 14:51 [PATCH mptcp-net] mptcp: fix corrupt receiver key in MPC + data + checksum Davide Caratti 2021-10-21 15:00 ` mptcp: fix corrupt receiver key in MPC + data + checksum: Build Failure MPTCP CI 2021-10-21 15:37 ` [PATCH mptcp-net] mptcp: fix corrupt receiver key in MPC + data + checksum Matthieu Baerts 2021-10-22 23:22 ` Mat Martineau 2021-10-26 4:56 ` kernel test robot [this message] 2021-10-26 4:56 ` kernel test robot 2021-10-26 5:08 ` mptcp: fix corrupt receiver key in MPC + data + checksum: Build Failure MPTCP CI 2021-10-26 9:11 ` MPTCP CI
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202110261216.ULu64496-lkp@intel.com \ --to=lkp@intel.com \ --cc=dcaratti@redhat.com \ --cc=kbuild-all@lists.01.org \ --cc=mathew.j.martineau@linux.intel.com \ --cc=matthieu.baerts@tessares.net \ --cc=mptcp@lists.linux.dev \ --cc=pabeni@redhat.com \ --cc=psonparo@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.