From: kernel test robot <lkp@intel.com>
To: Keerthy <j-keerthy@ti.com>,
robh+dt@kernel.org, daniel.lezcano@linaro.org,
rui.zhang@intel.com, amitk@kernel.org, kristo@kernel.org
Cc: kbuild-all@lists.01.org, j-keerthy@ti.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support
Date: Tue, 26 Oct 2021 18:51:40 +0800 [thread overview]
Message-ID: <202110261816.J2kSX34A-lkp@intel.com> (raw)
In-Reply-To: <20211025180603.22290-5-j-keerthy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2819 bytes --]
Hi Keerthy,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on rafael-pm/thermal v5.15-rc7 next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Keerthy/thermal-k3_j72xx_bandgap-Add-the-bandgap-driver-support/20211026-021100
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: h8300-buildonly-randconfig-r002-20211026 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a60ffd2edff44c1ee199aa7ad3b847815aad93e7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Keerthy/thermal-k3_j72xx_bandgap-Add-the-bandgap-driver-support/20211026-021100
git checkout a60ffd2edff44c1ee199aa7ad3b847815aad93e7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/thermal/k3_j72xx_bandgap.c:97:6: warning: no previous prototype for 'init_table' [-Wmissing-prototypes]
97 | void init_table(bool wa, int *mytable)
| ^~~~~~~~~~
drivers/thermal/k3_j72xx_bandgap.c: In function 'prep_lookup_table':
drivers/thermal/k3_j72xx_bandgap.c:148:13: warning: variable 'start_temp' set but not used [-Wunused-but-set-variable]
148 | int start_temp, inc, i;
| ^~~~~~~~~~
drivers/thermal/k3_j72xx_bandgap.c: At top level:
drivers/thermal/k3_j72xx_bandgap.c:227:5: warning: no previous prototype for 'two_cmp' [-Wmissing-prototypes]
227 | int two_cmp(int tmp, int mask)
| ^~~~~~~
vim +/init_table +97 drivers/thermal/k3_j72xx_bandgap.c
96
> 97 void init_table(bool wa, int *mytable)
98 {
99 s64 *factors;
100 const int size = 1024;
101 int factors_size;
102 int i;
103
104 if (wa) {
105 factors_size = 3;
106 factors = pvt_wa_factors;
107 } else {
108 factors_size = 5;
109 factors = golden_factors;
110 }
111
112 for (i = 0; i < size; i++)
113 mytable[i] = compute_value(i, factors, factors_size, 13);
114 }
115
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36286 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 4/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support
Date: Tue, 26 Oct 2021 18:51:40 +0800 [thread overview]
Message-ID: <202110261816.J2kSX34A-lkp@intel.com> (raw)
In-Reply-To: <20211025180603.22290-5-j-keerthy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2887 bytes --]
Hi Keerthy,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on rafael-pm/thermal v5.15-rc7 next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Keerthy/thermal-k3_j72xx_bandgap-Add-the-bandgap-driver-support/20211026-021100
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: h8300-buildonly-randconfig-r002-20211026 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a60ffd2edff44c1ee199aa7ad3b847815aad93e7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Keerthy/thermal-k3_j72xx_bandgap-Add-the-bandgap-driver-support/20211026-021100
git checkout a60ffd2edff44c1ee199aa7ad3b847815aad93e7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/thermal/k3_j72xx_bandgap.c:97:6: warning: no previous prototype for 'init_table' [-Wmissing-prototypes]
97 | void init_table(bool wa, int *mytable)
| ^~~~~~~~~~
drivers/thermal/k3_j72xx_bandgap.c: In function 'prep_lookup_table':
drivers/thermal/k3_j72xx_bandgap.c:148:13: warning: variable 'start_temp' set but not used [-Wunused-but-set-variable]
148 | int start_temp, inc, i;
| ^~~~~~~~~~
drivers/thermal/k3_j72xx_bandgap.c: At top level:
drivers/thermal/k3_j72xx_bandgap.c:227:5: warning: no previous prototype for 'two_cmp' [-Wmissing-prototypes]
227 | int two_cmp(int tmp, int mask)
| ^~~~~~~
vim +/init_table +97 drivers/thermal/k3_j72xx_bandgap.c
96
> 97 void init_table(bool wa, int *mytable)
98 {
99 s64 *factors;
100 const int size = 1024;
101 int factors_size;
102 int i;
103
104 if (wa) {
105 factors_size = 3;
106 factors = pvt_wa_factors;
107 } else {
108 factors_size = 5;
109 factors = golden_factors;
110 }
111
112 for (i = 0; i < size; i++)
113 mytable[i] = compute_value(i, factors, factors_size, 13);
114 }
115
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36286 bytes --]
next prev parent reply other threads:[~2021-10-26 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 18:05 [PATCH v3 0/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Keerthy
2021-10-25 18:06 ` [PATCH v3 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation Keerthy
2021-11-01 20:47 ` Rob Herring
2021-10-25 18:06 ` [PATCH v3 2/4] arm64: dts: ti: j721e: Add VTM node Keerthy
2021-10-25 18:06 ` [PATCH v3 3/4] arm64: dts: ti: j7200: " Keerthy
2021-10-25 18:06 ` [PATCH v3 4/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Keerthy
2021-10-26 10:51 ` kernel test robot [this message]
2021-10-26 10:51 ` kernel test robot
2021-10-26 11:08 ` J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110261816.J2kSX34A-lkp@intel.com \
--to=lkp@intel.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=kbuild-all@lists.01.org \
--cc=kristo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.