* [PATCH BlueZ 1/2] Makefile: Fix code style
@ 2021-10-26 18:18 Luiz Augusto von Dentz
2021-10-26 18:18 ` [PATCH BlueZ 2/2] obexd: Add missing phonebook backends Luiz Augusto von Dentz
2021-10-26 18:41 ` [BlueZ,1/2] Makefile: Fix code style bluez.test.bot
0 siblings, 2 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2021-10-26 18:18 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fix lines going over 80 columns.
---
Makefile.am | 3 ++-
Makefile.obexd | 3 ++-
configure.ac | 20 ++++++++++++--------
3 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index a9439588a..7985db090 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -24,7 +24,8 @@ pkgincludedir = $(includedir)/bluetooth
pkginclude_HEADERS =
-AM_CFLAGS = $(WARNING_CFLAGS) $(MISC_CFLAGS) $(UDEV_CFLAGS) $(LIBEBOOK_CFLAGS) $(LIBEDATASERVER_CFLAGS) $(ell_cflags)
+AM_CFLAGS = $(WARNING_CFLAGS) $(MISC_CFLAGS) $(UDEV_CFLAGS) $(LIBEBOOK_CFLAGS) \
+ $(LIBEDATASERVER_CFLAGS) $(ell_cflags)
AM_LDFLAGS = $(MISC_LDFLAGS)
if DATAFILES
diff --git a/Makefile.obexd b/Makefile.obexd
index 2c0d19518..b9fbc9b3b 100644
--- a/Makefile.obexd
+++ b/Makefile.obexd
@@ -80,7 +80,8 @@ obexd_src_obexd_SOURCES = $(btio_sources) $(gobex_sources) \
obexd/src/map_ap.h
obexd_src_obexd_LDADD = lib/libbluetooth-internal.la \
gdbus/libgdbus-internal.la \
- $(ICAL_LIBS) $(DBUS_LIBS) $(LIBEBOOK_LIBS) $(LIBEDATASERVER_LIBS) $(GLIB_LIBS) -ldl
+ $(ICAL_LIBS) $(DBUS_LIBS) $(LIBEBOOK_LIBS) \
+ $(LIBEDATASERVER_LIBS) $(GLIB_LIBS) -ldl
obexd_src_obexd_LDFLAGS = $(AM_LDFLAGS) -Wl,--export-dynamic
diff --git a/configure.ac b/configure.ac
index 0c0418452..0329095ee 100644
--- a/configure.ac
+++ b/configure.ac
@@ -242,7 +242,7 @@ AM_CONDITIONAL(MIDI, test "${enable_midi}" = "yes")
if (test "${enable_midi}" = "yes"); then
PKG_CHECK_MODULES(ALSA, alsa, dummy=yes,
- AC_MSG_ERROR(ALSA lib is required for MIDI support))
+ AC_MSG_ERROR(ALSA lib is required for MIDI support))
AC_SUBST(ALSA_CFLAGS)
AC_SUBST(ALSA_LIBS)
fi
@@ -333,7 +333,8 @@ if (test "${enable_manpages}" != "no"); then
fi
fi
AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" != "no")
-AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" != "no" && test "${RST2MAN}" != "no")
+AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" != "no" &&
+ test "${RST2MAN}" != "no")
AC_ARG_ENABLE(testing, AC_HELP_STRING([--enable-testing],
[enable testing tools]),
@@ -405,14 +406,14 @@ AM_CONDITIONAL(ANDROID, test "${enable_android}" = "yes")
if (test "${enable_android}" = "yes"); then
PKG_CHECK_MODULES(SBC, sbc >= 1.2, dummy=yes,
- AC_MSG_ERROR(SBC library >= 1.2 is required))
+ AC_MSG_ERROR(SBC library >= 1.2 is required))
AC_SUBST(SBC_CFLAGS)
AC_SUBST(SBC_LIBS)
fi
if (test "${enable_android}" = "yes"); then
PKG_CHECK_MODULES(SPEEXDSP, speexdsp >= 1.2, dummy=yes,
- AC_MSG_ERROR(SPEEXDSP library >= 1.2 is required))
+ AC_MSG_ERROR(SPEEXDSP library >= 1.2 is required))
AC_SUBST(SPEEXDSP_CFLAGS)
AC_SUBST(SPEEXDSP_LIBS)
fi
@@ -421,17 +422,20 @@ AC_DEFINE_UNQUOTED(ANDROID_STORAGEDIR, "${storagedir}/android",
[Directory for the Android daemon storage files])
AC_ARG_WITH([phonebook], AC_HELP_STRING([--with-phonebook=PLUGIN],
- [obexd phonebook plugin (default=dummy)]),
- [plugin_phonebook=${withval}])
+ [obexd phonebook plugin (default=dummy)]),
+ [plugin_phonebook=${withval}])
if (test -z "${plugin_phonebook}"); then
plugin_phonebook=dummy
fi
if (test "${plugin_phonebook}" = "ebook"); then
- PKG_CHECK_MODULES(LIBEBOOK, [libebook-1.2 >= 3.3], dummy=yes, AC_MSG_ERROR(libebook >= 3.3 is required))
+ PKG_CHECK_MODULES(LIBEBOOK, [libebook-1.2 >= 3.3], dummy=yes,
+ AC_MSG_ERROR(libebook >= 3.3 is required))
AC_SUBST(LIBEBOOK_CFLAGS)
AC_SUBST(LIBEBOOK_LIBS)
- PKG_CHECK_MODULES(LIBEDATESERVER, [libedataserver-1.2 >= 3.3], dummy=yes, AC_MSG_ERROR(libedataserver >= 3.3 is required))
+ PKG_CHECK_MODULES(LIBEDATESERVER, [libedataserver-1.2 >= 3.3],
+ dummy=yes,
+ AC_MSG_ERROR(libedataserver >= 3.3 is required))
AC_SUBST(LIBEDATESERVER_CFLAGS)
AC_SUBST(LIBEDATESERVER_LIBS)
fi
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH BlueZ 2/2] obexd: Add missing phonebook backends
2021-10-26 18:18 [PATCH BlueZ 1/2] Makefile: Fix code style Luiz Augusto von Dentz
@ 2021-10-26 18:18 ` Luiz Augusto von Dentz
2021-10-26 18:41 ` [BlueZ,1/2] Makefile: Fix code style bluez.test.bot
1 sibling, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2021-10-26 18:18 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This adds missing phonebook backends to EXTRA_DIST so they can be build
from tarballs.
Fixes: https://github.com/bluez/bluez/issues/222
---
Makefile.obexd | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.obexd b/Makefile.obexd
index b9fbc9b3b..37a133455 100644
--- a/Makefile.obexd
+++ b/Makefile.obexd
@@ -42,6 +42,8 @@ obexd_builtin_sources += obexd/plugins/pbap.c \
obexd/plugins/vcard.h obexd/plugins/vcard.c \
obexd/plugins/phonebook.h \
obexd/plugins/phonebook-@PLUGIN_PHONEBOOK@.c
+EXTRA_DIST += obexd/plugins/phonebook-dummy.c obexd/plugins/phonebook-ebook.c \
+ obexd/plugins/phonebook-tracker.c
obexd_builtin_modules += mas
obexd_builtin_sources += obexd/plugins/mas.c obexd/src/map_ap.h \
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [BlueZ,1/2] Makefile: Fix code style
2021-10-26 18:18 [PATCH BlueZ 1/2] Makefile: Fix code style Luiz Augusto von Dentz
2021-10-26 18:18 ` [PATCH BlueZ 2/2] obexd: Add missing phonebook backends Luiz Augusto von Dentz
@ 2021-10-26 18:41 ` bluez.test.bot
2021-10-26 20:27 ` Luiz Augusto von Dentz
1 sibling, 1 reply; 4+ messages in thread
From: bluez.test.bot @ 2021-10-26 18:41 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=570633
---Test result---
Test Summary:
CheckPatch PASS 2.98 seconds
GitLint PASS 1.96 seconds
Prep - Setup ELL PASS 52.53 seconds
Build - Prep PASS 0.53 seconds
Build - Configure PASS 9.97 seconds
Build - Make PASS 216.18 seconds
Make Check PASS 9.08 seconds
Make Distcheck PASS 243.89 seconds
Build w/ext ELL - Configure PASS 9.39 seconds
Build w/ext ELL - Make PASS 184.54 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BlueZ,1/2] Makefile: Fix code style
2021-10-26 18:41 ` [BlueZ,1/2] Makefile: Fix code style bluez.test.bot
@ 2021-10-26 20:27 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2021-10-26 20:27 UTC (permalink / raw)
To: linux-bluetooth
Hi,
On Tue, Oct 26, 2021 at 11:41 AM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=570633
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 2.98 seconds
> GitLint PASS 1.96 seconds
> Prep - Setup ELL PASS 52.53 seconds
> Build - Prep PASS 0.53 seconds
> Build - Configure PASS 9.97 seconds
> Build - Make PASS 216.18 seconds
> Make Check PASS 9.08 seconds
> Make Distcheck PASS 243.89 seconds
> Build w/ext ELL - Configure PASS 9.39 seconds
> Build w/ext ELL - Make PASS 184.54 seconds
>
>
>
> ---
> Regards,
> Linux Bluetooth
Pushed.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-26 20:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 18:18 [PATCH BlueZ 1/2] Makefile: Fix code style Luiz Augusto von Dentz
2021-10-26 18:18 ` [PATCH BlueZ 2/2] obexd: Add missing phonebook backends Luiz Augusto von Dentz
2021-10-26 18:41 ` [BlueZ,1/2] Makefile: Fix code style bluez.test.bot
2021-10-26 20:27 ` Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.