Re: [PATCH] pinctrl: tegra: Use correct offset for pin group

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3645 bytes --]

Hi Prathamesh,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tegra/for-next]
[also build test ERROR on v5.15-rc7 next-20211026]
[cannot apply to linusw-pinctrl/devel]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Prathamesh-Shete/pinctrl-tegra-Use-correct-offset-for-pin-group/20211025-191234
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2fc9d61e0fb127a2e51e51cf0c2c6f2a9528cb37
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Prathamesh-Shete/pinctrl-tegra-Use-correct-offset-for-pin-group/20211025-191234
        git checkout 2fc9d61e0fb127a2e51e51cf0c2c6f2a9528cb37
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_get_group':
>> drivers/pinctrl/tegra/pinctrl-tegra.c:293:40: error: return discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
     293 |                                 return &pmx->soc->groups[group];
         |                                        ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pinctrl/tegra/pinctrl-tegra.c:282:32: error: unused variable 'g' [-Werror=unused-variable]
     282 |         struct tegra_pingroup *g;
         |                                ^
   drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_gpio_disable_free':
   drivers/pinctrl/tegra/pinctrl-tegra.c:341:24: error: 'return' with a value, in function returning void [-Werror=return-type]
     341 |                 return -EINVAL;
         |                        ^
   drivers/pinctrl/tegra/pinctrl-tegra.c:327:13: note: declared here
     327 | static void tegra_pinctrl_gpio_disable_free(struct pinctrl_dev *pctldev,
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/const +293 drivers/pinctrl/tegra/pinctrl-tegra.c

   277	
   278	static struct tegra_pingroup *tegra_pinctrl_get_group(struct pinctrl_dev *pctldev,
   279						unsigned int offset)
   280	{
   281		struct tegra_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
 > 282		struct tegra_pingroup *g;
   283		unsigned int group, num_pins, j;
   284		const unsigned int *pins;
   285		int ret;
   286	
   287		for (group = 0; group < pmx->soc->ngroups; ++group) {
   288			ret = tegra_pinctrl_get_group_pins(pctldev, group, &pins, &num_pins);
   289			if (ret < 0)
   290				continue;
   291			for (j = 0; j < num_pins; j++) {
   292				if (offset == pins[j])
 > 293					return &pmx->soc->groups[group];
   294			}
   295		}
   296	
   297		dev_err(pctldev->dev, "Pingroup not found for pin %u\n", offset);
   298		return NULL;
   299	}
   300	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 79216 bytes --]