* [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c
@ 2021-10-27 8:15 cgel.zte
2021-10-27 8:19 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2021-10-27 8:15 UTC (permalink / raw)
To: santoshkumar.yadav
Cc: peter.korsgaard, hdegoede, markgross, platform-driver-x86,
linux-kernel, ran jianping, Zeal Robot
From: ran jianping <ran.jianping@zte.com.cn>
'linux/io.h' included in 'drivers/platform/x86/barco-p50-gpio.c'
is duplicated.It is also included on the 17 line.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
drivers/platform/x86/barco-p50-gpio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
index f5c72e33f9ae..bb8ed8e95225 100644
--- a/drivers/platform/x86/barco-p50-gpio.c
+++ b/drivers/platform/x86/barco-p50-gpio.c
@@ -14,7 +14,6 @@
#include <linux/delay.h>
#include <linux/dmi.h>
#include <linux/err.h>
-#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/module.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c
2021-10-27 8:15 [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c cgel.zte
@ 2021-10-27 8:19 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2021-10-27 8:19 UTC (permalink / raw)
To: cgel.zte
Cc: santoshkumar.yadav, peter.korsgaard, hdegoede, markgross,
platform-driver-x86, linux-kernel, ran jianping, Zeal Robot
>>>>> "cgel" == cgel zte <cgel.zte@gmail.com> writes:
> From: ran jianping <ran.jianping@zte.com.cn>
> 'linux/io.h' included in 'drivers/platform/x86/barco-p50-gpio.c'
> is duplicated.It is also included on the 17 line.
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
> ---
> drivers/platform/x86/barco-p50-gpio.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
> index f5c72e33f9ae..bb8ed8e95225 100644
> --- a/drivers/platform/x86/barco-p50-gpio.c
> +++ b/drivers/platform/x86/barco-p50-gpio.c
> @@ -14,7 +14,6 @@
> #include <linux/delay.h>
> #include <linux/dmi.h>
> #include <linux/err.h>
> -#include <linux/io.h>
It probably makes more sense to drop the include from line 17 to keep
alphabetical ordering, but otherwise it looks good to.
With that fixed:
Acked-by: Peter Korsgaard <peter@korsgaard.com>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-27 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 8:15 [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c cgel.zte
2021-10-27 8:19 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.