From: Sean Young <sean@mess.org> To: "Maíra Canal" <maira.canal@usp.br> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "kernel test robot" <lkp@intel.com>, mchehab@kernel.org, thierry.reding@gmail.com, "Lee Jones" <lee.jones@linaro.org>, llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH v3] media: rc: pwm-ir-tx: Switch to atomic PWM API Date: Wed, 27 Oct 2021 13:48:59 +0100 [thread overview] Message-ID: <20211027124859.GA6320@gofer.mess.org> (raw) In-Reply-To: <CAH7FV3=7Y7Z0y+Mq5Ak12KDMiZpHQHXGixF_pcrnQkuqCO9kvQ@mail.gmail.com> Hi Maíra, On Wed, Oct 27, 2021 at 09:43:47AM -0300, Maíra Canal wrote: > [resend it in Plain Text] > Thank you for the feedback! I appreciate that! I'm new at the kernel > and I got a little confused about how to send the new patch. Should I > send a v4 of this patch or just send a new patch fixing this issue? > I'm sorry about the question and thank you for your attention. Please send out a v4 with the problem fixed. Also top-posting is deprecated on linux mailing lists. Thanks, Sean > > Em qua., 27 de out. de 2021 às 04:32, Sean Young <sean@mess.org> escreveu: > >> > >> On Wed, Oct 27, 2021 at 08:15:52AM +0200, Uwe Kleine-König wrote: > >> > On Wed, Oct 27, 2021 at 02:07:19PM +0800, kernel test robot wrote: > >> > > If you fix the issue, kindly add following tag as appropriate > >> > > Reported-by: kernel test robot <lkp@intel.com> > >> > > > >> > > All errors (new ones prefixed by >>, old ones prefixed by <<): > >> > > > >> > > >> ERROR: modpost: "__udivdi3" [drivers/media/rc/pwm-ir-tx.ko] undefined! > >> > > >> > This comes from the line: > >> > > >> > state.duty_cycle = DIV_ROUND_CLOSEST(pwm_ir->duty_cycle * state.period, 100); > >> > > >> > where DIV_ROUND_CLOSEST expands to a normal division but state.period is > >> > a u64. So this should use DIV64_U64_ROUND_CLOSEST I guess. > >> > >> DIV64_U64_ROUND_CLOSEST is for dividing a u64 with a u64. We're dividing > >> by 100 here so this is not necessary. > >> > >> It should use DIV_ROUND_CLOSEST_ULL, however it might be nicer to use: > >> > >> pwm_set_relative_duty_cycle(&state, pwm_ir->duty_cycle, 100); > >> > >> Thanks > >> > >> Sean
WARNING: multiple messages have this Message-ID (diff)
From: Sean Young <sean@mess.org> To: kbuild-all@lists.01.org Subject: Re: [PATCH v3] media: rc: pwm-ir-tx: Switch to atomic PWM API Date: Wed, 27 Oct 2021 13:48:59 +0100 [thread overview] Message-ID: <20211027124859.GA6320@gofer.mess.org> (raw) In-Reply-To: <CAH7FV3=7Y7Z0y+Mq5Ak12KDMiZpHQHXGixF_pcrnQkuqCO9kvQ@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1682 bytes --] Hi Maíra, On Wed, Oct 27, 2021 at 09:43:47AM -0300, Maíra Canal wrote: > [resend it in Plain Text] > Thank you for the feedback! I appreciate that! I'm new at the kernel > and I got a little confused about how to send the new patch. Should I > send a v4 of this patch or just send a new patch fixing this issue? > I'm sorry about the question and thank you for your attention. Please send out a v4 with the problem fixed. Also top-posting is deprecated on linux mailing lists. Thanks, Sean > > Em qua., 27 de out. de 2021 às 04:32, Sean Young <sean@mess.org> escreveu: > >> > >> On Wed, Oct 27, 2021 at 08:15:52AM +0200, Uwe Kleine-König wrote: > >> > On Wed, Oct 27, 2021 at 02:07:19PM +0800, kernel test robot wrote: > >> > > If you fix the issue, kindly add following tag as appropriate > >> > > Reported-by: kernel test robot <lkp@intel.com> > >> > > > >> > > All errors (new ones prefixed by >>, old ones prefixed by <<): > >> > > > >> > > >> ERROR: modpost: "__udivdi3" [drivers/media/rc/pwm-ir-tx.ko] undefined! > >> > > >> > This comes from the line: > >> > > >> > state.duty_cycle = DIV_ROUND_CLOSEST(pwm_ir->duty_cycle * state.period, 100); > >> > > >> > where DIV_ROUND_CLOSEST expands to a normal division but state.period is > >> > a u64. So this should use DIV64_U64_ROUND_CLOSEST I guess. > >> > >> DIV64_U64_ROUND_CLOSEST is for dividing a u64 with a u64. We're dividing > >> by 100 here so this is not necessary. > >> > >> It should use DIV_ROUND_CLOSEST_ULL, however it might be nicer to use: > >> > >> pwm_set_relative_duty_cycle(&state, pwm_ir->duty_cycle, 100); > >> > >> Thanks > >> > >> Sean
next prev parent reply other threads:[~2021-10-27 12:49 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-24 10:33 [PATCH v3] media: rc: pwm-ir-tx: Switch to atomic PWM API Maíra Canal 2021-10-25 6:08 ` Uwe Kleine-König 2021-10-27 6:07 ` kernel test robot 2021-10-27 6:07 ` kernel test robot 2021-10-27 6:15 ` Uwe Kleine-König 2021-10-27 6:15 ` Uwe Kleine-König 2021-10-27 7:32 ` Sean Young 2021-10-27 7:32 ` Sean Young 2021-10-27 12:38 ` Maíra Canal 2021-10-27 12:43 ` Maíra Canal 2021-10-27 12:43 ` Maíra Canal 2021-10-27 12:48 ` Sean Young [this message] 2021-10-27 12:48 ` Sean Young
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211027124859.GA6320@gofer.mess.org \ --to=sean@mess.org \ --cc=kbuild-all@lists.01.org \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=lkp@intel.com \ --cc=llvm@lists.linux.dev \ --cc=maira.canal@usp.br \ --cc=mchehab@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.