* [PATCH] raid5-ppl: use swap() to make code cleaner
@ 2021-10-28 1:00 Yang Guang
2021-10-28 6:33 ` Paul Menzel
0 siblings, 1 reply; 2+ messages in thread
From: Yang Guang @ 2021-10-28 1:00 UTC (permalink / raw)
To: Song Liu; +Cc: Yang Guang, Zeal Robot, linux-raid, linux-kernel
Using swap() make it more readable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
---
drivers/md/raid5-ppl.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
index 3ddc2aa0b530..4ab417915d7f 100644
--- a/drivers/md/raid5-ppl.c
+++ b/drivers/md/raid5-ppl.c
@@ -1081,7 +1081,7 @@ static int ppl_load_distributed(struct ppl_log *log)
struct ppl_conf *ppl_conf = log->ppl_conf;
struct md_rdev *rdev = log->rdev;
struct mddev *mddev = rdev->mddev;
- struct page *page, *page2, *tmp;
+ struct page *page, *page2;
struct ppl_header *pplhdr = NULL, *prev_pplhdr = NULL;
u32 crc, crc_stored;
u32 signature;
@@ -1156,9 +1156,7 @@ static int ppl_load_distributed(struct ppl_log *log)
prev_pplhdr_offset = pplhdr_offset;
prev_pplhdr = pplhdr;
- tmp = page;
- page = page2;
- page2 = tmp;
+ swap(page, page2);
/* calculate next potential ppl offset */
for (i = 0; i < le32_to_cpu(pplhdr->entries_count); i++)
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] raid5-ppl: use swap() to make code cleaner
2021-10-28 1:00 [PATCH] raid5-ppl: use swap() to make code cleaner Yang Guang
@ 2021-10-28 6:33 ` Paul Menzel
0 siblings, 0 replies; 2+ messages in thread
From: Paul Menzel @ 2021-10-28 6:33 UTC (permalink / raw)
To: Yang Guang; +Cc: Yang Guang, Zeal Robot, linux-raid, linux-kernel, Song Liu
Dear Yang,
Thank you for the patch.
On 28.10.21 03:00, Yang Guang wrote:
> Using swap() make it more readable.
make*s*
Maybe:
Use the macro `swap()` defined in `include/linux/minmax.h` to avoid
opencoding it.
By the way, there is also the Coccinelle script
`scripts/coccinelle/misc/swap.cocci`.
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
> ---
> drivers/md/raid5-ppl.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
> index 3ddc2aa0b530..4ab417915d7f 100644
> --- a/drivers/md/raid5-ppl.c
> +++ b/drivers/md/raid5-ppl.c
> @@ -1081,7 +1081,7 @@ static int ppl_load_distributed(struct ppl_log *log)
> struct ppl_conf *ppl_conf = log->ppl_conf;
> struct md_rdev *rdev = log->rdev;
> struct mddev *mddev = rdev->mddev;
> - struct page *page, *page2, *tmp;
> + struct page *page, *page2;
> struct ppl_header *pplhdr = NULL, *prev_pplhdr = NULL;
> u32 crc, crc_stored;
> u32 signature;
> @@ -1156,9 +1156,7 @@ static int ppl_load_distributed(struct ppl_log *log)
> prev_pplhdr_offset = pplhdr_offset;
> prev_pplhdr = pplhdr;
>
> - tmp = page;
> - page = page2;
> - page2 = tmp;
> + swap(page, page2);
>
> /* calculate next potential ppl offset */
> for (i = 0; i < le32_to_cpu(pplhdr->entries_count); i++)
>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-28 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-28 1:00 [PATCH] raid5-ppl: use swap() to make code cleaner Yang Guang
2021-10-28 6:33 ` Paul Menzel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.