* [PATCH] Fix MMC numbering issue for Raspberry Pi 3
@ 2021-10-27 22:26 karels
2021-10-28 7:44 ` Emmanuel Vadot
0 siblings, 1 reply; 3+ messages in thread
From: karels @ 2021-10-27 22:26 UTC (permalink / raw)
To: u-boot; +Cc: Rick Chen, Aswath Govindraju, Tero Kristo, Mike Karels
From: Mike Karels <karels@FreeBSD.org>
Using mmc.dtbo from rpi-firmware to switch the controller for the SD
card slot from sdhci to sdhost causes the numbering to change; the
SD card is then not recognized at boot. Add to the range checked.
---
include/configs/rpi.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/configs/rpi.h b/include/configs/rpi.h
index 55768a46da..4c5c1ac31f 100644
--- a/include/configs/rpi.h
+++ b/include/configs/rpi.h
@@ -137,7 +137,8 @@
#if CONFIG_IS_ENABLED(CMD_MMC)
#define BOOT_TARGET_MMC(func) \
func(MMC, mmc, 0) \
- func(MMC, mmc, 1)
+ func(MMC, mmc, 1) \
+ func(MMC, mmc, 2)
#else
#define BOOT_TARGET_MMC(func)
#endif
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix MMC numbering issue for Raspberry Pi 3
2021-10-27 22:26 [PATCH] Fix MMC numbering issue for Raspberry Pi 3 karels
@ 2021-10-28 7:44 ` Emmanuel Vadot
2021-11-30 15:09 ` Matthias Brugger
0 siblings, 1 reply; 3+ messages in thread
From: Emmanuel Vadot @ 2021-10-28 7:44 UTC (permalink / raw)
To: karels; +Cc: u-boot, Rick Chen, Aswath Govindraju, Tero Kristo
On Wed, 27 Oct 2021 22:26:15 +0000
karels@FreeBSD.org wrote:
> From: Mike Karels <karels@FreeBSD.org>
>
> Using mmc.dtbo from rpi-firmware to switch the controller for the SD
> card slot from sdhci to sdhost causes the numbering to change; the
> SD card is then not recognized at boot. Add to the range checked.
> ---
> include/configs/rpi.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/configs/rpi.h b/include/configs/rpi.h
> index 55768a46da..4c5c1ac31f 100644
> --- a/include/configs/rpi.h
> +++ b/include/configs/rpi.h
> @@ -137,7 +137,8 @@
> #if CONFIG_IS_ENABLED(CMD_MMC)
> #define BOOT_TARGET_MMC(func) \
> func(MMC, mmc, 0) \
> - func(MMC, mmc, 1)
> + func(MMC, mmc, 1) \
> + func(MMC, mmc, 2)
> #else
> #define BOOT_TARGET_MMC(func)
> #endif
> --
> 2.32.0
>
Reviewed-by: Emmanuel Vadot <manu@FreeBSD.org>
--
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix MMC numbering issue for Raspberry Pi 3
2021-10-28 7:44 ` Emmanuel Vadot
@ 2021-11-30 15:09 ` Matthias Brugger
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2021-11-30 15:09 UTC (permalink / raw)
To: Emmanuel Vadot; +Cc: karels, u-boot, Rick Chen, Aswath Govindraju, Tero Kristo
On Thu, Oct 28, 2021 at 09:44:09AM +0200, Emmanuel Vadot wrote:
> On Wed, 27 Oct 2021 22:26:15 +0000
> karels@FreeBSD.org wrote:
>
> > From: Mike Karels <karels@FreeBSD.org>
> >
> > Using mmc.dtbo from rpi-firmware to switch the controller for the SD
> > card slot from sdhci to sdhost causes the numbering to change; the
> > SD card is then not recognized at boot. Add to the range checked.
> > ---
> > include/configs/rpi.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/configs/rpi.h b/include/configs/rpi.h
> > index 55768a46da..4c5c1ac31f 100644
> > --- a/include/configs/rpi.h
> > +++ b/include/configs/rpi.h
> > @@ -137,7 +137,8 @@
> > #if CONFIG_IS_ENABLED(CMD_MMC)
> > #define BOOT_TARGET_MMC(func) \
> > func(MMC, mmc, 0) \
> > - func(MMC, mmc, 1)
> > + func(MMC, mmc, 1) \
> > + func(MMC, mmc, 2)
> > #else
> > #define BOOT_TARGET_MMC(func)
> > #endif
> > --
> > 2.32.0
> >
>
> Reviewed-by: Emmanuel Vadot <manu@FreeBSD.org>
Applied to rpi-next
Thanks!
>
> --
> Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-30 15:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 22:26 [PATCH] Fix MMC numbering issue for Raspberry Pi 3 karels
2021-10-28 7:44 ` Emmanuel Vadot
2021-11-30 15:09 ` Matthias Brugger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.