All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/hyperv: Remove duplicate include
@ 2021-10-27  8:57 Jiapeng Chong
  2021-10-28 11:38 ` Wei Liu
  0 siblings, 1 reply; 5+ messages in thread
From: Jiapeng Chong @ 2021-10-27  8:57 UTC (permalink / raw)
  To: kys
  Cc: haiyangz, sthemmin, wei.liu, decui, tglx, mingo, bp, dave.hansen,
	x86, hpa, linux-hyperv, linux-kernel, Jiapeng Chong

Clean up the following includecheck warning:

./arch/x86/hyperv/ivm.c: linux/bitfield.h is included more than once.
./arch/x86/hyperv/ivm.c: linux/types.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 arch/x86/hyperv/ivm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
index 4d012fd..69c7a57 100644
--- a/arch/x86/hyperv/ivm.c
+++ b/arch/x86/hyperv/ivm.c
@@ -6,11 +6,9 @@
  *  Tianyu Lan <Tianyu.Lan@microsoft.com>
  */
 
-#include <linux/types.h>
 #include <linux/bitfield.h>
 #include <linux/hyperv.h>
 #include <linux/types.h>
-#include <linux/bitfield.h>
 #include <linux/slab.h>
 #include <asm/svm.h>
 #include <asm/sev.h>
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86/hyperv: Remove duplicate include
  2021-10-27  8:57 [PATCH] x86/hyperv: Remove duplicate include Jiapeng Chong
@ 2021-10-28 11:38 ` Wei Liu
  0 siblings, 0 replies; 5+ messages in thread
From: Wei Liu @ 2021-10-28 11:38 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: kys, haiyangz, sthemmin, wei.liu, decui, tglx, mingo, bp,
	dave.hansen, x86, hpa, linux-hyperv, linux-kernel

On Wed, Oct 27, 2021 at 04:57:02PM +0800, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
> 
> ./arch/x86/hyperv/ivm.c: linux/bitfield.h is included more than once.
> ./arch/x86/hyperv/ivm.c: linux/types.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Applied to hyperv-next. Thanks.

> ---
>  arch/x86/hyperv/ivm.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
> index 4d012fd..69c7a57 100644
> --- a/arch/x86/hyperv/ivm.c
> +++ b/arch/x86/hyperv/ivm.c
> @@ -6,11 +6,9 @@
>   *  Tianyu Lan <Tianyu.Lan@microsoft.com>
>   */
>  
> -#include <linux/types.h>
>  #include <linux/bitfield.h>
>  #include <linux/hyperv.h>
>  #include <linux/types.h>
> -#include <linux/bitfield.h>
>  #include <linux/slab.h>
>  #include <asm/svm.h>
>  #include <asm/sev.h>
> -- 
> 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86/hyperv: Remove duplicate include
  2023-08-24  8:03 Jiapeng Chong
  2023-08-24 17:59 ` Dexuan Cui
@ 2023-08-25  0:06 ` Wei Liu
  1 sibling, 0 replies; 5+ messages in thread
From: Wei Liu @ 2023-08-25  0:06 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: kys, haiyangz, wei.liu, decui, tglx, mingo, bp, dave.hansen, x86,
	hpa, linux-hyperv, linux-kernel, Abaci Robot

On Thu, Aug 24, 2023 at 04:03:52PM +0800, Jiapeng Chong wrote:
> ./arch/x86/hyperv/ivm.c: asm/sev.h is included more than once.
> ./arch/x86/hyperv/ivm.c: asm/coco.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6212
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Applied to hyperv-next, thanks!

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] x86/hyperv: Remove duplicate include
  2023-08-24  8:03 Jiapeng Chong
@ 2023-08-24 17:59 ` Dexuan Cui
  2023-08-25  0:06 ` Wei Liu
  1 sibling, 0 replies; 5+ messages in thread
From: Dexuan Cui @ 2023-08-24 17:59 UTC (permalink / raw)
  To: Jiapeng Chong, KY Srinivasan
  Cc: Haiyang Zhang, wei.liu, tglx, mingo, bp, dave.hansen, x86, hpa,
	linux-hyperv, linux-kernel, Abaci Robot

> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Sent: Thursday, August 24, 2023 1:04 AM
> [...]
> diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
> @@ -18,9 +18,7 @@
>  #include <asm/mshyperv.h>
>  #include <asm/hypervisor.h>
>  #include <asm/mtrr.h>
> -#include <asm/coco.h>
>  #include <asm/io_apic.h>
> -#include <asm/sev.h>
>  #include <asm/realmode.h>
>  #include <asm/e820/api.h>
>  #include <asm/desc.h>

I wish the header files were alphabetically ordered so that we
would have avoided the issue...

Reviewed-by: Dexuan Cui <decui@microsoft.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] x86/hyperv: Remove duplicate include
@ 2023-08-24  8:03 Jiapeng Chong
  2023-08-24 17:59 ` Dexuan Cui
  2023-08-25  0:06 ` Wei Liu
  0 siblings, 2 replies; 5+ messages in thread
From: Jiapeng Chong @ 2023-08-24  8:03 UTC (permalink / raw)
  To: kys
  Cc: haiyangz, wei.liu, decui, tglx, mingo, bp, dave.hansen, x86, hpa,
	linux-hyperv, linux-kernel, Jiapeng Chong, Abaci Robot

./arch/x86/hyperv/ivm.c: asm/sev.h is included more than once.
./arch/x86/hyperv/ivm.c: asm/coco.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6212
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 arch/x86/hyperv/ivm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
index 1448c6338971..55d43415a2fd 100644
--- a/arch/x86/hyperv/ivm.c
+++ b/arch/x86/hyperv/ivm.c
@@ -18,9 +18,7 @@
 #include <asm/mshyperv.h>
 #include <asm/hypervisor.h>
 #include <asm/mtrr.h>
-#include <asm/coco.h>
 #include <asm/io_apic.h>
-#include <asm/sev.h>
 #include <asm/realmode.h>
 #include <asm/e820/api.h>
 #include <asm/desc.h>
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-08-25  0:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27  8:57 [PATCH] x86/hyperv: Remove duplicate include Jiapeng Chong
2021-10-28 11:38 ` Wei Liu
2023-08-24  8:03 Jiapeng Chong
2023-08-24 17:59 ` Dexuan Cui
2023-08-25  0:06 ` Wei Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.