* [PATCH 2/5] clk: scmi: define LOG_CATEGORY
2021-10-28 13:01 [PATCH 1/5] reset: scmi: define LOG_CATEGORY Patrick Delaunay
@ 2021-10-28 13:01 ` Patrick Delaunay
2021-10-28 13:01 ` [PATCH 3/5] power: regulator: " Patrick Delaunay
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patrick Delaunay @ 2021-10-28 13:01 UTC (permalink / raw)
To: u-boot
Cc: Etienne Carriere, Etienne Carriere, Patrick Delaunay,
Lukasz Majewski, U-Boot STM32
Define LOG_CATEGORY to allow filtering with log command.
Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---
drivers/clk/clk_scmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/clk_scmi.c b/drivers/clk/clk_scmi.c
index 93a4819501..9a0a6f6643 100644
--- a/drivers/clk/clk_scmi.c
+++ b/drivers/clk/clk_scmi.c
@@ -2,6 +2,9 @@
/*
* Copyright (C) 2019-2020 Linaro Limited
*/
+
+#define LOG_CATEGORY UCLASS_CLK
+
#include <common.h>
#include <clk-uclass.h>
#include <dm.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/5] power: regulator: scmi: define LOG_CATEGORY
2021-10-28 13:01 [PATCH 1/5] reset: scmi: define LOG_CATEGORY Patrick Delaunay
2021-10-28 13:01 ` [PATCH 2/5] clk: " Patrick Delaunay
@ 2021-10-28 13:01 ` Patrick Delaunay
2021-10-28 13:01 ` [PATCH 4/5] firmware: scmi: add configs to select the supported agents Patrick Delaunay
2021-10-28 13:01 ` [PATCH 5/5] stm32mp15: deactivate CONFIG_SCMI_AGENT_MAILBOX Patrick Delaunay
3 siblings, 0 replies; 6+ messages in thread
From: Patrick Delaunay @ 2021-10-28 13:01 UTC (permalink / raw)
To: u-boot
Cc: Etienne Carriere, Etienne Carriere, Patrick Delaunay,
Jaehoon Chung, U-Boot STM32
Define LOG_CATEGORY to allow filtering with log command.
Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---
drivers/power/regulator/scmi_regulator.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/power/regulator/scmi_regulator.c b/drivers/power/regulator/scmi_regulator.c
index b3142bf4e1..3ddeaf4adc 100644
--- a/drivers/power/regulator/scmi_regulator.c
+++ b/drivers/power/regulator/scmi_regulator.c
@@ -2,6 +2,9 @@
/*
* Copyright (C) 2020-2021 Linaro Limited
*/
+
+#define LOG_CATEGORY UCLASS_REGULATOR
+
#include <common.h>
#include <dm.h>
#include <errno.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/5] firmware: scmi: add configs to select the supported agents
2021-10-28 13:01 [PATCH 1/5] reset: scmi: define LOG_CATEGORY Patrick Delaunay
2021-10-28 13:01 ` [PATCH 2/5] clk: " Patrick Delaunay
2021-10-28 13:01 ` [PATCH 3/5] power: regulator: " Patrick Delaunay
@ 2021-10-28 13:01 ` Patrick Delaunay
2021-10-28 14:18 ` Etienne Carriere
2021-10-28 13:01 ` [PATCH 5/5] stm32mp15: deactivate CONFIG_SCMI_AGENT_MAILBOX Patrick Delaunay
3 siblings, 1 reply; 6+ messages in thread
From: Patrick Delaunay @ 2021-10-28 13:01 UTC (permalink / raw)
To: u-boot
Cc: Etienne Carriere, Etienne Carriere, Patrick Delaunay,
Wolfgang Denk, U-Boot STM32
Add two configs CONFIG_SCMI_AGENT_MAILBOX and CONFIG_SCMI_AGENT_SMCCC
to select the supported agents as all the agents are not supported.
Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---
drivers/firmware/scmi/Kconfig | 16 ++++++++++++++++
drivers/firmware/scmi/Makefile | 4 ++--
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/scmi/Kconfig b/drivers/firmware/scmi/Kconfig
index c3a109beac..db35438dda 100644
--- a/drivers/firmware/scmi/Kconfig
+++ b/drivers/firmware/scmi/Kconfig
@@ -17,3 +17,19 @@ config SCMI_FIRMWARE
based on message exchange. Messages can be exchange over tranport
channels as a mailbox device or an Arm SMCCC service with some
piece of identified shared memory.
+
+config SCMI_AGENT_MAILBOX
+ bool "Enable SCMI agent mailbox"
+ depends on SCMI_FIRMWARE && DM_MAILBOX
+ default y
+ help
+ Enable the SCMI communication channel based on mailbox
+ for compatible "arm,scmi".
+
+config SCMI_AGENT_SMCCC
+ bool "Enable SCMI agent SMCCC"
+ depends on SCMI_FIRMWARE && ARM_SMCCC
+ default y
+ help
+ Enable the SCMI communication channel based on Arm SMCCC service for
+ compatibble "arm,scmi-smc".
diff --git a/drivers/firmware/scmi/Makefile b/drivers/firmware/scmi/Makefile
index 966475ec10..d6d6f89493 100644
--- a/drivers/firmware/scmi/Makefile
+++ b/drivers/firmware/scmi/Makefile
@@ -1,5 +1,5 @@
obj-y += scmi_agent-uclass.o
obj-y += smt.o
-obj-$(CONFIG_ARM_SMCCC) += smccc_agent.o
-obj-$(CONFIG_DM_MAILBOX) += mailbox_agent.o
+obj-$(SCMI_AGENT_SMCCC) += smccc_agent.o
+obj-$(SCMI_AGENT_MAILBOX) += mailbox_agent.o
obj-$(CONFIG_SANDBOX) += sandbox-scmi_agent.o sandbox-scmi_devices.o
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 4/5] firmware: scmi: add configs to select the supported agents
2021-10-28 13:01 ` [PATCH 4/5] firmware: scmi: add configs to select the supported agents Patrick Delaunay
@ 2021-10-28 14:18 ` Etienne Carriere
0 siblings, 0 replies; 6+ messages in thread
From: Etienne Carriere @ 2021-10-28 14:18 UTC (permalink / raw)
To: Patrick Delaunay; +Cc: u-boot, Etienne Carriere, Wolfgang Denk, U-Boot STM32
Hello Patrick,
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
for the series with typo fixed in patch 4/5 (see below).
On Thu, 28 Oct 2021 at 15:01, Patrick Delaunay
<patrick.delaunay@foss.st.com> wrote:
>
> Add two configs CONFIG_SCMI_AGENT_MAILBOX and CONFIG_SCMI_AGENT_SMCCC
> to select the supported agents as all the agents are not supported.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
>
> drivers/firmware/scmi/Kconfig | 16 ++++++++++++++++
> drivers/firmware/scmi/Makefile | 4 ++--
> 2 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/scmi/Kconfig b/drivers/firmware/scmi/Kconfig
> index c3a109beac..db35438dda 100644
> --- a/drivers/firmware/scmi/Kconfig
> +++ b/drivers/firmware/scmi/Kconfig
> @@ -17,3 +17,19 @@ config SCMI_FIRMWARE
> based on message exchange. Messages can be exchange over tranport
> channels as a mailbox device or an Arm SMCCC service with some
> piece of identified shared memory.
> +
> +config SCMI_AGENT_MAILBOX
> + bool "Enable SCMI agent mailbox"
> + depends on SCMI_FIRMWARE && DM_MAILBOX
> + default y
> + help
> + Enable the SCMI communication channel based on mailbox
> + for compatible "arm,scmi".
> +
> +config SCMI_AGENT_SMCCC
> + bool "Enable SCMI agent SMCCC"
> + depends on SCMI_FIRMWARE && ARM_SMCCC
> + default y
> + help
> + Enable the SCMI communication channel based on Arm SMCCC service for
> + compatibble "arm,scmi-smc".
s/compatibble/compatible/
regards,
etienne
> diff --git a/drivers/firmware/scmi/Makefile b/drivers/firmware/scmi/Makefile
> index 966475ec10..d6d6f89493 100644
> --- a/drivers/firmware/scmi/Makefile
> +++ b/drivers/firmware/scmi/Makefile
> @@ -1,5 +1,5 @@
> obj-y += scmi_agent-uclass.o
> obj-y += smt.o
> -obj-$(CONFIG_ARM_SMCCC) += smccc_agent.o
> -obj-$(CONFIG_DM_MAILBOX) += mailbox_agent.o
> +obj-$(SCMI_AGENT_SMCCC) += smccc_agent.o
> +obj-$(SCMI_AGENT_MAILBOX) += mailbox_agent.o
> obj-$(CONFIG_SANDBOX) += sandbox-scmi_agent.o sandbox-scmi_devices.o
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 5/5] stm32mp15: deactivate CONFIG_SCMI_AGENT_MAILBOX
2021-10-28 13:01 [PATCH 1/5] reset: scmi: define LOG_CATEGORY Patrick Delaunay
` (2 preceding siblings ...)
2021-10-28 13:01 ` [PATCH 4/5] firmware: scmi: add configs to select the supported agents Patrick Delaunay
@ 2021-10-28 13:01 ` Patrick Delaunay
3 siblings, 0 replies; 6+ messages in thread
From: Patrick Delaunay @ 2021-10-28 13:01 UTC (permalink / raw)
To: u-boot
Cc: Etienne Carriere, Etienne Carriere, Patrick Delaunay,
Ilias Apalodimas, Jean-Philippe ROMAIN, Patrice Chotard,
uboot-stm32
Deactivate the SCMI agent mailbox which is not used on STM32MP15
platforms.
Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---
configs/stm32mp15_defconfig | 1 +
configs/stm32mp15_trusted_defconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig
index 701b1510c5..e4989efad1 100644
--- a/configs/stm32mp15_defconfig
+++ b/configs/stm32mp15_defconfig
@@ -75,6 +75,7 @@ CONFIG_FASTBOOT_MMC_USER_NAME="mmc1"
CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_FASTBOOT_CMD_OEM_PARTCONF=y
CONFIG_FASTBOOT_CMD_OEM_BOOTBUS=y
+# CONFIG_SCMI_AGENT_MAILBOX is not set
CONFIG_GPIO_HOG=y
CONFIG_DM_HWSPINLOCK=y
CONFIG_HWSPINLOCK_STM32=y
diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig
index b4ed090e3f..a3d2a6e1b4 100644
--- a/configs/stm32mp15_trusted_defconfig
+++ b/configs/stm32mp15_trusted_defconfig
@@ -76,6 +76,7 @@ CONFIG_FASTBOOT_MMC_USER_NAME="mmc1"
CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_FASTBOOT_CMD_OEM_PARTCONF=y
CONFIG_FASTBOOT_CMD_OEM_BOOTBUS=y
+# CONFIG_SCMI_AGENT_MAILBOX is not set
CONFIG_GPIO_HOG=y
CONFIG_DM_HWSPINLOCK=y
CONFIG_HWSPINLOCK_STM32=y
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread