Re: [PATCH 13/13] extcon: intel-cht-wc: Add support for devices with an USB-micro-B connector

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2837 bytes --]

Hi Hans,

I love your patch! Yet something to improve:

[auto build test ERROR on efi/next]
[also build test ERROR on chanwoo-extcon/extcon-next linus/master v5.15-rc7]
[cannot apply to sre-power-supply/for-next next-20211029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hans-de-Goede/power-suppy-i2c-extcon-Add-support-for-cht-wc-PMIC-without-USB-PD-support/20211031-023017
base:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
config: x86_64-randconfig-a005-20211031 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/8793768dfa9dd49d9355c4acf620c186a87ee3ee
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hans-de-Goede/power-suppy-i2c-extcon-Add-support-for-cht-wc-PMIC-without-USB-PD-support/20211031-023017
        git checkout 8793768dfa9dd49d9355c4acf620c186a87ee3ee
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/extcon/extcon-intel-cht-wc.c: In function 'cht_wc_find_role_sw':
>> drivers/extcon/extcon-intel-cht-wc.c:377:17: error: implicit declaration of function 'usb_role_switch_find_by_fwnode' [-Werror=implicit-function-declaration]
     377 |  ext->role_sw = usb_role_switch_find_by_fwnode(fwnode);
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/extcon/extcon-intel-cht-wc.c:377:15: warning: assignment to 'struct usb_role_switch *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     377 |  ext->role_sw = usb_role_switch_find_by_fwnode(fwnode);
         |               ^
   cc1: some warnings being treated as errors


vim +/usb_role_switch_find_by_fwnode +377 drivers/extcon/extcon-intel-cht-wc.c

   366	
   367	static int cht_wc_find_role_sw(struct cht_wc_extcon_data *ext)
   368	{
   369		const struct software_node *swnode;
   370		struct fwnode_handle *fwnode;
   371	
   372		swnode = software_node_find_by_name(NULL, "intel-xhci-usb-sw");
   373		if (!swnode)
   374			return -EPROBE_DEFER;
   375	
   376		fwnode = software_node_fwnode(swnode);
 > 377		ext->role_sw = usb_role_switch_find_by_fwnode(fwnode);
   378		fwnode_handle_put(fwnode);
   379	
   380		return ext->role_sw ? 0 : -EPROBE_DEFER;
   381	}
   382	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34062 bytes --]