* [PATCH v2] media: i2c: max9286: Depend on VIDEO_V4L2
@ 2021-11-02 11:02 Kieran Bingham
2021-11-02 14:59 ` Niklas Söderlund
2021-11-04 10:59 ` Jacopo Mondi
0 siblings, 2 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-11-02 11:02 UTC (permalink / raw)
To: sakari.ailus, Niklas Söderlund, linux-media, linux-renesas-soc
Cc: Kieran Bingham
The MAX9286 has not explicitly declared a dependency upon VIDEO_V4L2.
While this dependency has likely always been met by configurations
including it, the device does use V4L2 core, and should depend upon it.
Add VIDEO_V4L2 as a dependency to match other drivers and prevent
failures when compile testing.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
v2:
- Split VIDEO_V4L2 to it's own line
A bit of an RFC almost, as I haven't seen any failure on this, however
this does stand out as different to other drivers, and the recent
"max96712: Select VIDEO_V4L2" posting has shown that these deserialiser
drivers could find themselves being compile tested in a manner which
would other wise break.
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index d6a5d4ca439a..e9cfedf561d3 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -469,6 +469,7 @@ config VIDEO_VPX3220
config VIDEO_MAX9286
tristate "Maxim MAX9286 GMSL deserializer support"
depends on I2C && I2C_MUX
+ depends on VIDEO_V4L2
depends on OF_GPIO
select V4L2_FWNODE
select VIDEO_V4L2_SUBDEV_API
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: i2c: max9286: Depend on VIDEO_V4L2
2021-11-02 11:02 [PATCH v2] media: i2c: max9286: Depend on VIDEO_V4L2 Kieran Bingham
@ 2021-11-02 14:59 ` Niklas Söderlund
2021-11-04 10:59 ` Jacopo Mondi
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2021-11-02 14:59 UTC (permalink / raw)
To: Kieran Bingham; +Cc: sakari.ailus, linux-media, linux-renesas-soc
Hi Kieran,
Thanks for your work.
On 2021-11-02 11:02:43 +0000, Kieran Bingham wrote:
> The MAX9286 has not explicitly declared a dependency upon VIDEO_V4L2.
> While this dependency has likely always been met by configurations
> including it, the device does use V4L2 core, and should depend upon it.
>
> Add VIDEO_V4L2 as a dependency to match other drivers and prevent
> failures when compile testing.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> ---
> v2:
> - Split VIDEO_V4L2 to it's own line
>
> A bit of an RFC almost, as I haven't seen any failure on this, however
> this does stand out as different to other drivers, and the recent
> "max96712: Select VIDEO_V4L2" posting has shown that these deserialiser
> drivers could find themselves being compile tested in a manner which
> would other wise break.
>
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index d6a5d4ca439a..e9cfedf561d3 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -469,6 +469,7 @@ config VIDEO_VPX3220
> config VIDEO_MAX9286
> tristate "Maxim MAX9286 GMSL deserializer support"
> depends on I2C && I2C_MUX
> + depends on VIDEO_V4L2
> depends on OF_GPIO
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> --
> 2.30.2
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: i2c: max9286: Depend on VIDEO_V4L2
2021-11-02 11:02 [PATCH v2] media: i2c: max9286: Depend on VIDEO_V4L2 Kieran Bingham
2021-11-02 14:59 ` Niklas Söderlund
@ 2021-11-04 10:59 ` Jacopo Mondi
1 sibling, 0 replies; 3+ messages in thread
From: Jacopo Mondi @ 2021-11-04 10:59 UTC (permalink / raw)
To: Kieran Bingham
Cc: sakari.ailus, Niklas Söderlund, linux-media, linux-renesas-soc
Hi Kieran
On Tue, Nov 02, 2021 at 11:02:43AM +0000, Kieran Bingham wrote:
> The MAX9286 has not explicitly declared a dependency upon VIDEO_V4L2.
> While this dependency has likely always been met by configurations
> including it, the device does use V4L2 core, and should depend upon it.
>
> Add VIDEO_V4L2 as a dependency to match other drivers and prevent
> failures when compile testing.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org> o
Thanks
j
>
> ---
> v2:
> - Split VIDEO_V4L2 to it's own line
>
> A bit of an RFC almost, as I haven't seen any failure on this, however
> this does stand out as different to other drivers, and the recent
> "max96712: Select VIDEO_V4L2" posting has shown that these deserialiser
> drivers could find themselves being compile tested in a manner which
> would other wise break.
>
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index d6a5d4ca439a..e9cfedf561d3 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -469,6 +469,7 @@ config VIDEO_VPX3220
> config VIDEO_MAX9286
> tristate "Maxim MAX9286 GMSL deserializer support"
> depends on I2C && I2C_MUX
> + depends on VIDEO_V4L2
> depends on OF_GPIO
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-04 10:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 11:02 [PATCH v2] media: i2c: max9286: Depend on VIDEO_V4L2 Kieran Bingham
2021-11-02 14:59 ` Niklas Söderlund
2021-11-04 10:59 ` Jacopo Mondi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.