From: Tommaso Merciai <tomm.merciai@gmail.com> To: Adam Ford <aford173@gmail.com> Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>, arm-soc <linux-arm-kernel@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, Peng Fan <peng.fan@nxp.com>, Alice Guo <alice.guo@nxp.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Joakim Zhang <qiangqing.zhang@nxp.com>, Krzysztof Kozlowski <krzk@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Lucas Stach <l.stach@pengutronix.de> Subject: Re: [PATCH] arm64: dts: imx8m: add syscon node for display_blk_ctrl module regs Date: Tue, 2 Nov 2021 12:59:21 +0100 [thread overview] Message-ID: <20211102115739.GA48972@tom-ThinkBook-14-G2-ARE> (raw) In-Reply-To: <CAHCN7xLDHCQoA41FJpP3GY+nbFm99zf=tspHSOXkeFogMF22+A@mail.gmail.com> On Mon, Nov 01, 2021 at 11:22:21PM -0500, Adam Ford wrote: > On Mon, Nov 1, 2021 at 5:58 PM Tommaso Merciai <tomm.merciai@gmail.com> wrote: > > > > On Mon, Nov 01, 2021 at 11:35:49PM +0100, Ahmad Fatoum wrote: > > > Hello Tommaso, > > > > > > On 01.11.21 23:28, Tommaso Merciai wrote: > > > > Add system controller node for registers of module Display Block Control > > > > (DISPLAY_BLK_CTRL, base address: 0x32e28000). > > > > The DISPLAY_BLK_CTRL module contains general purpose registers (GPRs), > > > > which control varied features of the associated peripherals. > > > > Reference: IMX8MMRM Rev. 3, 11/2020, p 3897 > > > > --- > > > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > > index 2f632e8ca388..3e496b457e1a 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > > @@ -961,6 +961,11 @@ aips4: bus@32c00000 { > > > > #size-cells = <1>; > > > > ranges = <0x32c00000 0x32c00000 0x400000>; > > > > > > > > + dispmix_gpr: display-gpr@32e28000 { > > > > + compatible = "fsl, imx8mm-iomuxc-gpr", "syscon"; > > > > > > Please read vendor patches before submitting them. The space > > > is out-of-place in the compatible and the compatible is wrong: > > > This doesn't look like a i.MX8MM pin controller. > > > > > > Cheers, > > > Ahmad > > > > Hi Ahmad, > > Thanks for your review. Do you think this is correct? > > > > compatible = "fsl,imx8mm-dispmix-gpr", "syscon"; > > > > Let me know. > > There was already a driver created for the blk-ctrl stuff and it has a > device tree binding at 32e28000. It's tied into the power-domain > system, so if you want to enable the csi, dsi, or lcd, etc. you can > just reference the blt-ctrl power domain index, and it enables the > device's gpc power domain and takes the corresponding device out of > reset. Hi Adam, You mean using the gpcv2.c driver? drivers/soc/imx/gpcv2.c With the following node, to put out of reset eLCDIF and mipi_dsi: gpc: gpc@303a0000 { compatible = "fsl,imx8mm-gpc"; reg = <0x303a0000 0x10000>; interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; interrupt-controller; #interrupt-cells = <3>; pgc { #address-cells = <1>; #size-cells = <0>; pgc_mipi: power-domain@0 { #power-domain-cells = <0>; reg = <IMX8M_POWER_DOMAIN_MIPI>; }; pgc_disp: power-domain@7 { #power-domain-cells = <0>; reg = <IMX8M_POWER_DOMAIN_DISP>; }; }; }; Let me know. Thanks, Tommaso > > adam > > > > Thanks, > > Tommaso > > > > > > > > > + reg = <0x32e28000 0x100>; > > > > + }; > > > > + > > > > usbotg1: usb@32e40000 { > > > > compatible = "fsl,imx8mm-usb", "fsl,imx7d-usb"; > > > > reg = <0x32e40000 0x200>; > > > > > > > > > > > > > -- > > > Pengutronix e.K. | | > > > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > > > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Tommaso Merciai <tomm.merciai@gmail.com> To: Adam Ford <aford173@gmail.com> Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>, arm-soc <linux-arm-kernel@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, Peng Fan <peng.fan@nxp.com>, Alice Guo <alice.guo@nxp.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Joakim Zhang <qiangqing.zhang@nxp.com>, Krzysztof Kozlowski <krzk@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Lucas Stach <l.stach@pengutronix.de> Subject: Re: [PATCH] arm64: dts: imx8m: add syscon node for display_blk_ctrl module regs Date: Tue, 2 Nov 2021 12:59:21 +0100 [thread overview] Message-ID: <20211102115739.GA48972@tom-ThinkBook-14-G2-ARE> (raw) In-Reply-To: <CAHCN7xLDHCQoA41FJpP3GY+nbFm99zf=tspHSOXkeFogMF22+A@mail.gmail.com> On Mon, Nov 01, 2021 at 11:22:21PM -0500, Adam Ford wrote: > On Mon, Nov 1, 2021 at 5:58 PM Tommaso Merciai <tomm.merciai@gmail.com> wrote: > > > > On Mon, Nov 01, 2021 at 11:35:49PM +0100, Ahmad Fatoum wrote: > > > Hello Tommaso, > > > > > > On 01.11.21 23:28, Tommaso Merciai wrote: > > > > Add system controller node for registers of module Display Block Control > > > > (DISPLAY_BLK_CTRL, base address: 0x32e28000). > > > > The DISPLAY_BLK_CTRL module contains general purpose registers (GPRs), > > > > which control varied features of the associated peripherals. > > > > Reference: IMX8MMRM Rev. 3, 11/2020, p 3897 > > > > --- > > > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > > index 2f632e8ca388..3e496b457e1a 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > > @@ -961,6 +961,11 @@ aips4: bus@32c00000 { > > > > #size-cells = <1>; > > > > ranges = <0x32c00000 0x32c00000 0x400000>; > > > > > > > > + dispmix_gpr: display-gpr@32e28000 { > > > > + compatible = "fsl, imx8mm-iomuxc-gpr", "syscon"; > > > > > > Please read vendor patches before submitting them. The space > > > is out-of-place in the compatible and the compatible is wrong: > > > This doesn't look like a i.MX8MM pin controller. > > > > > > Cheers, > > > Ahmad > > > > Hi Ahmad, > > Thanks for your review. Do you think this is correct? > > > > compatible = "fsl,imx8mm-dispmix-gpr", "syscon"; > > > > Let me know. > > There was already a driver created for the blk-ctrl stuff and it has a > device tree binding at 32e28000. It's tied into the power-domain > system, so if you want to enable the csi, dsi, or lcd, etc. you can > just reference the blt-ctrl power domain index, and it enables the > device's gpc power domain and takes the corresponding device out of > reset. Hi Adam, You mean using the gpcv2.c driver? drivers/soc/imx/gpcv2.c With the following node, to put out of reset eLCDIF and mipi_dsi: gpc: gpc@303a0000 { compatible = "fsl,imx8mm-gpc"; reg = <0x303a0000 0x10000>; interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; interrupt-controller; #interrupt-cells = <3>; pgc { #address-cells = <1>; #size-cells = <0>; pgc_mipi: power-domain@0 { #power-domain-cells = <0>; reg = <IMX8M_POWER_DOMAIN_MIPI>; }; pgc_disp: power-domain@7 { #power-domain-cells = <0>; reg = <IMX8M_POWER_DOMAIN_DISP>; }; }; }; Let me know. Thanks, Tommaso > > adam > > > > Thanks, > > Tommaso > > > > > > > > > + reg = <0x32e28000 0x100>; > > > > + }; > > > > + > > > > usbotg1: usb@32e40000 { > > > > compatible = "fsl,imx8mm-usb", "fsl,imx7d-usb"; > > > > reg = <0x32e40000 0x200>; > > > > > > > > > > > > > -- > > > Pengutronix e.K. | | > > > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > > > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-02 11:59 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-01 22:28 [PATCH] arm64: dts: imx8m: add syscon node for display_blk_ctrl module regs Tommaso Merciai 2021-11-01 22:28 ` Tommaso Merciai 2021-11-01 22:35 ` Ahmad Fatoum 2021-11-01 22:35 ` Ahmad Fatoum 2021-11-01 22:58 ` Tommaso Merciai 2021-11-01 22:58 ` Tommaso Merciai 2021-11-02 4:22 ` Adam Ford 2021-11-02 4:22 ` Adam Ford 2021-11-02 11:59 ` Tommaso Merciai [this message] 2021-11-02 11:59 ` Tommaso Merciai 2021-11-02 12:23 ` Adam Ford 2021-11-02 12:23 ` Adam Ford 2021-11-02 15:47 ` Tommaso Merciai 2021-11-02 15:47 ` Tommaso Merciai 2021-11-02 16:07 ` Adam Ford 2021-11-02 16:07 ` Adam Ford 2021-11-02 18:18 ` Tim Harvey 2021-11-02 18:18 ` Tim Harvey 2021-11-02 22:43 ` Tommaso Merciai 2021-11-02 22:43 ` Tommaso Merciai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211102115739.GA48972@tom-ThinkBook-14-G2-ARE \ --to=tomm.merciai@gmail.com \ --cc=a.fatoum@pengutronix.de \ --cc=aford173@gmail.com \ --cc=alice.guo@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=krzk@kernel.org \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peng.fan@nxp.com \ --cc=qiangqing.zhang@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.