All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Headset fixup for Clevo NH77HJQ
@ 2021-11-02 17:21 Tim Crawford
  2021-11-02 18:06 ` Tim Crawford
  2021-11-02 18:10 ` Tim Crawford
  0 siblings, 2 replies; 4+ messages in thread
From: Tim Crawford @ 2021-11-02 17:21 UTC (permalink / raw)
  To: alsa-devel; +Cc: productdev, Jeremy Soller, tiwai

From: Jeremy Soller <jeremy@system76.com>

On Clevo NH77HJ, NH77HP, and their 15" variants, there is a headset
microphone input attached to 0x19 that does not have a jack detect. In
order to get it working, the pin configuration needs to be set
correctly, and a new ALC256_FIXUP_HEADSET_MODE_NO_HP_MIC fixup is
applied. This is similar to the existing System76 quirk for ALC293, but
for ALC256.

Signed-off-by: Jeremy Soller <jeremy@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
---
 sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 8a3e2fe42106..e6b266416393 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6739,6 +6739,7 @@ enum {
 	ALC287_FIXUP_YOGA7_14ITL_SPEAKERS,
 	ALC287_FIXUP_13S_GEN2_SPEAKERS,
 	ALC256_FIXUP_TONGFANG_RESET_PERSISTENT_SETTINGS,
+	ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE,
 };
 
 static const struct hda_fixup alc269_fixups[] = {
@@ -8450,6 +8451,15 @@ static const struct hda_fixup alc269_fixups[] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc245_fixup_hp_gpio_led,
 	},
+	[ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{ 0x19, 0x03a11120 }, /* use as headset mic, without its own jack detect */
+			{ }
+		},
+		.chained = true,
+		.chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC,
+	},
 };
 
 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -8750,11 +8760,15 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1558, 0x40a1, "Clevo NL40GU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x40c1, "Clevo NL40[CZ]U", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x40d1, "Clevo NL41DU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x1558, 0x5015, "Clevo NH5[58]H[HJK]Q", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x1558, 0x5017, "Clevo NH7[79]H[HJK]Q", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x50a3, "Clevo NJ51GU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x50b3, "Clevo NK50S[BEZ]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x50b6, "Clevo NK50S5", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x50b8, "Clevo NK50SZ", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x50d5, "Clevo NP50D5", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x1558, 0x50e1, "Clevo NH5[58]HPQ", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x1558, 0x50e2, "Clevo NH7[79]HPQ", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x50f0, "Clevo NH50A[CDF]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x50f2, "Clevo NH50E[PR]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x50f3, "Clevo NH58DPQ", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Headset fixup for Clevo NH77HJQ
  2021-11-02 17:21 [PATCH] ALSA: hda/realtek: Headset fixup for Clevo NH77HJQ Tim Crawford
@ 2021-11-02 18:06 ` Tim Crawford
  2021-11-02 18:10 ` Tim Crawford
  1 sibling, 0 replies; 4+ messages in thread
From: Tim Crawford @ 2021-11-02 18:06 UTC (permalink / raw)
  To: alsa-devel; +Cc: productdev, tiwai



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Headset fixup for Clevo NH77HJQ
  2021-11-02 17:21 [PATCH] ALSA: hda/realtek: Headset fixup for Clevo NH77HJQ Tim Crawford
  2021-11-02 18:06 ` Tim Crawford
@ 2021-11-02 18:10 ` Tim Crawford
  2021-11-03 16:05   ` Takashi Iwai
  1 sibling, 1 reply; 4+ messages in thread
From: Tim Crawford @ 2021-11-02 18:10 UTC (permalink / raw)
  To: tiwai; +Cc: productdev, alsa-devel

> correctly, and a new ALC256_FIXUP_HEADSET_MODE_NO_HP_MIC fixup is

Sorry, that should say ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE.

-- 
Tim Crawford
System76
Kernel Engineer
tcrawford@system76.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Headset fixup for Clevo NH77HJQ
  2021-11-02 18:10 ` Tim Crawford
@ 2021-11-03 16:05   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-11-03 16:05 UTC (permalink / raw)
  To: Tim Crawford; +Cc: productdev, alsa-devel, tiwai

On Tue, 02 Nov 2021 19:10:07 +0100,
Tim Crawford wrote:
> 
> > correctly, and a new ALC256_FIXUP_HEADSET_MODE_NO_HP_MIC fixup is
> 
> Sorry, that should say ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE.

Don't worry, I corrected and applied now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-03 16:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 17:21 [PATCH] ALSA: hda/realtek: Headset fixup for Clevo NH77HJQ Tim Crawford
2021-11-02 18:06 ` Tim Crawford
2021-11-02 18:10 ` Tim Crawford
2021-11-03 16:05   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.