* [PATCHv3 net 0/5] kselftests/net: add missed tests to Makefile
@ 2021-11-03 2:44 Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 1/5] kselftests/net: add missed icmp.sh test " Hangbin Liu
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Hangbin Liu @ 2021-11-03 2:44 UTC (permalink / raw)
To: netdev
Cc: David S . Miller, Andrea Mayer, Coco Li, Paolo Lungaroni,
Paolo Abeni, Toke Høiland-Jørgensen, linux-kselftest,
Willem de Bruijn, Jakub Kicinski, Hangbin Liu
When generating the selftest to another folder, some tests are missing
as they are not added in Makefile. e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
These pathset add them separately to make the Fixes tags less. It would
also make the stable tree or downstream backport easier.
If you think there is no need to add the Fixes tag for this minor issue.
I can repost a new patch and merge all the fixes together.
Thanks
v3: no update, just rebase to latest net tree.
v2: move toeplitz.sh/toeplitz_client.sh under TEST_PROGS_EXTENDED.
Hangbin Liu (5):
kselftests/net: add missed icmp.sh test to Makefile
kselftests/net: add missed setup_loopback.sh/setup_veth.sh to Makefile
kselftests/net: add missed SRv6 tests
kselftests/net: add missed vrf_strict_mode_test.sh test to Makefile
kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile
tools/testing/selftests/net/Makefile | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
--
2.31.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCHv3 net 1/5] kselftests/net: add missed icmp.sh test to Makefile
2021-11-03 2:44 [PATCHv3 net 0/5] kselftests/net: add missed tests to Makefile Hangbin Liu
@ 2021-11-03 2:44 ` Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 2/5] kselftests/net: add missed setup_loopback.sh/setup_veth.sh " Hangbin Liu
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Hangbin Liu @ 2021-11-03 2:44 UTC (permalink / raw)
To: netdev
Cc: David S . Miller, Andrea Mayer, Coco Li, Paolo Lungaroni,
Paolo Abeni, Toke Høiland-Jørgensen, linux-kselftest,
Willem de Bruijn, Jakub Kicinski, Hangbin Liu
When generating the selftests to another folder, the icmp.sh test will
miss as it is not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Fixes: 7e9838b7915e ("selftests/net: Add icmp.sh for testing ICMP dummy address responses")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/net/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index aee76d1bb9da..7b079b01aa1b 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -12,7 +12,7 @@ TEST_PROGS += udpgro_bench.sh udpgro.sh test_vxlan_under_vrf.sh reuseport_addr_a
TEST_PROGS += test_vxlan_fdb_changelink.sh so_txtime.sh ipv6_flowlabel.sh
TEST_PROGS += tcp_fastopen_backup_key.sh fcnal-test.sh l2tp.sh traceroute.sh
TEST_PROGS += fin_ack_lat.sh fib_nexthop_multiprefix.sh fib_nexthops.sh
-TEST_PROGS += altnames.sh icmp_redirect.sh ip6_gre_headroom.sh
+TEST_PROGS += altnames.sh icmp.sh icmp_redirect.sh ip6_gre_headroom.sh
TEST_PROGS += route_localnet.sh
TEST_PROGS += reuseaddr_ports_exhausted.sh
TEST_PROGS += txtimestamp.sh
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCHv3 net 2/5] kselftests/net: add missed setup_loopback.sh/setup_veth.sh to Makefile
2021-11-03 2:44 [PATCHv3 net 0/5] kselftests/net: add missed tests to Makefile Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 1/5] kselftests/net: add missed icmp.sh test " Hangbin Liu
@ 2021-11-03 2:44 ` Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 3/5] kselftests/net: add missed SRv6 tests Hangbin Liu
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Hangbin Liu @ 2021-11-03 2:44 UTC (permalink / raw)
To: netdev
Cc: David S . Miller, Andrea Mayer, Coco Li, Paolo Lungaroni,
Paolo Abeni, Toke Høiland-Jørgensen, linux-kselftest,
Willem de Bruijn, Jakub Kicinski, Hangbin Liu
When generating the selftests to another folder, the include file
setup_loopback.sh/setup_veth.sh for gro.sh/gre_gro.sh are missing as
they are not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test")
Fixes: 9af771d2ec04 ("selftests/net: allow GRO coalesce test on veth")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/net/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 7b079b01aa1b..8c3d0709b870 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -30,7 +30,7 @@ TEST_PROGS += ioam6.sh
TEST_PROGS += gro.sh
TEST_PROGS += gre_gso.sh
TEST_PROGS += cmsg_so_mark.sh
-TEST_PROGS_EXTENDED := in_netns.sh
+TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
TEST_GEN_FILES = socket nettest
TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any
TEST_GEN_FILES += tcp_mmap tcp_inq psock_snd txring_overwrite
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCHv3 net 3/5] kselftests/net: add missed SRv6 tests
2021-11-03 2:44 [PATCHv3 net 0/5] kselftests/net: add missed tests to Makefile Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 1/5] kselftests/net: add missed icmp.sh test " Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 2/5] kselftests/net: add missed setup_loopback.sh/setup_veth.sh " Hangbin Liu
@ 2021-11-03 2:44 ` Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 4/5] kselftests/net: add missed vrf_strict_mode_test.sh test to Makefile Hangbin Liu
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Hangbin Liu @ 2021-11-03 2:44 UTC (permalink / raw)
To: netdev
Cc: David S . Miller, Andrea Mayer, Coco Li, Paolo Lungaroni,
Paolo Abeni, Toke Høiland-Jørgensen, linux-kselftest,
Willem de Bruijn, Jakub Kicinski, Hangbin Liu
When generating the selftests to another folder, the SRv6 tests are
missing as they are not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Fixes: 03a0b567a03d ("selftests: seg6: add selftest for SRv6 End.DT46 Behavior")
Fixes: 2195444e09b4 ("selftests: add selftest for the SRv6 End.DT4 behavior")
Fixes: 2bc035538e16 ("selftests: add selftest for the SRv6 End.DT6 (VRF) behavior")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/net/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 8c3d0709b870..256dcd17cd8d 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -30,6 +30,9 @@ TEST_PROGS += ioam6.sh
TEST_PROGS += gro.sh
TEST_PROGS += gre_gso.sh
TEST_PROGS += cmsg_so_mark.sh
+TEST_PROGS += srv6_end_dt46_l3vpn_test.sh
+TEST_PROGS += srv6_end_dt4_l3vpn_test.sh
+TEST_PROGS += srv6_end_dt6_l3vpn_test.sh
TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
TEST_GEN_FILES = socket nettest
TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCHv3 net 4/5] kselftests/net: add missed vrf_strict_mode_test.sh test to Makefile
2021-11-03 2:44 [PATCHv3 net 0/5] kselftests/net: add missed tests to Makefile Hangbin Liu
` (2 preceding siblings ...)
2021-11-03 2:44 ` [PATCHv3 net 3/5] kselftests/net: add missed SRv6 tests Hangbin Liu
@ 2021-11-03 2:44 ` Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh " Hangbin Liu
2021-11-03 11:20 ` [PATCHv3 net 0/5] kselftests/net: add missed tests " patchwork-bot+netdevbpf
5 siblings, 0 replies; 7+ messages in thread
From: Hangbin Liu @ 2021-11-03 2:44 UTC (permalink / raw)
To: netdev
Cc: David S . Miller, Andrea Mayer, Coco Li, Paolo Lungaroni,
Paolo Abeni, Toke Høiland-Jørgensen, linux-kselftest,
Willem de Bruijn, Jakub Kicinski, Hangbin Liu
When generating the selftests to another folder, the
vrf_strict_mode_test.sh test will miss as it is not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Fixes: 8735e6eaa438 ("selftests: add selftest for the VRF strict mode")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/net/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 256dcd17cd8d..218a24f0567e 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -33,6 +33,7 @@ TEST_PROGS += cmsg_so_mark.sh
TEST_PROGS += srv6_end_dt46_l3vpn_test.sh
TEST_PROGS += srv6_end_dt4_l3vpn_test.sh
TEST_PROGS += srv6_end_dt6_l3vpn_test.sh
+TEST_PROGS += vrf_strict_mode_test.sh
TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
TEST_GEN_FILES = socket nettest
TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCHv3 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile
2021-11-03 2:44 [PATCHv3 net 0/5] kselftests/net: add missed tests to Makefile Hangbin Liu
` (3 preceding siblings ...)
2021-11-03 2:44 ` [PATCHv3 net 4/5] kselftests/net: add missed vrf_strict_mode_test.sh test to Makefile Hangbin Liu
@ 2021-11-03 2:44 ` Hangbin Liu
2021-11-03 11:20 ` [PATCHv3 net 0/5] kselftests/net: add missed tests " patchwork-bot+netdevbpf
5 siblings, 0 replies; 7+ messages in thread
From: Hangbin Liu @ 2021-11-03 2:44 UTC (permalink / raw)
To: netdev
Cc: David S . Miller, Andrea Mayer, Coco Li, Paolo Lungaroni,
Paolo Abeni, Toke Høiland-Jørgensen, linux-kselftest,
Willem de Bruijn, Jakub Kicinski, Hangbin Liu, Willem de Bruijn
When generating the selftests to another folder, the toeplitz.sh
and toeplitz_client.sh are missing as they are not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Making them under TEST_PROGS_EXTENDED as they test NIC hardware features
and are not intended to be run from kselftests.
Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
--
v3: no update
v2: move the tests under TEST_PROGS_EXTENDED as Willem suggested.
---
tools/testing/selftests/net/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 218a24f0567e..7615f29831eb 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -35,6 +35,7 @@ TEST_PROGS += srv6_end_dt4_l3vpn_test.sh
TEST_PROGS += srv6_end_dt6_l3vpn_test.sh
TEST_PROGS += vrf_strict_mode_test.sh
TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
+TEST_PROGS_EXTENDED += toeplitz_client.sh toeplitz.sh
TEST_GEN_FILES = socket nettest
TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any
TEST_GEN_FILES += tcp_mmap tcp_inq psock_snd txring_overwrite
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCHv3 net 0/5] kselftests/net: add missed tests to Makefile
2021-11-03 2:44 [PATCHv3 net 0/5] kselftests/net: add missed tests to Makefile Hangbin Liu
` (4 preceding siblings ...)
2021-11-03 2:44 ` [PATCHv3 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh " Hangbin Liu
@ 2021-11-03 11:20 ` patchwork-bot+netdevbpf
5 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-03 11:20 UTC (permalink / raw)
To: Hangbin Liu
Cc: netdev, davem, andrea.mayer, lixiaoyan, paolo.lungaroni, pabeni,
toke, linux-kselftest, willemdebruijn.kernel, kuba
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 3 Nov 2021 10:44:54 +0800 you wrote:
> When generating the selftest to another folder, some tests are missing
> as they are not added in Makefile. e.g.
>
> make -C tools/testing/selftests/ install \
> TARGETS="net" INSTALL_PATH=/tmp/kselftests
>
> These pathset add them separately to make the Fixes tags less. It would
> also make the stable tree or downstream backport easier.
>
> [...]
Here is the summary with links:
- [PATCHv3,net,1/5] kselftests/net: add missed icmp.sh test to Makefile
https://git.kernel.org/netdev/net/c/ca3676f94b8f
- [PATCHv3,net,2/5] kselftests/net: add missed setup_loopback.sh/setup_veth.sh to Makefile
https://git.kernel.org/netdev/net/c/b99ac1841147
- [PATCHv3,net,3/5] kselftests/net: add missed SRv6 tests
https://git.kernel.org/netdev/net/c/653e7f19b4a0
- [PATCHv3,net,4/5] kselftests/net: add missed vrf_strict_mode_test.sh test to Makefile
https://git.kernel.org/netdev/net/c/8883deb50eb6
- [PATCHv3,net,5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile
https://git.kernel.org/netdev/net/c/17b67370c38d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-11-03 11:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 2:44 [PATCHv3 net 0/5] kselftests/net: add missed tests to Makefile Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 1/5] kselftests/net: add missed icmp.sh test " Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 2/5] kselftests/net: add missed setup_loopback.sh/setup_veth.sh " Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 3/5] kselftests/net: add missed SRv6 tests Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 4/5] kselftests/net: add missed vrf_strict_mode_test.sh test to Makefile Hangbin Liu
2021-11-03 2:44 ` [PATCHv3 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh " Hangbin Liu
2021-11-03 11:20 ` [PATCHv3 net 0/5] kselftests/net: add missed tests " patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.