* [PATCH] qdev-monitor: Fix use after free on duplicate device ID error
@ 2021-11-03 7:38 Markus Armbruster
2021-11-03 7:42 ` Marc-André Lureau
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Markus Armbruster @ 2021-11-03 7:38 UTC (permalink / raw)
To: qemu-devel; +Cc: damien.hedde, kwolf
Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd
Reported-by: Coverity CID 1465223
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
softmmu/qdev-monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
index e49d9773d2..14c1fb76c5 100644
--- a/softmmu/qdev-monitor.c
+++ b/softmmu/qdev-monitor.c
@@ -592,8 +592,8 @@ const char *qdev_set_id(DeviceState *dev, char *id, Error **errp)
if (prop) {
dev->id = id;
} else {
- g_free(id);
error_setg(errp, "Duplicate device ID '%s'", id);
+ g_free(id);
return NULL;
}
} else {
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qdev-monitor: Fix use after free on duplicate device ID error
2021-11-03 7:38 [PATCH] qdev-monitor: Fix use after free on duplicate device ID error Markus Armbruster
@ 2021-11-03 7:42 ` Marc-André Lureau
2021-11-03 9:25 ` Damien Hedde
2021-11-03 9:33 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2021-11-03 7:42 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Damien Hedde, Kevin Wolf, QEMU
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Wed, Nov 3, 2021 at 11:39 AM Markus Armbruster <armbru@redhat.com> wrote:
> Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd
> Reported-by: Coverity CID 1465223
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> softmmu/qdev-monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
> index e49d9773d2..14c1fb76c5 100644
> --- a/softmmu/qdev-monitor.c
> +++ b/softmmu/qdev-monitor.c
> @@ -592,8 +592,8 @@ const char *qdev_set_id(DeviceState *dev, char *id,
> Error **errp)
> if (prop) {
> dev->id = id;
> } else {
> - g_free(id);
> error_setg(errp, "Duplicate device ID '%s'", id);
> + g_free(id);
> return NULL;
> }
> } else {
> --
> 2.31.1
>
>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 1583 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qdev-monitor: Fix use after free on duplicate device ID error
2021-11-03 7:38 [PATCH] qdev-monitor: Fix use after free on duplicate device ID error Markus Armbruster
2021-11-03 7:42 ` Marc-André Lureau
@ 2021-11-03 9:25 ` Damien Hedde
2021-11-03 9:33 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Damien Hedde @ 2021-11-03 9:25 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: kwolf
On 11/3/21 08:38, Markus Armbruster wrote:
> Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd
> Reported-by: Coverity CID 1465223
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
Thanks,
Damien
> ---
> softmmu/qdev-monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
> index e49d9773d2..14c1fb76c5 100644
> --- a/softmmu/qdev-monitor.c
> +++ b/softmmu/qdev-monitor.c
> @@ -592,8 +592,8 @@ const char *qdev_set_id(DeviceState *dev, char *id, Error **errp)
> if (prop) {
> dev->id = id;
> } else {
> - g_free(id);
> error_setg(errp, "Duplicate device ID '%s'", id);
> + g_free(id);
> return NULL;
> }
> } else {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qdev-monitor: Fix use after free on duplicate device ID error
2021-11-03 7:38 [PATCH] qdev-monitor: Fix use after free on duplicate device ID error Markus Armbruster
2021-11-03 7:42 ` Marc-André Lureau
2021-11-03 9:25 ` Damien Hedde
@ 2021-11-03 9:33 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2021-11-03 9:33 UTC (permalink / raw)
To: Markus Armbruster; +Cc: damien.hedde, qemu-devel, stefanha
Am 03.11.2021 um 08:38 hat Markus Armbruster geschrieben:
> Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd
> Reported-by: Coverity CID 1465223
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Stefan already sent a patch yesterday:
https://lists.gnu.org/archive/html/qemu-devel/2021-11/msg00759.html
Message-Id: <20211102163342.31162-1-stefanha@redhat.com>
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-03 9:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 7:38 [PATCH] qdev-monitor: Fix use after free on duplicate device ID error Markus Armbruster
2021-11-03 7:42 ` Marc-André Lureau
2021-11-03 9:25 ` Damien Hedde
2021-11-03 9:33 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.