From: Dan Carpenter <dan.carpenter@oracle.com> To: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm> Cc: Steve Longerbeam <slongerbeam@gmail.com>, Philipp Zabel <p.zabel@pengutronix.de>, Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@puri.sm, phone-devel@vger.kernel.org Subject: Re: [PATCHv2 4/4] media: imx: Use dedicated format handler for i.MX7/8 Date: Wed, 3 Nov 2021 13:41:00 +0300 [thread overview] Message-ID: <20211103104100.GM2794@kadam> (raw) In-Reply-To: <20211017102904.756408-4-dorota.czaplejewicz@puri.sm> On Sun, Oct 17, 2021 at 01:08:37PM +0200, Dorota Czaplejewicz wrote: > +static int imx78_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, > + const struct v4l2_mbus_framefmt *mbus, > + const struct imx_media_pixfmt *cc) > +{ > + u32 width; > + u32 stride; > + u8 divisor; > + > + if (!cc) { > + cc = imx_media_find_ipu_format(mbus->code, > + PIXFMT_SEL_YUV_RGB); > + if (!cc) > + cc = imx_media_find_mbus_format(mbus->code, > + PIXFMT_SEL_ANY); > + if (!cc) > + return -EINVAL; > + } > + > + /* > + * TODO: the IPU currently does not support the AYUV32 format, > + * so until it does convert to a supported YUV format. > + */ > + if (cc->ipufmt && cc->cs == IPUV3_COLORSPACE_YUV) { > + u32 code; > + > + imx_media_enum_mbus_formats(&code, 0, PIXFMT_SEL_YUV); > + cc = imx_media_find_mbus_format(code, PIXFMT_SEL_YUV); Do we need a if (!cc) NULL check after this assignment? > + } > + > + /* > + * The hardware can handle line lengths divisible by 4 bytes, > + * as long as the number of lines is even. > + * Otherwise, use the value of 8 bytes recommended in the datasheet. > + */ > + divisor = 4 << (mbus->height % 2); > + > + width = round_up(mbus->width, divisor); > + > + if (cc->planar) > + stride = round_up(width, 16); > + else > + stride = round_up((width * cc->bpp) >> 3, divisor); > + > + pix->width = width; > + pix->height = mbus->height; > + pix->pixelformat = cc->fourcc; > + pix->colorspace = mbus->colorspace; > + pix->xfer_func = mbus->xfer_func; > + pix->ycbcr_enc = mbus->ycbcr_enc; > + pix->quantization = mbus->quantization; > + pix->field = mbus->field; > + pix->bytesperline = stride; > + pix->sizeimage = cc->planar ? ((stride * pix->height * cc->bpp) >> 3) : > + stride * pix->height; > + > + return 0; > +} regards, dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm> Cc: Steve Longerbeam <slongerbeam@gmail.com>, Philipp Zabel <p.zabel@pengutronix.de>, Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@puri.sm, phone-devel@vger.kernel.org Subject: Re: [PATCHv2 4/4] media: imx: Use dedicated format handler for i.MX7/8 Date: Wed, 3 Nov 2021 13:41:00 +0300 [thread overview] Message-ID: <20211103104100.GM2794@kadam> (raw) In-Reply-To: <20211017102904.756408-4-dorota.czaplejewicz@puri.sm> On Sun, Oct 17, 2021 at 01:08:37PM +0200, Dorota Czaplejewicz wrote: > +static int imx78_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, > + const struct v4l2_mbus_framefmt *mbus, > + const struct imx_media_pixfmt *cc) > +{ > + u32 width; > + u32 stride; > + u8 divisor; > + > + if (!cc) { > + cc = imx_media_find_ipu_format(mbus->code, > + PIXFMT_SEL_YUV_RGB); > + if (!cc) > + cc = imx_media_find_mbus_format(mbus->code, > + PIXFMT_SEL_ANY); > + if (!cc) > + return -EINVAL; > + } > + > + /* > + * TODO: the IPU currently does not support the AYUV32 format, > + * so until it does convert to a supported YUV format. > + */ > + if (cc->ipufmt && cc->cs == IPUV3_COLORSPACE_YUV) { > + u32 code; > + > + imx_media_enum_mbus_formats(&code, 0, PIXFMT_SEL_YUV); > + cc = imx_media_find_mbus_format(code, PIXFMT_SEL_YUV); Do we need a if (!cc) NULL check after this assignment? > + } > + > + /* > + * The hardware can handle line lengths divisible by 4 bytes, > + * as long as the number of lines is even. > + * Otherwise, use the value of 8 bytes recommended in the datasheet. > + */ > + divisor = 4 << (mbus->height % 2); > + > + width = round_up(mbus->width, divisor); > + > + if (cc->planar) > + stride = round_up(width, 16); > + else > + stride = round_up((width * cc->bpp) >> 3, divisor); > + > + pix->width = width; > + pix->height = mbus->height; > + pix->pixelformat = cc->fourcc; > + pix->colorspace = mbus->colorspace; > + pix->xfer_func = mbus->xfer_func; > + pix->ycbcr_enc = mbus->ycbcr_enc; > + pix->quantization = mbus->quantization; > + pix->field = mbus->field; > + pix->bytesperline = stride; > + pix->sizeimage = cc->planar ? ((stride * pix->height * cc->bpp) >> 3) : > + stride * pix->height; > + > + return 0; > +} regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-03 10:41 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-17 11:08 [PATCHv2 1/4] media: imx: Remove unused functions Dorota Czaplejewicz 2021-10-17 11:08 ` Dorota Czaplejewicz 2021-10-17 11:08 ` [PATCHv2 2/4] media: imx: Store the type of hardware implementation Dorota Czaplejewicz 2021-10-17 11:08 ` Dorota Czaplejewicz 2021-10-18 10:20 ` Philipp Zabel 2021-10-18 10:20 ` Philipp Zabel 2021-10-17 11:08 ` [PATCHv2 3/4] media: imx: Forward " Dorota Czaplejewicz 2021-10-17 11:08 ` Dorota Czaplejewicz 2021-10-18 10:20 ` Philipp Zabel 2021-10-18 10:20 ` Philipp Zabel 2021-10-17 11:08 ` [PATCHv2 4/4] media: imx: Use dedicated format handler for i.MX7/8 Dorota Czaplejewicz 2021-10-17 11:08 ` Dorota Czaplejewicz 2021-10-18 10:20 ` Philipp Zabel 2021-10-18 10:20 ` Philipp Zabel 2021-11-03 10:41 ` Dan Carpenter [this message] 2021-11-03 10:41 ` Dan Carpenter 2021-11-04 11:45 ` Dorota Czaplejewicz 2021-11-04 11:45 ` Dorota Czaplejewicz 2021-10-18 10:20 ` [PATCHv2 1/4] media: imx: Remove unused functions Philipp Zabel 2021-10-18 10:20 ` Philipp Zabel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211103104100.GM2794@kadam \ --to=dan.carpenter@oracle.com \ --cc=dorota.czaplejewicz@puri.sm \ --cc=festevam@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=kernel@pengutronix.de \ --cc=kernel@puri.sm \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ --cc=mchehab@kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=phone-devel@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=slongerbeam@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.