All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair@alistair23.me>
To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: mylene.josserand@free-electrons.com, linus.walleij@linaro.org,
	andreas@kemnade.info, rydberg@bitmath.org,
	dmitry.torokhov@gmail.com, robh+dt@kernel.org,
	alistair23@gmail.com, Alistair Francis <alistair@alistair23.me>
Subject: [PATCH v2 0/4] Add support for the Cypress cyttsp5
Date: Wed,  3 Nov 2021 21:48:26 +1000	[thread overview]
Message-ID: <20211103114830.62711-1-alistair@alistair23.me> (raw)

This patch series builds on top of [1] and adds support for the cyttsp5
touchscreen controller for the reMarkable 2.

I first tried to add an I2C HID device. Although the cyttsp5 has some HID
looking aspects it is not HID compatible. Just in trying to probe the device
I found:
 - The HID descriptor has extra padding
 - The HID descriptor sets the high bytes of the descriptor length
 - The HID descriptor has extra unrecognised tags
 - The HID reset command doesn't appear to work

I don't think there is a way to use the I2C HID framework with the cyttsp5.
For anyone interested you can see the work here [2]. In that branch though I
can only obtain a HID descriptor, nothing else works without more core
changes.

So instead I rebased the series from [1]. Converted to the new yaml DTS
documentation, added regulator support and fixed a x/y miscalculation bug.

1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/
2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid

Alistair Francis (2):
  ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen
  ARM: dts: imx7d: remarkable2: Enable the cyttsp5

Mylène Josserand (2):
  Input: Add driver for Cypress Generation 5 touchscreen
  Documentation: DT: bindings: input: Add documentation for cyttsp5

 .../input/touchscreen/cypress,tt21000.yaml    |   92 ++
 arch/arm/boot/dts/imx7d-remarkable2.dts       |   89 ++
 arch/arm/configs/imx_v6_v7_defconfig          |    1 +
 drivers/input/touchscreen/Kconfig             |   14 +
 drivers/input/touchscreen/Makefile            |    1 +
 drivers/input/touchscreen/cyttsp5.c           | 1135 +++++++++++++++++
 6 files changed, 1332 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
 create mode 100644 drivers/input/touchscreen/cyttsp5.c

-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Alistair Francis <alistair@alistair23.me>
To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: mylene.josserand@free-electrons.com, linus.walleij@linaro.org,
	andreas@kemnade.info, rydberg@bitmath.org,
	dmitry.torokhov@gmail.com, robh+dt@kernel.org,
	alistair23@gmail.com, Alistair Francis <alistair@alistair23.me>
Subject: [PATCH v2 0/4] Add support for the Cypress cyttsp5
Date: Wed,  3 Nov 2021 21:48:26 +1000	[thread overview]
Message-ID: <20211103114830.62711-1-alistair@alistair23.me> (raw)

This patch series builds on top of [1] and adds support for the cyttsp5
touchscreen controller for the reMarkable 2.

I first tried to add an I2C HID device. Although the cyttsp5 has some HID
looking aspects it is not HID compatible. Just in trying to probe the device
I found:
 - The HID descriptor has extra padding
 - The HID descriptor sets the high bytes of the descriptor length
 - The HID descriptor has extra unrecognised tags
 - The HID reset command doesn't appear to work

I don't think there is a way to use the I2C HID framework with the cyttsp5.
For anyone interested you can see the work here [2]. In that branch though I
can only obtain a HID descriptor, nothing else works without more core
changes.

So instead I rebased the series from [1]. Converted to the new yaml DTS
documentation, added regulator support and fixed a x/y miscalculation bug.

1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/
2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid

Alistair Francis (2):
  ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen
  ARM: dts: imx7d: remarkable2: Enable the cyttsp5

Mylène Josserand (2):
  Input: Add driver for Cypress Generation 5 touchscreen
  Documentation: DT: bindings: input: Add documentation for cyttsp5

 .../input/touchscreen/cypress,tt21000.yaml    |   92 ++
 arch/arm/boot/dts/imx7d-remarkable2.dts       |   89 ++
 arch/arm/configs/imx_v6_v7_defconfig          |    1 +
 drivers/input/touchscreen/Kconfig             |   14 +
 drivers/input/touchscreen/Makefile            |    1 +
 drivers/input/touchscreen/cyttsp5.c           | 1135 +++++++++++++++++
 6 files changed, 1332 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
 create mode 100644 drivers/input/touchscreen/cyttsp5.c

-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2021-11-03 11:48 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 11:48 Alistair Francis [this message]
2021-11-03 11:48 ` [PATCH v2 0/4] Add support for the Cypress cyttsp5 Alistair Francis
2021-11-03 11:48 ` [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen Alistair Francis
2021-11-03 11:48   ` Alistair Francis
2021-11-05 15:01   ` Andreas Kemnade
2021-11-05 15:01     ` Andreas Kemnade
2021-11-06  6:47   ` Dmitry Torokhov
2021-11-06  6:47     ` Dmitry Torokhov
2021-12-01 12:27     ` Alistair Francis
2021-12-01 12:27       ` Alistair Francis
2021-12-13  5:45       ` Dmitry Torokhov
2021-12-13  5:45         ` Dmitry Torokhov
2021-12-13 18:49         ` Andreas Kemnade
2021-12-13 18:49           ` Andreas Kemnade
2021-12-18 22:18         ` Andreas Kemnade
2021-12-18 22:18           ` Andreas Kemnade
2021-12-21 23:28           ` Alistair Francis
2021-12-21 23:28             ` Alistair Francis
2021-12-23 13:47   ` Andy Shevchenko
2021-12-23 13:47     ` Andy Shevchenko
2021-11-03 11:48 ` [PATCH v2 2/4] Documentation: DT: bindings: input: Add documentation for cyttsp5 Alistair Francis
2021-11-03 11:48   ` Alistair Francis
2021-11-03 23:07   ` Rob Herring
2021-11-03 23:07     ` Rob Herring
2021-11-05 14:21   ` Andreas Kemnade
2021-11-05 14:21     ` Andreas Kemnade
2021-11-10 12:59     ` Alistair Francis
2021-11-10 12:59       ` Alistair Francis
2021-11-10 17:36       ` Andreas Kemnade
2021-11-10 17:36         ` Andreas Kemnade
2021-11-11 15:16         ` Linus Walleij
2021-11-11 15:16           ` Linus Walleij
2021-11-18 12:51           ` Alistair Francis
2021-11-18 12:51             ` Alistair Francis
2021-11-03 11:48 ` [PATCH v2 3/4] ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen Alistair Francis
2021-11-03 11:48   ` Alistair Francis
2021-11-03 11:48 ` [PATCH v2 4/4] ARM: dts: imx7d: remarkable2: Enable the cyttsp5 Alistair Francis
2021-11-03 11:48   ` Alistair Francis
2021-11-06  2:25   ` Dmitry Torokhov
2021-11-06  2:25     ` Dmitry Torokhov
2021-11-05 14:52 ` [PATCH v2 0/4] Add support for the Cypress cyttsp5 Andreas Kemnade
2021-11-05 14:52   ` Andreas Kemnade
2021-11-25  9:44   ` Alistair Francis
2021-11-25  9:44     ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103114830.62711-1-alistair@alistair23.me \
    --to=alistair@alistair23.me \
    --cc=alistair23@gmail.com \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mylene.josserand@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.