* [PATCH] ksmbd-tools: fix unit file
@ 2021-11-03 16:20 Guillaume Castagnino
2021-11-03 23:20 ` Namjae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Guillaume Castagnino @ 2021-11-03 16:20 UTC (permalink / raw)
To: linux-cifs; +Cc: Guillaume Castagnino
Signed-off-by: Guillaume Castagnino <casta@xwing.info>
---
ksmbd.service | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ksmbd.service b/ksmbd.service
index 5717177..3309fa9 100644
--- a/ksmbd.service
+++ b/ksmbd.service
@@ -10,7 +10,7 @@ Group=root
RemainAfterExit=yes
ExecStartPre=-/sbin/modprobe ksmbd
ExecStart=/sbin/ksmbd.mountd -s
-ExecReload=/sbin/ksmbd.control -s && /sbin/ksmbd.mountd
+ExecReload=/bin/sh -c '/sbin/ksmbd.control -s && /sbin/ksmbd.mountd -s'
ExecStop=/sbin/ksmbd.control -s
[Install]
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ksmbd-tools: fix unit file
2021-11-03 16:20 [PATCH] ksmbd-tools: fix unit file Guillaume Castagnino
@ 2021-11-03 23:20 ` Namjae Jeon
2021-11-05 19:00 ` Enzo Matsumiya
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2021-11-03 23:20 UTC (permalink / raw)
To: Guillaume Castagnino; +Cc: linux-cifs, Enzo Matsumiya
2021-11-04 1:20 GMT+09:00, Guillaume Castagnino <casta@xwing.info>:
Cc: Enzo.
I will add the below description in patch header.
"Shell logic must be enclosed in shell subprocess, systemd cannot
handle it directly, so reload will fail."
> Signed-off-by: Guillaume Castagnino <casta@xwing.info>
I will apply this patch, Enzo, Let me know if you have other opinion.
Thanks!
> ---
> ksmbd.service | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ksmbd.service b/ksmbd.service
> index 5717177..3309fa9 100644
> --- a/ksmbd.service
> +++ b/ksmbd.service
> @@ -10,7 +10,7 @@ Group=root
> RemainAfterExit=yes
> ExecStartPre=-/sbin/modprobe ksmbd
> ExecStart=/sbin/ksmbd.mountd -s
> -ExecReload=/sbin/ksmbd.control -s && /sbin/ksmbd.mountd
> +ExecReload=/bin/sh -c '/sbin/ksmbd.control -s && /sbin/ksmbd.mountd -s'
> ExecStop=/sbin/ksmbd.control -s
>
> [Install]
> --
> 2.33.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ksmbd-tools: fix unit file
2021-11-03 23:20 ` Namjae Jeon
@ 2021-11-05 19:00 ` Enzo Matsumiya
0 siblings, 0 replies; 3+ messages in thread
From: Enzo Matsumiya @ 2021-11-05 19:00 UTC (permalink / raw)
To: Namjae Jeon; +Cc: Guillaume Castagnino, linux-cifs
On 11/04, Namjae Jeon wrote:
>2021-11-04 1:20 GMT+09:00, Guillaume Castagnino <casta@xwing.info>:
>Cc: Enzo.
>
>I will add the below description in patch header.
>
>"Shell logic must be enclosed in shell subprocess, systemd cannot
>handle it directly, so reload will fail."
>
>> Signed-off-by: Guillaume Castagnino <casta@xwing.info>
>I will apply this patch, Enzo, Let me know if you have other opinion.
My bad, that's the right way. Please apply it.
>Thanks!
>> ---
>> ksmbd.service | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ksmbd.service b/ksmbd.service
>> index 5717177..3309fa9 100644
>> --- a/ksmbd.service
>> +++ b/ksmbd.service
>> @@ -10,7 +10,7 @@ Group=root
>> RemainAfterExit=yes
>> ExecStartPre=-/sbin/modprobe ksmbd
>> ExecStart=/sbin/ksmbd.mountd -s
>> -ExecReload=/sbin/ksmbd.control -s && /sbin/ksmbd.mountd
>> +ExecReload=/bin/sh -c '/sbin/ksmbd.control -s && /sbin/ksmbd.mountd -s'
>> ExecStop=/sbin/ksmbd.control -s
>>
>> [Install]
>> --
>> 2.33.1
Cheers,
Enzo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-05 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 16:20 [PATCH] ksmbd-tools: fix unit file Guillaume Castagnino
2021-11-03 23:20 ` Namjae Jeon
2021-11-05 19:00 ` Enzo Matsumiya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.