[PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[Nghia Le]

The newinet value is initialized with inet_sk() in a block code starting
from checking condition of protocol to exiting by returning newsk
structure. Along the code path, newinet is never read. Thus, assignment
to newinet is wredundant and can be removed.

Signed-off-by: Nghia Le <nghialm78@gmail.com>
---
 net/ipv6/tcp_ipv6.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 2cc9b0e53ad1..551fce49841d 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *
 
 		inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);
 
-		newinet = inet_sk(newsk);
 		newnp = tcp_inet6_sk(newsk);
 		newtp = tcp_sk(newsk);
 
-- 
2.25.1

[linux-safety] [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[Nghia Le]

The newinet value is initialized with inet_sk() in a block code starting
from checking condition of protocol to exiting by returning newsk
structure. Along the code path, newinet is never read. Thus, assignment
to newinet is wredundant and can be removed.

Signed-off-by: Nghia Le <nghialm78@gmail.com>
---
 net/ipv6/tcp_ipv6.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 2cc9b0e53ad1..551fce49841d 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *
 
 		inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);
 
-		newinet = inet_sk(newsk);
 		newnp = tcp_inet6_sk(newsk);
 		newtp = tcp_sk(newsk);
 
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#261): https://lists.elisa.tech/g/linux-safety/message/261
Mute This Topic: https://lists.elisa.tech/mt/86805127/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[Lukas Bulwahn]

On Thu, Nov 4, 2021 at 12:28 AM Nghia Le <nghialm78@gmail.com> wrote:
>
> The newinet value is initialized with inet_sk() in a block code starting
> from checking condition of protocol to exiting by returning newsk
> structure. Along the code path, newinet is never read. Thus, assignment
> to newinet is wredundant and can be removed.
>

Just a bit improving your English:

s/in a block code starting from checking condition of protocol to
exiting by returning newsk structure/in a block code to handle sockets
for the ETH_P_IP protocol/

s/Along the code path/Along this code path/

s/wredundant/redundant/

I would prefer "needless" or "useless" to "redundant", but all words are okay.

Lukas

> Signed-off-by: Nghia Le <nghialm78@gmail.com>
> ---
>  net/ipv6/tcp_ipv6.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index 2cc9b0e53ad1..551fce49841d 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *
>
>                 inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);
>
> -               newinet = inet_sk(newsk);
>                 newnp = tcp_inet6_sk(newsk);
>                 newtp = tcp_sk(newsk);
>
> --
> 2.25.1
>

Re: [linux-safety] [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[Lukas Bulwahn]

On Thu, Nov 4, 2021 at 12:28 AM Nghia Le <nghialm78@gmail.com> wrote:
>
> The newinet value is initialized with inet_sk() in a block code starting
> from checking condition of protocol to exiting by returning newsk
> structure. Along the code path, newinet is never read. Thus, assignment
> to newinet is wredundant and can be removed.
>

Just a bit improving your English:

s/in a block code starting from checking condition of protocol to
exiting by returning newsk structure/in a block code to handle sockets
for the ETH_P_IP protocol/

s/Along the code path/Along this code path/

s/wredundant/redundant/

I would prefer "needless" or "useless" to "redundant", but all words are okay.

Lukas

> Signed-off-by: Nghia Le <nghialm78@gmail.com>
> ---
>  net/ipv6/tcp_ipv6.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index 2cc9b0e53ad1..551fce49841d 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *
>
>                 inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);
>
> -               newinet = inet_sk(newsk);
>                 newnp = tcp_inet6_sk(newsk);
>                 newtp = tcp_sk(newsk);
>
> --
> 2.25.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#262): https://lists.elisa.tech/g/linux-safety/message/262
Mute This Topic: https://lists.elisa.tech/mt/86805127/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[Nghia Le]

On Thu, Nov 04, 2021 at 07:50:18AM +0100, Lukas Bulwahn wrote:
> On Thu, Nov 4, 2021 at 12:28 AM Nghia Le <nghialm78@gmail.com> wrote:
> >
> > The newinet value is initialized with inet_sk() in a block code starting
> > from checking condition of protocol to exiting by returning newsk
> > structure. Along the code path, newinet is never read. Thus, assignment
> > to newinet is wredundant and can be removed.
> >
> 
> Just a bit improving your English:
> 
> s/in a block code starting from checking condition of protocol to
> exiting by returning newsk structure/in a block code to handle sockets
> for the ETH_P_IP protocol/
> 
> s/Along the code path/Along this code path/
> 
> s/wredundant/redundant/
> 
> I would prefer "needless" or "useless" to "redundant", but all words are okay.
> 
> Lukas
> 
> > Signed-off-by: Nghia Le <nghialm78@gmail.com>
> > ---
> >  net/ipv6/tcp_ipv6.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> > index 2cc9b0e53ad1..551fce49841d 100644
> > --- a/net/ipv6/tcp_ipv6.c
> > +++ b/net/ipv6/tcp_ipv6.c
> > @@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *
> >
> >                 inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);
> >
> > -               newinet = inet_sk(newsk);
> >                 newnp = tcp_inet6_sk(newsk);
> >                 newtp = tcp_sk(newsk);
> >
> > --
> > 2.25.1
> >
Thanks Lukas, I revised and submitted patch to public mailing list.
Best regards,
Nghia Le

Re: [linux-safety] [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[Nghia Le]

On Thu, Nov 04, 2021 at 07:50:18AM +0100, Lukas Bulwahn wrote:
> On Thu, Nov 4, 2021 at 12:28 AM Nghia Le <nghialm78@gmail.com> wrote:
> >
> > The newinet value is initialized with inet_sk() in a block code starting
> > from checking condition of protocol to exiting by returning newsk
> > structure. Along the code path, newinet is never read. Thus, assignment
> > to newinet is wredundant and can be removed.
> >
> 
> Just a bit improving your English:
> 
> s/in a block code starting from checking condition of protocol to
> exiting by returning newsk structure/in a block code to handle sockets
> for the ETH_P_IP protocol/
> 
> s/Along the code path/Along this code path/
> 
> s/wredundant/redundant/
> 
> I would prefer "needless" or "useless" to "redundant", but all words are okay.
> 
> Lukas
> 
> > Signed-off-by: Nghia Le <nghialm78@gmail.com>
> > ---
> >  net/ipv6/tcp_ipv6.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> > index 2cc9b0e53ad1..551fce49841d 100644
> > --- a/net/ipv6/tcp_ipv6.c
> > +++ b/net/ipv6/tcp_ipv6.c
> > @@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *
> >
> >                 inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);
> >
> > -               newinet = inet_sk(newsk);
> >                 newnp = tcp_inet6_sk(newsk);
> >                 newtp = tcp_sk(newsk);
> >
> > --
> > 2.25.1
> >
Thanks Lukas, I revised and submitted patch to public mailing list.
Best regards,
Nghia Le


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#263): https://lists.elisa.tech/g/linux-safety/message/263
Mute This Topic: https://lists.elisa.tech/mt/86805127/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

[PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[Nghia Le]

The newinet value is initialized with inet_sk() in a block code to
handle sockets for the ETH_P_IP protocol. Along this code path,
newinet is never read. Thus, assignment to newinet is needless and
can be removed.

Signed-off-by: Nghia Le <nghialm78@gmail.com>
---
 net/ipv6/tcp_ipv6.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 2cc9b0e53ad1..551fce49841d 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *
 
 		inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);
 
-		newinet = inet_sk(newsk);
 		newnp = tcp_inet6_sk(newsk);
 		newtp = tcp_sk(newsk);
 
-- 
2.25.1

Re: [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[Eric Dumazet]

On 11/4/21 7:37 AM, Nghia Le wrote:
> The newinet value is initialized with inet_sk() in a block code to
> handle sockets for the ETH_P_IP protocol. Along this code path,
> newinet is never read. Thus, assignment to newinet is needless and
> can be removed.
> 
> Signed-off-by: Nghia Le <nghialm78@gmail.com>
> ---
>  net/ipv6/tcp_ipv6.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index 2cc9b0e53ad1..551fce49841d 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *
>  
>  		inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);
>  
> -		newinet = inet_sk(newsk);
>  		newnp = tcp_inet6_sk(newsk);
>  		newtp = tcp_sk(newsk);
>  
> 

Reviewed-by: Eric Dumazet <edumazet@google.com>

Re: [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu,  4 Nov 2021 21:37:40 +0700 you wrote:
> The newinet value is initialized with inet_sk() in a block code to
> handle sockets for the ETH_P_IP protocol. Along this code path,
> newinet is never read. Thus, assignment to newinet is needless and
> can be removed.
> 
> Signed-off-by: Nghia Le <nghialm78@gmail.com>
> 
> [...]

Here is the summary with links:
  - ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()
    https://git.kernel.org/netdev/net/c/70bf363d7adb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu,  4 Nov 2021 21:37:40 +0700 you wrote:
> The newinet value is initialized with inet_sk() in a block code to
> handle sockets for the ETH_P_IP protocol. Along this code path,
> newinet is never read. Thus, assignment to newinet is needless and
> can be removed.
> 
> Signed-off-by: Nghia Le <nghialm78@gmail.com>
> 
> [...]

Here is the summary with links:
  - ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()
    https://git.kernel.org/bpf/bpf/c/70bf363d7adb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html