From: kernel test robot <lkp@intel.com>
To: davidcomponentone@gmail.com, jdike@addtoit.com
Cc: kbuild-all@lists.01.org, davidcomponentone@gmail.com,
richard@nod.at, anton.ivanov@cambridgegreys.com,
johannes.berg@intel.com, yang.guang5@zte.com.cn,
linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] um: use swap() to make code cleaner
Date: Thu, 4 Nov 2021 19:10:46 +0800 [thread overview]
Message-ID: <202111041905.SrTJwTW8-lkp@intel.com> (raw)
In-Reply-To: <20211104061609.1496503-1-yang.guang5@zte.com.cn>
[-- Attachment #1: Type: text/plain, Size: 3279 bytes --]
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rw-uml/linux-next]
[also build test ERROR on v5.15 next-20211104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/davidcomponentone-gmail-com/um-use-swap-to-make-code-cleaner/20211104-141655
base: https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git linux-next
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/0daa3d13fe02d69f3d42d17d176edb0043136241
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review davidcomponentone-gmail-com/um-use-swap-to-make-code-cleaner/20211104-141655
git checkout 0daa3d13fe02d69f3d42d17d176edb0043136241
# save the attached .config to linux build tree
make W=1 ARCH=um SUBARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/um/os-Linux/sigio.c: In function 'write_sigio_thread':
>> arch/um/os-Linux/sigio.c:80:5: error: implicit declaration of function 'swap'; did you mean 'swab'? [-Werror=implicit-function-declaration]
80 | swap(current_poll, next_poll);
| ^~~~
| swab
cc1: some warnings being treated as errors
vim +80 arch/um/os-Linux/sigio.c
50
51 static int write_sigio_thread(void *unused)
52 {
53 struct pollfds *fds;
54 struct pollfd *p;
55 int i, n, respond_fd;
56 char c;
57
58 os_fix_helper_signals();
59 fds = ¤t_poll;
60 while (1) {
61 n = poll(fds->poll, fds->used, -1);
62 if (n < 0) {
63 if (errno == EINTR)
64 continue;
65 printk(UM_KERN_ERR "write_sigio_thread : poll returned "
66 "%d, errno = %d\n", n, errno);
67 }
68 for (i = 0; i < fds->used; i++) {
69 p = &fds->poll[i];
70 if (p->revents == 0)
71 continue;
72 if (p->fd == sigio_private[1]) {
73 CATCH_EINTR(n = read(sigio_private[1], &c,
74 sizeof(c)));
75 if (n != sizeof(c))
76 printk(UM_KERN_ERR
77 "write_sigio_thread : "
78 "read on socket failed, "
79 "err = %d\n", errno);
> 80 swap(current_poll, next_poll);
81 respond_fd = sigio_private[1];
82 }
83 else {
84 respond_fd = write_sigio_fds[1];
85 fds->used--;
86 memmove(&fds->poll[i], &fds->poll[i + 1],
87 (fds->used - i) * sizeof(*fds->poll));
88 }
89
90 CATCH_EINTR(n = write(respond_fd, &c, sizeof(c)));
91 if (n != sizeof(c))
92 printk(UM_KERN_ERR "write_sigio_thread : "
93 "write on socket failed, err = %d\n",
94 errno);
95 }
96 }
97
98 return 0;
99 }
100
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 9675 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] um: use swap() to make code cleaner
Date: Thu, 04 Nov 2021 19:10:46 +0800 [thread overview]
Message-ID: <202111041905.SrTJwTW8-lkp@intel.com> (raw)
In-Reply-To: <20211104061609.1496503-1-yang.guang5@zte.com.cn>
[-- Attachment #1: Type: text/plain, Size: 3373 bytes --]
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rw-uml/linux-next]
[also build test ERROR on v5.15 next-20211104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/davidcomponentone-gmail-com/um-use-swap-to-make-code-cleaner/20211104-141655
base: https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git linux-next
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/0daa3d13fe02d69f3d42d17d176edb0043136241
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review davidcomponentone-gmail-com/um-use-swap-to-make-code-cleaner/20211104-141655
git checkout 0daa3d13fe02d69f3d42d17d176edb0043136241
# save the attached .config to linux build tree
make W=1 ARCH=um SUBARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/um/os-Linux/sigio.c: In function 'write_sigio_thread':
>> arch/um/os-Linux/sigio.c:80:5: error: implicit declaration of function 'swap'; did you mean 'swab'? [-Werror=implicit-function-declaration]
80 | swap(current_poll, next_poll);
| ^~~~
| swab
cc1: some warnings being treated as errors
vim +80 arch/um/os-Linux/sigio.c
50
51 static int write_sigio_thread(void *unused)
52 {
53 struct pollfds *fds;
54 struct pollfd *p;
55 int i, n, respond_fd;
56 char c;
57
58 os_fix_helper_signals();
59 fds = ¤t_poll;
60 while (1) {
61 n = poll(fds->poll, fds->used, -1);
62 if (n < 0) {
63 if (errno == EINTR)
64 continue;
65 printk(UM_KERN_ERR "write_sigio_thread : poll returned "
66 "%d, errno = %d\n", n, errno);
67 }
68 for (i = 0; i < fds->used; i++) {
69 p = &fds->poll[i];
70 if (p->revents == 0)
71 continue;
72 if (p->fd == sigio_private[1]) {
73 CATCH_EINTR(n = read(sigio_private[1], &c,
74 sizeof(c)));
75 if (n != sizeof(c))
76 printk(UM_KERN_ERR
77 "write_sigio_thread : "
78 "read on socket failed, "
79 "err = %d\n", errno);
> 80 swap(current_poll, next_poll);
81 respond_fd = sigio_private[1];
82 }
83 else {
84 respond_fd = write_sigio_fds[1];
85 fds->used--;
86 memmove(&fds->poll[i], &fds->poll[i + 1],
87 (fds->used - i) * sizeof(*fds->poll));
88 }
89
90 CATCH_EINTR(n = write(respond_fd, &c, sizeof(c)));
91 if (n != sizeof(c))
92 printk(UM_KERN_ERR "write_sigio_thread : "
93 "write on socket failed, err = %d\n",
94 errno);
95 }
96 }
97
98 return 0;
99 }
100
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 9675 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: davidcomponentone@gmail.com, jdike@addtoit.com
Cc: kbuild-all@lists.01.org, richard@nod.at,
anton.ivanov@cambridgegreys.com, johannes.berg@intel.com,
yang.guang5@zte.com.cn, linux-um@lists.infradead.org,
linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] um: use swap() to make code cleaner
Date: Thu, 4 Nov 2021 19:10:46 +0800 [thread overview]
Message-ID: <202111041905.SrTJwTW8-lkp@intel.com> (raw)
In-Reply-To: <20211104061609.1496503-1-yang.guang5@zte.com.cn>
[-- Attachment #1: Type: text/plain, Size: 3279 bytes --]
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rw-uml/linux-next]
[also build test ERROR on v5.15 next-20211104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/davidcomponentone-gmail-com/um-use-swap-to-make-code-cleaner/20211104-141655
base: https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git linux-next
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/0daa3d13fe02d69f3d42d17d176edb0043136241
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review davidcomponentone-gmail-com/um-use-swap-to-make-code-cleaner/20211104-141655
git checkout 0daa3d13fe02d69f3d42d17d176edb0043136241
# save the attached .config to linux build tree
make W=1 ARCH=um SUBARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/um/os-Linux/sigio.c: In function 'write_sigio_thread':
>> arch/um/os-Linux/sigio.c:80:5: error: implicit declaration of function 'swap'; did you mean 'swab'? [-Werror=implicit-function-declaration]
80 | swap(current_poll, next_poll);
| ^~~~
| swab
cc1: some warnings being treated as errors
vim +80 arch/um/os-Linux/sigio.c
50
51 static int write_sigio_thread(void *unused)
52 {
53 struct pollfds *fds;
54 struct pollfd *p;
55 int i, n, respond_fd;
56 char c;
57
58 os_fix_helper_signals();
59 fds = ¤t_poll;
60 while (1) {
61 n = poll(fds->poll, fds->used, -1);
62 if (n < 0) {
63 if (errno == EINTR)
64 continue;
65 printk(UM_KERN_ERR "write_sigio_thread : poll returned "
66 "%d, errno = %d\n", n, errno);
67 }
68 for (i = 0; i < fds->used; i++) {
69 p = &fds->poll[i];
70 if (p->revents == 0)
71 continue;
72 if (p->fd == sigio_private[1]) {
73 CATCH_EINTR(n = read(sigio_private[1], &c,
74 sizeof(c)));
75 if (n != sizeof(c))
76 printk(UM_KERN_ERR
77 "write_sigio_thread : "
78 "read on socket failed, "
79 "err = %d\n", errno);
> 80 swap(current_poll, next_poll);
81 respond_fd = sigio_private[1];
82 }
83 else {
84 respond_fd = write_sigio_fds[1];
85 fds->used--;
86 memmove(&fds->poll[i], &fds->poll[i + 1],
87 (fds->used - i) * sizeof(*fds->poll));
88 }
89
90 CATCH_EINTR(n = write(respond_fd, &c, sizeof(c)));
91 if (n != sizeof(c))
92 printk(UM_KERN_ERR "write_sigio_thread : "
93 "write on socket failed, err = %d\n",
94 errno);
95 }
96 }
97
98 return 0;
99 }
100
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 9675 bytes --]
[-- Attachment #3: Type: text/plain, Size: 152 bytes --]
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2021-11-04 11:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 6:16 [PATCH] um: use swap() to make code cleaner davidcomponentone
2021-11-04 6:16 ` davidcomponentone
2021-11-04 11:10 ` kernel test robot [this message]
2021-11-04 11:10 ` kernel test robot
2021-11-04 11:10 ` kernel test robot
2021-11-04 14:11 ` Anton Ivanov
2021-11-04 14:11 ` Anton Ivanov
2021-11-05 6:12 ` [PATCH v2] " davidcomponentone
2021-11-05 6:18 ` Yang Guang
2021-11-05 6:18 ` Yang Guang
2021-11-05 11:30 ` David Laight
2021-11-05 11:30 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111041905.SrTJwTW8-lkp@intel.com \
--to=lkp@intel.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=davidcomponentone@gmail.com \
--cc=jdike@addtoit.com \
--cc=johannes.berg@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=yang.guang5@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.