* [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects
@ 2021-11-05 13:03 ` Thomas Hellström
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Hellström @ 2021-11-05 13:03 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Thomas Hellström, matthew.auld
Gem-TTM objects that are backed by shmem might have populated
page-vectors without having the Gem pages set. Those objects
aren't moved to the correct shrinker / purge list by the
gem_madvise. Furthermore they are purged directly on
MADV_DONTNEED rather than waiting for the shrinker to do that.
For such objects, identified by having the
_SELF_MANAGED_SHRINK_LIST set, make sure they end up on the
correct list and defer purging to the shrinker.
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index d0e642c82064..da972c8d45b1 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1005,7 +1005,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
obj->ops->adjust_lru(obj);
}
- if (i915_gem_object_has_pages(obj)) {
+ if (i915_gem_object_has_pages(obj) ||
+ i915_gem_object_has_self_managed_shrink_list(obj)) {
unsigned long flags;
spin_lock_irqsave(&i915->mm.obj_lock, flags);
@@ -1024,7 +1025,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
/* if the object is no longer attached, discard its backing storage */
if (obj->mm.madv == I915_MADV_DONTNEED &&
- !i915_gem_object_has_pages(obj))
+ !i915_gem_object_has_pages(obj) &&
+ !i915_gem_object_has_self_managed_shrink_list(obj))
i915_gem_object_truncate(obj);
args->retained = obj->mm.madv != __I915_MADV_PURGED;
--
2.31.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects
@ 2021-11-05 13:03 ` Thomas Hellström
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Hellström @ 2021-11-05 13:03 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Thomas Hellström, matthew.auld
Gem-TTM objects that are backed by shmem might have populated
page-vectors without having the Gem pages set. Those objects
aren't moved to the correct shrinker / purge list by the
gem_madvise. Furthermore they are purged directly on
MADV_DONTNEED rather than waiting for the shrinker to do that.
For such objects, identified by having the
_SELF_MANAGED_SHRINK_LIST set, make sure they end up on the
correct list and defer purging to the shrinker.
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index d0e642c82064..da972c8d45b1 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1005,7 +1005,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
obj->ops->adjust_lru(obj);
}
- if (i915_gem_object_has_pages(obj)) {
+ if (i915_gem_object_has_pages(obj) ||
+ i915_gem_object_has_self_managed_shrink_list(obj)) {
unsigned long flags;
spin_lock_irqsave(&i915->mm.obj_lock, flags);
@@ -1024,7 +1025,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
/* if the object is no longer attached, discard its backing storage */
if (obj->mm.madv == I915_MADV_DONTNEED &&
- !i915_gem_object_has_pages(obj))
+ !i915_gem_object_has_pages(obj) &&
+ !i915_gem_object_has_self_managed_shrink_list(obj))
i915_gem_object_truncate(obj);
args->retained = obj->mm.madv != __I915_MADV_PURGED;
--
2.31.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Fix gem_madvise for ttm+shmem objects
2021-11-05 13:03 ` [Intel-gfx] " Thomas Hellström
(?)
@ 2021-11-05 13:50 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-11-05 13:50 UTC (permalink / raw)
To: Thomas Hellström; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9471 bytes --]
== Series Details ==
Series: drm/i915/gem: Fix gem_madvise for ttm+shmem objects
URL : https://patchwork.freedesktop.org/series/96611/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10846 -> Patchwork_21525
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/index.html
Participating hosts (43 -> 35)
------------------------------
Additional (3): fi-tgl-1115g4 fi-skl-6600u fi-snb-2600
Missing (11): fi-kbl-soraka fi-ilk-m540 bat-adls-5 bat-dg1-6 bat-dg1-5 fi-hsw-4200u fi-icl-u2 fi-bsw-cyan bat-adlp-4 fi-ctg-p8600 fi-icl-y
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21525:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@vgem_basic@unload:
- {fi-tgl-dsi}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/fi-tgl-dsi/igt@vgem_basic@unload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-tgl-dsi/igt@vgem_basic@unload.html
Known issues
------------
Here are the changes found in Patchwork_21525 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-rkl-guc: NOTRUN -> [SKIP][3] ([fdo#109315]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-rkl-guc/igt@amdgpu/amd_basic@cs-gfx.html
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-1115g4: NOTRUN -> [SKIP][4] ([fdo#109315])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-tgl-1115g4/igt@amdgpu/amd_basic@query-info.html
* igt@amdgpu/amd_cs_nop@nop-gfx0:
- fi-tgl-1115g4: NOTRUN -> [SKIP][5] ([fdo#109315] / [i915#2575]) +16 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-tgl-1115g4/igt@amdgpu/amd_cs_nop@nop-gfx0.html
* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][6] ([fdo#109271]) +23 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-skl-6600u/igt@amdgpu/amd_cs_nop@sync-fork-gfx0.html
* igt@gem_exec_suspend@basic-s3:
- fi-bdw-5557u: [PASS][7] -> [INCOMPLETE][8] ([i915#146])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][10] ([i915#2190])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
* igt@i915_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][11] ([i915#1155])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [PASS][12] -> [INCOMPLETE][13] ([i915#2940])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
- fi-bsw-n3050: [PASS][14] -> [INCOMPLETE][15] ([i915#2940])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-snb-2600: NOTRUN -> [SKIP][16] ([fdo#109271]) +37 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-snb-2600/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][17] ([fdo#111827]) +8 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-snb-2600: NOTRUN -> [SKIP][18] ([fdo#109271] / [fdo#111827]) +8 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-snb-2600/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> [SKIP][19] ([fdo#109271] / [fdo#111827]) +8 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-1115g4: NOTRUN -> [SKIP][20] ([i915#4103]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][21] ([fdo#109285])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][22] -> [DMESG-WARN][23] ([i915#4269])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6600u: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#533])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-tgl-1115g4: NOTRUN -> [SKIP][25] ([i915#1072]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-1115g4: NOTRUN -> [SKIP][26] ([i915#3301])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> [FAIL][27] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-bsw-kefka/igt@runner@aborted.html
- fi-bsw-n3050: NOTRUN -> [FAIL][28] ([fdo#109271] / [i915#1436] / [i915#2722] / [i915#3428] / [i915#4312])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-bsw-n3050/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_engines:
- fi-rkl-guc: [INCOMPLETE][29] ([i915#4432]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4432]: https://gitlab.freedesktop.org/drm/intel/issues/4432
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_10846 -> Patchwork_21525
CI-20190529: 20190529
CI_DRM_10846: 7c9be254055dc831fa786361627ba3a5766b45cc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6274: 569de51145fba197a8d93b2417348d47507bf485 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21525: 44ca65a1f0949b7dc95a1b75032a1dcc4589aa4d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
44ca65a1f094 drm/i915/gem: Fix gem_madvise for ttm+shmem objects
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/index.html
[-- Attachment #2: Type: text/html, Size: 11648 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects
2021-11-05 13:03 ` [Intel-gfx] " Thomas Hellström
@ 2021-11-05 15:18 ` Matthew Auld
-1 siblings, 0 replies; 10+ messages in thread
From: Matthew Auld @ 2021-11-05 15:18 UTC (permalink / raw)
To: Thomas Hellström, intel-gfx, dri-devel
On 05/11/2021 13:03, Thomas Hellström wrote:
> Gem-TTM objects that are backed by shmem might have populated
> page-vectors without having the Gem pages set. Those objects
> aren't moved to the correct shrinker / purge list by the
> gem_madvise. Furthermore they are purged directly on
> MADV_DONTNEED rather than waiting for the shrinker to do that.
>
> For such objects, identified by having the
> _SELF_MANAGED_SHRINK_LIST set, make sure they end up on the
> correct list and defer purging to the shrinker.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index d0e642c82064..da972c8d45b1 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1005,7 +1005,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
> obj->ops->adjust_lru(obj);
> }
>
> - if (i915_gem_object_has_pages(obj)) {
> + if (i915_gem_object_has_pages(obj) ||
> + i915_gem_object_has_self_managed_shrink_list(obj)) {
Makes sense.
> unsigned long flags;
>
> spin_lock_irqsave(&i915->mm.obj_lock, flags);
> @@ -1024,7 +1025,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
>
> /* if the object is no longer attached, discard its backing storage */
> if (obj->mm.madv == I915_MADV_DONTNEED &&
> - !i915_gem_object_has_pages(obj))
> + !i915_gem_object_has_pages(obj) &&
> + !i915_gem_object_has_self_managed_shrink_list(obj))
> i915_gem_object_truncate(obj);
And it looks like this also matches the workings of lmem, where under
memory pressure we also just purge such objects, instead of moving them,
making sure to keep them first in the LRU?
One thing is to maybe immediately discard already swapped-out objects
here, since the shrinker will be oblivious to them, and they sort of
just linger in swap until the object is destroyed?
>
> args->retained = obj->mm.madv != __I915_MADV_PURGED;
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects
@ 2021-11-05 15:18 ` Matthew Auld
0 siblings, 0 replies; 10+ messages in thread
From: Matthew Auld @ 2021-11-05 15:18 UTC (permalink / raw)
To: Thomas Hellström, intel-gfx, dri-devel
On 05/11/2021 13:03, Thomas Hellström wrote:
> Gem-TTM objects that are backed by shmem might have populated
> page-vectors without having the Gem pages set. Those objects
> aren't moved to the correct shrinker / purge list by the
> gem_madvise. Furthermore they are purged directly on
> MADV_DONTNEED rather than waiting for the shrinker to do that.
>
> For such objects, identified by having the
> _SELF_MANAGED_SHRINK_LIST set, make sure they end up on the
> correct list and defer purging to the shrinker.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index d0e642c82064..da972c8d45b1 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1005,7 +1005,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
> obj->ops->adjust_lru(obj);
> }
>
> - if (i915_gem_object_has_pages(obj)) {
> + if (i915_gem_object_has_pages(obj) ||
> + i915_gem_object_has_self_managed_shrink_list(obj)) {
Makes sense.
> unsigned long flags;
>
> spin_lock_irqsave(&i915->mm.obj_lock, flags);
> @@ -1024,7 +1025,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
>
> /* if the object is no longer attached, discard its backing storage */
> if (obj->mm.madv == I915_MADV_DONTNEED &&
> - !i915_gem_object_has_pages(obj))
> + !i915_gem_object_has_pages(obj) &&
> + !i915_gem_object_has_self_managed_shrink_list(obj))
> i915_gem_object_truncate(obj);
And it looks like this also matches the workings of lmem, where under
memory pressure we also just purge such objects, instead of moving them,
making sure to keep them first in the LRU?
One thing is to maybe immediately discard already swapped-out objects
here, since the shrinker will be oblivious to them, and they sort of
just linger in swap until the object is destroyed?
>
> args->retained = obj->mm.madv != __I915_MADV_PURGED;
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Fix gem_madvise for ttm+shmem objects
2021-11-05 13:03 ` [Intel-gfx] " Thomas Hellström
` (2 preceding siblings ...)
(?)
@ 2021-11-05 15:23 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-11-05 15:23 UTC (permalink / raw)
To: Thomas Hellström; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30274 bytes --]
== Series Details ==
Series: drm/i915/gem: Fix gem_madvise for ttm+shmem objects
URL : https://patchwork.freedesktop.org/series/96611/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10846_full -> Patchwork_21525_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21525_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_pwrite_crc:
- {shard-rkl}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-rkl-2/igt@kms_pwrite_crc.html
Known issues
------------
Here are the changes found in Patchwork_21525_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-glk: ([PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26]) -> ([PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [FAIL][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51]) ([i915#4392])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk1/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk1/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk1/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk2/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk2/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk2/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk3/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk3/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk4/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk4/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk4/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk6/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk7/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk7/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk7/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk8/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk8/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk8/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk9/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk9/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk9/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk3/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk3/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk3/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk4/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk4/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk4/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk5/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk5/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk5/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk2/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk7/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk2/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk7/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk7/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk8/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk8/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk8/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk9/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk1/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk9/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk9/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk9/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-tglb: [PASS][52] -> [INCOMPLETE][53] ([i915#1373])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-tglb3/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb7/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_exec_capture@pi@vcs0:
- shard-skl: NOTRUN -> [INCOMPLETE][54] ([i915#2369])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl4/igt@gem_exec_capture@pi@vcs0.html
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][55] ([i915#2846])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl10/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [PASS][56] -> [FAIL][57] ([i915#2842])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-tglb6/igt@gem_exec_fair@basic-pace@bcs0.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb3/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][58] -> [FAIL][59] ([i915#2842])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk8/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][60] -> [SKIP][61] ([i915#2190])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-tglb3/igt@gem_huc_copy@huc-copy.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_pread@exhaustion:
- shard-tglb: NOTRUN -> [WARN][62] ([i915#2658])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@gem_pread@exhaustion.html
- shard-kbl: NOTRUN -> [WARN][63] ([i915#2658])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl7/igt@gem_pread@exhaustion.html
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][64] ([i915#2658]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl9/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][65] ([i915#3002])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl10/igt@gem_userptr_blits@input-checking.html
- shard-kbl: NOTRUN -> [DMESG-WARN][66] ([i915#3002])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl2/igt@gem_userptr_blits@input-checking.html
* igt@gen7_exec_parse@load-register-reg:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109289])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-iclb6/igt@gen7_exec_parse@load-register-reg.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][68] -> [FAIL][69] ([i915#454])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-tglb: NOTRUN -> [WARN][70] ([i915#2681] / [i915#2684])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb8/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_pm_sseu@full-enable:
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#4387])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-iclb6/igt@i915_pm_sseu@full-enable.html
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [PASS][72] -> [DMESG-WARN][73] ([i915#118])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk8/igt@kms_big_fb@linear-32bpp-rotate-180.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk3/igt@kms_big_fb@linear-32bpp-rotate-180.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#3777])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#3886]) +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl2/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#3689]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][77] ([i915#3689] / [i915#3886]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#3886]) +9 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl10/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-apl1/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][80] ([fdo#109271]) +43 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-snb7/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html
* igt@kms_ccs@pipe-d-random-ccs-data-yf_tiled_ccs:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109278]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-iclb6/igt@kms_ccs@pipe-d-random-ccs-data-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-kbl: NOTRUN -> [SKIP][82] ([fdo#109271] / [fdo#111827]) +7 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl7/igt@kms_chamelium@hdmi-hpd-storm.html
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [fdo#111827]) +17 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl10/igt@kms_chamelium@vga-hpd-for-each-pipe.html
* igt@kms_chamelium@vga-hpd-with-enabled-mode:
- shard-snb: NOTRUN -> [SKIP][84] ([fdo#109271] / [fdo#111827]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-snb7/igt@kms_chamelium@vga-hpd-with-enabled-mode.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: NOTRUN -> [DMESG-WARN][85] ([i915#1982])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl6/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][86] -> [DMESG-WARN][87] ([i915#1982])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-skl1/igt@kms_color@pipe-b-ctm-0-75.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl7/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109284] / [fdo#111827])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-iclb6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-d-ctm-limited-range:
- shard-tglb: NOTRUN -> [SKIP][89] ([fdo#109284] / [fdo#111827]) +5 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb6/igt@kms_color_chamelium@pipe-d-ctm-limited-range.html
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> [TIMEOUT][90] ([i915#1319]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl2/igt@kms_content_protection@atomic.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][91] -> [DMESG-WARN][92] ([i915#180]) +5 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-32x10-onscreen:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#3359]) +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@kms_cursor_crc@pipe-b-cursor-32x10-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][94] ([fdo#109279] / [i915#3359]) +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-skl: NOTRUN -> [SKIP][95] ([fdo#109271]) +182 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl9/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#533])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-apl1/igt@kms_cursor_legacy@pipe-d-single-bo.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][97] -> [INCOMPLETE][98] ([i915#180] / [i915#636])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][99] -> [FAIL][100] ([i915#79])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][101] -> [FAIL][102] ([i915#79])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][103] -> [FAIL][104] ([i915#2122]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2672])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
- shard-skl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#2672])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move:
- shard-iclb: NOTRUN -> [SKIP][107] ([fdo#109280])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271]) +85 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][109] ([fdo#111825]) +10 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][110] -> [FAIL][111] ([i915#1188]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-apl: [PASS][112] -> [DMESG-WARN][113] ([i915#180]) +2 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-apl3/igt@kms_hdr@bpc-switch-suspend.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-apl6/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-tglb: NOTRUN -> [SKIP][114] ([fdo#109289]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][115] ([i915#265])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: NOTRUN -> [FAIL][116] ([fdo#108145] / [i915#265]) +3 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][117] ([fdo#108145] / [i915#265]) +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
- shard-tglb: NOTRUN -> [SKIP][118] ([i915#2920])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
- shard-kbl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#658])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
* igt@kms_psr2_su@frontbuffer:
- shard-skl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#658]) +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl10/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][121] -> [SKIP][122] ([fdo#109441]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-tglb: NOTRUN -> [SKIP][123] ([fdo#111615])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html
* igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][124] ([i915#2530]) +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame.html
* igt@prime_nv_api@i915_self_import:
- shard-tglb: NOTRUN -> [SKIP][125] ([fdo#109291])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@prime_nv_api@i915_self_import.html
* igt@sysfs_clients@create:
- shard-skl: NOTRUN -> [SKIP][126] ([fdo#109271] / [i915#2994]) +2 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl6/igt@sysfs_clients@create.html
* igt@sysfs_clients@sema-50:
- shard-kbl: NOTRUN -> [SKIP][127] ([fdo#109271] / [i915#2994])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl2/igt@sysfs_clients@sema-50.html
#### Possible fixes ####
* igt@feature_discovery@psr1:
- {shard-rkl}: [SKIP][128] ([i915#658]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-rkl-2/igt@feature_discovery@psr1.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-rkl-6/igt@feature_discovery@psr1.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [TIMEOUT][130] ([i915#2369] / [i915#2481] / [i915#3070]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-iclb8/igt@gem_eio@unwedge-stress.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-iclb3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [INCOMPLETE][132] ([i915#2369]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-skl9/igt@gem_exec_capture@pi@rcs0.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl4/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-kbl: [SKIP][134] ([fdo#109271]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-kbl4/igt@gem_exec_fair@basic-none-share@rcs0.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-kbl4/igt@gem_exec_fair@basic-none-share@rcs0.html
- shard-iclb: [FAIL][136] ([i915#2842]) -> [PASS][137] +2 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-iclb5/igt@gem_exec_fair@basic-none-share@rcs0.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
- shard-apl: [SKIP][138] ([fdo#109271]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-apl8/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [FAIL][140] ([i915#2842]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-apl8/igt@gem_exec_fair@basic-none@vcs0.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-apl7/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][142] ([i915#2842]) -> [PASS][143] +1 similar issue
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_suspend@basic-s0:
- shard-tglb: [INCOMPLETE][144] ([i915#456]) -> [PASS][145] +1 similar issue
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-tglb7/igt@gem_exec_suspend@basic-s0.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-tglb2/igt@gem_exec_suspend@basic-s0.html
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-glk: [DMESG-WARN][146] ([i915#118]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk1/igt@gem_ppgtt@blt-vs-render-ctx0.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk7/igt@gem_ppgtt@blt-vs-render-ctx0.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][148] ([i915#3921]) -> [PASS][149]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-snb4/igt@i915_selftest@live@hangcheck.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-snb7/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- {shard-rkl}: [SKIP][150] ([i915#1845]) -> [PASS][151] +9 similar issues
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-rkl-2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-rkl-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen:
- shard-snb: [SKIP][152] ([fdo#109271]) -> [PASS][153] +1 similar issue
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-snb6/igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-snb6/igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- {shard-rkl}: [SKIP][154] ([fdo#112022] / [i915#4070]) -> [PASS][155] +2 similar issues
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-rkl-2/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html
* igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge:
- {shard-rkl}: [SKIP][156] ([i915#1849] / [i915#4070]) -> [PASS][157] +1 similar issue
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-rkl-2/igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-rkl-6/igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- {shard-rkl}: [SKIP][158] ([fdo#111825] / [i915#4070]) -> [PASS][159]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-rkl-2/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-rkl-6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_fbcon_fbt@fbc-suspend:
- {shard-rkl}: [SKIP][160] ([i915#1849]) -> [PASS][161] +15 similar issues
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-rkl-2/igt@kms_fbcon_fbt@fbc-suspend.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-rkl-6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][162] ([i915#79]) -> [PASS][163]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [FAIL][164] ([i915#79]) -> [PASS][165]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-glk3/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-kbl: [INCOMPLETE][166] ([i915#3614]) -> [PASS][167]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10846/shard-kbl2/igt@kms_flip@flip-vs-suspend-inter
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21525/index.html
[-- Attachment #2: Type: text/html, Size: 33503 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects
2021-11-05 15:18 ` [Intel-gfx] " Matthew Auld
@ 2021-11-08 8:08 ` Thomas Hellström
-1 siblings, 0 replies; 10+ messages in thread
From: Thomas Hellström @ 2021-11-08 8:08 UTC (permalink / raw)
To: Matthew Auld, intel-gfx, dri-devel
On 11/5/21 16:18, Matthew Auld wrote:
> On 05/11/2021 13:03, Thomas Hellström wrote:
>> Gem-TTM objects that are backed by shmem might have populated
>> page-vectors without having the Gem pages set. Those objects
>> aren't moved to the correct shrinker / purge list by the
>> gem_madvise. Furthermore they are purged directly on
>> MADV_DONTNEED rather than waiting for the shrinker to do that.
>>
>> For such objects, identified by having the
>> _SELF_MANAGED_SHRINK_LIST set, make sure they end up on the
>> correct list and defer purging to the shrinker.
>>
>> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_gem.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c
>> b/drivers/gpu/drm/i915/i915_gem.c
>> index d0e642c82064..da972c8d45b1 100644
>> --- a/drivers/gpu/drm/i915/i915_gem.c
>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>> @@ -1005,7 +1005,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev,
>> void *data,
>> obj->ops->adjust_lru(obj);
>> }
>> - if (i915_gem_object_has_pages(obj)) {
>> + if (i915_gem_object_has_pages(obj) ||
>> + i915_gem_object_has_self_managed_shrink_list(obj)) {
>
> Makes sense.
>
>> unsigned long flags;
>> spin_lock_irqsave(&i915->mm.obj_lock, flags);
>> @@ -1024,7 +1025,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev,
>> void *data,
>> /* if the object is no longer attached, discard its backing
>> storage */
>> if (obj->mm.madv == I915_MADV_DONTNEED &&
>> - !i915_gem_object_has_pages(obj))
>> + !i915_gem_object_has_pages(obj) &&
>> + !i915_gem_object_has_self_managed_shrink_list(obj))
>> i915_gem_object_truncate(obj);
>
> And it looks like this also matches the workings of lmem, where under
> memory pressure we also just purge such objects, instead of moving
> them, making sure to keep them first in the LRU?
>
> One thing is to maybe immediately discard already swapped-out objects
> here, since the shrinker will be oblivious to them, and they sort of
> just linger in swap until the object is destroyed?
This might be a bit ugly if we want to avoid exposing even more gem
object ops.
Could we perhaps for the truncate callback only truncate swapped-out
objects if we have a self-managed shrinker list? That will match all the
current call-sites AFAICT since truncate is never called from the
shrinker with the self-managed shrinker list...
/Thomas
>
>> args->retained = obj->mm.madv != __I915_MADV_PURGED;
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects
@ 2021-11-08 8:08 ` Thomas Hellström
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Hellström @ 2021-11-08 8:08 UTC (permalink / raw)
To: Matthew Auld, intel-gfx, dri-devel
On 11/5/21 16:18, Matthew Auld wrote:
> On 05/11/2021 13:03, Thomas Hellström wrote:
>> Gem-TTM objects that are backed by shmem might have populated
>> page-vectors without having the Gem pages set. Those objects
>> aren't moved to the correct shrinker / purge list by the
>> gem_madvise. Furthermore they are purged directly on
>> MADV_DONTNEED rather than waiting for the shrinker to do that.
>>
>> For such objects, identified by having the
>> _SELF_MANAGED_SHRINK_LIST set, make sure they end up on the
>> correct list and defer purging to the shrinker.
>>
>> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_gem.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c
>> b/drivers/gpu/drm/i915/i915_gem.c
>> index d0e642c82064..da972c8d45b1 100644
>> --- a/drivers/gpu/drm/i915/i915_gem.c
>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>> @@ -1005,7 +1005,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev,
>> void *data,
>> obj->ops->adjust_lru(obj);
>> }
>> - if (i915_gem_object_has_pages(obj)) {
>> + if (i915_gem_object_has_pages(obj) ||
>> + i915_gem_object_has_self_managed_shrink_list(obj)) {
>
> Makes sense.
>
>> unsigned long flags;
>> spin_lock_irqsave(&i915->mm.obj_lock, flags);
>> @@ -1024,7 +1025,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev,
>> void *data,
>> /* if the object is no longer attached, discard its backing
>> storage */
>> if (obj->mm.madv == I915_MADV_DONTNEED &&
>> - !i915_gem_object_has_pages(obj))
>> + !i915_gem_object_has_pages(obj) &&
>> + !i915_gem_object_has_self_managed_shrink_list(obj))
>> i915_gem_object_truncate(obj);
>
> And it looks like this also matches the workings of lmem, where under
> memory pressure we also just purge such objects, instead of moving
> them, making sure to keep them first in the LRU?
>
> One thing is to maybe immediately discard already swapped-out objects
> here, since the shrinker will be oblivious to them, and they sort of
> just linger in swap until the object is destroyed?
This might be a bit ugly if we want to avoid exposing even more gem
object ops.
Could we perhaps for the truncate callback only truncate swapped-out
objects if we have a self-managed shrinker list? That will match all the
current call-sites AFAICT since truncate is never called from the
shrinker with the self-managed shrinker list...
/Thomas
>
>> args->retained = obj->mm.madv != __I915_MADV_PURGED;
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects
2021-11-08 8:08 ` [Intel-gfx] " Thomas Hellström
@ 2021-11-08 8:39 ` Thomas Hellström
-1 siblings, 0 replies; 10+ messages in thread
From: Thomas Hellström @ 2021-11-08 8:39 UTC (permalink / raw)
To: Matthew Auld, intel-gfx, dri-devel
On 11/8/21 09:08, Thomas Hellström wrote:
>
> On 11/5/21 16:18, Matthew Auld wrote:
>> On 05/11/2021 13:03, Thomas Hellström wrote:
>>> Gem-TTM objects that are backed by shmem might have populated
>>> page-vectors without having the Gem pages set. Those objects
>>> aren't moved to the correct shrinker / purge list by the
>>> gem_madvise. Furthermore they are purged directly on
>>> MADV_DONTNEED rather than waiting for the shrinker to do that.
>>>
>>> For such objects, identified by having the
>>> _SELF_MANAGED_SHRINK_LIST set, make sure they end up on the
>>> correct list and defer purging to the shrinker.
>>>
>>> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_gem.c | 6 ++++--
>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c
>>> b/drivers/gpu/drm/i915/i915_gem.c
>>> index d0e642c82064..da972c8d45b1 100644
>>> --- a/drivers/gpu/drm/i915/i915_gem.c
>>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>>> @@ -1005,7 +1005,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev,
>>> void *data,
>>> obj->ops->adjust_lru(obj);
>>> }
>>> - if (i915_gem_object_has_pages(obj)) {
>>> + if (i915_gem_object_has_pages(obj) ||
>>> + i915_gem_object_has_self_managed_shrink_list(obj)) {
>>
>> Makes sense.
>>
>>> unsigned long flags;
>>> spin_lock_irqsave(&i915->mm.obj_lock, flags);
>>> @@ -1024,7 +1025,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev,
>>> void *data,
>>> /* if the object is no longer attached, discard its backing
>>> storage */
>>> if (obj->mm.madv == I915_MADV_DONTNEED &&
>>> - !i915_gem_object_has_pages(obj))
>>> + !i915_gem_object_has_pages(obj) &&
>>> + !i915_gem_object_has_self_managed_shrink_list(obj))
>>> i915_gem_object_truncate(obj);
>>
>> And it looks like this also matches the workings of lmem, where under
>> memory pressure we also just purge such objects, instead of moving
>> them, making sure to keep them first in the LRU?
>>
>> One thing is to maybe immediately discard already swapped-out objects
>> here, since the shrinker will be oblivious to them, and they sort of
>> just linger in swap until the object is destroyed?
>
> This might be a bit ugly if we want to avoid exposing even more gem
> object ops.
>
> Could we perhaps for the truncate callback only truncate swapped-out
> objects if we have a self-managed shrinker list? That will match all
> the current call-sites AFAICT since truncate is never called from the
> shrinker with the self-managed shrinker list...
>
Or actually, Thinking of it, if we don't have GEM pages, even if there
are CPU PTEs set up, I can't see why we shouldn't purge this object
immediately. I'll just revert that last hunk.
/Thomas
> /Thomas
>
>>
>>> args->retained = obj->mm.madv != __I915_MADV_PURGED;
>>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects
@ 2021-11-08 8:39 ` Thomas Hellström
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Hellström @ 2021-11-08 8:39 UTC (permalink / raw)
To: Matthew Auld, intel-gfx, dri-devel
On 11/8/21 09:08, Thomas Hellström wrote:
>
> On 11/5/21 16:18, Matthew Auld wrote:
>> On 05/11/2021 13:03, Thomas Hellström wrote:
>>> Gem-TTM objects that are backed by shmem might have populated
>>> page-vectors without having the Gem pages set. Those objects
>>> aren't moved to the correct shrinker / purge list by the
>>> gem_madvise. Furthermore they are purged directly on
>>> MADV_DONTNEED rather than waiting for the shrinker to do that.
>>>
>>> For such objects, identified by having the
>>> _SELF_MANAGED_SHRINK_LIST set, make sure they end up on the
>>> correct list and defer purging to the shrinker.
>>>
>>> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_gem.c | 6 ++++--
>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c
>>> b/drivers/gpu/drm/i915/i915_gem.c
>>> index d0e642c82064..da972c8d45b1 100644
>>> --- a/drivers/gpu/drm/i915/i915_gem.c
>>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>>> @@ -1005,7 +1005,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev,
>>> void *data,
>>> obj->ops->adjust_lru(obj);
>>> }
>>> - if (i915_gem_object_has_pages(obj)) {
>>> + if (i915_gem_object_has_pages(obj) ||
>>> + i915_gem_object_has_self_managed_shrink_list(obj)) {
>>
>> Makes sense.
>>
>>> unsigned long flags;
>>> spin_lock_irqsave(&i915->mm.obj_lock, flags);
>>> @@ -1024,7 +1025,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev,
>>> void *data,
>>> /* if the object is no longer attached, discard its backing
>>> storage */
>>> if (obj->mm.madv == I915_MADV_DONTNEED &&
>>> - !i915_gem_object_has_pages(obj))
>>> + !i915_gem_object_has_pages(obj) &&
>>> + !i915_gem_object_has_self_managed_shrink_list(obj))
>>> i915_gem_object_truncate(obj);
>>
>> And it looks like this also matches the workings of lmem, where under
>> memory pressure we also just purge such objects, instead of moving
>> them, making sure to keep them first in the LRU?
>>
>> One thing is to maybe immediately discard already swapped-out objects
>> here, since the shrinker will be oblivious to them, and they sort of
>> just linger in swap until the object is destroyed?
>
> This might be a bit ugly if we want to avoid exposing even more gem
> object ops.
>
> Could we perhaps for the truncate callback only truncate swapped-out
> objects if we have a self-managed shrinker list? That will match all
> the current call-sites AFAICT since truncate is never called from the
> shrinker with the self-managed shrinker list...
>
Or actually, Thinking of it, if we don't have GEM pages, even if there
are CPU PTEs set up, I can't see why we shouldn't purge this object
immediately. I'll just revert that last hunk.
/Thomas
> /Thomas
>
>>
>>> args->retained = obj->mm.madv != __I915_MADV_PURGED;
>>>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-11-08 8:39 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 13:03 [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects Thomas Hellström
2021-11-05 13:03 ` [Intel-gfx] " Thomas Hellström
2021-11-05 13:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-05 15:18 ` [PATCH] " Matthew Auld
2021-11-05 15:18 ` [Intel-gfx] " Matthew Auld
2021-11-08 8:08 ` Thomas Hellström
2021-11-08 8:08 ` [Intel-gfx] " Thomas Hellström
2021-11-08 8:39 ` Thomas Hellström
2021-11-08 8:39 ` [Intel-gfx] " Thomas Hellström
2021-11-05 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.