From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [dm-devel] [PATCH 1/8] libmulitpath: add section name to invalid keyword output
Date: Fri, 5 Nov 2021 12:28:19 -0500 [thread overview]
Message-ID: <20211105172819.GF19591@octiron.msp.redhat.com> (raw)
In-Reply-To: <3214cb1e9be6070086dfada89deef4c7977de9e0.camel@suse.com>
On Thu, Nov 04, 2021 at 08:55:39PM +0000, Martin Wilck wrote:
> On Wed, 2021-10-06 at 15:04 -0500, Benjamin Marzinski wrote:
> > If users forget the closing brace for a section in multipath.conf,
> > multipath has no way to detect that. When it sees the keyword at the
> > start of the next section, it will complain that there is an invalid
> > keyword, because that keyword doesn't belong in previous section
> > (which
> > was never ended with a closing brace). This can confuse users. To
> > make
> > this easier to understand, when multipath prints and invalid keyword
> > message, it now also prints the current section name, which can give
> > users a hint that they didn't end the previous section.
> >
> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
>
> Apart from typo in the subject:
Oops. I'll fix that.
-Ben
>
> Reviewed-by: Martin Wilck <mwilck@suse.com>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-11-05 17:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 20:04 [dm-devel] [PATCH 0/8] improving config parsing warnings Benjamin Marzinski
2021-10-06 20:04 ` [dm-devel] [PATCH 1/8] libmulitpath: add section name to invalid keyword output Benjamin Marzinski
2021-11-04 20:55 ` Martin Wilck
2021-11-05 17:28 ` Benjamin Marzinski [this message]
2021-10-06 20:04 ` [dm-devel] [PATCH 2/8] libmultipath: use typedef for keyword handler function Benjamin Marzinski
2021-11-04 20:55 ` Martin Wilck
2021-10-06 20:04 ` [dm-devel] [PATCH 3/8] libmultipath: print the correct file when parsing fails Benjamin Marzinski
2021-11-04 20:55 ` Martin Wilck
2021-10-06 20:04 ` [dm-devel] [PATCH 4/8] libmultipath: pass file and line number to keyword handlers Benjamin Marzinski
2021-11-04 20:55 ` Martin Wilck
2021-11-05 17:33 ` Benjamin Marzinski
2021-10-06 20:04 ` [dm-devel] [PATCH 5/8] libmultipath: make set_int take a range for valid values Benjamin Marzinski
2021-11-04 20:34 ` Martin Wilck
2021-11-05 17:34 ` Benjamin Marzinski
2021-10-06 20:04 ` [dm-devel] [PATCH 6/8] libmultipath: improve checks for set_str Benjamin Marzinski
2021-11-04 20:34 ` Martin Wilck
2021-11-05 6:59 ` Martin Wilck
2021-11-05 17:45 ` Benjamin Marzinski
2021-11-05 20:13 ` Martin Wilck
2021-11-05 17:38 ` Benjamin Marzinski
2021-10-06 20:04 ` [dm-devel] [PATCH 7/8] libmultipath: split set_int to enable reuse Benjamin Marzinski
2021-11-04 20:54 ` Martin Wilck
2021-11-05 18:08 ` Benjamin Marzinski
2021-11-05 19:56 ` Martin Wilck
2021-11-11 11:56 ` Martin Wilck
2021-10-06 20:04 ` [dm-devel] [PATCH 8/8] libmultipath: cleanup invalid config handling Benjamin Marzinski
2021-11-04 21:11 ` Martin Wilck
2021-11-05 20:10 ` Benjamin Marzinski
2021-11-05 20:16 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105172819.GF19591@octiron.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
--cc=martin.wilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.