All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <martin.wilck@suse.com>
To: "bmarzins@redhat.com" <bmarzins@redhat.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [dm-devel] [PATCH 6/8] libmultipath: improve checks for set_str
Date: Fri, 5 Nov 2021 20:13:05 +0000	[thread overview]
Message-ID: <d02f2f1e145f54a30438d7006c7f615f8e7506d3.camel@suse.com> (raw)
In-Reply-To: <20211105174509.GJ19591@octiron.msp.redhat.com>

On Fri, 2021-11-05 at 12:45 -0500, Benjamin Marzinski wrote:
> > 
> > I've changed my mind on this one. The options for directories and
> > paths
> > should be turned into buildtime options instead. If we do that, we
> > don't need this sort of checks any more, except the "noslash" part.
> 
> That seems reasonable. I do want to ask around a little bit to see if
> I
> can find anyone who is actually setting the directories. The only one
> I
> really worry about is "config_dir". I worry that people might do
> something like stick that on shared storage, to make it possible to
> change the multipath config on a bunch of machines in one place.

Not impossible, but frankly, that sort of setup would be typical for
the mid-2000's. Nowadays people would rather use something like ansible
to distribute the configuration. (*)

For us as distribution maintainers, these arbitrarily configurable
paths are a nightmare.

Regards
Martin

(In my testing and playing-around routine, I actually rely on the fact
that it's possible to set a config_dir that doesn't exist. Under normal
operation, it doesn't - if I want to experiment, I just move something
there. But I think I could easily live with built-time settings).


--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2021-11-05 20:13 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 20:04 [dm-devel] [PATCH 0/8] improving config parsing warnings Benjamin Marzinski
2021-10-06 20:04 ` [dm-devel] [PATCH 1/8] libmulitpath: add section name to invalid keyword output Benjamin Marzinski
2021-11-04 20:55   ` Martin Wilck
2021-11-05 17:28     ` Benjamin Marzinski
2021-10-06 20:04 ` [dm-devel] [PATCH 2/8] libmultipath: use typedef for keyword handler function Benjamin Marzinski
2021-11-04 20:55   ` Martin Wilck
2021-10-06 20:04 ` [dm-devel] [PATCH 3/8] libmultipath: print the correct file when parsing fails Benjamin Marzinski
2021-11-04 20:55   ` Martin Wilck
2021-10-06 20:04 ` [dm-devel] [PATCH 4/8] libmultipath: pass file and line number to keyword handlers Benjamin Marzinski
2021-11-04 20:55   ` Martin Wilck
2021-11-05 17:33     ` Benjamin Marzinski
2021-10-06 20:04 ` [dm-devel] [PATCH 5/8] libmultipath: make set_int take a range for valid values Benjamin Marzinski
2021-11-04 20:34   ` Martin Wilck
2021-11-05 17:34     ` Benjamin Marzinski
2021-10-06 20:04 ` [dm-devel] [PATCH 6/8] libmultipath: improve checks for set_str Benjamin Marzinski
2021-11-04 20:34   ` Martin Wilck
2021-11-05  6:59     ` Martin Wilck
2021-11-05 17:45       ` Benjamin Marzinski
2021-11-05 20:13         ` Martin Wilck [this message]
2021-11-05 17:38     ` Benjamin Marzinski
2021-10-06 20:04 ` [dm-devel] [PATCH 7/8] libmultipath: split set_int to enable reuse Benjamin Marzinski
2021-11-04 20:54   ` Martin Wilck
2021-11-05 18:08     ` Benjamin Marzinski
2021-11-05 19:56       ` Martin Wilck
2021-11-11 11:56   ` Martin Wilck
2021-10-06 20:04 ` [dm-devel] [PATCH 8/8] libmultipath: cleanup invalid config handling Benjamin Marzinski
2021-11-04 21:11   ` Martin Wilck
2021-11-05 20:10     ` Benjamin Marzinski
2021-11-05 20:16       ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d02f2f1e145f54a30438d7006c7f615f8e7506d3.camel@suse.com \
    --to=martin.wilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.