From: kernel test robot <lkp@intel.com>
To: Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH] sched: Tweak default dynamic preempt mode selection
Date: Sat, 6 Nov 2021 13:05:24 +0800 [thread overview]
Message-ID: <202111061341.QdauxAuH-lkp@intel.com> (raw)
In-Reply-To: <20211105104035.3112162-1-valentin.schneider@arm.com>
[-- Attachment #1: Type: text/plain, Size: 17949 bytes --]
Hi Valentin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/master]
[also build test ERROR on linus/master next-20211105]
[cannot apply to linux/master v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched-Tweak-default-dynamic-preempt-mode-selection/20211105-184135
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ea79c24a30aa27ccc4aac26be33f8b73f3f1f59c
config: x86_64-buildonly-randconfig-r004-20211105 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 847a6807332b13f43704327c2d30103ec0347c77)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4731291127aa2100c984229a91533b671044a74b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Valentin-Schneider/sched-Tweak-default-dynamic-preempt-mode-selection/20211105-184135
git checkout 4731291127aa2100c984229a91533b671044a74b
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/sched/core.c:3439:6: error: no previous prototype for function 'sched_set_stop_task' [-Werror,-Wmissing-prototypes]
void sched_set_stop_task(int cpu, struct task_struct *stop)
^
kernel/sched/core.c:3439:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sched_set_stop_task(int cpu, struct task_struct *stop)
^
static
>> kernel/sched/core.c:6576:2: error: use of undeclared identifier '__SCT__preempt_schedule'
static_call_update(preempt_schedule, __preempt_schedule_func);
^
include/linux/static_call.h:154:10: note: expanded from macro 'static_call_update'
typeof(&STATIC_CALL_TRAMP(name)) __F = (func); \
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:252:1: note: expanded from here
__SCT__preempt_schedule
^
>> kernel/sched/core.c:6576:39: error: use of undeclared identifier '__preempt_schedule_func'; did you mean 'preempt_schedule_irq'?
static_call_update(preempt_schedule, __preempt_schedule_func);
^~~~~~~~~~~~~~~~~~~~~~~
preempt_schedule_irq
include/linux/static_call.h:154:42: note: expanded from macro 'static_call_update'
typeof(&STATIC_CALL_TRAMP(name)) __F = (func); \
^
include/linux/sched.h:291:17: note: 'preempt_schedule_irq' declared here
asmlinkage void preempt_schedule_irq(void);
^
>> kernel/sched/core.c:6576:2: error: use of undeclared identifier '__SCK__preempt_schedule'
static_call_update(preempt_schedule, __preempt_schedule_func);
^
include/linux/static_call.h:155:24: note: expanded from macro 'static_call_update'
__static_call_update(&STATIC_CALL_KEY(name), \
^
include/linux/static_call_types.h:12:32: note: expanded from macro 'STATIC_CALL_KEY'
#define STATIC_CALL_KEY(name) __PASTE(STATIC_CALL_KEY_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:253:1: note: expanded from here
__SCK__preempt_schedule
^
>> kernel/sched/core.c:6576:2: error: use of undeclared identifier '__SCT__preempt_schedule'
include/linux/static_call.h:156:9: note: expanded from macro 'static_call_update'
STATIC_CALL_TRAMP_ADDR(name), __F); \
^
include/linux/static_call.h:146:39: note: expanded from macro 'STATIC_CALL_TRAMP_ADDR'
#define STATIC_CALL_TRAMP_ADDR(name) &STATIC_CALL_TRAMP(name)
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:254:1: note: expanded from here
__SCT__preempt_schedule
^
>> kernel/sched/core.c:6577:2: error: use of undeclared identifier '__SCT__preempt_schedule_notrace'
static_call_update(preempt_schedule_notrace, __preempt_schedule_notrace_func);
^
include/linux/static_call.h:154:10: note: expanded from macro 'static_call_update'
typeof(&STATIC_CALL_TRAMP(name)) __F = (func); \
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:255:1: note: expanded from here
__SCT__preempt_schedule_notrace
^
>> kernel/sched/core.c:6577:47: error: use of undeclared identifier '__preempt_schedule_notrace_func'
static_call_update(preempt_schedule_notrace, __preempt_schedule_notrace_func);
^
>> kernel/sched/core.c:6577:2: error: use of undeclared identifier '__SCK__preempt_schedule_notrace'
static_call_update(preempt_schedule_notrace, __preempt_schedule_notrace_func);
^
include/linux/static_call.h:155:24: note: expanded from macro 'static_call_update'
__static_call_update(&STATIC_CALL_KEY(name), \
^
include/linux/static_call_types.h:12:32: note: expanded from macro 'STATIC_CALL_KEY'
#define STATIC_CALL_KEY(name) __PASTE(STATIC_CALL_KEY_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:256:1: note: expanded from here
__SCK__preempt_schedule_notrace
^
>> kernel/sched/core.c:6577:2: error: use of undeclared identifier '__SCT__preempt_schedule_notrace'
include/linux/static_call.h:156:9: note: expanded from macro 'static_call_update'
STATIC_CALL_TRAMP_ADDR(name), __F); \
^
include/linux/static_call.h:146:39: note: expanded from macro 'STATIC_CALL_TRAMP_ADDR'
#define STATIC_CALL_TRAMP_ADDR(name) &STATIC_CALL_TRAMP(name)
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:257:1: note: expanded from here
__SCT__preempt_schedule_notrace
^
kernel/sched/core.c:6584:3: error: use of undeclared identifier '__SCT__preempt_schedule'
static_call_update(preempt_schedule, NULL);
^
include/linux/static_call.h:154:10: note: expanded from macro 'static_call_update'
typeof(&STATIC_CALL_TRAMP(name)) __F = (func); \
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:11:1: note: expanded from here
__SCT__preempt_schedule
^
kernel/sched/core.c:6584:3: error: use of undeclared identifier '__SCK__preempt_schedule'
include/linux/static_call.h:155:24: note: expanded from macro 'static_call_update'
__static_call_update(&STATIC_CALL_KEY(name), \
^
include/linux/static_call_types.h:12:32: note: expanded from macro 'STATIC_CALL_KEY'
#define STATIC_CALL_KEY(name) __PASTE(STATIC_CALL_KEY_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:12:1: note: expanded from here
__SCK__preempt_schedule
^
kernel/sched/core.c:6584:3: error: use of undeclared identifier '__SCT__preempt_schedule'
include/linux/static_call.h:156:9: note: expanded from macro 'static_call_update'
STATIC_CALL_TRAMP_ADDR(name), __F); \
^
include/linux/static_call.h:146:39: note: expanded from macro 'STATIC_CALL_TRAMP_ADDR'
#define STATIC_CALL_TRAMP_ADDR(name) &STATIC_CALL_TRAMP(name)
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:13:1: note: expanded from here
__SCT__preempt_schedule
^
kernel/sched/core.c:6585:3: error: use of undeclared identifier '__SCT__preempt_schedule_notrace'
static_call_update(preempt_schedule_notrace, NULL);
^
include/linux/static_call.h:154:10: note: expanded from macro 'static_call_update'
typeof(&STATIC_CALL_TRAMP(name)) __F = (func); \
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:14:1: note: expanded from here
__SCT__preempt_schedule_notrace
^
kernel/sched/core.c:6585:3: error: use of undeclared identifier '__SCK__preempt_schedule_notrace'
include/linux/static_call.h:155:24: note: expanded from macro 'static_call_update'
__static_call_update(&STATIC_CALL_KEY(name), \
^
include/linux/static_call_types.h:12:32: note: expanded from macro 'STATIC_CALL_KEY'
#define STATIC_CALL_KEY(name) __PASTE(STATIC_CALL_KEY_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
vim +/__SCT__preempt_schedule +6576 kernel/sched/core.c
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6567
1011dcce99f802 Peter Zijlstra 2021-03-25 6568 void sched_dynamic_update(int mode)
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6569) {
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6570 /*
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6571 * Avoid {NONE,VOLUNTARY} -> FULL transitions from ever ending up in
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6572 * the ZERO state, which is invalid.
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6573 */
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6574 static_call_update(cond_resched, __cond_resched);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6575 static_call_update(might_resched, __cond_resched);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 @6576 static_call_update(preempt_schedule, __preempt_schedule_func);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 @6577 static_call_update(preempt_schedule_notrace, __preempt_schedule_notrace_func);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6578 static_call_update(irqentry_exit_cond_resched, irqentry_exit_cond_resched);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6579
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6580 switch (mode) {
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6581 case preempt_dynamic_none:
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6582) static_call_update(cond_resched, __cond_resched);
9432bbd969c667 Peter Zijlstra 2021-03-23 6583 static_call_update(might_resched, (void *)&__static_call_return0);
9432bbd969c667 Peter Zijlstra 2021-03-23 6584 static_call_update(preempt_schedule, NULL);
9432bbd969c667 Peter Zijlstra 2021-03-23 6585 static_call_update(preempt_schedule_notrace, NULL);
9432bbd969c667 Peter Zijlstra 2021-03-23 6586 static_call_update(irqentry_exit_cond_resched, NULL);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6587 pr_info("Dynamic Preempt: none\n");
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6588 break;
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6589
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6590 case preempt_dynamic_voluntary:
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6591) static_call_update(cond_resched, __cond_resched);
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6592) static_call_update(might_resched, __cond_resched);
9432bbd969c667 Peter Zijlstra 2021-03-23 6593 static_call_update(preempt_schedule, NULL);
9432bbd969c667 Peter Zijlstra 2021-03-23 6594 static_call_update(preempt_schedule_notrace, NULL);
9432bbd969c667 Peter Zijlstra 2021-03-23 6595 static_call_update(irqentry_exit_cond_resched, NULL);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6596 pr_info("Dynamic Preempt: voluntary\n");
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6597 break;
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6598
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6599 case preempt_dynamic_full:
9432bbd969c667 Peter Zijlstra 2021-03-23 6600 static_call_update(cond_resched, (void *)&__static_call_return0);
9432bbd969c667 Peter Zijlstra 2021-03-23 6601 static_call_update(might_resched, (void *)&__static_call_return0);
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6602) static_call_update(preempt_schedule, __preempt_schedule_func);
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6603) static_call_update(preempt_schedule_notrace, __preempt_schedule_notrace_func);
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6604) static_call_update(irqentry_exit_cond_resched, irqentry_exit_cond_resched);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6605 pr_info("Dynamic Preempt: full\n");
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6606 break;
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6607 }
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6608
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6609 preempt_dynamic_mode = mode;
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6610 }
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6611
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32514 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] sched: Tweak default dynamic preempt mode selection
Date: Sat, 06 Nov 2021 13:05:24 +0800 [thread overview]
Message-ID: <202111061341.QdauxAuH-lkp@intel.com> (raw)
In-Reply-To: <20211105104035.3112162-1-valentin.schneider@arm.com>
[-- Attachment #1: Type: text/plain, Size: 18247 bytes --]
Hi Valentin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/master]
[also build test ERROR on linus/master next-20211105]
[cannot apply to linux/master v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched-Tweak-default-dynamic-preempt-mode-selection/20211105-184135
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ea79c24a30aa27ccc4aac26be33f8b73f3f1f59c
config: x86_64-buildonly-randconfig-r004-20211105 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 847a6807332b13f43704327c2d30103ec0347c77)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4731291127aa2100c984229a91533b671044a74b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Valentin-Schneider/sched-Tweak-default-dynamic-preempt-mode-selection/20211105-184135
git checkout 4731291127aa2100c984229a91533b671044a74b
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/sched/core.c:3439:6: error: no previous prototype for function 'sched_set_stop_task' [-Werror,-Wmissing-prototypes]
void sched_set_stop_task(int cpu, struct task_struct *stop)
^
kernel/sched/core.c:3439:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sched_set_stop_task(int cpu, struct task_struct *stop)
^
static
>> kernel/sched/core.c:6576:2: error: use of undeclared identifier '__SCT__preempt_schedule'
static_call_update(preempt_schedule, __preempt_schedule_func);
^
include/linux/static_call.h:154:10: note: expanded from macro 'static_call_update'
typeof(&STATIC_CALL_TRAMP(name)) __F = (func); \
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:252:1: note: expanded from here
__SCT__preempt_schedule
^
>> kernel/sched/core.c:6576:39: error: use of undeclared identifier '__preempt_schedule_func'; did you mean 'preempt_schedule_irq'?
static_call_update(preempt_schedule, __preempt_schedule_func);
^~~~~~~~~~~~~~~~~~~~~~~
preempt_schedule_irq
include/linux/static_call.h:154:42: note: expanded from macro 'static_call_update'
typeof(&STATIC_CALL_TRAMP(name)) __F = (func); \
^
include/linux/sched.h:291:17: note: 'preempt_schedule_irq' declared here
asmlinkage void preempt_schedule_irq(void);
^
>> kernel/sched/core.c:6576:2: error: use of undeclared identifier '__SCK__preempt_schedule'
static_call_update(preempt_schedule, __preempt_schedule_func);
^
include/linux/static_call.h:155:24: note: expanded from macro 'static_call_update'
__static_call_update(&STATIC_CALL_KEY(name), \
^
include/linux/static_call_types.h:12:32: note: expanded from macro 'STATIC_CALL_KEY'
#define STATIC_CALL_KEY(name) __PASTE(STATIC_CALL_KEY_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:253:1: note: expanded from here
__SCK__preempt_schedule
^
>> kernel/sched/core.c:6576:2: error: use of undeclared identifier '__SCT__preempt_schedule'
include/linux/static_call.h:156:9: note: expanded from macro 'static_call_update'
STATIC_CALL_TRAMP_ADDR(name), __F); \
^
include/linux/static_call.h:146:39: note: expanded from macro 'STATIC_CALL_TRAMP_ADDR'
#define STATIC_CALL_TRAMP_ADDR(name) &STATIC_CALL_TRAMP(name)
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:254:1: note: expanded from here
__SCT__preempt_schedule
^
>> kernel/sched/core.c:6577:2: error: use of undeclared identifier '__SCT__preempt_schedule_notrace'
static_call_update(preempt_schedule_notrace, __preempt_schedule_notrace_func);
^
include/linux/static_call.h:154:10: note: expanded from macro 'static_call_update'
typeof(&STATIC_CALL_TRAMP(name)) __F = (func); \
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:255:1: note: expanded from here
__SCT__preempt_schedule_notrace
^
>> kernel/sched/core.c:6577:47: error: use of undeclared identifier '__preempt_schedule_notrace_func'
static_call_update(preempt_schedule_notrace, __preempt_schedule_notrace_func);
^
>> kernel/sched/core.c:6577:2: error: use of undeclared identifier '__SCK__preempt_schedule_notrace'
static_call_update(preempt_schedule_notrace, __preempt_schedule_notrace_func);
^
include/linux/static_call.h:155:24: note: expanded from macro 'static_call_update'
__static_call_update(&STATIC_CALL_KEY(name), \
^
include/linux/static_call_types.h:12:32: note: expanded from macro 'STATIC_CALL_KEY'
#define STATIC_CALL_KEY(name) __PASTE(STATIC_CALL_KEY_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:256:1: note: expanded from here
__SCK__preempt_schedule_notrace
^
>> kernel/sched/core.c:6577:2: error: use of undeclared identifier '__SCT__preempt_schedule_notrace'
include/linux/static_call.h:156:9: note: expanded from macro 'static_call_update'
STATIC_CALL_TRAMP_ADDR(name), __F); \
^
include/linux/static_call.h:146:39: note: expanded from macro 'STATIC_CALL_TRAMP_ADDR'
#define STATIC_CALL_TRAMP_ADDR(name) &STATIC_CALL_TRAMP(name)
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:257:1: note: expanded from here
__SCT__preempt_schedule_notrace
^
kernel/sched/core.c:6584:3: error: use of undeclared identifier '__SCT__preempt_schedule'
static_call_update(preempt_schedule, NULL);
^
include/linux/static_call.h:154:10: note: expanded from macro 'static_call_update'
typeof(&STATIC_CALL_TRAMP(name)) __F = (func); \
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:11:1: note: expanded from here
__SCT__preempt_schedule
^
kernel/sched/core.c:6584:3: error: use of undeclared identifier '__SCK__preempt_schedule'
include/linux/static_call.h:155:24: note: expanded from macro 'static_call_update'
__static_call_update(&STATIC_CALL_KEY(name), \
^
include/linux/static_call_types.h:12:32: note: expanded from macro 'STATIC_CALL_KEY'
#define STATIC_CALL_KEY(name) __PASTE(STATIC_CALL_KEY_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:12:1: note: expanded from here
__SCK__preempt_schedule
^
kernel/sched/core.c:6584:3: error: use of undeclared identifier '__SCT__preempt_schedule'
include/linux/static_call.h:156:9: note: expanded from macro 'static_call_update'
STATIC_CALL_TRAMP_ADDR(name), __F); \
^
include/linux/static_call.h:146:39: note: expanded from macro 'STATIC_CALL_TRAMP_ADDR'
#define STATIC_CALL_TRAMP_ADDR(name) &STATIC_CALL_TRAMP(name)
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:13:1: note: expanded from here
__SCT__preempt_schedule
^
kernel/sched/core.c:6585:3: error: use of undeclared identifier '__SCT__preempt_schedule_notrace'
static_call_update(preempt_schedule_notrace, NULL);
^
include/linux/static_call.h:154:10: note: expanded from macro 'static_call_update'
typeof(&STATIC_CALL_TRAMP(name)) __F = (func); \
^
include/linux/static_call_types.h:18:34: note: expanded from macro 'STATIC_CALL_TRAMP'
#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:14:1: note: expanded from here
__SCT__preempt_schedule_notrace
^
kernel/sched/core.c:6585:3: error: use of undeclared identifier '__SCK__preempt_schedule_notrace'
include/linux/static_call.h:155:24: note: expanded from macro 'static_call_update'
__static_call_update(&STATIC_CALL_KEY(name), \
^
include/linux/static_call_types.h:12:32: note: expanded from macro 'STATIC_CALL_KEY'
#define STATIC_CALL_KEY(name) __PASTE(STATIC_CALL_KEY_PREFIX, name)
^
include/linux/compiler_types.h:60:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:59:23: note: expanded from macro '___PASTE'
vim +/__SCT__preempt_schedule +6576 kernel/sched/core.c
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6567
1011dcce99f802 Peter Zijlstra 2021-03-25 6568 void sched_dynamic_update(int mode)
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6569) {
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6570 /*
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6571 * Avoid {NONE,VOLUNTARY} -> FULL transitions from ever ending up in
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6572 * the ZERO state, which is invalid.
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6573 */
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6574 static_call_update(cond_resched, __cond_resched);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6575 static_call_update(might_resched, __cond_resched);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 @6576 static_call_update(preempt_schedule, __preempt_schedule_func);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 @6577 static_call_update(preempt_schedule_notrace, __preempt_schedule_notrace_func);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6578 static_call_update(irqentry_exit_cond_resched, irqentry_exit_cond_resched);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6579
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6580 switch (mode) {
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6581 case preempt_dynamic_none:
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6582) static_call_update(cond_resched, __cond_resched);
9432bbd969c667 Peter Zijlstra 2021-03-23 6583 static_call_update(might_resched, (void *)&__static_call_return0);
9432bbd969c667 Peter Zijlstra 2021-03-23 6584 static_call_update(preempt_schedule, NULL);
9432bbd969c667 Peter Zijlstra 2021-03-23 6585 static_call_update(preempt_schedule_notrace, NULL);
9432bbd969c667 Peter Zijlstra 2021-03-23 6586 static_call_update(irqentry_exit_cond_resched, NULL);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6587 pr_info("Dynamic Preempt: none\n");
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6588 break;
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6589
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6590 case preempt_dynamic_voluntary:
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6591) static_call_update(cond_resched, __cond_resched);
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6592) static_call_update(might_resched, __cond_resched);
9432bbd969c667 Peter Zijlstra 2021-03-23 6593 static_call_update(preempt_schedule, NULL);
9432bbd969c667 Peter Zijlstra 2021-03-23 6594 static_call_update(preempt_schedule_notrace, NULL);
9432bbd969c667 Peter Zijlstra 2021-03-23 6595 static_call_update(irqentry_exit_cond_resched, NULL);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6596 pr_info("Dynamic Preempt: voluntary\n");
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6597 break;
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6598
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6599 case preempt_dynamic_full:
9432bbd969c667 Peter Zijlstra 2021-03-23 6600 static_call_update(cond_resched, (void *)&__static_call_return0);
9432bbd969c667 Peter Zijlstra 2021-03-23 6601 static_call_update(might_resched, (void *)&__static_call_return0);
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6602) static_call_update(preempt_schedule, __preempt_schedule_func);
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6603) static_call_update(preempt_schedule_notrace, __preempt_schedule_notrace_func);
826bfeb37bb430 Peter Zijlstra (Intel 2021-01-18 6604) static_call_update(irqentry_exit_cond_resched, irqentry_exit_cond_resched);
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6605 pr_info("Dynamic Preempt: full\n");
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6606 break;
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6607 }
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6608
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6609 preempt_dynamic_mode = mode;
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6610 }
e59e10f8ef63d4 Peter Zijlstra 2021-01-22 6611
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32514 bytes --]
next prev parent reply other threads:[~2021-11-06 5:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 10:40 [PATCH] sched: Tweak default dynamic preempt mode selection Valentin Schneider
2021-11-06 4:40 ` Mike Galbraith
2021-11-08 11:17 ` Valentin Schneider
2021-11-08 12:27 ` Mike Galbraith
2021-11-08 15:21 ` Valentin Schneider
2021-11-09 5:30 ` Mike Galbraith
2021-11-09 9:52 ` Valentin Schneider
2021-11-09 11:00 ` Mike Galbraith
2021-11-09 12:19 ` Valentin Schneider
2021-11-09 13:31 ` Mike Galbraith
2021-11-06 5:05 ` kernel test robot [this message]
2021-11-06 5:05 ` kernel test robot
2021-11-08 12:00 ` Valentin Schneider
2021-11-08 12:00 ` Valentin Schneider
2021-11-06 5:33 ` kernel test robot
2021-11-06 5:33 ` kernel test robot
2021-11-06 7:58 ` kernel test robot
2021-11-06 7:58 ` kernel test robot
2021-11-09 10:25 ` Frederic Weisbecker
2021-11-10 0:03 ` Valentin Schneider
2021-11-10 5:44 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111061341.QdauxAuH-lkp@intel.com \
--to=lkp@intel.com \
--cc=frederic@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.