All of lore.kernel.org
 help / color / mirror / Atom feed
* [hnaz-mm:master 284/435] mm/damon/dbgfs.c:525 dbgfs_init_regions_write() warn: passing a valid pointer to 'PTR_ERR'
@ 2021-11-06  8:13 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-11-06  8:13 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3043 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: SeongJae Park <sj@kernel.org>
CC: Johannes Weiner <hannes@cmpxchg.org>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>

tree:   https://github.com/hnaz/linux-mm master
head:   b8280145cf2a894c873fdf91fb2af474c52ac6cc
commit: 378cb366cfd7c3c4aa7ec42382795cd7f0a69a9f [284/435] mm/damon/dbgfs: allow users to set initial monitoring target regions
:::::: branch date: 9 days ago
:::::: commit date: 9 days ago
config: microblaze-randconfig-m031-20211104 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
mm/damon/dbgfs.c:525 dbgfs_init_regions_write() warn: passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +525 mm/damon/dbgfs.c

378cb366cfd7c3 SeongJae Park 2021-10-28  513  
378cb366cfd7c3 SeongJae Park 2021-10-28  514  static ssize_t dbgfs_init_regions_write(struct file *file,
378cb366cfd7c3 SeongJae Park 2021-10-28  515  					  const char __user *buf, size_t count,
378cb366cfd7c3 SeongJae Park 2021-10-28  516  					  loff_t *ppos)
378cb366cfd7c3 SeongJae Park 2021-10-28  517  {
378cb366cfd7c3 SeongJae Park 2021-10-28  518  	struct damon_ctx *ctx = file->private_data;
378cb366cfd7c3 SeongJae Park 2021-10-28  519  	char *kbuf;
378cb366cfd7c3 SeongJae Park 2021-10-28  520  	ssize_t ret = count;
378cb366cfd7c3 SeongJae Park 2021-10-28  521  	int err;
378cb366cfd7c3 SeongJae Park 2021-10-28  522  
378cb366cfd7c3 SeongJae Park 2021-10-28  523  	kbuf = user_input_str(buf, count, ppos);
378cb366cfd7c3 SeongJae Park 2021-10-28  524  	if (IS_ERR(kbuf))
378cb366cfd7c3 SeongJae Park 2021-10-28 @525  		return PTR_ERR(kbuf);
378cb366cfd7c3 SeongJae Park 2021-10-28  526  
378cb366cfd7c3 SeongJae Park 2021-10-28  527  	mutex_lock(&ctx->kdamond_lock);
378cb366cfd7c3 SeongJae Park 2021-10-28  528  	if (ctx->kdamond) {
378cb366cfd7c3 SeongJae Park 2021-10-28  529  		ret = -EBUSY;
378cb366cfd7c3 SeongJae Park 2021-10-28  530  		goto unlock_out;
378cb366cfd7c3 SeongJae Park 2021-10-28  531  	}
378cb366cfd7c3 SeongJae Park 2021-10-28  532  
378cb366cfd7c3 SeongJae Park 2021-10-28  533  	err = set_init_regions(ctx, kbuf, ret);
378cb366cfd7c3 SeongJae Park 2021-10-28  534  	if (err)
378cb366cfd7c3 SeongJae Park 2021-10-28  535  		ret = err;
378cb366cfd7c3 SeongJae Park 2021-10-28  536  
378cb366cfd7c3 SeongJae Park 2021-10-28  537  unlock_out:
378cb366cfd7c3 SeongJae Park 2021-10-28  538  	mutex_unlock(&ctx->kdamond_lock);
378cb366cfd7c3 SeongJae Park 2021-10-28  539  	kfree(kbuf);
378cb366cfd7c3 SeongJae Park 2021-10-28  540  	return ret;
378cb366cfd7c3 SeongJae Park 2021-10-28  541  }
378cb366cfd7c3 SeongJae Park 2021-10-28  542  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34682 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [hnaz-mm:master 284/435] mm/damon/dbgfs.c:525 dbgfs_init_regions_write() warn: passing a valid pointer to 'PTR_ERR'
@ 2021-11-11 22:36 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-11-11 22:36 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3075 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: SeongJae Park <sj@kernel.org>
CC: Johannes Weiner <hannes@cmpxchg.org>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>

tree:   https://github.com/hnaz/linux-mm master
head:   b8280145cf2a894c873fdf91fb2af474c52ac6cc
commit: 378cb366cfd7c3c4aa7ec42382795cd7f0a69a9f [284/435] mm/damon/dbgfs: allow users to set initial monitoring target regions
:::::: branch date: 2 weeks ago
:::::: commit date: 2 weeks ago
config: microblaze-randconfig-m031-20211104 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
mm/damon/dbgfs.c:525 dbgfs_init_regions_write() warn: passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +525 mm/damon/dbgfs.c

378cb366cfd7c3c SeongJae Park 2021-10-28  513  
378cb366cfd7c3c SeongJae Park 2021-10-28  514  static ssize_t dbgfs_init_regions_write(struct file *file,
378cb366cfd7c3c SeongJae Park 2021-10-28  515  					  const char __user *buf, size_t count,
378cb366cfd7c3c SeongJae Park 2021-10-28  516  					  loff_t *ppos)
378cb366cfd7c3c SeongJae Park 2021-10-28  517  {
378cb366cfd7c3c SeongJae Park 2021-10-28  518  	struct damon_ctx *ctx = file->private_data;
378cb366cfd7c3c SeongJae Park 2021-10-28  519  	char *kbuf;
378cb366cfd7c3c SeongJae Park 2021-10-28  520  	ssize_t ret = count;
378cb366cfd7c3c SeongJae Park 2021-10-28  521  	int err;
378cb366cfd7c3c SeongJae Park 2021-10-28  522  
378cb366cfd7c3c SeongJae Park 2021-10-28  523  	kbuf = user_input_str(buf, count, ppos);
378cb366cfd7c3c SeongJae Park 2021-10-28  524  	if (IS_ERR(kbuf))
378cb366cfd7c3c SeongJae Park 2021-10-28 @525  		return PTR_ERR(kbuf);
378cb366cfd7c3c SeongJae Park 2021-10-28  526  
378cb366cfd7c3c SeongJae Park 2021-10-28  527  	mutex_lock(&ctx->kdamond_lock);
378cb366cfd7c3c SeongJae Park 2021-10-28  528  	if (ctx->kdamond) {
378cb366cfd7c3c SeongJae Park 2021-10-28  529  		ret = -EBUSY;
378cb366cfd7c3c SeongJae Park 2021-10-28  530  		goto unlock_out;
378cb366cfd7c3c SeongJae Park 2021-10-28  531  	}
378cb366cfd7c3c SeongJae Park 2021-10-28  532  
378cb366cfd7c3c SeongJae Park 2021-10-28  533  	err = set_init_regions(ctx, kbuf, ret);
378cb366cfd7c3c SeongJae Park 2021-10-28  534  	if (err)
378cb366cfd7c3c SeongJae Park 2021-10-28  535  		ret = err;
378cb366cfd7c3c SeongJae Park 2021-10-28  536  
378cb366cfd7c3c SeongJae Park 2021-10-28  537  unlock_out:
378cb366cfd7c3c SeongJae Park 2021-10-28  538  	mutex_unlock(&ctx->kdamond_lock);
378cb366cfd7c3c SeongJae Park 2021-10-28  539  	kfree(kbuf);
378cb366cfd7c3c SeongJae Park 2021-10-28  540  	return ret;
378cb366cfd7c3c SeongJae Park 2021-10-28  541  }
378cb366cfd7c3c SeongJae Park 2021-10-28  542  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34682 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-11 22:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-06  8:13 [hnaz-mm:master 284/435] mm/damon/dbgfs.c:525 dbgfs_init_regions_write() warn: passing a valid pointer to 'PTR_ERR' kernel test robot
2021-11-11 22:36 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.