All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/softhsm2: needs threads
@ 2021-11-07  9:52 Fabrice Fontaine
  2021-11-07 20:21 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2021-11-07  9:52 UTC (permalink / raw)
  To: buildroot; +Cc: José Pekkarinen, Fabrice Fontaine

softhsm2 needs threads since the addition of the package in commit
53873b6daecd2a97740833cae7c5b4cdb185a6b2 to avoid the following build
failure:

osmutex.cpp:240:2: error: #error "There are no mutex implementations for your operating system yet"
  240 | #error "There are no mutex implementations for your operating system yet"
      |  ^~~~~

While at it, fix a typo in comment

Fixes:
 - http://autobuild.buildroot.org/results/40a8c2d9f58fbe490b6832754fdf8ac4ee0804fc

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/softhsm2/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/softhsm2/Config.in b/package/softhsm2/Config.in
index 58f3e3086e..78fccc9512 100644
--- a/package/softhsm2/Config.in
+++ b/package/softhsm2/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_SOFTHSM2
 	bool "softhsm2"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS # dlopen()
 	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
@@ -14,6 +15,7 @@ config BR2_PACKAGE_SOFTHSM2
 
 	  https://www.opendnssec.org/softhsm
 
-comment "sofhsm2 needs a toolchain w/ C++, gcc >= 4.8 and dynamic library support"
+comment "softhsm2 needs a toolchain w/ C++, threads, gcc >= 4.8 and dynamic library support"
 	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || \
+		!BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/softhsm2: needs threads
  2021-11-07  9:52 [Buildroot] [PATCH 1/1] package/softhsm2: needs threads Fabrice Fontaine
@ 2021-11-07 20:21 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2021-11-07 20:21 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: José Pekkarinen, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > softhsm2 needs threads since the addition of the package in commit
 > 53873b6daecd2a97740833cae7c5b4cdb185a6b2 to avoid the following build
 > failure:

 > osmutex.cpp:240:2: error: #error "There are no mutex implementations for your operating system yet"
 >   240 | #error "There are no mutex implementations for your operating system yet"
 >       |  ^~~~~

 > While at it, fix a typo in comment

 > Fixes:
 >  - http://autobuild.buildroot.org/results/40a8c2d9f58fbe490b6832754fdf8ac4ee0804fc

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-07 20:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-07  9:52 [Buildroot] [PATCH 1/1] package/softhsm2: needs threads Fabrice Fontaine
2021-11-07 20:21 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.