All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57
@ 2021-11-07 19:29 Romain Naour
  2021-11-07 19:29 ` [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag Romain Naour
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Romain Naour @ 2021-11-07 19:29 UTC (permalink / raw)
  To: buildroot; +Cc: Romain Naour

When booting with cortex-a53, qemu refuse to start with the following message [1]:

  qemu-system-aarch64: sbsa-ref: CPU type other than the built-in cortex-a57 not supported

Use ARM cortex a57 as requested by Qemu.

[1] https://git.qemu.org/?p=qemu.git;a=commitdiff;h=64580903c2b3aee08d74d64e6248a313b246cb69

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Dick Olsson <hi@senzilla.io>
---
 board/qemu/aarch64-sbsa/readme.txt  | 2 +-
 configs/qemu_aarch64_sbsa_defconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/qemu/aarch64-sbsa/readme.txt b/board/qemu/aarch64-sbsa/readme.txt
index 7935108ef1..b62947f55f 100644
--- a/board/qemu/aarch64-sbsa/readme.txt
+++ b/board/qemu/aarch64-sbsa/readme.txt
@@ -17,7 +17,7 @@ Run the emulation with:
 
   qemu-system-aarch64 \
     -M sbsa-ref \
-    -cpu cortex-a53 \
+    -cpu cortex-a57 \
     -smp 4 \
     -m 1024 \
     -nographic \
diff --git a/configs/qemu_aarch64_sbsa_defconfig b/configs/qemu_aarch64_sbsa_defconfig
index 0e1c799b4d..d1e0adadd1 100644
--- a/configs/qemu_aarch64_sbsa_defconfig
+++ b/configs/qemu_aarch64_sbsa_defconfig
@@ -1,6 +1,6 @@
 # Architecture
 BR2_aarch64=y
-BR2_cortex_a53=y
+BR2_cortex_a57=y
 
 # Toolchain
 BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
-- 
2.31.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag
  2021-11-07 19:29 [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57 Romain Naour
@ 2021-11-07 19:29 ` Romain Naour
  2021-11-07 21:31   ` D. Olsson via buildroot
                     ` (2 more replies)
  2021-11-07 21:25 ` [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57 D. Olsson via buildroot
  2021-11-09 10:48 ` Peter Korsgaard
  2 siblings, 3 replies; 10+ messages in thread
From: Romain Naour @ 2021-11-07 19:29 UTC (permalink / raw)
  To: buildroot; +Cc: Romain Naour

Enable the runtime testing by adding the tag in the readme.txt

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Dick Olsson <hi@senzilla.io>
---
The gitlab job needs more that 3h to build and execute the test:
https://gitlab.com/kubu93/buildroot/-/jobs/1755899154
Tested locally using the Buildroot docker image.

I'm not sure about the comment about SeaBIOS package, the test works
fine with the current host-qemu (6.1.0).
---
 board/qemu/aarch64-sbsa/readme.txt  | 2 +-
 configs/qemu_aarch64_sbsa_defconfig | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/board/qemu/aarch64-sbsa/readme.txt b/board/qemu/aarch64-sbsa/readme.txt
index b62947f55f..cf5f66d4d6 100644
--- a/board/qemu/aarch64-sbsa/readme.txt
+++ b/board/qemu/aarch64-sbsa/readme.txt
@@ -23,7 +23,7 @@ Run the emulation with:
     -nographic \
     -pflash output/images/SBSA_FLASH0.fd \
     -pflash output/images/SBSA_FLASH1.fd \
-    -hda output/images/disk.img
+    -hda output/images/disk.img # qemu_aarch64_sbsa_defconfig
 
 Note that if you want to run sbsa-ref emulation with QEMU provided by
 your distro (i.e., not host-qemu by Buildroot) then you may need to
diff --git a/configs/qemu_aarch64_sbsa_defconfig b/configs/qemu_aarch64_sbsa_defconfig
index d1e0adadd1..e7d3bd03ca 100644
--- a/configs/qemu_aarch64_sbsa_defconfig
+++ b/configs/qemu_aarch64_sbsa_defconfig
@@ -16,8 +16,8 @@ BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_TARGET_ROOTFS_EXT2_SIZE="128M"
 
 # Image
-BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/aarch64-sbsa/assemble-flash-images support/scripts/genimage.sh"
-BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/qemu/aarch64-sbsa/genimage.cfg"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/post-image.sh board/qemu/aarch64-sbsa/assemble-flash-images support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG) -c board/qemu/aarch64-sbsa/genimage.cfg"
 
 # Linux headers same as kernel
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
-- 
2.31.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57
  2021-11-07 19:29 [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57 Romain Naour
  2021-11-07 19:29 ` [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag Romain Naour
@ 2021-11-07 21:25 ` D. Olsson via buildroot
  2021-11-07 22:12   ` Romain Naour
  2021-11-09 10:48 ` Peter Korsgaard
  2 siblings, 1 reply; 10+ messages in thread
From: D. Olsson via buildroot @ 2021-11-07 21:25 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot


[-- Attachment #1.1: Type: text/plain, Size: 1840 bytes --]

Hi Romain,

Resending my review because I didn't reply to all :)

> On 7 Nov 2021, at 20:29, Romain Naour <romain.naour@gmail.com> wrote:
> 
> When booting with cortex-a53, qemu refuse to start with the following message [1]:
> 
>  qemu-system-aarch64: sbsa-ref: CPU type other than the built-in cortex-a57 not supported

Thanks for catching this! Looks like removal of a53 support is a fairly recent change in QEMU: https://github.com/qemu/qemu/commit/4f335a6381f83beb5d6ac0d3993514379454a99d#diff-8efb73c3e0dd9d7a13b0597a056b4cd8fa9d9250c7de8b1d3b538d07d98a8c50

> Use ARM cortex a57 as requested by Qemu.
> 
> [1] https://git.qemu.org/?p=qemu.git;a=commitdiff;h=64580903c2b3aee08d74d64e6248a313b246cb69
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Dick Olsson <hi@senzilla.io>
> ---
> board/qemu/aarch64-sbsa/readme.txt  | 2 +-
> configs/qemu_aarch64_sbsa_defconfig | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/qemu/aarch64-sbsa/readme.txt b/board/qemu/aarch64-sbsa/readme.txt
> index 7935108ef1..b62947f55f 100644
> --- a/board/qemu/aarch64-sbsa/readme.txt
> +++ b/board/qemu/aarch64-sbsa/readme.txt
> @@ -17,7 +17,7 @@ Run the emulation with:
> 
>   qemu-system-aarch64 \
>     -M sbsa-ref \
> -    -cpu cortex-a53 \
> +    -cpu cortex-a57 \
>     -smp 4 \
>     -m 1024 \
>     -nographic \
> diff --git a/configs/qemu_aarch64_sbsa_defconfig b/configs/qemu_aarch64_sbsa_defconfig
> index 0e1c799b4d..d1e0adadd1 100644
> --- a/configs/qemu_aarch64_sbsa_defconfig
> +++ b/configs/qemu_aarch64_sbsa_defconfig
> @@ -1,6 +1,6 @@
> # Architecture
> BR2_aarch64=y
> -BR2_cortex_a53=y
> +BR2_cortex_a57=y
> 
> # Toolchain
> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> -- 
> 2.31.1

Looks good!

Reviewed-by: Dick Olsson <hi@senzilla.io>


[-- Attachment #1.2: Type: text/html, Size: 3285 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag
  2021-11-07 19:29 ` [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag Romain Naour
@ 2021-11-07 21:31   ` D. Olsson via buildroot
  2021-11-07 22:18     ` Romain Naour
  2021-11-08  9:59   ` Yann E. MORIN
  2021-11-09 10:48   ` Peter Korsgaard
  2 siblings, 1 reply; 10+ messages in thread
From: D. Olsson via buildroot @ 2021-11-07 21:31 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

Hi Romain,

> On 7 Nov 2021, at 20:29, Romain Naour <romain.naour@gmail.com> wrote:
> 
> Enable the runtime testing by adding the tag in the readme.txt
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Dick Olsson <hi@senzilla.io>
> ---
> The gitlab job needs more that 3h to build and execute the test:
> https://gitlab.com/kubu93/buildroot/-/jobs/1755899154
> Tested locally using the Buildroot docker image.
> 
> I'm not sure about the comment about SeaBIOS package, the test works
> fine with the current host-qemu (6.1.0).

Right, host-qemu works great! My CI setup has to rely on qemu packed by Debian, however. And if I recall correctly I ran into some display or VGA related issues with qemu from Debian for the sbsa machine. It was resolved by installing seabios because it adds some drivers to qemu.

It's probably a good idea to leave the comment there for others who might run into the same issue.

> ---
> board/qemu/aarch64-sbsa/readme.txt  | 2 +-
> configs/qemu_aarch64_sbsa_defconfig | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/board/qemu/aarch64-sbsa/readme.txt b/board/qemu/aarch64-sbsa/readme.txt
> index b62947f55f..cf5f66d4d6 100644
> --- a/board/qemu/aarch64-sbsa/readme.txt
> +++ b/board/qemu/aarch64-sbsa/readme.txt
> @@ -23,7 +23,7 @@ Run the emulation with:
>     -nographic \
>     -pflash output/images/SBSA_FLASH0.fd \
>     -pflash output/images/SBSA_FLASH1.fd \
> -    -hda output/images/disk.img
> +    -hda output/images/disk.img # qemu_aarch64_sbsa_defconfig
> 
> Note that if you want to run sbsa-ref emulation with QEMU provided by
> your distro (i.e., not host-qemu by Buildroot) then you may need to
> diff --git a/configs/qemu_aarch64_sbsa_defconfig b/configs/qemu_aarch64_sbsa_defconfig
> index d1e0adadd1..e7d3bd03ca 100644
> --- a/configs/qemu_aarch64_sbsa_defconfig
> +++ b/configs/qemu_aarch64_sbsa_defconfig
> @@ -16,8 +16,8 @@ BR2_TARGET_ROOTFS_EXT2_4=y
> BR2_TARGET_ROOTFS_EXT2_SIZE="128M"
> 
> # Image
> -BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/aarch64-sbsa/assemble-flash-images support/scripts/genimage.sh"
> -BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/qemu/aarch64-sbsa/genimage.cfg"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/post-image.sh board/qemu/aarch64-sbsa/assemble-flash-images support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG) -c board/qemu/aarch64-sbsa/genimage.cfg"
> 
> # Linux headers same as kernel
> BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> -- 
> 2.31.1

Looks good!

Reviewed-by: Dick Olsson <hi@senzilla.io>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57
  2021-11-07 21:25 ` [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57 D. Olsson via buildroot
@ 2021-11-07 22:12   ` Romain Naour
  2021-11-08  9:59     ` Yann E. MORIN
  0 siblings, 1 reply; 10+ messages in thread
From: Romain Naour @ 2021-11-07 22:12 UTC (permalink / raw)
  To: D. Olsson; +Cc: buildroot

Hi Dick,

Le 07/11/2021 à 22:25, D. Olsson a écrit :
> Hi Romain,
> 
> Resending my review because I didn't reply to all :)
> 
>> On 7 Nov 2021, at 20:29, Romain Naour <romain.naour@gmail.com> wrote:
>>
>> When booting with cortex-a53, qemu refuse to start with the following message
>> [1]:
>>
>>  qemu-system-aarch64: sbsa-ref: CPU type other than the built-in cortex-a57
>> not supported
> 
> Thanks for catching this! Looks like removal of a53 support is a fairly recent
> change in
> QEMU: https://github.com/qemu/qemu/commit/4f335a6381f83beb5d6ac0d3993514379454a99d#diff-8efb73c3e0dd9d7a13b0597a056b4cd8fa9d9250c7de8b1d3b538d07d98a8c50
> <https://github.com/qemu/qemu/commit/4f335a6381f83beb5d6ac0d3993514379454a99d#diff-8efb73c3e0dd9d7a13b0597a056b4cd8fa9d9250c7de8b1d3b538d07d98a8c50>

Thanks for the link! Indeed the a53 support has been removed since qemu 6.0.

I was surprised by having this issue, It's a good reason to enable the gitlab
runtime testing in the following patch.

Best regards,
Romain


> 
>> Use ARM cortex a57 as requested by Qemu.
>>
>> [1]
>> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=64580903c2b3aee08d74d64e6248a313b246cb69
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> Cc: Dick Olsson <hi@senzilla.io>
>> ---
>> board/qemu/aarch64-sbsa/readme.txt  | 2 +-
>> configs/qemu_aarch64_sbsa_defconfig | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/board/qemu/aarch64-sbsa/readme.txt
>> b/board/qemu/aarch64-sbsa/readme.txt
>> index 7935108ef1..b62947f55f 100644
>> --- a/board/qemu/aarch64-sbsa/readme.txt
>> +++ b/board/qemu/aarch64-sbsa/readme.txt
>> @@ -17,7 +17,7 @@ Run the emulation with:
>>
>>   qemu-system-aarch64 \
>>     -M sbsa-ref \
>> -    -cpu cortex-a53 \
>> +    -cpu cortex-a57 \
>>     -smp 4 \
>>     -m 1024 \
>>     -nographic \
>> diff --git a/configs/qemu_aarch64_sbsa_defconfig
>> b/configs/qemu_aarch64_sbsa_defconfig
>> index 0e1c799b4d..d1e0adadd1 100644
>> --- a/configs/qemu_aarch64_sbsa_defconfig
>> +++ b/configs/qemu_aarch64_sbsa_defconfig
>> @@ -1,6 +1,6 @@
>> # Architecture
>> BR2_aarch64=y
>> -BR2_cortex_a53=y
>> +BR2_cortex_a57=y
>>
>> # Toolchain
>> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>> -- 
>> 2.31.1
> 
> Looks good!
> 
> Reviewed-by: Dick Olsson <hi@senzilla.io>
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag
  2021-11-07 21:31   ` D. Olsson via buildroot
@ 2021-11-07 22:18     ` Romain Naour
  0 siblings, 0 replies; 10+ messages in thread
From: Romain Naour @ 2021-11-07 22:18 UTC (permalink / raw)
  To: D. Olsson; +Cc: buildroot

Hi Dick,

Le 07/11/2021 à 22:31, D. Olsson a écrit :
> Hi Romain,
> 
>> On 7 Nov 2021, at 20:29, Romain Naour <romain.naour@gmail.com> wrote:
>>
>> Enable the runtime testing by adding the tag in the readme.txt
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> Cc: Dick Olsson <hi@senzilla.io>
>> ---
>> The gitlab job needs more that 3h to build and execute the test:
>> https://gitlab.com/kubu93/buildroot/-/jobs/1755899154
>> Tested locally using the Buildroot docker image.
>>
>> I'm not sure about the comment about SeaBIOS package, the test works
>> fine with the current host-qemu (6.1.0).
> 
> Right, host-qemu works great! My CI setup has to rely on qemu packed by Debian, however. And if I recall correctly I ran into some display or VGA related issues with qemu from Debian for the sbsa machine. It was resolved by installing seabios because it adds some drivers to qemu.

Indeed, the host-qemu is missing some important features (like the graphic
support) because it would require to enable host variant for some packages (like
sdl2).

> 
> It's probably a good idea to leave the comment there for others who might run into the same issue.
Ok to leave the comment as is.

Thanks for the review!

Best regards,
Romain


> 
>> ---
>> board/qemu/aarch64-sbsa/readme.txt  | 2 +-
>> configs/qemu_aarch64_sbsa_defconfig | 4 ++--
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/board/qemu/aarch64-sbsa/readme.txt b/board/qemu/aarch64-sbsa/readme.txt
>> index b62947f55f..cf5f66d4d6 100644
>> --- a/board/qemu/aarch64-sbsa/readme.txt
>> +++ b/board/qemu/aarch64-sbsa/readme.txt
>> @@ -23,7 +23,7 @@ Run the emulation with:
>>     -nographic \
>>     -pflash output/images/SBSA_FLASH0.fd \
>>     -pflash output/images/SBSA_FLASH1.fd \
>> -    -hda output/images/disk.img
>> +    -hda output/images/disk.img # qemu_aarch64_sbsa_defconfig
>>
>> Note that if you want to run sbsa-ref emulation with QEMU provided by
>> your distro (i.e., not host-qemu by Buildroot) then you may need to
>> diff --git a/configs/qemu_aarch64_sbsa_defconfig b/configs/qemu_aarch64_sbsa_defconfig
>> index d1e0adadd1..e7d3bd03ca 100644
>> --- a/configs/qemu_aarch64_sbsa_defconfig
>> +++ b/configs/qemu_aarch64_sbsa_defconfig
>> @@ -16,8 +16,8 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>> BR2_TARGET_ROOTFS_EXT2_SIZE="128M"
>>
>> # Image
>> -BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/aarch64-sbsa/assemble-flash-images support/scripts/genimage.sh"
>> -BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/qemu/aarch64-sbsa/genimage.cfg"
>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/post-image.sh board/qemu/aarch64-sbsa/assemble-flash-images support/scripts/genimage.sh"
>> +BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG) -c board/qemu/aarch64-sbsa/genimage.cfg"
>>
>> # Linux headers same as kernel
>> BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
>> -- 
>> 2.31.1
> 
> Looks good!
> 
> Reviewed-by: Dick Olsson <hi@senzilla.io>
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57
  2021-11-07 22:12   ` Romain Naour
@ 2021-11-08  9:59     ` Yann E. MORIN
  0 siblings, 0 replies; 10+ messages in thread
From: Yann E. MORIN @ 2021-11-08  9:59 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

Romain, Dick, All,

On 2021-11-07 23:12 +0100, Romain Naour spake thusly:
> Le 07/11/2021 à 22:25, D. Olsson a écrit :
> > Hi Romain,
> > 
> > Resending my review because I didn't reply to all :)
> > 
> >> On 7 Nov 2021, at 20:29, Romain Naour <romain.naour@gmail.com> wrote:
> >>
> >> When booting with cortex-a53, qemu refuse to start with the following message
> >> [1]:
> >>
> >>  qemu-system-aarch64: sbsa-ref: CPU type other than the built-in cortex-a57
> >> not supported
> > 
> > Thanks for catching this! Looks like removal of a53 support is a fairly recent
> > change in
> > QEMU: https://github.com/qemu/qemu/commit/4f335a6381f83beb5d6ac0d3993514379454a99d#diff-8efb73c3e0dd9d7a13b0597a056b4cd8fa9d9250c7de8b1d3b538d07d98a8c50
> > <https://github.com/qemu/qemu/commit/4f335a6381f83beb5d6ac0d3993514379454a99d#diff-8efb73c3e0dd9d7a13b0597a056b4cd8fa9d9250c7de8b1d3b538d07d98a8c50>
> 
> Thanks for the link! Indeed the a53 support has been removed since qemu 6.0.

Cortex-a53 has not been removed from qemu. It's just that it no longer
is a valid CPU for the sbsa-ref machine.

I've ammended the commit log with the info provided by Dick, and applied
to master, thanks.

Regards,
Yann E. MORIN.

> I was surprised by having this issue, It's a good reason to enable the gitlab
> runtime testing in the following patch.
> 
> Best regards,
> Romain
> 
> 
> > 
> >> Use ARM cortex a57 as requested by Qemu.
> >>
> >> [1]
> >> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=64580903c2b3aee08d74d64e6248a313b246cb69
> >>
> >> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> >> Cc: Dick Olsson <hi@senzilla.io>
> >> ---
> >> board/qemu/aarch64-sbsa/readme.txt  | 2 +-
> >> configs/qemu_aarch64_sbsa_defconfig | 2 +-
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/board/qemu/aarch64-sbsa/readme.txt
> >> b/board/qemu/aarch64-sbsa/readme.txt
> >> index 7935108ef1..b62947f55f 100644
> >> --- a/board/qemu/aarch64-sbsa/readme.txt
> >> +++ b/board/qemu/aarch64-sbsa/readme.txt
> >> @@ -17,7 +17,7 @@ Run the emulation with:
> >>
> >>   qemu-system-aarch64 \
> >>     -M sbsa-ref \
> >> -    -cpu cortex-a53 \
> >> +    -cpu cortex-a57 \
> >>     -smp 4 \
> >>     -m 1024 \
> >>     -nographic \
> >> diff --git a/configs/qemu_aarch64_sbsa_defconfig
> >> b/configs/qemu_aarch64_sbsa_defconfig
> >> index 0e1c799b4d..d1e0adadd1 100644
> >> --- a/configs/qemu_aarch64_sbsa_defconfig
> >> +++ b/configs/qemu_aarch64_sbsa_defconfig
> >> @@ -1,6 +1,6 @@
> >> # Architecture
> >> BR2_aarch64=y
> >> -BR2_cortex_a53=y
> >> +BR2_cortex_a57=y
> >>
> >> # Toolchain
> >> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> >> -- 
> >> 2.31.1
> > 
> > Looks good!
> > 
> > Reviewed-by: Dick Olsson <hi@senzilla.io>
> > 
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag
  2021-11-07 19:29 ` [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag Romain Naour
  2021-11-07 21:31   ` D. Olsson via buildroot
@ 2021-11-08  9:59   ` Yann E. MORIN
  2021-11-09 10:48   ` Peter Korsgaard
  2 siblings, 0 replies; 10+ messages in thread
From: Yann E. MORIN @ 2021-11-08  9:59 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

Romain, All,

On 2021-11-07 20:29 +0100, Romain Naour spake thusly:
> Enable the runtime testing by adding the tag in the readme.txt
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Dick Olsson <hi@senzilla.io>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> The gitlab job needs more that 3h to build and execute the test:
> https://gitlab.com/kubu93/buildroot/-/jobs/1755899154
> Tested locally using the Buildroot docker image.
> 
> I'm not sure about the comment about SeaBIOS package, the test works
> fine with the current host-qemu (6.1.0).
> ---
>  board/qemu/aarch64-sbsa/readme.txt  | 2 +-
>  configs/qemu_aarch64_sbsa_defconfig | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/board/qemu/aarch64-sbsa/readme.txt b/board/qemu/aarch64-sbsa/readme.txt
> index b62947f55f..cf5f66d4d6 100644
> --- a/board/qemu/aarch64-sbsa/readme.txt
> +++ b/board/qemu/aarch64-sbsa/readme.txt
> @@ -23,7 +23,7 @@ Run the emulation with:
>      -nographic \
>      -pflash output/images/SBSA_FLASH0.fd \
>      -pflash output/images/SBSA_FLASH1.fd \
> -    -hda output/images/disk.img
> +    -hda output/images/disk.img # qemu_aarch64_sbsa_defconfig
>  
>  Note that if you want to run sbsa-ref emulation with QEMU provided by
>  your distro (i.e., not host-qemu by Buildroot) then you may need to
> diff --git a/configs/qemu_aarch64_sbsa_defconfig b/configs/qemu_aarch64_sbsa_defconfig
> index d1e0adadd1..e7d3bd03ca 100644
> --- a/configs/qemu_aarch64_sbsa_defconfig
> +++ b/configs/qemu_aarch64_sbsa_defconfig
> @@ -16,8 +16,8 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>  BR2_TARGET_ROOTFS_EXT2_SIZE="128M"
>  
>  # Image
> -BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/aarch64-sbsa/assemble-flash-images support/scripts/genimage.sh"
> -BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/qemu/aarch64-sbsa/genimage.cfg"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/post-image.sh board/qemu/aarch64-sbsa/assemble-flash-images support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG) -c board/qemu/aarch64-sbsa/genimage.cfg"
>  
>  # Linux headers same as kernel
>  BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57
  2021-11-07 19:29 [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57 Romain Naour
  2021-11-07 19:29 ` [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag Romain Naour
  2021-11-07 21:25 ` [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57 D. Olsson via buildroot
@ 2021-11-09 10:48 ` Peter Korsgaard
  2 siblings, 0 replies; 10+ messages in thread
From: Peter Korsgaard @ 2021-11-09 10:48 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > When booting with cortex-a53, qemu refuse to start with the following message [1]:
 >   qemu-system-aarch64: sbsa-ref: CPU type other than the built-in cortex-a57 not supported

 > Use ARM cortex a57 as requested by Qemu.

 > [1] https://git.qemu.org/?p=qemu.git;a=commitdiff;h=64580903c2b3aee08d74d64e6248a313b246cb69

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > Cc: Dick Olsson <hi@senzilla.io>

Committed to 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag
  2021-11-07 19:29 ` [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag Romain Naour
  2021-11-07 21:31   ` D. Olsson via buildroot
  2021-11-08  9:59   ` Yann E. MORIN
@ 2021-11-09 10:48   ` Peter Korsgaard
  2 siblings, 0 replies; 10+ messages in thread
From: Peter Korsgaard @ 2021-11-09 10:48 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > Enable the runtime testing by adding the tag in the readme.txt
 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > Cc: Dick Olsson <hi@senzilla.io>
 > ---
 > The gitlab job needs more that 3h to build and execute the test:
 > https://gitlab.com/kubu93/buildroot/-/jobs/1755899154
 > Tested locally using the Buildroot docker image.

 > I'm not sure about the comment about SeaBIOS package, the test works
 > fine with the current host-qemu (6.1.0).

Committed to 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-11-09 10:48 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-07 19:29 [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57 Romain Naour
2021-11-07 19:29 ` [Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag Romain Naour
2021-11-07 21:31   ` D. Olsson via buildroot
2021-11-07 22:18     ` Romain Naour
2021-11-08  9:59   ` Yann E. MORIN
2021-11-09 10:48   ` Peter Korsgaard
2021-11-07 21:25 ` [Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57 D. Olsson via buildroot
2021-11-07 22:12   ` Romain Naour
2021-11-08  9:59     ` Yann E. MORIN
2021-11-09 10:48 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.