All of lore.kernel.org
 help / color / mirror / Atom feed
* [intel-lts:5.4/yocto 10445/18528] drivers/dma/dmaengine.c:603:18: warning: no previous prototype for function 'dma_get_slave_channel'
@ 2021-11-07 17:47 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-11-07 17:47 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 6431 bytes --]

Hi Geert,

FYI, the error/warning still remains.

tree:   https://github.com/intel/linux-intel-lts.git 5.4/yocto
head:   f74600f861eeb3536c7443943a3ce78a77c692dc
commit: de9c6920ba5aa70a57dfe39b7f99a9e287ac4c50 [10445/18528] dmaengine: Move dma_get_{,any_}slave_channel() to private dmaengine.h
config: x86_64-randconfig-a014-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 28981015526f2192440c18f18e8a20cd11b0779c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel/linux-intel-lts/commit/de9c6920ba5aa70a57dfe39b7f99a9e287ac4c50
        git remote add intel-lts https://github.com/intel/linux-intel-lts.git
        git fetch --no-tags intel-lts 5.4/yocto
        git checkout de9c6920ba5aa70a57dfe39b7f99a9e287ac4c50
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/dma/dmaengine.c:603:18: warning: no previous prototype for function 'dma_get_slave_channel' [-Wmissing-prototypes]
   struct dma_chan *dma_get_slave_channel(struct dma_chan *chan)
                    ^
   drivers/dma/dmaengine.c:603:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct dma_chan *dma_get_slave_channel(struct dma_chan *chan)
   ^
   static 
>> drivers/dma/dmaengine.c:634:18: warning: no previous prototype for function 'dma_get_any_slave_channel' [-Wmissing-prototypes]
   struct dma_chan *dma_get_any_slave_channel(struct dma_device *device)
                    ^
   drivers/dma/dmaengine.c:634:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct dma_chan *dma_get_any_slave_channel(struct dma_device *device)
   ^
   static 
   2 warnings generated.


vim +/dma_get_slave_channel +603 drivers/dma/dmaengine.c

7bd903c5ca47fd Peter Ujfalusi 2015-12-14  598  
59b5ec21446b92 Dan Williams   2009-01-06  599  /**
19d643d68bd678 Stefan Agner   2015-06-01  600   * dma_get_slave_channel - try to get specific channel exclusively
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  601   * @chan: target channel
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  602   */
7bb587f4eef8f7 Zhangfei Gao   2013-06-28 @603  struct dma_chan *dma_get_slave_channel(struct dma_chan *chan)
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  604  {
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  605  	int err = -EBUSY;
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  606  
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  607  	/* lock against __dma_request_channel */
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  608  	mutex_lock(&dma_list_mutex);
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  609  
d9a6c8f52d1039 Vinod Koul     2013-08-19  610  	if (chan->client_count == 0) {
214fc4e423ff38 Peter Ujfalusi 2015-09-24  611  		struct dma_device *device = chan->device;
214fc4e423ff38 Peter Ujfalusi 2015-09-24  612  
214fc4e423ff38 Peter Ujfalusi 2015-09-24  613  		dma_cap_set(DMA_PRIVATE, device->cap_mask);
214fc4e423ff38 Peter Ujfalusi 2015-09-24  614  		device->privatecnt++;
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  615  		err = dma_chan_get(chan);
214fc4e423ff38 Peter Ujfalusi 2015-09-24  616  		if (err) {
ef859312c3a16b Jarkko Nikula  2016-03-14  617  			dev_dbg(chan->device->dev,
ef859312c3a16b Jarkko Nikula  2016-03-14  618  				"%s: failed to get %s: (%d)\n",
d9a6c8f52d1039 Vinod Koul     2013-08-19  619  				__func__, dma_chan_name(chan), err);
214fc4e423ff38 Peter Ujfalusi 2015-09-24  620  			chan = NULL;
214fc4e423ff38 Peter Ujfalusi 2015-09-24  621  			if (--device->privatecnt == 0)
214fc4e423ff38 Peter Ujfalusi 2015-09-24  622  				dma_cap_clear(DMA_PRIVATE, device->cap_mask);
214fc4e423ff38 Peter Ujfalusi 2015-09-24  623  		}
d9a6c8f52d1039 Vinod Koul     2013-08-19  624  	} else
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  625  		chan = NULL;
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  626  
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  627  	mutex_unlock(&dma_list_mutex);
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  628  
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  629  
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  630  	return chan;
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  631  }
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  632  EXPORT_SYMBOL_GPL(dma_get_slave_channel);
7bb587f4eef8f7 Zhangfei Gao   2013-06-28  633  
8010dad55a0ab0 Stephen Warren 2013-11-26 @634  struct dma_chan *dma_get_any_slave_channel(struct dma_device *device)
8010dad55a0ab0 Stephen Warren 2013-11-26  635  {
8010dad55a0ab0 Stephen Warren 2013-11-26  636  	dma_cap_mask_t mask;
8010dad55a0ab0 Stephen Warren 2013-11-26  637  	struct dma_chan *chan;
8010dad55a0ab0 Stephen Warren 2013-11-26  638  
8010dad55a0ab0 Stephen Warren 2013-11-26  639  	dma_cap_zero(mask);
8010dad55a0ab0 Stephen Warren 2013-11-26  640  	dma_cap_set(DMA_SLAVE, mask);
8010dad55a0ab0 Stephen Warren 2013-11-26  641  
8010dad55a0ab0 Stephen Warren 2013-11-26  642  	/* lock against __dma_request_channel */
8010dad55a0ab0 Stephen Warren 2013-11-26  643  	mutex_lock(&dma_list_mutex);
8010dad55a0ab0 Stephen Warren 2013-11-26  644  
7bd903c5ca47fd Peter Ujfalusi 2015-12-14  645  	chan = find_candidate(device, &mask, NULL, NULL);
8010dad55a0ab0 Stephen Warren 2013-11-26  646  
8010dad55a0ab0 Stephen Warren 2013-11-26  647  	mutex_unlock(&dma_list_mutex);
8010dad55a0ab0 Stephen Warren 2013-11-26  648  
7bd903c5ca47fd Peter Ujfalusi 2015-12-14  649  	return IS_ERR(chan) ? NULL : chan;
8010dad55a0ab0 Stephen Warren 2013-11-26  650  }
8010dad55a0ab0 Stephen Warren 2013-11-26  651  EXPORT_SYMBOL_GPL(dma_get_any_slave_channel);
8010dad55a0ab0 Stephen Warren 2013-11-26  652  

:::::: The code at line 603 was first introduced by commit
:::::: 7bb587f4eef8f71ce589f360ab99bb54ab0fc85d dmaengine: add interface of dma_get_slave_channel

:::::: TO: Zhangfei Gao <zhangfei.gao@linaro.org>
:::::: CC: Vinod Koul <vinod.koul@intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27932 bytes --]

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2021-11-07 17:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-07 17:47 [intel-lts:5.4/yocto 10445/18528] drivers/dma/dmaengine.c:603:18: warning: no previous prototype for function 'dma_get_slave_channel' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.