From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Cc: Jisheng Zhang <jszhang@marvell.com>,
linux-pwm@vger.kernel.org, Thomas Hebb <tommyhebb@gmail.com>,
kernel@pengutronix.de
Subject: Re: [PATCH 2/4] pwm: berlin: Put channel config into driver data
Date: Mon, 8 Nov 2021 12:04:13 +0100 [thread overview]
Message-ID: <20211108110413.6kfe6fguabvgclnd@pengutronix.de> (raw)
In-Reply-To: <20210909141603.6u5p3dkgderru67x@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
Hello Thierry,
On Thu, Sep 09, 2021 at 04:16:03PM +0200, Uwe Kleine-König wrote:
> On Wed, Jun 30, 2021 at 08:18:04AM +0200, Uwe Kleine-König wrote:
> > On Tue, May 04, 2021 at 03:25:35PM +0200, Uwe Kleine-König wrote:
> > > Instead of allocating extra data in .request() provide the needed memory
> > > in struct berlin_pwm_chip. This reduces the number of allocations. A side
> > > effect is that on suspend and resume the state for all four channels is
> > > always saved and restored. This is easier (and probably quicker) than
> > > looking up the matching pwm_device and checking its PWMF_REQUESTED bit.
> >
> > I noticed you applied the other three patches in this series, but
> > skipped this one and marked it as rejected.
> >
> > Please point out what you don't like about this patch instead of just
> > dropping it without comment.
>
> Any news on this? I still consider the patch good and would like to know
> your objections.
This patch is still in my private working copy and I still don't know
why you rejected it. :-\
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-08 11:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 13:25 [PATCH 1/4] pwm: berlin: use consistent naming for variables Uwe Kleine-König
2021-05-04 13:25 ` [PATCH 2/4] pwm: berlin: Put channel config into driver data Uwe Kleine-König
2021-06-30 6:18 ` Uwe Kleine-König
2021-09-09 14:16 ` Uwe Kleine-König
2021-11-08 11:04 ` Uwe Kleine-König [this message]
2021-11-08 12:09 ` Thierry Reding
2021-11-08 13:08 ` Uwe Kleine-König
2021-05-04 13:25 ` [PATCH 3/4] pwm: berlin: Implement .apply() callback Uwe Kleine-König
2021-05-04 13:25 ` [PATCH 4/4] pwm: berlin: Don't check the return code of pwmchip_remove() Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211108110413.6kfe6fguabvgclnd@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=jszhang@marvell.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tommyhebb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.