From: Xuan Zhuo <xuanzhuo@linux.alibaba.com> To: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Cc: "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org> Subject: [PATCH v4 0/3] virtio support cache indirect desc Date: Mon, 8 Nov 2021 19:49:48 +0800 [thread overview] Message-ID: <20211108114951.92862-1-xuanzhuo@linux.alibaba.com> (raw) If the VIRTIO_RING_F_INDIRECT_DESC negotiation succeeds, and the number of sgs used for sending packets is greater than 1. We must constantly call __kmalloc/kfree to allocate/release desc. In the case of extremely fast package delivery, the overhead cannot be ignored: 27.46% [kernel] [k] virtqueue_add 16.66% [kernel] [k] detach_buf_split 16.51% [kernel] [k] virtnet_xsk_xmit 14.04% [kernel] [k] virtqueue_add_outbuf 5.18% [kernel] [k] __kmalloc 4.08% [kernel] [k] kfree 2.80% [kernel] [k] virtqueue_get_buf_ctx 2.22% [kernel] [k] xsk_tx_peek_desc 2.08% [kernel] [k] memset_erms 0.83% [kernel] [k] virtqueue_kick_prepare 0.76% [kernel] [k] virtnet_xsk_run 0.62% [kernel] [k] __free_old_xmit_ptr 0.60% [kernel] [k] vring_map_one_sg 0.53% [kernel] [k] native_apic_mem_write 0.46% [kernel] [k] sg_next 0.43% [kernel] [k] sg_init_table 0.41% [kernel] [k] kmalloc_slab This patch adds a cache function to virtio to cache these allocated indirect desc instead of constantly allocating and releasing desc. v4: 1. Only allow desc cache when VIRTIO_RING_F_INDIRECT_DESC negotiation is successful 2. The desc cache threshold can be set for each virtqueue v3: pre-allocate per buffer indirect descriptors array v2: use struct list_head to cache the desc Xuan Zhuo (3): virtio: cache indirect desc for split virtio: cache indirect desc for packed virtio-net: enable virtio desc cache drivers/net/virtio_net.c | 12 ++- drivers/virtio/virtio_ring.c | 152 +++++++++++++++++++++++++++++++---- include/linux/virtio.h | 17 ++++ 3 files changed, 163 insertions(+), 18 deletions(-) -- 2.31.0
WARNING: multiple messages have this Message-ID (diff)
From: Xuan Zhuo <xuanzhuo@linux.alibaba.com> To: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Cc: Jakub Kicinski <kuba@kernel.org>, "David S. Miller" <davem@davemloft.net>, "Michael S. Tsirkin" <mst@redhat.com> Subject: [PATCH v4 0/3] virtio support cache indirect desc Date: Mon, 8 Nov 2021 19:49:48 +0800 [thread overview] Message-ID: <20211108114951.92862-1-xuanzhuo@linux.alibaba.com> (raw) If the VIRTIO_RING_F_INDIRECT_DESC negotiation succeeds, and the number of sgs used for sending packets is greater than 1. We must constantly call __kmalloc/kfree to allocate/release desc. In the case of extremely fast package delivery, the overhead cannot be ignored: 27.46% [kernel] [k] virtqueue_add 16.66% [kernel] [k] detach_buf_split 16.51% [kernel] [k] virtnet_xsk_xmit 14.04% [kernel] [k] virtqueue_add_outbuf 5.18% [kernel] [k] __kmalloc 4.08% [kernel] [k] kfree 2.80% [kernel] [k] virtqueue_get_buf_ctx 2.22% [kernel] [k] xsk_tx_peek_desc 2.08% [kernel] [k] memset_erms 0.83% [kernel] [k] virtqueue_kick_prepare 0.76% [kernel] [k] virtnet_xsk_run 0.62% [kernel] [k] __free_old_xmit_ptr 0.60% [kernel] [k] vring_map_one_sg 0.53% [kernel] [k] native_apic_mem_write 0.46% [kernel] [k] sg_next 0.43% [kernel] [k] sg_init_table 0.41% [kernel] [k] kmalloc_slab This patch adds a cache function to virtio to cache these allocated indirect desc instead of constantly allocating and releasing desc. v4: 1. Only allow desc cache when VIRTIO_RING_F_INDIRECT_DESC negotiation is successful 2. The desc cache threshold can be set for each virtqueue v3: pre-allocate per buffer indirect descriptors array v2: use struct list_head to cache the desc Xuan Zhuo (3): virtio: cache indirect desc for split virtio: cache indirect desc for packed virtio-net: enable virtio desc cache drivers/net/virtio_net.c | 12 ++- drivers/virtio/virtio_ring.c | 152 +++++++++++++++++++++++++++++++---- include/linux/virtio.h | 17 ++++ 3 files changed, 163 insertions(+), 18 deletions(-) -- 2.31.0 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next reply other threads:[~2021-11-08 11:49 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-08 11:49 Xuan Zhuo [this message] 2021-11-08 11:49 ` [PATCH v4 0/3] virtio support cache indirect desc Xuan Zhuo 2021-11-08 11:49 ` [PATCH v4 1/3] virtio: cache indirect desc for split Xuan Zhuo 2021-11-08 11:49 ` Xuan Zhuo 2021-11-09 13:09 ` Michael S. Tsirkin 2021-11-09 13:09 ` Michael S. Tsirkin 2021-11-09 15:00 ` Xuan Zhuo 2021-11-08 11:49 ` [PATCH v4 2/3] virtio: cache indirect desc for packed Xuan Zhuo 2021-11-08 11:49 ` Xuan Zhuo 2021-11-08 11:49 ` [PATCH v4 3/3] virtio-net: enable virtio desc cache Xuan Zhuo 2021-11-08 11:49 ` Xuan Zhuo 2021-11-08 13:49 ` [PATCH v4 0/3] virtio support cache indirect desc Michael S. Tsirkin 2021-11-08 13:49 ` Michael S. Tsirkin 2021-11-08 14:47 ` Xuan Zhuo 2021-11-10 12:53 ` Michael S. Tsirkin 2021-11-10 12:53 ` Michael S. Tsirkin 2021-11-10 12:54 ` Michael S. Tsirkin 2021-11-10 12:54 ` Michael S. Tsirkin 2021-11-11 6:52 ` Xuan Zhuo 2021-11-11 15:02 ` Michael S. Tsirkin 2021-11-11 15:02 ` Michael S. Tsirkin 2021-11-12 1:53 ` Xuan Zhuo 2021-11-09 13:03 ` Michael S. Tsirkin 2021-11-09 13:03 ` Michael S. Tsirkin 2021-11-09 15:14 ` Xuan Zhuo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211108114951.92862-1-xuanzhuo@linux.alibaba.com \ --to=xuanzhuo@linux.alibaba.com \ --cc=davem@davemloft.net \ --cc=jasowang@redhat.com \ --cc=kuba@kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.