All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>,
	Lee Jones <lee.jones@linaro.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org,
	kernel@pengutronix.de
Subject: [PATCH 2/4] pwm: meson: Drop useless check for channel data being NULL
Date: Mon,  8 Nov 2021 14:46:25 +0100	[thread overview]
Message-ID: <20211108134628.120474-2-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20211108134628.120474-1-u.kleine-koenig@pengutronix.de>

In meson_pwm_free() the function pwm_get_chip_data() always returns a
non-NULL pointer because it's only called when the request callback
succeeded and this callback calls pwm_set_chip_data() in this case.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-meson.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
index be3c806b57e4..1fbe54a2abfe 100644
--- a/drivers/pwm/pwm-meson.c
+++ b/drivers/pwm/pwm-meson.c
@@ -148,8 +148,7 @@ static void meson_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
 {
 	struct meson_pwm_channel *channel = pwm_get_chip_data(pwm);
 
-	if (channel)
-		clk_disable_unprepare(channel->clk);
+	clk_disable_unprepare(channel->clk);
 }
 
 static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm,
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>,
	Lee Jones <lee.jones@linaro.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org,
	kernel@pengutronix.de
Subject: [PATCH 2/4] pwm: meson: Drop useless check for channel data being NULL
Date: Mon,  8 Nov 2021 14:46:25 +0100	[thread overview]
Message-ID: <20211108134628.120474-2-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20211108134628.120474-1-u.kleine-koenig@pengutronix.de>

In meson_pwm_free() the function pwm_get_chip_data() always returns a
non-NULL pointer because it's only called when the request callback
succeeded and this callback calls pwm_set_chip_data() in this case.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-meson.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
index be3c806b57e4..1fbe54a2abfe 100644
--- a/drivers/pwm/pwm-meson.c
+++ b/drivers/pwm/pwm-meson.c
@@ -148,8 +148,7 @@ static void meson_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
 {
 	struct meson_pwm_channel *channel = pwm_get_chip_data(pwm);
 
-	if (channel)
-		clk_disable_unprepare(channel->clk);
+	clk_disable_unprepare(channel->clk);
 }
 
 static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm,
-- 
2.30.2


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2021-11-08 13:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 13:46 [PATCH 1/4] pwm: meson: Drop always false check from .request() Uwe Kleine-König
2021-11-08 13:46 ` Uwe Kleine-König
2021-11-08 13:46 ` Uwe Kleine-König [this message]
2021-11-08 13:46   ` [PATCH 2/4] pwm: meson: Drop useless check for channel data being NULL Uwe Kleine-König
2021-11-20 23:34   ` Martin Blumenstingl
2021-11-20 23:34     ` Martin Blumenstingl
2021-11-08 13:46 ` [PATCH 3/4] pwm: meson: Simplify duplicated per-channel tracking Uwe Kleine-König
2021-11-08 13:46   ` Uwe Kleine-König
2021-11-20 23:35   ` Martin Blumenstingl
2021-11-20 23:35     ` Martin Blumenstingl
2021-11-08 13:46 ` [PATCH 4/4] pwm: meson: Drop always false check from .apply() Uwe Kleine-König
2021-11-08 13:46   ` Uwe Kleine-König
2021-11-20 23:35   ` Martin Blumenstingl
2021-11-20 23:35     ` Martin Blumenstingl
2021-11-20 23:34 ` [PATCH 1/4] pwm: meson: Drop always false check from .request() Martin Blumenstingl
2021-11-20 23:34   ` Martin Blumenstingl
2022-02-01  7:47 ` Thierry Reding
2022-02-01  7:47   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211108134628.120474-2-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=jbrunet@baylibre.com \
    --cc=kernel@pengutronix.de \
    --cc=khilman@baylibre.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.