* [PATCH for-4.16] tools/configure: make iPXE dependent on QEMU traditional
@ 2021-11-09 9:47 Roger Pau Monne
2021-11-09 10:52 ` Ian Jackson
0 siblings, 1 reply; 2+ messages in thread
From: Roger Pau Monne @ 2021-11-09 9:47 UTC (permalink / raw)
To: xen-devel; +Cc: Roger Pau Monne, Wei Liu, Andrew Cooper, Ian Jackson
iPXE is only used by QEMU traditional, so make it off by default
unless QEMU traditional is enabled.
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Fixes: bcf77ce510 ('configure: modify default of building rombios')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <iwj@xenproject.org>
Please run autoconf before commit.
Without this patch FreeBSD build is broken, as iPXE won't build. The
main risk would be getting the configure script runes wrong, but I
think that's fairly easy to check as it will either work on not. It's
a change in the defaults, but it basically restores the behavior
previous to disabling qemu-trad on Linux.
---
tools/configure.ac | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/configure.ac b/tools/configure.ac
index 03eb7cf146..3ac62626a5 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -130,13 +130,13 @@ AC_SUBST(qemu_traditional)
AC_ARG_ENABLE([ipxe],
AS_HELP_STRING([--enable-ipxe],
- [Enable in-tree IPXE, (DEFAULT is on for x86,
- otherwise off, see also --with-system-ipxe)]),,[
- case "$host_cpu" in
- i[[3456]]86|x86_64)
- enable_ipxe="yes";;
- *) enable_ipxe="no";;
- esac
+ [Enable in-tree IPXE,
+ (DEFAULT is off, see also --with-system-ipxe)]),,[
+ AS_IF([test "x$enable_qemu_traditional" = "xyes"], [
+ enable_ipxe="yes"
+ ], [
+ enable_ipxe="no"
+ ])
])
AS_IF([test "x$enable_ipxe" = "xno"], [ipxe=n], [ipxe=y])
AC_ARG_WITH([system-ipxe],
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH for-4.16] tools/configure: make iPXE dependent on QEMU traditional
2021-11-09 9:47 [PATCH for-4.16] tools/configure: make iPXE dependent on QEMU traditional Roger Pau Monne
@ 2021-11-09 10:52 ` Ian Jackson
0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2021-11-09 10:52 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Wei Liu, Andrew Cooper
Roger Pau Monne writes ("[PATCH for-4.16] tools/configure: make iPXE dependent on QEMU traditional"):
> iPXE is only used by QEMU traditional, so make it off by default
> unless QEMU traditional is enabled.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Fixes: bcf77ce510 ('configure: modify default of building rombios')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
This seems to me to be, effectively, a missing hunk from bcf77ce510.
I have stared at it and it looks right to me. I also looked at some
CI logs.
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
Ian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-09 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09 9:47 [PATCH for-4.16] tools/configure: make iPXE dependent on QEMU traditional Roger Pau Monne
2021-11-09 10:52 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.