* [PATCH] platform/x86: thinkpad_acpi: fix documentation for adaptive keyboard
@ 2021-11-09 19:52 Vincent Bernat
2021-11-11 9:45 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Vincent Bernat @ 2021-11-09 19:52 UTC (permalink / raw)
To: Henrique de Moraes Holschuh, ibm-acpi-devel, platform-driver-x86
Cc: Vincent Bernat
The different values were offset by 1. 0 is for "home mode", 1 for
"web-browser mode", etc. Moreover, the URL to the laptop's user guide
did not work anymore.
Signed-off-by: Vincent Bernat <vincent@bernat.ch>
---
Documentation/admin-guide/laptops/thinkpad-acpi.rst | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/admin-guide/laptops/thinkpad-acpi.rst b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
index 6721a80a2d4f..475eb0e81e4a 100644
--- a/Documentation/admin-guide/laptops/thinkpad-acpi.rst
+++ b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
@@ -1520,15 +1520,15 @@ This sysfs attribute controls the keyboard "face" that will be shown on the
Lenovo X1 Carbon 2nd gen (2014)'s adaptive keyboard. The value can be read
and set.
-- 1 = Home mode
-- 2 = Web-browser mode
-- 3 = Web-conference mode
-- 4 = Function mode
-- 5 = Layflat mode
+- 0 = Home mode
+- 1 = Web-browser mode
+- 2 = Web-conference mode
+- 3 = Function mode
+- 4 = Layflat mode
For more details about which buttons will appear depending on the mode, please
review the laptop's user guide:
-http://www.lenovo.com/shop/americas/content/user_guides/x1carbon_2_ug_en.pdf
+https://download.lenovo.com/ibmdl/pub/pc/pccbbs/mobiles_pdf/x1carbon_2_ug_en.pdf
Battery charge control
----------------------
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: thinkpad_acpi: fix documentation for adaptive keyboard
2021-11-09 19:52 [PATCH] platform/x86: thinkpad_acpi: fix documentation for adaptive keyboard Vincent Bernat
@ 2021-11-11 9:45 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-11-11 9:45 UTC (permalink / raw)
To: Vincent Bernat, Henrique de Moraes Holschuh, ibm-acpi-devel,
platform-driver-x86
Hi,
On 11/9/21 20:52, Vincent Bernat wrote:
> The different values were offset by 1. 0 is for "home mode", 1 for
> "web-browser mode", etc. Moreover, the URL to the laptop's user guide
> did not work anymore.
>
> Signed-off-by: Vincent Bernat <vincent@bernat.ch>
Thank you for this fix.
I will add this fix to my tree once 5.16-rc is out and
I will include this fix in my first pdx86 fixes pull-req
for 5.16.
Regards,
Hans
> ---
> Documentation/admin-guide/laptops/thinkpad-acpi.rst | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/admin-guide/laptops/thinkpad-acpi.rst b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> index 6721a80a2d4f..475eb0e81e4a 100644
> --- a/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> +++ b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> @@ -1520,15 +1520,15 @@ This sysfs attribute controls the keyboard "face" that will be shown on the
> Lenovo X1 Carbon 2nd gen (2014)'s adaptive keyboard. The value can be read
> and set.
>
> -- 1 = Home mode
> -- 2 = Web-browser mode
> -- 3 = Web-conference mode
> -- 4 = Function mode
> -- 5 = Layflat mode
> +- 0 = Home mode
> +- 1 = Web-browser mode
> +- 2 = Web-conference mode
> +- 3 = Function mode
> +- 4 = Layflat mode
>
> For more details about which buttons will appear depending on the mode, please
> review the laptop's user guide:
> -http://www.lenovo.com/shop/americas/content/user_guides/x1carbon_2_ug_en.pdf
> +https://download.lenovo.com/ibmdl/pub/pc/pccbbs/mobiles_pdf/x1carbon_2_ug_en.pdf
>
> Battery charge control
> ----------------------
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-11 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09 19:52 [PATCH] platform/x86: thinkpad_acpi: fix documentation for adaptive keyboard Vincent Bernat
2021-11-11 9:45 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.