All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/dsi: transmit brightness command in HS state
@ 2021-11-09  6:50 William Tseng
  2021-11-09  7:22 ` Jani Nikula
                   ` (8 more replies)
  0 siblings, 9 replies; 17+ messages in thread
From: William Tseng @ 2021-11-09  6:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: Cooper Chiou, William Tseng

In Video Mode, if DSI transcoder is set to transmit packets
in LP Escape mode, screen flickering would be obseved when
brightness commands are continuously and quickly transmitted
to a panel.

The problem may be resolved by changing the mode to transmit
packets from Low Power to HS.

Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Signed-off-by: William Tseng <william.tseng@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c b/drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c
index f61ed82e8867..a71ef1eb598c 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c
@@ -81,6 +81,7 @@ static void dcs_set_backlight(const struct drm_connector_state *conn_state, u32
 
 	for_each_dsi_port(port, intel_dsi->dcs_backlight_ports) {
 		dsi_device = intel_dsi->dsi_hosts[port]->device;
+		dsi_device->mode_flags &= ~MIPI_DSI_MODE_LPM;
 		mipi_dsi_dcs_write(dsi_device, MIPI_DCS_SET_DISPLAY_BRIGHTNESS,
 				   &data, len);
 	}
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2021-11-11 10:09 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09  6:50 [Intel-gfx] [PATCH] drm/i915/dsi: transmit brightness command in HS state William Tseng
2021-11-09  7:22 ` Jani Nikula
2021-11-09  8:23   ` Tseng, William
2021-11-09  7:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-09  8:24 ` [Intel-gfx] [PATCH v2] " William Tseng
2021-11-09 10:40   ` Jani Nikula
2021-11-10  1:01     ` Tseng, William
2021-11-10  1:02   ` [Intel-gfx] [PATCH v3] " William Tseng
2021-11-10 10:44     ` Jani Nikula
2021-11-11  1:14       ` Tseng, William
2021-11-11 10:09         ` Jani Nikula
2021-11-09  9:10 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2021-11-09 10:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: transmit brightness command in HS state (rev2) Patchwork
2021-11-09 12:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-11-10  2:21 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: transmit brightness command in HS state (rev3) Patchwork
2021-11-10 15:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: transmit brightness command in HS state (rev4) Patchwork
2021-11-10 18:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.