* [PATCH v3 0/1] Mediatek pinctrl patch
@ 2021-11-10 2:14 ` Zhiyong Tao
0 siblings, 0 replies; 11+ messages in thread
From: Zhiyong Tao @ 2021-11-10 2:14 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio
This series includes 1 patches:
1. fix global-out-of-bounds issue.
Changes in patch v3:
1. keep original patch author
2. fix version issue.
Changes in patch v2:
1. change check eint number boundary condition.
Guodong Liu (1):
pinctrl: mediatek: fix global-out-of-bounds issue
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
2.18.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3 0/1] Mediatek pinctrl patch
@ 2021-11-10 2:14 ` Zhiyong Tao
0 siblings, 0 replies; 11+ messages in thread
From: Zhiyong Tao @ 2021-11-10 2:14 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio
This series includes 1 patches:
1. fix global-out-of-bounds issue.
Changes in patch v3:
1. keep original patch author
2. fix version issue.
Changes in patch v2:
1. change check eint number boundary condition.
Guodong Liu (1):
pinctrl: mediatek: fix global-out-of-bounds issue
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3 0/1] Mediatek pinctrl patch
@ 2021-11-10 2:14 ` Zhiyong Tao
0 siblings, 0 replies; 11+ messages in thread
From: Zhiyong Tao @ 2021-11-10 2:14 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio
This series includes 1 patches:
1. fix global-out-of-bounds issue.
Changes in patch v3:
1. keep original patch author
2. fix version issue.
Changes in patch v2:
1. change check eint number boundary condition.
Guodong Liu (1):
pinctrl: mediatek: fix global-out-of-bounds issue
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3] pinctrl: mediatek: fix global-out-of-bounds issue
2021-11-10 2:14 ` Zhiyong Tao
(?)
@ 2021-11-10 2:14 ` Zhiyong Tao
-1 siblings, 0 replies; 11+ messages in thread
From: Zhiyong Tao @ 2021-11-10 2:14 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio, Guodong Liu
From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
When eint virtual eint number is greater than gpio number,
it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 45ebdeba985a..12163d3c4bcb 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
desc = (const struct mtk_pin_desc *)hw->soc->pins;
*gpio_chip = &hw->chip;
- /* Be greedy to guess first gpio_n is equal to eint_n */
- if (desc[eint_n].eint.eint_n == eint_n)
+ /*
+ * Be greedy to guess first gpio_n is equal to eint_n.
+ * Only eint virtual eint number is greater than gpio number.
+ */
+ if (hw->soc->npins > eint_n &&
+ desc[eint_n].eint.eint_n == eint_n)
*gpio_n = eint_n;
else
*gpio_n = mtk_xt_find_eint_num(hw, eint_n);
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3] pinctrl: mediatek: fix global-out-of-bounds issue
@ 2021-11-10 2:14 ` Zhiyong Tao
0 siblings, 0 replies; 11+ messages in thread
From: Zhiyong Tao @ 2021-11-10 2:14 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio, Guodong Liu
From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
When eint virtual eint number is greater than gpio number,
it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 45ebdeba985a..12163d3c4bcb 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
desc = (const struct mtk_pin_desc *)hw->soc->pins;
*gpio_chip = &hw->chip;
- /* Be greedy to guess first gpio_n is equal to eint_n */
- if (desc[eint_n].eint.eint_n == eint_n)
+ /*
+ * Be greedy to guess first gpio_n is equal to eint_n.
+ * Only eint virtual eint number is greater than gpio number.
+ */
+ if (hw->soc->npins > eint_n &&
+ desc[eint_n].eint.eint_n == eint_n)
*gpio_n = eint_n;
else
*gpio_n = mtk_xt_find_eint_num(hw, eint_n);
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3] pinctrl: mediatek: fix global-out-of-bounds issue
@ 2021-11-10 2:14 ` Zhiyong Tao
0 siblings, 0 replies; 11+ messages in thread
From: Zhiyong Tao @ 2021-11-10 2:14 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio, Guodong Liu
From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
When eint virtual eint number is greater than gpio number,
it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 45ebdeba985a..12163d3c4bcb 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
desc = (const struct mtk_pin_desc *)hw->soc->pins;
*gpio_chip = &hw->chip;
- /* Be greedy to guess first gpio_n is equal to eint_n */
- if (desc[eint_n].eint.eint_n == eint_n)
+ /*
+ * Be greedy to guess first gpio_n is equal to eint_n.
+ * Only eint virtual eint number is greater than gpio number.
+ */
+ if (hw->soc->npins > eint_n &&
+ desc[eint_n].eint.eint_n == eint_n)
*gpio_n = eint_n;
else
*gpio_n = mtk_xt_find_eint_num(hw, eint_n);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3] pinctrl: mediatek: fix global-out-of-bounds issue
2021-11-10 2:14 ` Zhiyong Tao
(?)
@ 2021-11-10 5:54 ` Chen-Yu Tsai
-1 siblings, 0 replies; 11+ messages in thread
From: Chen-Yu Tsai @ 2021-11-10 5:54 UTC (permalink / raw)
To: Zhiyong Tao
Cc: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang,
srv_heupstream, hui.liu, light.hsieh, sean.wang, seiya.wang,
rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio, Guodong Liu
On Wed, Nov 10, 2021 at 10:14 AM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
>
> From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
>
> When eint virtual eint number is greater than gpio number,
> it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
The order of Signed-off-by is still reversed though. The author comes first,
then comes everyone who subsequently handled the patch.
Once fixed,
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Also, for single patches, you don't really need to have a cover letter.
Any info you would convey through the cover letter, such as changelogs,
additional context, or whose tree you would like it merged through, can
be put after the triple-dash ...
> ---
here. Text put here won't get included in the commit log.
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 45ebdeba985a..12163d3c4bcb 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
> desc = (const struct mtk_pin_desc *)hw->soc->pins;
> *gpio_chip = &hw->chip;
>
> - /* Be greedy to guess first gpio_n is equal to eint_n */
> - if (desc[eint_n].eint.eint_n == eint_n)
> + /*
> + * Be greedy to guess first gpio_n is equal to eint_n.
> + * Only eint virtual eint number is greater than gpio number.
> + */
> + if (hw->soc->npins > eint_n &&
> + desc[eint_n].eint.eint_n == eint_n)
> *gpio_n = eint_n;
> else
> *gpio_n = mtk_xt_find_eint_num(hw, eint_n);
> --
> 2.25.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] pinctrl: mediatek: fix global-out-of-bounds issue
@ 2021-11-10 5:54 ` Chen-Yu Tsai
0 siblings, 0 replies; 11+ messages in thread
From: Chen-Yu Tsai @ 2021-11-10 5:54 UTC (permalink / raw)
To: Zhiyong Tao
Cc: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang,
srv_heupstream, hui.liu, light.hsieh, sean.wang, seiya.wang,
rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio, Guodong Liu
On Wed, Nov 10, 2021 at 10:14 AM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
>
> From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
>
> When eint virtual eint number is greater than gpio number,
> it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
The order of Signed-off-by is still reversed though. The author comes first,
then comes everyone who subsequently handled the patch.
Once fixed,
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Also, for single patches, you don't really need to have a cover letter.
Any info you would convey through the cover letter, such as changelogs,
additional context, or whose tree you would like it merged through, can
be put after the triple-dash ...
> ---
here. Text put here won't get included in the commit log.
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 45ebdeba985a..12163d3c4bcb 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
> desc = (const struct mtk_pin_desc *)hw->soc->pins;
> *gpio_chip = &hw->chip;
>
> - /* Be greedy to guess first gpio_n is equal to eint_n */
> - if (desc[eint_n].eint.eint_n == eint_n)
> + /*
> + * Be greedy to guess first gpio_n is equal to eint_n.
> + * Only eint virtual eint number is greater than gpio number.
> + */
> + if (hw->soc->npins > eint_n &&
> + desc[eint_n].eint.eint_n == eint_n)
> *gpio_n = eint_n;
> else
> *gpio_n = mtk_xt_find_eint_num(hw, eint_n);
> --
> 2.25.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] pinctrl: mediatek: fix global-out-of-bounds issue
@ 2021-11-10 5:54 ` Chen-Yu Tsai
0 siblings, 0 replies; 11+ messages in thread
From: Chen-Yu Tsai @ 2021-11-10 5:54 UTC (permalink / raw)
To: Zhiyong Tao
Cc: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang,
srv_heupstream, hui.liu, light.hsieh, sean.wang, seiya.wang,
rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio, Guodong Liu
On Wed, Nov 10, 2021 at 10:14 AM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
>
> From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
>
> When eint virtual eint number is greater than gpio number,
> it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
The order of Signed-off-by is still reversed though. The author comes first,
then comes everyone who subsequently handled the patch.
Once fixed,
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Also, for single patches, you don't really need to have a cover letter.
Any info you would convey through the cover letter, such as changelogs,
additional context, or whose tree you would like it merged through, can
be put after the triple-dash ...
> ---
here. Text put here won't get included in the commit log.
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 45ebdeba985a..12163d3c4bcb 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
> desc = (const struct mtk_pin_desc *)hw->soc->pins;
> *gpio_chip = &hw->chip;
>
> - /* Be greedy to guess first gpio_n is equal to eint_n */
> - if (desc[eint_n].eint.eint_n == eint_n)
> + /*
> + * Be greedy to guess first gpio_n is equal to eint_n.
> + * Only eint virtual eint number is greater than gpio number.
> + */
> + if (hw->soc->npins > eint_n &&
> + desc[eint_n].eint.eint_n == eint_n)
> *gpio_n = eint_n;
> else
> *gpio_n = mtk_xt_find_eint_num(hw, eint_n);
> --
> 2.25.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] pinctrl: mediatek: fix global-out-of-bounds issue
2021-11-10 5:54 ` Chen-Yu Tsai
@ 2021-11-10 7:02 ` zhiyong.tao
-1 siblings, 0 replies; 11+ messages in thread
From: zhiyong.tao @ 2021-11-10 7:02 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang,
srv_heupstream, hui.liu, light.hsieh, sean.wang, seiya.wang,
rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio, Guodong Liu
On Wed, 2021-11-10 at 13:54 +0800, Chen-Yu Tsai wrote:
> On Wed, Nov 10, 2021 at 10:14 AM Zhiyong Tao <
> zhiyong.tao@mediatek.com> wrote:
> >
> > From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
> >
> > When eint virtual eint number is greater than gpio number,
> > it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
> >
> > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> > Signed-off-by: Guodong Liu <
> > guodong.liu@mediatek.corp-partner.google.com>
>
> The order of Signed-off-by is still reversed though. The author comes
> first,
> then comes everyone who subsequently handled the patch.
>
> Once fixed,
>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
>
> Also, for single patches, you don't really need to have a cover
> letter.
> Any info you would convey through the cover letter, such as
> changelogs,
> additional context, or whose tree you would like it merged through,
> can
> be put after the triple-dash ...
>
> > ---
>
> here. Text put here won't get included in the commit log.
Thanks for your suggestion, we will fix it in next version(v4).
>
> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > index 45ebdeba985a..12163d3c4bcb 100644
> > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > @@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data,
> > unsigned long eint_n,
> > desc = (const struct mtk_pin_desc *)hw->soc->pins;
> > *gpio_chip = &hw->chip;
> >
> > - /* Be greedy to guess first gpio_n is equal to eint_n */
> > - if (desc[eint_n].eint.eint_n == eint_n)
> > + /*
> > + * Be greedy to guess first gpio_n is equal to eint_n.
> > + * Only eint virtual eint number is greater than gpio
> > number.
> > + */
> > + if (hw->soc->npins > eint_n &&
> > + desc[eint_n].eint.eint_n == eint_n)
> > *gpio_n = eint_n;
> > else
> > *gpio_n = mtk_xt_find_eint_num(hw, eint_n);
> > --
> > 2.25.1
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] pinctrl: mediatek: fix global-out-of-bounds issue
@ 2021-11-10 7:02 ` zhiyong.tao
0 siblings, 0 replies; 11+ messages in thread
From: zhiyong.tao @ 2021-11-10 7:02 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang,
srv_heupstream, hui.liu, light.hsieh, sean.wang, seiya.wang,
rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio, Guodong Liu
On Wed, 2021-11-10 at 13:54 +0800, Chen-Yu Tsai wrote:
> On Wed, Nov 10, 2021 at 10:14 AM Zhiyong Tao <
> zhiyong.tao@mediatek.com> wrote:
> >
> > From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
> >
> > When eint virtual eint number is greater than gpio number,
> > it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
> >
> > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> > Signed-off-by: Guodong Liu <
> > guodong.liu@mediatek.corp-partner.google.com>
>
> The order of Signed-off-by is still reversed though. The author comes
> first,
> then comes everyone who subsequently handled the patch.
>
> Once fixed,
>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
>
> Also, for single patches, you don't really need to have a cover
> letter.
> Any info you would convey through the cover letter, such as
> changelogs,
> additional context, or whose tree you would like it merged through,
> can
> be put after the triple-dash ...
>
> > ---
>
> here. Text put here won't get included in the commit log.
Thanks for your suggestion, we will fix it in next version(v4).
>
> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > index 45ebdeba985a..12163d3c4bcb 100644
> > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > @@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data,
> > unsigned long eint_n,
> > desc = (const struct mtk_pin_desc *)hw->soc->pins;
> > *gpio_chip = &hw->chip;
> >
> > - /* Be greedy to guess first gpio_n is equal to eint_n */
> > - if (desc[eint_n].eint.eint_n == eint_n)
> > + /*
> > + * Be greedy to guess first gpio_n is equal to eint_n.
> > + * Only eint virtual eint number is greater than gpio
> > number.
> > + */
> > + if (hw->soc->npins > eint_n &&
> > + desc[eint_n].eint.eint_n == eint_n)
> > *gpio_n = eint_n;
> > else
> > *gpio_n = mtk_xt_find_eint_num(hw, eint_n);
> > --
> > 2.25.1
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-11-10 7:09 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 2:14 [PATCH v3 0/1] Mediatek pinctrl patch Zhiyong Tao
2021-11-10 2:14 ` Zhiyong Tao
2021-11-10 2:14 ` Zhiyong Tao
2021-11-10 2:14 ` [PATCH v3] pinctrl: mediatek: fix global-out-of-bounds issue Zhiyong Tao
2021-11-10 2:14 ` Zhiyong Tao
2021-11-10 2:14 ` Zhiyong Tao
2021-11-10 5:54 ` Chen-Yu Tsai
2021-11-10 5:54 ` Chen-Yu Tsai
2021-11-10 5:54 ` Chen-Yu Tsai
2021-11-10 7:02 ` zhiyong.tao
2021-11-10 7:02 ` zhiyong.tao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.