* [PATCH] staging: fieldbus: Replace snprintf in show functions with sysfs_emit
@ 2021-11-10 2:30 cgel.zte
2021-11-10 8:09 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2021-11-10 2:30 UTC (permalink / raw)
To: TheSven73; +Cc: gregkh, linux-staging, linux-kernel, Jing Yao, Zeal Robot
From: Jing Yao <yao.jing2@zte.com.cn>
coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING use scnprintf or sprintf
Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more
sense.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yao <yao.jing2@zte.com.cn>
---
drivers/staging/fieldbus/dev_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fieldbus/dev_core.c b/drivers/staging/fieldbus/dev_core.c
index 5aab734606ea..01862fe8e4cc 100644
--- a/drivers/staging/fieldbus/dev_core.c
+++ b/drivers/staging/fieldbus/dev_core.c
@@ -70,7 +70,7 @@ static ssize_t card_name_show(struct device *dev, struct device_attribute *attr,
* card_name was provided by child driver, could potentially be long.
* protect against buffer overrun.
*/
- return snprintf(buf, PAGE_SIZE, "%s\n", fb->card_name);
+ return sysfs_emit(buf, "%s\n", fb->card_name);
}
static DEVICE_ATTR_RO(card_name);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: fieldbus: Replace snprintf in show functions with sysfs_emit
2021-11-10 2:30 [PATCH] staging: fieldbus: Replace snprintf in show functions with sysfs_emit cgel.zte
@ 2021-11-10 8:09 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-11-10 8:09 UTC (permalink / raw)
To: cgel.zte; +Cc: TheSven73, linux-staging, linux-kernel, Jing Yao, Zeal Robot
On Wed, Nov 10, 2021 at 02:30:48AM +0000, cgel.zte@gmail.com wrote:
> From: Jing Yao <yao.jing2@zte.com.cn>
>
> coccicheck complains about the use of snprintf() in sysfs show
> functions:
> WARNING use scnprintf or sprintf
>
> Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more
> sense.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
But coccicheck is the thing that is reporting this, right?
And your subject line has two space characters between "with" and
"sysfs_emit" for some odd reason :(
> Signed-off-by: Jing Yao <yao.jing2@zte.com.cn>
> ---
> drivers/staging/fieldbus/dev_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fieldbus/dev_core.c b/drivers/staging/fieldbus/dev_core.c
> index 5aab734606ea..01862fe8e4cc 100644
> --- a/drivers/staging/fieldbus/dev_core.c
> +++ b/drivers/staging/fieldbus/dev_core.c
> @@ -70,7 +70,7 @@ static ssize_t card_name_show(struct device *dev, struct device_attribute *attr,
> * card_name was provided by child driver, could potentially be long.
> * protect against buffer overrun.
> */
> - return snprintf(buf, PAGE_SIZE, "%s\n", fb->card_name);
> + return sysfs_emit(buf, "%s\n", fb->card_name);
> }
> static DEVICE_ATTR_RO(card_name);
Your "bot" is not very good, why are you only changing one function in
this file and not all of the places where sysfs_emit() could be used?
Doing this one function at a time is really hard, please do not do it
that way.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-10 8:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 2:30 [PATCH] staging: fieldbus: Replace snprintf in show functions with sysfs_emit cgel.zte
2021-11-10 8:09 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.