From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
David Ahern <dsahern@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Ido Schimmel <idosch@nvidia.com>, Andrei Vagin <avagin@gmail.com>,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Alexander Mikhalitsyn <alexander@mihalicyn.com>
Subject: Re: [RFC PATCH net-next] rtnetlink: add RTNH_F_REJECT_MASK
Date: Thu, 11 Nov 2021 09:48:37 -0800 [thread overview]
Message-ID: <20211111094837.55937988@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20211111160240.739294-2-alexander.mikhalitsyn@virtuozzo.com>
On Thu, 11 Nov 2021 19:02:40 +0300 Alexander Mikhalitsyn wrote:
> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> index 5888492a5257..c15e591e5d25 100644
> --- a/include/uapi/linux/rtnetlink.h
> +++ b/include/uapi/linux/rtnetlink.h
> @@ -417,6 +417,9 @@ struct rtnexthop {
> #define RTNH_COMPARE_MASK (RTNH_F_DEAD | RTNH_F_LINKDOWN | \
> RTNH_F_OFFLOAD | RTNH_F_TRAP)
>
> +/* these flags can't be set by the userspace */
> +#define RTNH_F_REJECT_MASK (RTNH_F_DEAD | RTNH_F_LINKDOWN)
You should probably drop the _F_ since RTNH_COMPARE_MASK above
does not have it.
next prev parent reply other threads:[~2021-11-11 17:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 16:02 [RFC PATCH iproute2] ip route: save: exclude rtnh_flags which can't be set Alexander Mikhalitsyn
2021-11-11 16:02 ` [RFC PATCH net-next] rtnetlink: add RTNH_F_REJECT_MASK Alexander Mikhalitsyn
2021-11-11 17:48 ` Jakub Kicinski [this message]
2021-11-11 17:51 ` Alexander Mikhalitsyn
2021-11-11 17:56 ` Jakub Kicinski
2021-11-11 18:01 ` Alexander Mikhalitsyn
2021-11-11 19:13 ` David Ahern
2021-11-11 19:23 ` Alexander Mikhalitsyn
2021-11-11 22:19 ` David Ahern
2021-11-12 1:02 ` Roopa Prabhu
2021-11-12 2:27 ` David Ahern
2021-11-26 13:43 ` [PATCH iproute2] ip route: save: exclude rtnh_flags which can't be set Alexander Mikhalitsyn
2021-11-26 13:43 ` [PATCH net-next] rtnetlink: add RTNH_REJECT_MASK Alexander Mikhalitsyn
2021-11-28 14:01 ` Ido Schimmel
2021-11-29 0:19 ` David Ahern
2021-11-30 7:59 ` Ido Schimmel
2021-11-30 8:35 ` Alexander Mikhalitsyn
2021-11-30 9:28 ` Ido Schimmel
2021-11-30 9:53 ` Alexander Mikhalitsyn
2021-11-30 10:28 ` Ido Schimmel
2021-11-30 15:12 ` David Ahern
2021-11-30 8:18 ` Alexander Mikhalitsyn
2021-11-28 13:09 ` [PATCH iproute2] ip route: save: exclude rtnh_flags which can't be set Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211111094837.55937988@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=alexander.mikhalitsyn@virtuozzo.com \
--cc=alexander@mihalicyn.com \
--cc=avagin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.