Re: [PATCH iproute2] ip route: save: exclude rtnh_flags which can't be set

From: Ido Schimmel <idosch@idosch.org>
To: Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
	David Ahern <dsahern@gmail.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Ido Schimmel <idosch@nvidia.com>,
	Jakub Kicinski <kuba@kernel.org>, Roopa Prabhu <roopa@nvidia.com>,
	Andrei Vagin <avagin@gmail.com>,
	Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
	Alexander Mikhalitsyn <alexander@mihalicyn.com>
Subject: Re: [PATCH iproute2] ip route: save: exclude rtnh_flags which can't be set
Date: Sun, 28 Nov 2021 15:09:38 +0200	[thread overview]
Message-ID: <YaN/khA2eJJLgdte@shredder> (raw)
In-Reply-To: <20211126134311.920808-1-alexander.mikhalitsyn@virtuozzo.com>

On Fri, Nov 26, 2021 at 04:43:10PM +0300, Alexander Mikhalitsyn wrote:
> +	/*
> +	 * Exclude flags which can't be set directly
> +	 * by the userspace from the rtmsg dump.
> +	 */

I believe iproute2 is following netdev style comments [1] so this should
be:

/* Exclude flags which can't be set directly
 * by the userspace from the rtmsg dump.
 */

At least it's consistent with other comments in the file.

[1] https://www.kernel.org/doc/html/v5.12/networking/netdev-FAQ.html#is-the-comment-style-convention-different-for-the-networking-content

> +	r->rtm_flags &= ~RTNH_REJECT_MASK;
> +
>  	ret = write(STDOUT_FILENO, n, n->nlmsg_len);
>  	if ((ret > 0) && (ret != n->nlmsg_len)) {
>  		fprintf(stderr, "Short write while saving nlmsg\n");
> -- 
> 2.31.1
> 