From: Eugen Hristev <eugen.hristev@microchip.com> To: <linux-media@vger.kernel.org> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <jacopo@jmondi.org>, <laurent.pinchart@ideasonboard.com>, <sakari.ailus@iki.fi>, <nicolas.ferre@microchip.com>, Eugen Hristev <eugen.hristev@microchip.com> Subject: [PATCH v2 18/25] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Date: Fri, 12 Nov 2021 16:25:02 +0200 [thread overview] Message-ID: <20211112142509.2230884-19-eugen.hristev@microchip.com> (raw) In-Reply-To: <20211112142509.2230884-1-eugen.hristev@microchip.com> While this does not happen in production, this check should be done versus the mask, as checking with the YCYC value may not include some bits that may be set. Is it correct and safe to check the whole mask. Fixes: 123aaf816b95 ("media: atmel: atmel-sama5d2-isc: fix YUYV format") Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> --- drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c index a3e4c32a66c4..a8d4ba60d3ac 100644 --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c @@ -267,7 +267,7 @@ static void isc_sama5d2_config_rlp(struct isc_device *isc) * Thus, if the YCYC mode is selected, replace it with the * sama5d2-compliant mode which is YYCC . */ - if ((rlp_mode & ISC_RLP_CFG_MODE_YCYC) == ISC_RLP_CFG_MODE_YCYC) { + if ((rlp_mode & ISC_RLP_CFG_MODE_MASK) == ISC_RLP_CFG_MODE_YCYC) { rlp_mode &= ~ISC_RLP_CFG_MODE_MASK; rlp_mode |= ISC_RLP_CFG_MODE_YYCC; } -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Eugen Hristev <eugen.hristev@microchip.com> To: <linux-media@vger.kernel.org> Cc: devicetree@vger.kernel.org, jacopo@jmondi.org, linux-kernel@vger.kernel.org, sakari.ailus@iki.fi, laurent.pinchart@ideasonboard.com, Eugen Hristev <eugen.hristev@microchip.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 18/25] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Date: Fri, 12 Nov 2021 16:25:02 +0200 [thread overview] Message-ID: <20211112142509.2230884-19-eugen.hristev@microchip.com> (raw) In-Reply-To: <20211112142509.2230884-1-eugen.hristev@microchip.com> While this does not happen in production, this check should be done versus the mask, as checking with the YCYC value may not include some bits that may be set. Is it correct and safe to check the whole mask. Fixes: 123aaf816b95 ("media: atmel: atmel-sama5d2-isc: fix YUYV format") Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> --- drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c index a3e4c32a66c4..a8d4ba60d3ac 100644 --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c @@ -267,7 +267,7 @@ static void isc_sama5d2_config_rlp(struct isc_device *isc) * Thus, if the YCYC mode is selected, replace it with the * sama5d2-compliant mode which is YYCC . */ - if ((rlp_mode & ISC_RLP_CFG_MODE_YCYC) == ISC_RLP_CFG_MODE_YCYC) { + if ((rlp_mode & ISC_RLP_CFG_MODE_MASK) == ISC_RLP_CFG_MODE_YCYC) { rlp_mode &= ~ISC_RLP_CFG_MODE_MASK; rlp_mode |= ISC_RLP_CFG_MODE_YYCC; } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-12 14:29 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-12 14:24 [PATCH v2 00/25] media: atmel: atmel-isc: implement media controller Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:24 ` [PATCH v2 01/25] MAINTAINERS: add microchip csi2dc Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-29 23:14 ` Laurent Pinchart 2021-11-29 23:14 ` Laurent Pinchart 2021-12-13 13:40 ` Nicolas Ferre 2021-12-13 13:40 ` Nicolas Ferre 2021-11-12 14:24 ` [PATCH v2 02/25] dt-bindings: media: atmel: csi2dc: add bindings for " Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-29 21:10 ` Rob Herring 2021-11-29 21:10 ` Rob Herring 2021-11-29 21:37 ` Sakari Ailus 2021-11-29 21:37 ` Sakari Ailus 2021-12-06 8:57 ` Eugen.Hristev 2021-12-06 8:57 ` Eugen.Hristev 2021-11-29 23:14 ` Laurent Pinchart 2021-11-29 23:14 ` Laurent Pinchart 2021-11-12 14:24 ` [PATCH v2 03/25] media: atmel: introduce microchip csi2dc driver Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-12-06 10:51 ` Jacopo Mondi 2021-12-06 10:51 ` Jacopo Mondi 2021-12-06 11:42 ` Eugen.Hristev 2021-12-06 11:42 ` Eugen.Hristev 2021-12-06 12:06 ` Jacopo Mondi 2021-12-06 12:06 ` Jacopo Mondi 2021-12-10 11:07 ` Eugen.Hristev 2021-12-10 11:07 ` Eugen.Hristev 2021-12-10 12:59 ` Jacopo Mondi 2021-12-10 12:59 ` Jacopo Mondi 2021-11-12 14:24 ` [PATCH v2 04/25] MAINTAINERS: atmel-isc: add new file atmel-isc-clk.c Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-29 23:18 ` Laurent Pinchart 2021-11-29 23:18 ` Laurent Pinchart 2021-11-12 14:24 ` [PATCH v2 05/25] media: atmel: atmel-isc: split the clock code into separate source file Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:24 ` [PATCH v2 06/25] media: atmel: atmel-isc: replace video device name with module name Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:24 ` [PATCH v2 07/25] media: atmel: atmel-sama7g5-isc: fix ispck leftover Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:24 ` [PATCH v2 08/25] media: atmel: atmel-isc-base: use streaming status when queueing buffers Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:24 ` [PATCH v2 09/25] media: atmel: atmel-isc-base: remove frameintervals VIDIOC Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:24 ` [PATCH v2 10/25] media: atmel: atmel-isc-base: report frame sizes as full supported range Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:24 ` [PATCH v2 11/25] media: atmel: atmel-isc-base: implement mbus_code support in enumfmt Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:24 ` [PATCH v2 12/25] media: atmel: atmel-isc-base: fix bytesperline value for planar formats Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-12-06 16:38 ` Jacopo Mondi 2021-12-06 16:38 ` Jacopo Mondi 2021-12-07 11:21 ` Eugen.Hristev 2021-12-07 11:21 ` Eugen.Hristev 2021-11-12 14:24 ` [PATCH v2 13/25] MAINTAINERS: atmel-isc: add new file atmel-isc-mc.c Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:24 ` [PATCH v2 14/25] media: atmel: atmel-isc: implement media controller Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:24 ` [PATCH v2 15/25] ARM: dts: at91: sama7g5: add nodes for video capture Eugen Hristev 2021-11-12 14:24 ` Eugen Hristev 2021-11-12 14:25 ` [PATCH v2 16/25] ARM: configs: at91: sama7: add xisc and csi2dc Eugen Hristev 2021-11-12 14:25 ` Eugen Hristev 2021-11-12 14:25 ` [PATCH v2 17/25] ARM: multi_v7_defconfig: add atmel video pipeline modules Eugen Hristev 2021-11-12 14:25 ` Eugen Hristev 2021-11-12 14:25 ` Eugen Hristev [this message] 2021-11-12 14:25 ` [PATCH v2 18/25] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Eugen Hristev 2021-11-12 14:25 ` [PATCH v2 19/25] media: atmel: atmel-isc-base: use mutex to lock awb workqueue from streaming Eugen Hristev 2021-11-12 14:25 ` Eugen Hristev 2021-11-12 14:25 ` [PATCH v2 20/25] media: atmel: atmel-isc-base: add wb debug messages Eugen Hristev 2021-11-12 14:25 ` Eugen Hristev 2021-11-12 14:25 ` [PATCH v2 21/25] media: atmel: atmel-isc-base: clamp wb gain coefficients Eugen Hristev 2021-11-12 14:25 ` Eugen Hristev 2021-11-12 14:25 ` [PATCH v2 22/25] media: atmel: atmel-sama7g5-isc: fix UYVY input format mbus_code typo Eugen Hristev 2021-11-12 14:25 ` Eugen Hristev 2021-11-12 14:25 ` [PATCH v2 23/25] media: atmel: atmel-isc: add raw Bayer 8bit 10bit output formats Eugen Hristev 2021-11-12 14:25 ` Eugen Hristev 2021-11-12 14:25 ` [PATCH v2 24/25] media: atmel: atmel-isc: compact the controller formats list Eugen Hristev 2021-11-12 14:25 ` Eugen Hristev 2021-11-12 14:25 ` [PATCH v2 25/25] media: atmel: atmel-isc: change format propagation to subdev into only verification Eugen Hristev 2021-11-12 14:25 ` Eugen Hristev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211112142509.2230884-19-eugen.hristev@microchip.com \ --to=eugen.hristev@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=jacopo@jmondi.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=sakari.ailus@iki.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.